Commit Graph

213 Commits

Author SHA1 Message Date
Jekyll Wu
33678e7ca4 Add more convenient methods for accessing profile option 2012-03-19 18:29:44 +08:00
Jekyll Wu
683f2c9ec5 Merge Profile::HistoryModeEnum and HistorySizeDialog::HistoryMode into Enum::HistoryMode Enum 2012-03-19 16:07:27 +08:00
Kurt Hindenburg
e0862c603a Style fixes - separte commands - remove 2 ; - align { elses 2012-03-18 15:57:48 -04:00
Kurt Hindenburg
519e2614d6 Style fixes - remove spaces before ; and add spaces in for loops 2012-03-18 15:11:06 -04:00
Jekyll Wu
25b8b5353c Trivial style change: remove extra blank lines 2012-03-17 19:53:21 +08:00
Jekyll Wu
7179de8f3d Prefer qobject_cast to dynamic_cast when appropriate 2012-03-16 13:37:15 +08:00
Jekyll Wu
724da22d05 Remove TODO 2012-03-16 02:25:31 +08:00
Jekyll Wu
ebc4888fef The "Copy Input To" submenu should use combo boxes
REVIEW: 104202
2012-03-10 05:37:18 +08:00
Jekyll Wu
cb91bba872 Trivial style change 2012-03-09 14:15:33 +08:00
Jekyll Wu
f4fb943132 Most of time we only need <KLocalizedString> instead of <KLocale> 2012-03-07 06:48:26 +08:00
Jekyll Wu
2dd8024621 Redo: "Configure Current Profile" ==> "Edit Current Profile"
That change was incidentally overwritten by commit 08de49 later.
2012-03-04 03:29:26 +08:00
Jekyll Wu
08de49da1c konsolepart should not expose actions only meaningful to Konsole
Note: some actions, such as enlarging/shrinking font and setting
encoding, might actually be also useful in konsolepart. But since
konsolepart currently always use the default shortcut, the general
idea now is to expose actions as few as possible in konsolepart.

BUG: 248469
FIXED-IN: 4.9.0
REVIEW: 104034

CCMAIL: hein@kde.org
2012-03-01 08:58:37 +08:00
Jekyll Wu
4c374c889f UI string: Configure Current Profile ==> Edit Current Profile
Now we use the same word in the "Settings" menu and the "Manage
Profiles" dialog.
2012-02-27 21:40:42 +08:00
Jekyll Wu
cc1142c59d Prepare the whole command before sending it by calling Session::sendText()
That reduces the number of calling, and also make the code easier to
debug if something goes wrong with the command

TODO: there is code duplication between class Application and class
SessionController on how to compose and send ssh command based upon a
KUrl using the ssh:// protocol.
2012-02-23 07:37:07 +08:00
Jekyll Wu
4e2eb4c109 Reduce the delayment of snapshot on interaction to 1 second
This might be a stupid improvement to make the tab title updating in
a more prompt way. If anyone find this stupid improment introduces
noticable side effect such as high load, do not hesitate to revert it.
2012-02-21 13:41:43 +08:00
Jekyll Wu
4fb4da4c75 Add global option for showing window title on titlebar
When the window title from current session is emtpy, fallback to using
tab title.

CCBUG: 162326
REVIEW: 103978
2012-02-19 15:23:48 +08:00
Jekyll Wu
0d5355638c More constness 2012-02-18 05:44:02 +08:00
Jekyll Wu
e0a1336824 Just move code around 2012-02-17 01:11:19 +08:00
Jekyll Wu
e2de7c3125 The icon for activity/silence should stay on tab until interaction
This is a follow-up of commit 5a24215022
to deal with its side effect with the feature of monitoring
activity/silence
2012-02-16 21:06:12 +08:00
Jekyll Wu
29981c4b08 Make the code slightly more natural 2012-02-16 06:44:05 +08:00
Jekyll Wu
c9509d1cf1 Remove one line of no use 2012-02-16 06:31:40 +08:00
Jekyll Wu
67eff940e1 Make the the icon used for master/broadcasting mode a static member 2012-02-16 04:19:05 +08:00
Jekyll Wu
dfce59f1d0 Prefer the simpler way of initializing stative variables. 2012-02-16 04:04:02 +08:00
Jekyll Wu
5a24215022 Take snapshot of session state periodically in the background
This comes as an complement of the existing way of taking snapshot
on keyboard activity.

The time inverval is currently 2 seconds. That interval should be
increased if it causes noticable performance penalty.

BUG: 271275
FIXED-IN:4.8.1
2012-02-15 17:11:36 +08:00
Jekyll Wu
f0529c1c02 Prefer foreach(..) over iterating manually for readability 2012-02-13 21:28:48 +08:00
Jekyll Wu
3d8da1f878 Make 'foreach(...)' more readable 2012-01-14 22:54:56 +08:00
Jekyll Wu
4de54208d0 Add 'Ctrl + =' as the alternate shortcut for enlarging font .
Now we have two actions which have alternate shortcut by default:
'Paste' and 'Enlarge Font'.

REVIEW: 103661
2012-01-10 12:05:35 +08:00
Jekyll Wu
dad64e67e7 Change the default shortcut of 'Clear Scrollback and Reset' to Ctrl+Shift+K
The current default shortcut is Ctrl+Shift+X, which might be accidentally
pressed when users intend to press Ctrl+Shift+C for copying or Ctrl+Shift+V for
pasting. Scrollback is important asset, but it is impossible to recover
once gone. So change the default shortcut to decrease the chance of
accidents.

FEATURE: 282593
FIXED-IN: 4.9
REVIEW: 103660
2012-01-10 11:52:43 +08:00
Kurt Hindenburg
1baa56feda White space changes - astyle and Qt normalize don't like each other.
Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-25 13:13:55 -05:00
Kurt Hindenburg
d7ce9e8f0c Apply astyle-kdelibs
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-24 11:20:35 -05:00
Jekyll Wu
36bd1828f3 Revert "Ensure %w and %# are also expaned in the 'Copy input' dialog"
That fix is not good enough because it makes '%w' being updated only
after keystroke instead of immediately . The issue of updating title is
actually a little more complicated than I have understood.

Revert it because the regression should influence more users than the
fixed problem does. Need to spend more time to find a better fix.

CCBUG: 175755
CCBUG: 287536

This reverts commit 1c1981501b.
2011-11-29 14:15:47 +08:00
Jekyll Wu
a3744135fc Respect leading and trailing white spaces in the search string
BUG:286614
FIXED-IN:4.8
2011-11-20 13:09:07 +08:00
Jekyll Wu
82ef9ccd3a Fix 2 Krazy issues with modal dialog 2011-11-06 12:06:31 +08:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
e825a8e0b6 Prefer forward declaration when it is enough 2011-11-01 13:41:54 +08:00
Jekyll Wu
c9fa80cf62 Remove unused #include 2011-10-31 03:01:20 +08:00
Jekyll Wu
eb2515236c Remove #includes for <kdeversion.h> which are not needed now 2011-10-31 02:32:07 +08:00
Jekyll Wu
25f4a48779 Initilzie _searchBar as 0 explicitly 2011-10-31 00:19:24 +08:00
Jekyll Wu
348fe2bc9f Remove dead code enclosed by #if 0 .... #endif 2011-10-30 23:09:20 +08:00
Jekyll Wu
771c60c914 Rename members and methods related with the "switch-profile" action 2011-10-30 14:32:19 +08:00
Jekyll Wu
197d6fd311 Move code around 2011-10-30 13:51:49 +08:00
Jekyll Wu
996fae67d7 Action "select-all" should put selected text onto X11 selection
This is actually a hidden bug because the "select-all" action is
not available to users until 2.8
2011-10-27 23:38:59 +08:00
Jekyll Wu
1aac391849 Previous commit is supposed to close bug 227114. Typo 2011-10-25 19:47:22 +08:00
Jekyll Wu
8f7be18a64 Simplify the scrollback setting dialog to avoid potential confusion.
- the change is not saved into profile and only influences current tab
  - remove the 'Save to current profile' checkbox
  - remove the 'Defaults' button
  - change dialog title from "Scrollback Options" to "Adjust Scrollback"
  - change action from "Scrollback Options..." to "Adjust Scrollback..."

The new dialog makes the "Adjust Scrollback..." action more consistent with most
of other actions in the context menu, since they only influence or work in the
context of current tab.

The UI change is not quite satisfactory. Feel free to refine the UI part
to make it more clear and elegant.

BUG: 227144
FIXED-IN : 4.8
REVIEW: 102688
2011-10-25 19:24:15 +08:00
Jekyll Wu
068c637136 Update _allControllers at the end of the constructor 2011-10-24 10:33:48 +08:00
Jekyll Wu
e9bd2febee Simplify the code for updating codec action 2011-10-24 10:08:33 +08:00
Jekyll Wu
91f8e533c8 Delete slot saveSession() which is not implemented and used 2011-10-24 00:00:28 +08:00
Jekyll Wu
45726d9388 Move code around for better readability 2011-10-23 23:58:58 +08:00
Jekyll Wu
1c1981501b Ensure %w and %# are also expaned in the 'Copy input' dialog
The fix is quite simple. Just move the existing code for expanding
%# and %w into Session::getDynamicTitle(), where all other tab title
formatters are expanded. That also makes the code simple and natural.

BUG: 175755
FIXED-IN:4.8
2011-10-22 03:18:01 +08:00
Jekyll Wu
218ffbf8bf Setup icon for the 'select-all' and 'rename-session' actions
They use the same icons as their similar KStandardActions does.
2011-10-21 16:50:55 +08:00