Commit Graph

177 Commits

Author SHA1 Message Date
Jekyll Wu
354033e6f0 Rename pasteFromSelection to pasteFromXSelection 2011-10-13 09:45:00 +08:00
Jekyll Wu
c4a3398ef8 Refactor the drawLineCharString() method 2011-10-13 09:12:48 +08:00
Jekyll Wu
0a9abe991d Refactor the drawCharacters() method 2011-10-13 09:02:19 +08:00
Jekyll Wu
07b11fca4d Add comment for readability 2011-10-13 08:53:08 +08:00
Jekyll Wu
e1cf074b06 Refactor the drawCursor() method 2011-10-13 08:48:12 +08:00
Jekyll Wu
78c82a7d45 Rename member varibale dragInfo into _dragInfo 2011-10-11 02:00:31 +08:00
Jekyll Wu
2cbaa251a8 Minor change on comment 2011-10-11 01:38:35 +08:00
Jekyll Wu
fd4314d392 Remove one useless local variable 2011-10-10 23:56:01 +08:00
Jekyll Wu
f36887343c Move #include to the beginning. 2011-10-10 23:34:51 +08:00
Jekyll Wu
f56298ab62 Minor change on comment position 2011-10-10 20:05:50 +08:00
Jekyll Wu
07c2230dda Remove dead macro and comment. 2011-10-10 20:02:24 +08:00
Jekyll Wu
7fbfb0aee0 remove meaningless "#undef KeyPress" 2011-10-10 20:01:02 +08:00
Jekyll Wu
b729248dcb Rename for clarity. 2011-10-10 19:53:54 +08:00
Jekyll Wu
27f55b9f37 change _antialiasFont from static member into instance member.
antialias is a per display attribute, so it doesn't make sense to
define _antialiasFont as static member.
2011-10-10 18:08:28 +08:00
Jekyll Wu
0ca11c659f Initialize _showTerminalSizeHint as true to be consistent with profile default. 2011-10-10 17:33:54 +08:00
Jekyll Wu
b83b0c5419 Fix the inconsisten name/value between two scrollback emums.
TODO: it does not feel good to have two essentially the same enums
in two different places.
2011-10-10 17:25:41 +08:00
Jekyll Wu
2d7a67cc88 Remove memeber _terminalSizeStartup and related methods/calls.
That member was meant to control whether showing size hint on startup,
while it is actually only used to avoid showing size hint on startup.
That job can be done by a static variable within showResizeNotification()
2011-10-10 16:45:19 +08:00
Jekyll Wu
9ea9d62785 Reimplement the feature of "show/hide the size widget after resising"
This is a follow up of commit b40a006d which closees BUG 169054.
It turns out the old code already has most parts of similar logic.
So remove duplicated logic in the code.
2011-10-10 16:23:22 +08:00
Jekyll Wu
a3865d460e _clipboard is not a good name for non-member variable. 2011-10-10 15:17:12 +08:00
Jekyll Wu
66146b2e68 re-group members in a more related way. 2011-10-10 15:12:10 +08:00
Jekyll Wu
3d1f074cc3 Add 'Text' into the names of text-blinking related members and methods.
Explicit is often better than implicit.
2011-10-10 15:00:12 +08:00
Jekyll Wu
714ec30c32 Rename for consistency and clarity 2011-10-10 14:35:30 +08:00
Jekyll Wu
be4630f81f Remove dead method TerminalDisplay::setCursorPos() 2011-10-10 12:44:40 +08:00
Jekyll Wu
272ac9850e Include KDE headers consistently in the from of "#include <KSomething>" .
However, some KDE headers are still only available in the form of
"#include <ksomething.h>"

krun.h              ==>     KRun
kicon.h             ==>     KIcon
kdebug.h            ==>     KDebug
kshell.h            ==>     KShell
kdialog.h           ==>     KDialog
kconfig.h           ==>     KConfig
klocale.h           ==>     KLocale
kglobal.h           ==>     KGlobal
kcolorutils.h       ==>     KColorUtils
kconfiggroup.h      ==>     KConfigGroup
kdesktopfile.h      ==>     KDesktopFile
kcolorscheme.h      ==>     KColorScheme
kstandarddirs.h     ==>     KStandardDirs
ktemporaryfile.h    ==>     KTemporaryFile
klocalizedstring.h  ==>     KLocalizedString
2011-09-23 05:04:46 +08:00
Jekyll Wu
e14b2099cc Each filename inserted in d&d operation should be followd by a space.
FEATURE: 280838
FIXED-IN:4.8
2011-09-14 06:48:43 +08:00
Jekyll Wu
f78b734ef2 Remove unused #include . 2011-09-06 06:38:51 +08:00
Aaron Seigo
ff1740e438 call up the on screen keyboard when we get a click. 2011-08-16 13:56:53 +02:00
Jekyll Wu
1efdbea83e Last commit was meant to close REVIEW 102248. Typo. 2011-08-15 13:25:58 +08:00
Jekyll Wu
caece88d2c Don't emit keyPressedSignal when QInputMethodEvent::commitString() is empty.
When user switches focus (even using mouse) between tabs/windows
of konsole, ibus will trigger inputMethodEvent(). Most of the time
commitString() will be empty. Do not emit keyPressedSignal in such case,
otherwise konsole will scroll active view to bottom. See bug #236733.

The side effect is when inputmethod is activated, the active view
will not scroll to bottom on keystroke until user has committed
some string.

BUG: 236733
REVIEW: 102238
FIXED-IN : 4.8
2011-08-15 12:33:02 +08:00
Kurt Hindenburg
2dcd584255 Popup menu for drag-n-drop operations.
Restore KDE3 popup menu when any file is dropped into Konsole.

The popup menu allows to Copy, Move or Link the file into the current
working directory or to simply paste its URL as text (the latter being
the current behaviour in KDE4).

For non-local files, the URL is pasted as text.

Note that this adds a konq dependency - KonqOperations:doDrop

Patch by Frank Roscher
FEATURE: 160583
FIXED-IN: 4.8
REVIEW: 4600
2011-08-13 21:10:31 -04:00
Kurt Hindenburg
087f67e4fc Allow an image to be set as the background in the terminal.
Restore the KDE3 option to have a background image in each session.

Patch by Alexandre Becoulet <diaxen@free.fr>
BUG: 157882
FIXED-IN: 4.8
2011-08-07 18:44:16 -04:00
Kurt Hindenburg
51575d6f52 Accept drag and drop event from non-KDE Filemanagers
Thunar uses 'text/uri-list' in its mimetype, but konsole only accept
d&d events whose mimetype contains 'text/plain'.

Patch by Jekyll Wu <adaptee@gmail.com>
BUG: 219023
FIXED-IN: 4.8
REVIEW: 102176
2011-08-04 09:25:17 -04:00
Kurt Hindenburg
b40a006db8 Add a checkbox to hide the size widget upon resizing window.
Re-add the KDE 3 option to show/hide the size widget when the window is
changed.

Patch is years old from Chali Ahmul M.P.U <chali.ahmul@atlas.cz>
FEATURE: 169054
FIXED-IN: 4.8
2011-07-31 20:56:16 -04:00
Kurt Hindenburg
ca0cb95007 Fix notifications for non-visible sessions.
Currently all notifications are deemed 'visible'.  This patch fixes
that so all non-visible sessions go to their own notifications.

Patch by Tijl Coosemans.

I'll backport to the 4.7 branch.
BUG: 174505
FIXED-IN: 2.7.1
REVIEW: 101720
2011-07-09 18:18:09 -04:00
Albert Astals Cid
1c000fd50c Fix format/style matching
RE_EXTENDED_CHAR is not part of the character format/style
2011-07-03 15:16:19 +01:00
Albert Astals Cid
c335324f31 Support Unicode decomposed characters
BUGS: 96536
2011-06-26 16:32:30 +01:00
Albert Astals Cid
3913792ce6 Add some const to make the code easier to follow 2011-06-26 16:23:59 +01:00
Albert Astals Cid
4477ce504f Remove code that does nothing
Well, it did a new, some assignments, a delete a QString creation...
and then nothing with those
2011-06-03 08:58:50 +01:00
Kurt Hindenburg
3d20c090bf The last patch had some formatting issues and unused variable. 2011-04-23 21:07:26 -04:00
Kurt Hindenburg
e9d2a0b5e9 Fix an #include duplicate. 2011-04-17 22:57:19 -04:00
Kurt Hindenburg
48cdd11371 Add profile option to disable underlining links.
Add a configuration item that allows disabling of the underlined links
on mouse hover. The option is profile specific and defaults to the previous
behaviour where links are underlined on hover.

Patch by Amand Tihon <amand.tihon@alrj.com>

BUG: 174261
FIXED-IN: 4.7
CCMAIL: amand.tihon@alrj.com
2011-04-16 13:39:42 -04:00
Kurt Hindenburg
b88dfb402a Delegate PgUp/Down and Up/Down +Shift+AppScreen to terminal application.
After this patch, the following in the .keytab will work:

key Up+Shift+AppScreen : "appup"
key Down+Shift+AppScreen : "appdown"
key PgUp+Shift+AppScreen : "apppgup"
key PgDown+Shift+AppScreen : "apppgdown"

Patch by Tomáš Čech tcech@suse.cz

FEATURE: 267100
FIXED-IN: 4.7
2011-04-14 11:25:11 -04:00
Kurt Hindenburg
ff3f1cdce2 Substitue obsolete method of QDrag (start->exec). 2011-03-03 15:37:59 -05:00
Christophe Giboudeaux
8707e2e353 Build. 2011-01-30 20:32:09 +01:00
Kurt Hindenburg
f979c16ff7 Revert drag-n-drop to what KDE 3.x used such that CTRL is nowe required.
BUG: 165923

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1211082
2011-01-03 04:26:01 +00:00
David Faure
698a05b26d Fix use of deleted memory because the pointer returned by getImage() gets deleted+recreated when
updateImageSize emits changedContentSizeSignal() which ends up calling getImage() too.
Please check, I don't really know this code -- but valgrind was clear about the error.
CCMAIL: robertknight@gmail.com

Maybe it solves the crashes from 246652 if they were caused by this memory corruption.
(Hard to tell, without a valgrind log of that crash)
CCBUG: 246652

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1196295
2010-11-12 23:11:18 +00:00
Valentine Sinitsyn
253a5cc824 Make bold font for bright (intensive) ANSI colors a user-configurable option rather than hardcoded default.
BUG: 226308


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1133477
2010-06-01 20:06:11 +00:00
Sascha Peilicke
45d27ec764 Second chunk of menubar changes, see http://reviewboard.kde.org/r/3875/ for details.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1122683
2010-05-04 13:31:46 +00:00
Kurt Hindenburg
bc3e902d65 Correct where new Hotspots are calculated upon resize.
CCBUG: 228443

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1097379
2010-03-01 04:10:55 +00:00
Kurt Hindenburg
4b4dcf5afa Revert a fix for 199161 which is causing an ASSERT to crash.
CCBUG: 228443

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1097311
2010-02-28 22:02:17 +00:00