Summary:
BUG: 383603
Add the new KDE standard tab switching shortcuts that were introduced in https://phabricator.kde.org/R237:d85a57645f94d2d087711d7c608a0c5a46ed7ede.
Test Plan: Built and tested with current git master in up-to-date KDE Neon. Expected behavior is seen (default shortcuts have become shift+left/right and cmd+pgup/pgdn).
Reviewers: #kde_applications, #konsole, hindenburg, aacid, ltoscano, pino, dfaure
Reviewed By: dfaure
Subscribers: dfaure, davidedmundson, aacid, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D7354
DBus slot that returns the unique ids of the sessions in the
current view. The returned list is not sorted.
Differential Revision: https://phabricator.kde.org/D7067
KXMLGUIClient->actionCollection() only returns a non NULL value so I
don't think these checks are needed but for now add Q_ASSERTs and
returns. Previously, the if() didn't cover all the assignments.
The key sequence 'Ctrl+Shift+S' is ambiguous. Use 'Configure Shortcuts'
from the 'Settings' menu to solve the ambiguity. This shortcut was used
repeated times.
Now its changed to CTRL+SHIFT+X. For closing active tab in the konsole
of the split screen, it uses CTRL+SHIFT+X
Thanks to Aniketh Girish anikethgireesh gmail com
REVIEW: 129305
BUG: 354954
These 2 were hard coded - this allow them to be set in the profile.
There is currently no UI for these; add these to profile:
[General]
TerminalMargin=1
TerminalCenter=false
Thanks to Josef Kufner jk frozen doe net for patch
It appears the center flag doesn't work and perhaps hasn't for a long
time.
BUG: 346450
Konsole has builtin code to manually write out line characters. There
are certain reasons why this might not be desired. This adds a profile
option to use the fonts line characters. The default is as-is today
using the builtin code.
BUG: 364992
Implements a feature from e. g. good old Konqueror/KHTML, where you got
a number overlaid all links when pressing ctrl, and then you could press
ctrl+number to activate that link.
REVIEW: 128348
This patch allows the dnd menu to be disabled, making it possible to
drag and drop URLs as text by default.
Thanks to Peter Wu peter lekensteyn nl for patch
REVIEW: 124908
BUG: 304290
Move code responsible for 'forgetting' a view outside of code responding to the
TerminalDisplay deletion.
This avoids a loop like this:
~MainWindow
=> ~QStackedWidget
=> ~TerminalDisplay
=> QObject::destroyed
=> ViewContainer::viewDestroyed
=> ViewContainer::removeViewWidget
- internal cleanup
- try to remove TerminalDisplay from QStackedWidget which is being deleted and
crash
Instead the code now does:
~MainWindow
=> ~QStackedWidget
=> ~TerminalDisplay
=> QObject::destroyed
=> ViewContainer::viewDestroyed
=> ViewContainer::forgetView (does the internal clean up)
And if one tries to explicitly remove a view, sequence is:
ViewContainer::removeView
=> ViewContainer::forgetView
=> ViewContainer::removeViewWidget
The patch also removes ViewManager::focusActiveView() because it causes a crash
when closing a TerminalDisplay as it tries to put the focus on the deleted
TerminalDisplay. I initially called it through a queued connection, but realized
it is actually not needed for focus to be passed to the correct view, so just
removed it.
BUG: 331724
REVIEW: 118839
New feature in 2.13 allows columns/rows in profiles; however, the
rows would be incorrect depending on if tabbar was visible. Ideally,
this should not be needed but I would guess this won't get fixed
correctly until frameworks timeframe.
This calculation can still be wrong if ShowNavigationAsNeeded and
perhaps other times depending on height of tabbar.
FIXED: 2.13
(cherry picked from commit 73e1db3e3b)
With the recent new code, profiles can have the terminal col/rows.
Everyone will notice that the rows won't match what Konsole uses.
(cherry picked from commit 90691643fb)
This removes the profile setting to 'Save window size upon exit'. Now
it is in the Konsole settings; each profile can now set desired column
and row size.
Konsole Settings->Configure Konsole->General->Use current window size
on next startup:
Enabled - ignores all profile size settings - uses previous window size
Disabled - profile size settings are used - set via Edit Current
Profile 1st tab
Only new windows will use "new" col/row/size settings.
BUG: 152385
REVIEW: 115628
FIXED-IN: 2.13
(cherry picked from commit 931d64df81)
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
