Commit Graph

201 Commits

Author SHA1 Message Date
Jekyll Wu
3e0df809d2 Move array vt100_graphics[32] to more approriate place. 2011-10-14 23:20:48 +08:00
Jekyll Wu
bf3911ac90 Group font related methods 2011-10-14 17:26:26 +08:00
Jekyll Wu
a2642e08ef Less magic number to make the code more readable 2011-10-14 17:05:46 +08:00
Jekyll Wu
8d5d138d16 Group input method related methods 2011-10-14 16:26:12 +08:00
Jekyll Wu
644320ec35 Group mouse related methods 2011-10-14 16:20:52 +08:00
Jekyll Wu
c85397c23b Adjust indentation 2011-10-14 16:07:03 +08:00
Jekyll Wu
5492209f16 Adjust coding style 2011-10-14 15:49:25 +08:00
Jekyll Wu
2caa9e8c5d Remove duplicated code 2011-10-14 14:59:00 +08:00
Jekyll Wu
7a6f2aff0c Reuse Screen::defaultChar to reduce duplicated code 2011-10-14 14:41:11 +08:00
Jekyll Wu
8ffe485c24 Refacotor the updateImageSize() method 2011-10-14 14:14:43 +08:00
Jekyll Wu
8ffcb00118 Put related code closer 2011-10-14 12:47:38 +08:00
Jekyll Wu
59fe1beeb1 Not a good idea to call setCurrentTerminalDisplay() on every keystoke 2011-10-14 11:33:35 +08:00
Jekyll Wu
9fd0672458 Use the same variable consistently 2011-10-14 11:29:22 +08:00
Jekyll Wu
8beec0ad2f Minor change on code style 2011-10-14 10:08:03 +08:00
Jekyll Wu
5af12f08e3 Adjust indentation 2011-10-14 09:25:21 +08:00
Jekyll Wu
00e046fd6f SIGNAL(isBusySelecting(bool)) is not used anymore. 2011-10-14 04:09:28 +08:00
Jekyll Wu
976fc7bd3b Put related lines closer 2011-10-14 03:45:29 +08:00
Jekyll Wu
316e8427e7 "A || ( !A && B )" is actually the same as "A || B" 2011-10-14 03:31:03 +08:00
Jekyll Wu
3428b5cc57 Mark the problem of _mouseMarks 2011-10-14 03:18:46 +08:00
Jekyll Wu
4cd3af3c0f Remove dead code related with SIGNAL(clearSelectionSignal()) 2011-10-14 02:12:13 +08:00
Jekyll Wu
c7d4a4549b Move comment to more approriate place 2011-10-14 02:02:58 +08:00
Jekyll Wu
8a6d9bade0 Remove dead code related with SIGNAL(testIsSelected(bool)) 2011-10-14 01:59:47 +08:00
Jekyll Wu
beaefb2948 Rename method setSelection() to setXSelection() for clarity 2011-10-13 10:11:18 +08:00
Jekyll Wu
1ac8246ce9 Rename the emitSelection() method to doPaste()
The old name is really weird.
2011-10-13 09:58:54 +08:00
Jekyll Wu
354033e6f0 Rename pasteFromSelection to pasteFromXSelection 2011-10-13 09:45:00 +08:00
Jekyll Wu
c4a3398ef8 Refactor the drawLineCharString() method 2011-10-13 09:12:48 +08:00
Jekyll Wu
0a9abe991d Refactor the drawCharacters() method 2011-10-13 09:02:19 +08:00
Jekyll Wu
07b11fca4d Add comment for readability 2011-10-13 08:53:08 +08:00
Jekyll Wu
e1cf074b06 Refactor the drawCursor() method 2011-10-13 08:48:12 +08:00
Jekyll Wu
78c82a7d45 Rename member varibale dragInfo into _dragInfo 2011-10-11 02:00:31 +08:00
Jekyll Wu
2cbaa251a8 Minor change on comment 2011-10-11 01:38:35 +08:00
Jekyll Wu
fd4314d392 Remove one useless local variable 2011-10-10 23:56:01 +08:00
Jekyll Wu
f36887343c Move #include to the beginning. 2011-10-10 23:34:51 +08:00
Jekyll Wu
f56298ab62 Minor change on comment position 2011-10-10 20:05:50 +08:00
Jekyll Wu
07c2230dda Remove dead macro and comment. 2011-10-10 20:02:24 +08:00
Jekyll Wu
7fbfb0aee0 remove meaningless "#undef KeyPress" 2011-10-10 20:01:02 +08:00
Jekyll Wu
b729248dcb Rename for clarity. 2011-10-10 19:53:54 +08:00
Jekyll Wu
27f55b9f37 change _antialiasFont from static member into instance member.
antialias is a per display attribute, so it doesn't make sense to
define _antialiasFont as static member.
2011-10-10 18:08:28 +08:00
Jekyll Wu
0ca11c659f Initialize _showTerminalSizeHint as true to be consistent with profile default. 2011-10-10 17:33:54 +08:00
Jekyll Wu
b83b0c5419 Fix the inconsisten name/value between two scrollback emums.
TODO: it does not feel good to have two essentially the same enums
in two different places.
2011-10-10 17:25:41 +08:00
Jekyll Wu
2d7a67cc88 Remove memeber _terminalSizeStartup and related methods/calls.
That member was meant to control whether showing size hint on startup,
while it is actually only used to avoid showing size hint on startup.
That job can be done by a static variable within showResizeNotification()
2011-10-10 16:45:19 +08:00
Jekyll Wu
9ea9d62785 Reimplement the feature of "show/hide the size widget after resising"
This is a follow up of commit b40a006d which closees BUG 169054.
It turns out the old code already has most parts of similar logic.
So remove duplicated logic in the code.
2011-10-10 16:23:22 +08:00
Jekyll Wu
a3865d460e _clipboard is not a good name for non-member variable. 2011-10-10 15:17:12 +08:00
Jekyll Wu
66146b2e68 re-group members in a more related way. 2011-10-10 15:12:10 +08:00
Jekyll Wu
3d1f074cc3 Add 'Text' into the names of text-blinking related members and methods.
Explicit is often better than implicit.
2011-10-10 15:00:12 +08:00
Jekyll Wu
714ec30c32 Rename for consistency and clarity 2011-10-10 14:35:30 +08:00
Jekyll Wu
be4630f81f Remove dead method TerminalDisplay::setCursorPos() 2011-10-10 12:44:40 +08:00
Jekyll Wu
272ac9850e Include KDE headers consistently in the from of "#include <KSomething>" .
However, some KDE headers are still only available in the form of
"#include <ksomething.h>"

krun.h              ==>     KRun
kicon.h             ==>     KIcon
kdebug.h            ==>     KDebug
kshell.h            ==>     KShell
kdialog.h           ==>     KDialog
kconfig.h           ==>     KConfig
klocale.h           ==>     KLocale
kglobal.h           ==>     KGlobal
kcolorutils.h       ==>     KColorUtils
kconfiggroup.h      ==>     KConfigGroup
kdesktopfile.h      ==>     KDesktopFile
kcolorscheme.h      ==>     KColorScheme
kstandarddirs.h     ==>     KStandardDirs
ktemporaryfile.h    ==>     KTemporaryFile
klocalizedstring.h  ==>     KLocalizedString
2011-09-23 05:04:46 +08:00
Jekyll Wu
e14b2099cc Each filename inserted in d&d operation should be followd by a space.
FEATURE: 280838
FIXED-IN:4.8
2011-09-14 06:48:43 +08:00
Jekyll Wu
f78b734ef2 Remove unused #include . 2011-09-06 06:38:51 +08:00