Commit Graph

1982 Commits

Author SHA1 Message Date
Kurt Hindenburg
3e661e36b2 Apply astyle-kdelibs
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-23 11:50:10 -05:00
Kurt Hindenburg
7c6538712d Apply astyle-kdelibs 2011-12-23 00:36:42 -05:00
Kurt Hindenburg
c953cbd04b Merge branch 'kdebug' 2011-12-22 11:27:15 -05:00
Kurt Hindenburg
9f22f0ac58 Don't build XKB if we've set to avoid it.
My MacOSX Lion with macports won't build w/o this patch.  If we are
avoiding XKB, there is no reason to compile it.
Currently only Apple and OSF have avoid XKB.
2011-12-22 10:09:18 -05:00
Kurt Hindenburg
6acb48a23d Update version for new master/4.9 2011-12-22 09:54:43 -05:00
Kurt Hindenburg
bc087ae51b Remove unused KDebug includes 2011-12-18 00:01:32 -05:00
Jekyll Wu
36bd1828f3 Revert "Ensure %w and %# are also expaned in the 'Copy input' dialog"
That fix is not good enough because it makes '%w' being updated only
after keystroke instead of immediately . The issue of updating title is
actually a little more complicated than I have understood.

Revert it because the regression should influence more users than the
fixed problem does. Need to spend more time to find a better fix.

CCBUG: 175755
CCBUG: 287536

This reverts commit 1c1981501b.
2011-11-29 14:15:47 +08:00
Kurt Hindenburg
28d2782631 Doxygen doesn't like '\t' since their commands start with \ 2011-11-27 17:56:53 -05:00
Jekyll Wu
72a1adc631 Avoid extra trailing whitespace when copying text
A new 'isRealCharacter' flag is added into the 'Character' class
to distinguish real characters and charaters used as place holders.

The code is a bit ugly now. Should improve it later when the idea and
implementation are proven to be feasible and cause no regression.

CCBUG: 188528
2011-11-26 10:59:08 +08:00
Jekyll Wu
a3744135fc Respect leading and trailing white spaces in the search string
BUG:286614
FIXED-IN:4.8
2011-11-20 13:09:07 +08:00
Jekyll Wu
044fdf9020 Always use Left-To-Right as the "document layout" in the terminal area
REVIEW:102976
BUG:279048
FIXED-IN:4.8
2011-11-20 09:05:02 +08:00
Kurt Hindenburg
e718e93bf0 Add bidirectional text support by default
Make Konsole BiDi rendering enabled by default. Default Shell.profile
and also fallback profile are updated to have BidiRenderingEnabled set
to true by default.
AFAIK there is no reason not to have it on by default.  I don't see
any penalty code-wise.
BUG: 198169
FIXED-IN: 4.8
2011-11-19 15:46:35 -05:00
Jekyll Wu
b95f9443a0 Trivial change on #include 2011-11-16 13:31:24 +08:00
Jekyll Wu
ba3e2b4448 Use the bracket form for including konsoleadaptor.h
I'm not sure which form is the right one, but at least it should be
consistent.
2011-11-15 02:19:43 +08:00
Kurt Hindenburg
0905a301e6 Prevent crashing when dumping binary files to terminal.
"cat"ing binary files often crashes Konsole.  This patch checks the
indicies.
Note that there are tons of 'undecodable sequences' that also print
out.  These likely should not be displayed unless debugging.
BUG: 184964
FIXED-IN: 4.8
2011-11-13 16:21:49 -05:00
Jekyll Wu
e9e729074b Remove unnecessary '#include <QtGUI/QLineEdit' 2011-11-14 03:42:09 +08:00
Kurt Hindenburg
cb56375fff Update version for KDE 4.8 2011-11-12 11:30:18 -10:00
Kurt Hindenburg
4e5586f5c0 Revert "Add more i18nc KUIT context."
This reverts commit 05f8cc339f.

The issue is that some of the color schemes are in the KDE3 format
and some in KDE4.  This close to 4.8, I'll revert and fix later.

BUG: 286205
2011-11-12 10:37:16 -05:00
Jekyll Wu
142e6b73ca Normalize signal/slot 2011-11-07 17:28:58 +08:00
Jekyll Wu
d300378cae Make the "copy input to" dialog also being window modal
It is generally a good idea to make it modeless in the future
2011-11-06 12:53:22 +08:00
Jekyll Wu
81c6bccdc6 Make the tab rename dialog being window modal
This means that dialog will only block the current window, instead of
the whole application.

BUG:208229
FIXED-IN:4.8
2011-11-06 12:38:22 +08:00
Jekyll Wu
82ef9ccd3a Fix 2 Krazy issues with modal dialog 2011-11-06 12:06:31 +08:00
Jekyll Wu
125e2c7bd2 Declare pointer and reference in a consistent way
Most code use the "const QString& text" form, instead of the "const
QString &text" form. So change the minority to be consistent with
the majority.
2011-11-06 06:13:28 +08:00
Jekyll Wu
1826cfcdc9 Delete the unused 'Title' entry within Profile 2011-11-06 05:32:44 +08:00
Jekyll Wu
903dbe1b7f Make the code slightly more readable 2011-11-06 05:26:54 +08:00
Jekyll Wu
80ec2d216b Delete some kDebug messages 2011-11-06 03:47:14 +08:00
Jekyll Wu
330de6c6f4 Fix some spelling problems 2011-11-06 03:41:20 +08:00
Jekyll Wu
d601bd735a Change some global variables into static variables within method 2011-11-06 02:42:52 +08:00
Jekyll Wu
8f1bbd4353 Remove trailing white spaces 2011-11-05 19:49:23 +08:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
3432eaf388 Move code around and adjust whitespace 2011-11-03 18:04:13 +08:00
Jekyll Wu
50a07d79da Remove dead method Screen::compose(String) 2011-11-03 06:53:49 +08:00
Jekyll Wu
dcab90676b More document for public methods. 2011-11-03 06:23:34 +08:00
Jekyll Wu
6e7b93da0b Add document for some simple methods marked with "document me" 2011-11-03 05:50:02 +08:00
Jekyll Wu
948a56bb87 Prefer forward declaration 2011-11-03 03:54:04 +08:00
Jekyll Wu
fd4f45661b Remove dead code 2011-11-03 01:44:40 +08:00
Jekyll Wu
ad256b632c Avoid setting $PWD as "."
That would cause strange result. For example, run "konsole --workdir .",
then bash or zsh would report its current dir as "."

This is a follow up of commit 790e835c6f
2011-11-03 00:19:07 +08:00
Jekyll Wu
13fea35f69 Rename member variables to the form of _var for consistency 2011-11-02 10:51:13 +08:00
Jekyll Wu
02377dabf5 Minor change on layout and whitespace 2011-11-02 10:22:42 +08:00
Jekyll Wu
099a728206 Remove one FIXME which seems not a problem 2011-11-02 07:51:30 +08:00
Jekyll Wu
124fe7fddc Make internal constant static 2011-11-02 06:57:54 +08:00
Jekyll Wu
9f8969eb27 Remove some very old FIXMEs
I am not sure they all are already fixed, but taking their age into
consideration, leaving them there would be more confusing than helpful.
2011-11-02 06:54:23 +08:00
Jekyll Wu
70dbf3e92c Put pure virtual methods closer 2011-11-02 06:39:32 +08:00
Jekyll Wu
c2cc2f76ed Use size of -1 to indicate unlimited history, instead of the current 0
The old way has one problem: HistoryFileNone::isUnlimited() returned
true because HistoryFileNone::maximumLineCount() returned 0. Although
that did not cause problem for practical usage, it was still quite odd.
2011-11-02 06:23:40 +08:00
Jekyll Wu
d54b36c206 Remove unused method getFileName() 2011-11-02 05:01:17 +08:00
Jekyll Wu
0620d38d6f Minor change on whitespace 2011-11-02 04:59:56 +08:00
Jekyll Wu
3f1e01802d Move code around for better understanding 2011-11-02 04:33:42 +08:00
Jekyll Wu
7572e517e4 Add static declaration for some internal functions 2011-11-02 04:20:27 +08:00
Jekyll Wu
aea71d8892 Comment out two deprecated implementations for history of fixed size
The code of class HistoryScrollBuffer and HistoryScrollBlockArray are
quite old and not in use for quite some time. The current implementation
for history of fixed size is class CompactHistoryType.

Maybe those deprecated classes should be totally removed , but at the
moment just leave theme there as reference.
2011-11-02 01:04:29 +08:00
Jekyll Wu
2d4e6c6dd8 Remove unused #include 2011-11-01 13:41:54 +08:00