Move some code from EditProfileDialog::showColorSchemeEditor
* a part went in the slot EditProfileDialog::saveColorScheme
* a part becomes obsolete since ColorSchemeEditor is the whole KDialog
* a small part went into ColorSchemeEditor constructor
Make ColorSchemeEditor a non-modal dialog : The terminal is not frozen
when the dialog is open
- The Kdialog has an Apply button
- Some safeguard to check that there is only one ColorSchemeEditor open
- Use reference rather than pointer in ColorSchemeEditor interface
Thanks to Renan for improving on Konsole's ColorScheme.
Patch by renan fargetton renan.fargetton@gmail.com
REVIEW: 110560
GUI:
Add _isNewScheme bool as private member in ColorSchemeEditor class,
making the dialog aware if it correspond to a new theme or not.
Patch by renan fargetton renan.fargetton@gmail.com
REVIEW: 110534
The built-in behavior of Ctrl+<Mouse Wheel> to zoom in/out the terminal
can not be disabled. This patch adds an option to disable this
behavior. (Default to the original behavior).
Original patch by Yichao Yu yyc1992@gmail.com
I made some changes - bugs are mine as usual
REVIEW: 107281
FIXED-IN: 4.11
GUI:
Note, this doesn't mean the description can't be edited. It just can't
be changed in that UI.
Thanks to Yichao Yu for the spotting and the patch.
REVIEW: 107289
In the ongoing issue with spaces at the end of lines, this allows for
an option to trim the spaces. By default, it is disabled so only
people who need this will be affected.
Many thanks to David Smid <david@smidovi.eu>
CCBUG: 188528
So if someone notices later some Qt header is included in the form
of "#include <Class>" instead of the more common form of "#include
<Module/Class>", do not rush changing it.
REVIEW: 105819
A previous commit make the font size an integer. Per Christoph Feck
there are valid reasons to allow x.y font sizes. This patch restores
that ability.
An update/fix to ebc594cdf6
CCMAIL: christoph@maxiom.de
This replaces the text size slider by a number input w/ arrows. The
slider is awkard to change the size. Instead of fixing the slider, the
input arrows seem a better choice. The KIntNumInput has a slider that
could be enabled we want to enable it.
REVIEW: 105796
This provides a profile GUI to change the line spacing (0-5). Due to
the Qt4.8/BIDI issues, allowing the user to change the spacing allows
the user to fix any issues w/ the font they are using.
FEATURE: 279490
REVIEW: 105478
FIXED-IN: 4.10
This adds a GUI checkbox per profile to enable/disable requiring the
CTRL key to drag-n-drop text.
The default is to require the CTRL key as before.
Thanks to Scott Kitterman (kde@kitterman.com) for patch.
BUG: 165923
REVIEW: 105423
FIXED-IN: 4.10
The idea is to give users better hint that Konsole requires fixed-width font,
so only valid fixed-width fonts are listed. That should help reducing the
common question: "Why font <xyz> is not listed in konsole?"
* support "automatially copy selected text into clipboard"
* mouse middle button can be customized to paste from selectio or
clipboard
The first feature might look like a unnecessary duplicate of the
"synchronize selection and clipboard" feature of Klipper. However, that
klipper feature is generally problematic, while doing it only in Konsole
is generally useful and harmless.
FEATURE: 183490
FIXED-IN: 4.9.0
REVIEW: 103861
DIGEST:
This make EditProfileDialog and RenameTabsDialog reuse the same
widget, instead of duplicating each other in its own code or .ui file.
RenameTabsDialog is now just a simple container of RenameTabWidget
This make EditProfileDialog and HistorySizeDialog reuse the same
widget, instead of duplicating each other in its own code or .ui file.
HistorySizeDialog is now just a simple container of HistorySizeWidget
This reduces:
* The duplicated code for setting up that push button
* The duplicate entries in ui files for the Text and ToolTip
Note: there are still quite some duplicate between RenameTabsDialog and
EditProfileDialog. Maybe it is good idea to create a customized widget
EditTabTitleWidget to reduce the duplicate
* It never works in KDE4
* It is never revealed to users in KDE4
* It is better to be a global and konsole-only option; does it make
sense for a konsolepart to resize itself?
class KDE3ColorSchemeReader is also moved since it is supposed to an
compatibility helpr of which class ColorScheme does not need to know,
and eventualy it should be removed
The WarningBox.cpp is not deleted at the moment, in case using
KMessageWidget turns out to be problematic .
Note: the miminal requirement for kdelibs is increased to 4.7.0
due to using KMessageWidget.
REVIEW: 104053
