Commit Graph

216 Commits

Author SHA1 Message Date
Kurt Hindenburg
48a8a40566 More changes to QLatin1String, QLatin1Char and QStringLiteral 2017-05-08 09:38:57 -04:00
Kurt Hindenburg
a540e6fdd0 Fix readability-implicit-bool-cast issues using nullptr 2017-04-21 10:51:31 -04:00
Kurt Hindenburg
2b586e6ff8 use auto 2017-03-28 11:25:26 -04:00
R.J.V. Bertin
378518ea4b shortcut adaptation to platform standards on Mac
REVIEW: 120323
2016-11-24 17:35:31 +01:00
David Faure
efeaa73fe1 Fix compilation with KF < 5.23, patch by Aniketh Girish.
(part of https://git.reviewboard.kde.org/r/129305)
2016-11-01 11:58:05 +01:00
Martin T. H. Sandsmark
e21fc13c47 Warn when trying to close window with open tabs
REVIEW: 128668
BUG: 333023
2016-08-29 00:10:08 +02:00
Martin T. H. Sandsmark
79ca76a946 Fix checking of foreground process
The old method of checking it has unnecessary overhead (doing a full
process info update), and wasn't very reliable.

Instead just get the original shell PID from QProcess (via KProcess),
and the foreground process from the PTY.

CCBUG: 367746
REVIEW: 128789
2016-08-28 19:12:36 +02:00
Martin T. H. Sandsmark
6c23f43ec3 Avoid asking the user a second time for confirmation of closing an active tab 2016-08-13 20:51:06 +02:00
Martin T. H. Sandsmark
a28902e912 Fix transparent backgrounds
It's apparently not possible to set WA_TranslucentBackground after
show(). The MainWindow constructor calls applyKonsoleSettings() which
calls KMainWindow::setAutoSaveSettings() which in turn calls
setVisible(true), which makes any calls to setTransparency() from the
Application::newMainWindow() irrelevant, even if updateUseTransparency()
is called from it.

REVIEW: 128669
BUG: 366368
2016-08-13 20:33:48 +02:00
Kurt Hindenburg
92bc47ae14 Allow changing window icon only upon valid icon
Patch from rjvbertin gmail com
2016-07-08 10:12:27 -04:00
Kurt Hindenburg
f5418597f6 includes cleanup 2016-06-19 19:02:26 -04:00
Martin T. H. Sandsmark
27dec8d02f Port away from kdelibs4support.
Original work by Dāvis Mosāns.

REVIEW: 127625
REVIEW: 126808
2016-06-11 17:24:12 +02:00
Kurt Hindenburg
efca9088a3 Fix previous commits changing some \r to \n
f016a0f874 incorrectly changed all
sendTextToTerminal to send an \n - some previously had \r
2016-06-04 17:05:53 -04:00
Kurt Hindenburg
f016a0f874 Create new internal session->sendText() replacement method
Standardize all the internal Konsole sendText() calls into a new one.
In preparation for upcoming qdbus sendText changes.
2016-05-28 08:11:36 -04:00
Kurt Hindenburg
0a5e2b3497 When setting window size, take into account when menubar is not visible
Take into account menubar visibility when sizing a new window.
Note that this is only used when 'Use current window size on next
startup' is unchecked.

Thanks to Roman Gilg subdiff gmail com for patch

BUG: 359662
REVIEW: 27803
2016-05-21 18:43:10 -04:00
Kurt Hindenburg
fa5b25fced Restore KDE4 behavior - do not ask for confirmation on logout
Thanks Wolfgnag Bauer (wbauer) for patch

REVIEW: 127128
2016-03-05 12:10:21 -05:00
Kurt Hindenburg
70818f8c47 .arg() needs QStringLiteral 2015-10-15 16:40:19 -04:00
Kurt Hindenburg
bdee35bf38 Use QStringLiteral and QLatin1String 2015-10-15 16:25:32 -04:00
Kurt Hindenburg
04a5749717 Switch to use foreach() w/ QActions 2015-10-04 15:34:22 -04:00
Kurt Hindenburg
7ae2140235 s/KShortcut/QKeySequence - commented out code ATM 2015-09-18 09:42:47 -04:00
Kurt Hindenburg
e14c2992c5 Use const reference inside Q_FOREACH 2015-09-12 17:19:31 -04:00
Kurt Hindenburg
5168fa3c24 Move ManageProfiles dialog to Configure Konsole window
Change the stand alone ManageProfiles dialog into a tab inside the
Configure Konsole window.

Side effect is that Konsole KParts can't open manage profiles.
2015-09-12 14:27:23 -04:00
Kurt Hindenburg
a1957e8a8f Allow user to select where the scrollback/history files are written.
Currently, when unlimited scrollback is used, the files are stored in
/tmp.  As noted in the bug report, this can cause issues on some
distros.  The default is still /tmp but the user can selected to use
a location in their $HOME folder (QStandardPaths::CacheLocation).

This is somewhat a WIP.  Allowing for the changes to take effect
immediately appears to be a gigantic mess to get to work.

CCBUG: 173283
2015-08-16 13:32:36 -04:00
Aleix Pol
0975d32db9 Stop KDELibs4Support from being the all-mighty dependency
Now only Konsole application and some tests link against it
2015-04-17 18:02:14 +02:00
Kurt Hindenburg
571ffb4fb3 When visible session icon changes, change program icon
Sync window program icon with the visible session icon.  Noticeable
when using "Send to all" or "Monitor For"

BUG: 325413
REVIEW: 121399
2015-01-24 14:03:41 -10:00
Kurt Hindenburg
0b46073244 Remove unneeded includes 2015-01-07 04:14:10 -10:00
Kurt Hindenburg
95687e84b0 More KAction->QAction porting
REVIEW: 120557
2014-10-28 07:04:53 -04:00
Montel Laurent
79661ac5f6 Fix includes 2014-10-19 09:05:29 +02:00
Montel Laurent
83515eafbc Port to new connect api 2014-10-18 14:11:18 +02:00
Montel Laurent
78c9fd39cf Port to QMenu 2014-10-17 09:01:37 +02:00
Michal Humpula
d3310de9e0 port KIcon to QIcon
REVIEW: 120493
2014-10-11 14:38:18 +02:00
Lukáš Tinkl
cc85a5243c QAction::setShortcut -> KActionCollection::setDefaultShortcut 2014-10-06 22:27:29 +02:00
Kurt Hindenburg
b6304bcc59 Port KUrl to QUrl
Thanks to Michal Humpula michal humpula hudrydum cz

REVIEW: 120430
2014-10-04 11:41:50 -04:00
Kurt Hindenburg
eda0e431b2 Minor whitespace changes 2014-09-15 09:37:42 -04:00
Lukáš Tinkl
694b644bd2 remove accel markers
so that the top menubar doesn't conflict with Alt+<x> shortcuts
2014-07-15 20:19:46 +02:00
Kurt Hindenburg
86ee13f583 Fix crash in Manage Profile Dialog
In KDE5, KMenu* KActionMenu::menu() no longer creates a KMenu if it
doesn't exist.

Thanks to Arjun Ak arjunak234 gmail com

REVIEW: 119004
2014-07-02 10:26:05 -04:00
Eike Hein
c4f7f512f3 Fix translucency support.
CCBUG:332408
2014-05-26 14:00:24 +02:00
Alex Richardson
a3ce74d4eb Convert to Qt5 signal slot syntax
REVIEW: 117482
2014-04-30 19:16:54 +02:00
Kurt Hindenburg
cb84422082 Temporary crash fix - disable KWindowSystem::compositingActive() calls
See bko for more info

CCBUG: 332408
2014-03-22 00:03:40 -04:00
Kurt Hindenburg
6381dfff50 Add F11 as a shortcut for full screen
BUG: 303424
FIXED: 2.14
(cherry picked from commit 47fafb2134)
2014-03-04 23:26:41 -05:00
Kurt Hindenburg
522e4a57ba Allow konsole to store terminal size in the profile.
This removes the profile setting to 'Save window size upon exit'.  Now
it is in the Konsole settings; each profile can now set desired column
and row size.

Konsole Settings->Configure Konsole->General->Use current window size
on next startup:
Enabled - ignores all profile size settings - uses previous window size
Disabled - profile size settings are used - set via Edit Current
 Profile 1st tab

Only new windows will use "new" col/row/size settings.

BUG: 152385
REVIEW: 115628
FIXED-IN: 2.13
(cherry picked from commit 931d64df81)
2014-02-17 09:26:18 -05:00
Kurt Hindenburg
19ceea24f3 Allow users to specify css file for tab bar style
Currently, the default stylesheet for the tab bar just sets the min
and max width.  Now the user can load a .css file.  It is up to the
user to generate the css file to their liking.  Handbook documentation
and examples will follow.

This can be used to set minimum width of the tabs, distinguish active
tab, etc...
BUG: 330252
BUG: 330558
BUG: 330556
FEATURE:
REVIEW: 115554
FIXED-IN: 2.13

(cherry picked from commit da9331e0e9)
2014-02-10 09:25:15 -05:00
Kurt Hindenburg
4d5a30c821 Add option to remove '- Konsole' from window title
This may be overkill but for now add option to remove app name from
title.  The option is in the app-wide General Configure settings and
doesn't add unreasonable space to the dialog.

REVIEW: 115354
FEATURE: 307355
FIXED-IN: 2.13
(cherry picked from commit db6d9de83e)
2014-02-07 08:58:32 -05:00
Martin T. H. Sandsmark
adb57981be Don't add empty process items to list of currently running processes in a window
(cherry picked from commit 00e14ee248)
2014-01-11 18:54:03 -05:00
Kurt Hindenburg
1ea501da62 remove include moc from .cpp files - removes build warnings 2013-10-22 20:07:23 -04:00
Martin T. H. Sandsmark
3eb3605227 Check processes running when closing window
Instead of just counting the number of open sessions check what
processes are actually running in them when displaying the confirmation
dialog when closing a window.
(cherry picked from commit e0e7136b0c)
2013-10-02 10:11:24 -04:00
Alex Richardson
a83db71590 Port to KF5/Qt5
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937
2013-08-20 23:34:35 +02:00
Alex Richardson
ab5e15b1b7 Revert "Port to KF5/Qt5"
This reverts commit 4adfbe84bd.

This work will go into a new branch instead
2013-08-13 23:26:19 +02:00
Alex Richardson
4adfbe84bd Port to KF5/Qt5
To build for KF5 pass the option -DQT5_BUILD=ON to CMake

TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937
2013-08-13 21:26:59 +02:00
Michael Pyne
e61326fd0b Fix crash by not assuming standard shortcuts are present.
Neither of the two standard shortcuts used here are *guaranteed* to be
present (kdelibs filters both with some KAuthorized magic, and
help_contents also depends on the documentation subsystem), so avoid
crashing just because they're not around.

First noticed on my Gentoo-provided Konsole which is compiled without
the handbook USE flag.
(cherry picked from commit 8950584966)
2013-06-08 13:42:01 -04:00