mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-06-12 07:55:07 -04:00
Code Issues Packages Projects Releases Wiki Activity
6,035 Commits 141 Branches 418 Tags
4db5fb89e7681462f72bc95830eb86fbf9dc3edf
Commit Graph

80 Commits

Author SHA1 Message Date
Kurt Hindenburg
b4b4a502bf More changes to QLatin1String, QLatin1Char and QStringLiteral 2017-05-07 14:25:59 -04:00
Kurt Hindenburg
eade05a4bd Do not specify Qt modules in includes 2017-04-26 21:33:34 -04:00
Kurt Hindenburg
869c361602 constructors/decontructors use =default instead of {} 2017-04-01 14:01:41 -04:00
Kurt Hindenburg
dfafff97d4 remove QDebug/qWarning and use QCDebug 2017-03-31 21:06:18 -04:00
Kurt Hindenburg
66044df34b fix a lot of issues of readability-implicit-bool-cast 2017-03-29 08:32:59 -04:00
Kurt Hindenburg
068b2af454 use correct return value of write() and check for empty data 2017-03-27 09:39:00 -04:00
Kurt Hindenburg
7aef6a35f7 Check that pty()->masterFd() is valid in foregroundProcessGroup 
Other masterFd() have checks and it might prevent certain crashes in
Session::isForegroundProcessActive().
 2017-01-22 12:01:29 -05:00
Kurt Hindenburg
2671800b08 set default TERM=xterm-256color 
Change TERM=xterm to xterm-256color

CCBUG: 371919
BUG: 212145
 2016-11-24 11:29:11 -05:00
Martin T. H. Sandsmark
2f1c8cf397 Send EOF when closing first, before SIGHUP 
According to the bash maintainer sending EOF is the appropriate way of
telling e. g. bash to quit:
    http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602

I wasn't able to get KPtyProcess to send that in a nice way (calling
setStandardInputFile(QProcess::nullDevice(), for example), so we fetch
the EOF character manually with tcgetattr and send that.

BUG: 185140
REVIEW: 128416
 2016-07-11 12:57:54 +02:00
Kurt Hindenburg
fb2b4e3275 Port kde_file.h KDE::chmod to ::chmod 2015-02-08 10:25:55 -10:00
Kurt Hindenburg
959b7e3257 Port KDE_struct_stat to QT_STATBUF; KDE::stat to QT_STAT 2015-02-07 09:11:09 -10:00
Montel Laurent
8182ac8edc Port to QDebug 2014-10-17 09:09:20 +02:00
Alex Richardson
a3ce74d4eb Convert to Qt5 signal slot syntax 
REVIEW: 117482
 2014-04-30 19:16:54 +02:00
Kurt Hindenburg
f92a45da2f Check return values of ::stat() 
(cherry picked from commit 42240a7c6d)
 2014-04-16 21:40:05 -04:00
Kurt Hindenburg
8523bcf657 Check return value of KDE::chmod 
(cherry picked from commit fbffd35c31)
 2014-04-16 21:39:51 -04:00
Kurt Hindenburg
1ea501da62 remove include moc from .cpp files - removes build warnings 2013-10-22 20:07:23 -04:00
Kurt Hindenburg
2c686b7afe Minor warning fixes when running under FreeBSD 2013-02-23 10:00:25 -05:00
Jekyll Wu
1a26982427 "#ifdef(XYZ)" -> "#if defined(XYZ)" 
Use one form consistently in all code
 2012-11-20 11:42:12 +08:00
Jekyll Wu
0909c34405 Make code a little more consistent 2012-06-04 22:25:14 +08:00
Jekyll Wu
09fd58de95 Move the code for setting various Pty properties out of Pty:start() 
It feels strange that those properties are set again in Pty::start()
after they (should) have already been set before Pty::start() is called
 2012-06-04 22:07:47 +08:00
Jekyll Wu
045284c405 Swap the order of column(width) and line(height) in method signature 
It is more natural to use column x line.

TODO: The current code is inconsistent with itself regarding this issue
 2012-06-04 13:49:04 +08:00
Kurt Hindenburg
3ceb32461c Allow non-English for program names; useful w/ -e 
The old code used Latin1() to check program names and also used
QFile::encodeName().

Thanks to Eugene Shalygin for report and research.

Example:
cp `which vi` ./编辑器
konsole -e ./编辑器
BUG: 297529
FIXED-IN: 2.8.3
 2012-04-10 11:27:32 -04:00
Kurt Hindenburg
5b083640ce whitespace and style fixes 
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
 2012-04-05 11:08:53 -04:00
Kurt Hindenburg
8412c8c2d6 /s/0L/0 2012-03-21 08:20:39 -04:00
Jekyll Wu
25b8b5353c Trivial style change: remove extra blank lines 2012-03-17 19:53:21 +08:00
Jekyll Wu
bd9e7bfe3b Remove unneeded #includes 2012-03-07 00:22:49 +08:00
Kurt Hindenburg
4d774b6137 -Wshadow fixes to parameter names and variable names 2012-03-06 09:00:25 -05:00
Jekyll Wu
d81e355b54 Session does not need to know about internal detail of Pty 2012-03-06 21:24:55 +08:00
Jekyll Wu
cf1a4d0ea5 Invert the boolean logic to make the code more natural 2012-03-06 10:55:46 +08:00
Jekyll Wu
b60d33c64e Reduce code duplication 2012-03-06 10:48:23 +08:00
Jekyll Wu
8d8454a1cc Move code around for better readability 2012-03-06 10:16:32 +08:00
Jekyll Wu
90469a094a Add more constness 2012-03-06 02:00:15 +08:00
Jekyll Wu
78dbf8f1c1 Remove the left-over & unused code for supporting "Scroll Lock" key 
It is decided to not reimplement this feature in KDE4 konsole:

  * It is non-trivial work to implement it correctly
  * It annoyed some users when it was available in KDE3 konsole
  * Not many users want this feature back

This is a follow up of commit cee0ce539b

CCBUG:172271
REVIEW:104156
 2012-03-05 08:29:12 +08:00
Jekyll Wu
f42fd4721b Clean up unneeded #includes 2012-02-20 19:41:38 +08:00
Jekyll Wu
1db95618c9 QLatin1String ==> QLatin1Char 2012-02-10 03:28:28 +08:00
Jekyll Wu
c1cbab0f01 Make sure the $TERM envirable is always set 
The existing code sometimes fails to set $TERM. For example, when
the selected profile on disk contains this line :

    Environment=FOO=BAR

Konsole fails to set $TERM
 2012-02-10 03:00:38 +08:00
Jekyll Wu
7e6916d57c Move some environment varibale settings from Pty to Session 
I failed to see the intention of adding some environment variables in
class Session while adding some other environment variables in class
Pty. The current way makes Pty::start() contain too many parameters,
which looks ugly and is not easy to understand.

The only side effect of this commit is dbus method environment() will
return more. I don't think that would be harmful.
 2012-02-10 02:38:04 +08:00
Jekyll Wu
d9dfcdb9f0 Make the code a little more readable 2012-02-09 22:48:15 +08:00
Jekyll Wu
fdca5195cc Remove trailing slash when settings initial working directory 
BUG:293710
FIXED-IN: 2.8.1
 2012-02-09 22:00:43 +08:00
Jekyll Wu
6b6a5944f6 Prefer foreach(...) over while(...) for simplicity and readability 2012-01-22 10:21:45 +08:00
Kurt Hindenburg
cca04c279c Don't pollute the namespace - only "using" what is required. 2011-12-26 20:52:24 -05:00
Kurt Hindenburg
46c27663aa Apply astyle-kdelibs 
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
 2011-12-24 11:09:15 -05:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
ad256b632c Avoid setting $PWD as "." 
That would cause strange result. For example, run "konsole --workdir .",
then bash or zsh would report its current dir as "."

This is a follow up of commit 790e835c6f
 2011-11-03 00:19:07 +08:00
Jekyll Wu
790e835c6f Do not resolve the symlink for initial working directory. 
The patch is from Danny Daemonic <DannyDaemonic@gmail.com>

FEATURE: 242114
FIXED-IN: 4.8
 2011-09-30 23:56:19 +08:00
Jekyll Wu
5c59f17871 Fix a stupid mistake introduced in recent commit. 2011-09-27 15:17:19 +08:00
Jekyll Wu
195abc0324 Rename erase char related methods in class Pty. 
erase()    ==> eraseChar()
setErase() ==> setEraseChar()
 2011-09-27 13:27:38 +08:00
Jekyll Wu
afeb04c469 Make the code slightly more readable. 2011-09-27 12:52:57 +08:00
Jekyll Wu
4075c3b9d4 Invert the predication in 'if' statement. 
"if (enable)"  is more natural than " if (!enable)" .
 2011-09-27 12:33:56 +08:00
Jekyll Wu
b7d8843b54 Rename for clarity: cols ==> columns 2011-09-27 12:21:57 +08:00