Commit Graph

138 Commits

Author SHA1 Message Date
Kurt Hindenburg
b4b4a502bf More changes to QLatin1String, QLatin1Char and QStringLiteral 2017-05-07 14:25:59 -04:00
Kurt Hindenburg
eade05a4bd Do not specify Qt modules in includes 2017-04-26 21:33:34 -04:00
Kurt Hindenburg
dfafff97d4 remove QDebug/qWarning and use QCDebug 2017-03-31 21:06:18 -04:00
Kurt Hindenburg
2b586e6ff8 use auto 2017-03-28 11:25:26 -04:00
Martin T. H. Sandsmark
c5ccfc20e8 Don't crash/assert on trying to load session with invalid ID
Failing to find a ID should not be a fatal assert, the ViewManager
handles it properly.

BUG: 372173
2016-11-20 14:29:00 +01:00
Andreas Hartmetz
35fdfb2fcb A loop can run zero times without another check.
While at it, constify and adjust coding style.
2016-10-08 20:32:22 +02:00
Kurt Hindenburg
6d39aa019b add session.count() to qWarning 2015-10-10 18:30:57 -04:00
Montel Laurent
83515eafbc Port to new connect api 2014-10-18 14:11:18 +02:00
Montel Laurent
bce7d53c72 kdelibs4support-- 2014-10-18 13:07:29 +02:00
Montel Laurent
8182ac8edc Port to QDebug 2014-10-17 09:09:20 +02:00
Kurt Hindenburg
b6429eadec port from K_GLOBAL_STATIC to Q_GLOBAL_STATIC
Patch by Michal Humpula michal humpula hudrydum cz

REVIEW: 120496
2014-10-05 10:01:00 -04:00
Alex Richardson
a3ce74d4eb Convert to Qt5 signal slot syntax
REVIEW: 117482
2014-04-30 19:16:54 +02:00
Kurt Hindenburg
1ea501da62 remove include moc from .cpp files - removes build warnings 2013-10-22 20:07:23 -04:00
Kurt Hindenburg
e02fea6e17 astyle fixes
use git diff -w --ignore-all-space to see non-space changes
2012-08-05 13:35:03 -04:00
Kurt Hindenburg
ad52474e0c minor style changes - remove spaces 2012-05-13 12:33:35 -04:00
Kurt Hindenburg
bee9aa8f78 minor style fixes - remove empty lines start/end code blocks 2012-05-13 10:08:05 -04:00
Jekyll Wu
cc8cdd87c8 Move class SessionModelList into its own files 2012-04-20 11:38:49 +08:00
Jekyll Wu
c0cc298f48 Some small cleanup 2012-04-20 09:07:53 +08:00
Jekyll Wu
50668d65b0 Set the initial/preferred terminal size accroding to profile options
The old code always set the hardcoded 80x40 size.

Two profile options are added under the "General" group:

  * TerminalColumns
  * terminalRows

Note: Due to the way KMainWindow works, those profile options may not
work :(. Do not take this commit as something completed.
2012-04-09 11:37:04 +08:00
Kurt Hindenburg
5b083640ce whitespace and style fixes
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
2012-04-05 11:08:53 -04:00
Jekyll Wu
f2eed5bdb9 Cleanup #includes 2012-04-05 15:41:09 +08:00
Jekyll Wu
dc08f6dc37 Rename: ShouldApplyProperty2 ==> ShouldApplyProperty 2012-04-03 08:09:46 +08:00
Jekyll Wu
ace798d58d Merge the code of SessioManager::updateSession() into another method
SessioManager::updateSession() is only used once by the other method. No
good reason to keep two methods.
2012-04-03 08:07:44 +08:00
Jekyll Wu
193777e21a Split class SessionManager into ProfileMananger and SessionManager
REVIEW: 104425
2012-03-30 01:23:28 +08:00
Jekyll Wu
c5f0c6794d Prefer the convenient methods for accesing profile options 2012-03-21 06:08:23 +08:00
Jekyll Wu
5a1851e361 Another trivial change 2012-03-19 21:26:39 +08:00
Jekyll Wu
33678e7ca4 Add more convenient methods for accessing profile option 2012-03-19 18:29:44 +08:00
Jekyll Wu
6511de621b Prefer using the available convenient method for profile option 2012-03-19 17:31:11 +08:00
Jekyll Wu
683f2c9ec5 Merge Profile::HistoryModeEnum and HistorySizeDialog::HistoryMode into Enum::HistoryMode Enum 2012-03-19 16:07:27 +08:00
Kurt Hindenburg
e0862c603a Style fixes - separte commands - remove 2 ; - align { elses 2012-03-18 15:57:48 -04:00
Kurt Hindenburg
519e2614d6 Style fixes - remove spaces before ; and add spaces in for loops 2012-03-18 15:11:06 -04:00
Jekyll Wu
25b8b5353c Trivial style change: remove extra blank lines 2012-03-17 19:53:21 +08:00
Kurt Hindenburg
4dae2895bb Separate the profile reader/writer to their own file 2012-03-16 11:14:05 -04:00
Jekyll Wu
f4fb943132 Most of time we only need <KLocalizedString> instead of <KLocale> 2012-03-07 06:48:26 +08:00
Jekyll Wu
dccfaf1b54 Remove one unneeded #include 2012-02-29 02:08:54 +08:00
Jekyll Wu
f42fd4721b Clean up unneeded #includes 2012-02-20 19:41:38 +08:00
Jekyll Wu
9bfac3b509 Krazy2 fix for foreach(...)
Well, I don't think there is actually problem here for POD types.
Anyway, just change it to make krazy happy :)
2012-02-15 02:44:59 +08:00
Jekyll Wu
f0529c1c02 Prefer foreach(..) over iterating manually for readability 2012-02-13 21:28:48 +08:00
Jekyll Wu
13bdd4c611 Minor changes 2012-02-10 21:00:29 +08:00
Jekyll Wu
5044ebb263 SessionManager::loadProfile should return immediately with non-existing path 2012-02-07 05:40:13 +08:00
Kurt Hindenburg
0bd1927585 Select right profile name in saveFavorites()
Do not use "profile->name()" for retrieve profile name, but take it
from profile path.

When a profile name is changed (ex. test -> test2):
profile->path() (/home/xxxx/.../test.profile)
profile->name() (test2.profile)

Thanks to Francesco Cecconi (francesco.cecconi@gmail.com ) for patch

BUG: 292637
REVIEW: 103807
FIXED-IN: 4.9
2012-01-28 11:49:19 -05:00
Jekyll Wu
debfec2eb3 Add environment variable $KONSOLE_PROFILE_NAME
It records the name of the profile used in current tab/session.

FEATURE: 227296
FIXED-IN:4.9
2012-01-24 20:23:32 +08:00
Jekyll Wu
d33056c178 Rename: type ==> profile for more specific meaning 2012-01-22 10:21:45 +08:00
Jekyll Wu
6b6a5944f6 Prefer foreach(...) over while(...) for simplicity and readability 2012-01-22 10:21:45 +08:00
Kurt Hindenburg
8240973baf Use relative paths in config file
konsolerc uses in 'Favorites Profiles' and 'Profile Shortcuts' the full
path.  Changing this to relative path (if in a KDE location) allows
one user can copy then to another.

FIXED-IN: 4.9
BUG: 283102
REVIEW: 102749
2012-01-21 16:28:59 -05:00
Jekyll Wu
dcc57fce24 Split the exisint setDefaultProfile() methods into two methods 2012-01-16 20:55:38 +08:00
Jekyll Wu
81167d1084 Move the logic of ensuring all profiles are loaded into SessionManager itself.
The idea of delaying loading all profiles until needed is an internal
optimization, and should be hidden to the users of SessionManager.
2012-01-16 14:58:46 +08:00
Jekyll Wu
40f8bf736a Rename for clarity: closeAll() ==> closeAllSessions() 2012-01-16 13:31:04 +08:00
Jekyll Wu
3d8da1f878 Make 'foreach(...)' more readable 2012-01-14 22:54:56 +08:00
Jekyll Wu
562e949b52 Remove the code for reading KDE3 profile.
See BKO 218655.
2012-01-11 23:51:04 +08:00