In previous incarnations of kuniqueapplication it used to inject a common
command option --nofork which is meant to bypass single-instance behavior.
Given that konsole can and is being invoked from scripts they may well want
to ensure that the fork they created is the actual instance of konsole.
i.e. to monitor return values and life time
Presently, since the options are divergent between konsole4 and konsole5,
scripts are either incompatible with older konsoles or with newer konsoles.
To make life easier for everyone add a compat alias --nofork, which
behaves exactly like separate.
(this unbreaks steam, which is a notable recent offender of falling into
this particular trap)
REVIEW: 129647
CHANGELOG: Added compatibility command option `--nofork` for single-instance behavior
Adds a setting for forcing the use of multiple instances instead of
running all instances in the same process. This way all terminals don't
go down when one instance crashes.
REVIEW: 129345
If a new Konsole instance is launched via DBus (e. g. single process
mode), it re-used the QCommandLineParser each time, so each new instance
would inherit all parsed options.
Most noticeably is if you have konsole running, press Shift+F4 in
Dolphin to launch a Konsole instance in the current folder (which leads
Konsole to use a temporary profile), and then try to open a new konsole
instance outside of that, it would open in the folder from Dolphin.
REVIEW: 129217
debian policy for reasons beyond my apprehension wants a -T option to
set the window title (like in xterm).
to make debian's (and derivate's) life easier let's support a no-op
-T option but hide it. this option will not appear in --help output
but be accepted by the parser all the same.
this enables Debian and friends to drop a long standing useless patch
and at the same time prevents us from introducing a conflicting -T in
the future.
REVIEW: 128299
KDBusService is designed in a way that is fundamentally not compatible
with Qt, where it exit()s before the QApplication is deleted, which
leads to a lot of weird crashes in various parts of Qt.
To work around this we install an atexit() handler to delete the
QApplication before we shut down.
REVIEW: 127626
konsole is using
-DTRANSLATION_DOMAIN=\"konsole\"
that is wrong for applications, apps need to use
KLocalizedString::setApplicationDomain
since that is needed for some things like the transltators tab in the about
dialog.
I have not removed -DTRANSLATION_DOMAIN=\"konsole\" because on the other hand
this code is also a library (i.e. the konsole kpart).
The "being pedanticly correct" fix would be using -DTRANSLATION_DOMAIN=\"konsole\"
only to compile the files that are part of the kpart but that's prone to
break at some point and using both KLocalizedString::setApplicationDomain and
-DTRANSLATION_DOMAIN does not create any problem so i went that route
CCMAIL: konsole-devel@kde.org
The rc and ui files were already migrated. This patch copies the other
files from share/apps/konsole to local/share/konsole.
CCBUG: 346762
FIXED-IN: 15.08.0
(cherry picked from commit 5c13d4641a)
For now revert this, on non X11 systems it causes:
FAILURE (KCmdLineArgs):
Application requests for isSet("display") but the "display" option
has never been specified via addCmdLineOptions( ... )
This reverts commit d42ef186c8.
Use a new process if --separate is used on command line. Similiar to
--detach (from kuniqueapplication).
Patch by Jekyll Wu <adaptee@gmail.com>
BUG: 309249
REVIEW: 107127
FIXED-IN: 2.13
(cherry picked from commit 2b31d26151)
For now restore this option that was removed for 2.11. This option
is somewhat a hack and abnormal feature. However, it seems a number
of people use it and I can see how it would be useful. So instead of
spending a lot of time right now trying to correct the issues, just
restore the previous code.
Ideally for KDE 5, this portion of the code can be better handled.
35bb9cf9e7
BUG: 320783
FIXED-IN: 2.13#
(cherry picked from commit cfbfb0fd8c)
Conflicts:
src/Application.cpp
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
To build for KF5 pass the option -DQT5_BUILD=ON to CMake
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
If an user had only one profile and accidently puts a non-interactive
program (eg pwd) in the Command section it will start, run command and
then close.
The FALLBACK/ profile is the internal basic profile.
REVIEW: 109558
FIXED-IN: 4.11
