Commit Graph

380 Commits

Author SHA1 Message Date
Kurt Hindenburg
b0e4e474a9 For QPointer do not compare to nullptr, use isNull() 2018-04-01 14:45:13 -04:00
Kurt Hindenburg
8b4cbcaf7a Use constuctor initialization list for all members 2018-04-01 11:30:45 -04:00
Kurt Hindenburg
b85c469efc Check for valid session when detaching to prevent crashes
It is unclear what causes the session to be invalid when detaching
tabs, but there are enough BRs with the same backtraces to confirm it.
For now, check to prevent crashes.

CCBUG: 390736
2018-03-07 23:00:24 -05:00
Kurt Hindenburg
caf0ab2b75 Add a profile property to toggle copying text as HTML
The default behavior hasn't change.  Toggling this off will cause all
copy/paste to be text only.

BUG: 387397
FIXED-IN: 18.04
Differential Revision: https://phabricator.kde.org/D10448
2018-02-14 14:40:23 -05:00
Kurt Hindenburg
c63525fcdc Add option to ColorScheme to blur transparent background
Note that this does not affect KonsolePart; it is up to the app using
it to enable transparency (see src/tests/demo_konsolepart).

Patch by anemeth

FEATURE: 198175
Differential Revision: https://phabricator.kde.org/D10015
2018-02-01 08:52:05 -05:00
Kurt Hindenburg
3805cb9d9d convert QSignalMapper (switchToTab shortcuts) to lambda 2018-01-09 09:14:25 -05:00
Kurt Hindenburg
6b990498e7 convert QSignalMapper (viewAdded/Removed) to lambda 2018-01-08 22:57:57 -05:00
Kurt Hindenburg
cf56e5db4c sync declarations with definitions (have .h and .cpp variable names match) 2018-01-06 14:32:02 -05:00
Kurt Hindenburg
2e86be05dc Implement support for trimming leading whitespace
There's already an option for removing trailing whitespace.

Combining both pulls since the later makes the code easier to read.

Patches by sandsmark

Differential Revision: https://phabricator.kde.org/D8381
Differential Revision: https://phabricator.kde.org/D8417
2017-12-25 11:30:35 -05:00
Kurt Hindenburg
52185790cb Fix menus after closing a detaching tab
Patch by ahmadsamir

BUG: 348478
Differential Revision: https://phabricator.kde.org/D9448
2017-12-23 12:05:02 -05:00
Kurt Hindenburg
001d937d10 Add option to allow tab width to be expanding
Qt5.9+ changed the way tab widths are handled.  Add option to allow
tab width to expanding to full window or as width of tab text.

GUI:
BUG: 380879
FIXED-IN: 17.12
2017-11-05 11:56:18 -05:00
Albert Astals Cid
374b602d52 Add new standard KDE tab switching shortcuts (ctrl+pgup/pgdn)
Summary:
BUG: 383603

Add the new KDE standard tab switching shortcuts that were introduced in https://phabricator.kde.org/R237:d85a57645f94d2d087711d7c608a0c5a46ed7ede.

Test Plan: Built and tested with current git master in up-to-date KDE Neon. Expected behavior is seen (default shortcuts have become shift+left/right and cmd+pgup/pgdn).

Reviewers: #kde_applications, #konsole, hindenburg, aacid, ltoscano, pino, dfaure

Reviewed By: dfaure

Subscribers: dfaure, davidedmundson, aacid, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D7354
2017-08-28 01:01:37 +02:00
Kurt Hindenburg
8d27a2d388 Add new DBus method setCurrentSession
DBus slot that sets the current (active) session window using unique
session Id.

Differential Revision: https://phabricator.kde.org/D7066
2017-08-06 23:45:16 -04:00
Kurt Hindenburg
fa10e567ca change to use const_iterator 2017-08-06 23:33:12 -04:00
Kurt Hindenburg
c599242682 Add new DBus method sessionList
DBus slot that returns the unique ids of the sessions in the
current view.  The returned list is not sorted.

Differential Revision: https://phabricator.kde.org/D7067
2017-08-06 22:36:04 -04:00
Kurt Hindenburg
2a2a56d73c modernize use nullptr 2017-07-15 23:28:32 -04:00
Kurt Hindenburg
f360d02016 Add new DBus method newSession(profile)
This seems more useful then newSession(profile, directory) as the
working directory from the profile should be used.
A lot of duplicated code ATM.
2017-07-08 16:54:55 -04:00
Kurt Hindenburg
51cc49e95e Set KONSOLE_DBUS_WINDOW for new sessions started with DBus
BUG: 382116
2017-07-08 16:43:27 -04:00
R.J.V. Bertin
4cd725ffbe use the proper Mac platform token 2017-06-15 18:30:43 +02:00
Kurt Hindenburg
7d692e4446 uncrustify using kf5 config 2017-06-11 13:04:01 -04:00
Kurt Hindenburg
4db5fb89e7 More changes to QLatin1String, QLatin1Char and QStringLiteral 2017-05-08 10:12:49 -04:00
Kurt Hindenburg
59bdf59b24 remove unneeded includes 2017-04-26 22:52:07 -04:00
Kurt Hindenburg
eade05a4bd Do not specify Qt modules in includes 2017-04-26 21:33:34 -04:00
Kurt Hindenburg
a2b6a81b45 Add check for valid container (possible crash fix)
Possible fix for crashes from ambiguous shortcuts.  I have been unable
to duplicate the crashes.

CCBUG: 375540
2017-04-21 21:40:32 -04:00
Kurt Hindenburg
a540e6fdd0 Fix readability-implicit-bool-cast issues using nullptr 2017-04-21 10:51:31 -04:00
Kurt Hindenburg
ac8aedb3c6 Add Q_ASSERT/returns for _actionCollection
KXMLGUIClient->actionCollection() only returns a non NULL value so I
don't think these checks are needed but for now add Q_ASSERTs and
returns.  Previously, the if() didn't cover all the assignments.
2017-04-20 22:44:30 -04:00
Kurt Hindenburg
869c361602 constructors/decontructors use =default instead of {} 2017-04-01 14:01:41 -04:00
Kurt Hindenburg
5a15d20def use auto range loops 2017-03-31 22:21:10 -04:00
Kurt Hindenburg
2b586e6ff8 use auto 2017-03-28 11:25:26 -04:00
Kurt Hindenburg
369f990540 Fix numerous clazy issues
container-anti-pattern, detaching-temporary, incorrect-emit
2017-02-05 16:09:23 -05:00
R.J.V. Bertin
378518ea4b shortcut adaptation to platform standards on Mac
REVIEW: 120323
2016-11-24 17:35:31 +01:00
Martin T. H. Sandsmark
66e85acbc9 Silence ubsan warnings about invalid pointer casts
REVIEW: 129343
2016-11-09 13:31:41 +01:00
Kurt Hindenburg
f235818068 Change close activate view to Ctrl+Shift+X to avoid duplicate
The key sequence 'Ctrl+Shift+S' is ambiguous. Use 'Configure Shortcuts'
from the 'Settings' menu to solve the ambiguity. This shortcut was used
repeated times.

Now its changed to CTRL+SHIFT+X. For closing active tab in the konsole
of the split screen, it uses CTRL+SHIFT+X

Thanks to Aniketh Girish anikethgireesh gmail com

REVIEW: 129305
BUG: 354954
2016-11-07 14:21:45 -05:00
Martin T. H. Sandsmark
b2b044cf2a Make the config of file filters and url filters separate
REVIEW: 128828
BUG: 368234
2016-10-19 00:11:06 +02:00
Andreas Hartmetz
1b8c9ca40a A QSet is sufficient here. QSet is also hash-based. 2016-10-08 21:40:36 +02:00
Kurt Hindenburg
8e5a5b1ec1 Allow profile to set margin and center flag
These 2 were hard coded - this allow them to be set in the profile.
There is currently no UI for these; add these to profile:

[General]
TerminalMargin=1
TerminalCenter=false

Thanks to Josef Kufner jk frozen doe net for patch

It appears the center flag doesn't work and perhaps hasn't for a long
time.

BUG: 346450
2016-09-16 21:57:27 -04:00
Martin T. H. Sandsmark
04dce67996 Make the URL hint keyboard modifiers configurable
Instead of hardcoding CTRL which was a bit annoying add checkboxes to
the profile edit dialog to let the user select which keys to use.

REVIEW: 128778
2016-08-28 15:15:51 +02:00
Martin T. H. Sandsmark
13684bebe2 Fix crash when failing to restore session
REVIEW: 128670
BUG: 366217
2016-08-13 20:30:07 +02:00
Kurt Hindenburg
a4de3feb16 Add option to use the selected font's line characters
Konsole has builtin code to manually write out line characters.  There
are certain reasons why this might not be desired.  This adds a profile
option to use the fonts line characters.  The default is as-is today
using the builtin code.

BUG: 364992
2016-07-18 21:34:11 -04:00
Martin T. H. Sandsmark
6f02d6dbc9 Implement URL hints
Implements a feature from e. g. good old Konqueror/KHTML, where you got
a number overlaid all links when pressing ctrl, and then you could press
ctrl+number to activate that link.

REVIEW: 128348
2016-07-06 20:31:57 +02:00
Kurt Hindenburg
296cfc4233 remove unneeded #includes and forward classes 2015-10-15 18:45:11 -04:00
Kurt Hindenburg
ff66b231bf Remove unneeded includes 2015-09-16 23:34:40 -04:00
Kurt Hindenburg
917d932f46 Add const and & 2015-09-15 10:23:08 -04:00
Kurt Hindenburg
104f3dd1ef Remove unused function qHash 2015-09-15 10:18:43 -04:00
Kurt Hindenburg
0882caa18c Remove outdated dbus /Konsole - use /Windows/# 2015-09-12 12:42:33 -04:00
Kurt Hindenburg
7b07dd78cd s/QLatin1String/QStringLiteral/ 2015-09-12 12:35:49 -04:00
Kurt Hindenburg
9484507f90 Add option to insert DnD URLs as plain text
This patch allows the dnd menu to be disabled, making it possible to
drag and drop URLs as text by default.

Thanks to Peter Wu peter lekensteyn nl for patch

REVIEW: 124908
BUG: 304290
2015-08-29 08:40:38 -04:00
Kurt Hindenburg
b330491507 Fix crash when _viewSplitter->activeContainer() returns null
Crash research/fix by Alexander Richardson arichardson kde gmail com

FIXED-IN: 3.0.0
REVIEW: 121108
(cherry picked from commit 1826b91d26)
2014-11-27 13:05:46 -05:00
Montel Laurent
83515eafbc Port to new connect api 2014-10-18 14:11:18 +02:00
Michal Humpula
d3310de9e0 port KIcon to QIcon
REVIEW: 120493
2014-10-11 14:38:18 +02:00