mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-03 20:26:45 -04:00
Code Issues Packages Projects Releases Wiki Activity
4,549 Commits 139 Branches 416 Tags
5ebbba6efb8228e35b70ba7a2f841aeab19de7a2
Commit Graph

177 Commits

Author SHA1 Message Date
Jekyll Wu
5ebbba6efb Rename for clarity and consitency 2012-03-16 20:21:39 +08:00
Jekyll Wu
7179de8f3d Prefer qobject_cast to dynamic_cast when appropriate 2012-03-16 13:37:15 +08:00
Jekyll Wu
d99cf71a62 Rename method to match what it really does 2012-03-16 10:53:07 +08:00
Jekyll Wu
3bdf6bbe8c Remove unused signal: ViewContainer::closeRequest(QWidget*) 2012-03-16 10:25:20 +08:00
Jekyll Wu
4b7eedfb19 Add inline explanation for the casting 2012-03-16 10:25:10 +08:00
Jekyll Wu
edd9d2cfdf Revert "Use the appropriate casting" 
The received QWidget has already been destroyed, so using dynamic_cast
or qobject_cast does not work.

Another stupid mistake by me !

BUG: 296116

This reverts commit 02ac6dbf4d.
 2012-03-16 09:50:52 +08:00
Jekyll Wu
02ac6dbf4d Use the appropriate casting 2012-03-13 16:47:26 +08:00
Jekyll Wu
fa7fb637ff Move the code settings up 'split view' actions closer 2012-03-12 15:52:52 +08:00
Jekyll Wu
972ef5f97e Rename methods related with "split view" to avoid confusion 
"view" is reused to refer to two different things in ViewMananger:

  * one TerminalDisplay(tab/session)
  * one ViewContainer(tabbar)

That causes understanding problems for those who are not that familiar
with the code.

Maybe those actions related with "split view" defined in konsoleui.rc
should also be rename to avoid confusion further
 2012-03-12 15:35:36 +08:00
Jekyll Wu
0e152d9596 Remove old comment 2012-03-12 15:35:36 +08:00
Jekyll Wu
74eb0d9a59 More constness 2012-03-12 15:35:35 +08:00
Jekyll Wu
f4fb943132 Most of time we only need <KLocalizedString> instead of <KLocale> 2012-03-07 06:48:26 +08:00
Jekyll Wu
2f7a0965f5 Move class ColorSchemeMananger into its own file 
class KDE3ColorSchemeReader is also moved since it is supposed to an
compatibility helpr of which class ColorScheme does not need to know,
and eventualy it should be removed
 2012-02-29 22:31:56 +08:00
Jekyll Wu
f42fd4721b Clean up unneeded #includes 2012-02-20 19:41:38 +08:00
Jekyll Wu
b7498925b2 Fix #include 2012-02-20 03:38:38 +08:00
Jekyll Wu
2ba24db12c Add per-profile option 'BellMode' for choosing the type of bell 
There are no GUI elements for controlling that option, so it is a hidden
option at the moment.

To configure this option manually, put following lines into some konsole
profile under ~/.kde4/share/apps/konsole/ :

    [Terminal Features]
    BellMode=N

Where N could be 0 for system beep, 1 for system notification and 2 for
visual bell. That mapping might change before next major release.

CCBUG: 155622
CCBUG: 177861

REVIEW: 104013
 2012-02-19 06:50:52 +08:00
Jekyll Wu
07cddfe302 Create dbus object for each Konsole window respectively 
Its naming scheme is "/Windows/N", similar to "/Sessions/N" for
sessions. That is not the final decision and might change before next
major release.

The old "/Konsole" dbus object is still available at this moment, but
it might disappear or be used for something different in the future, so
it is better to use "/Windows/N" from now on.

For convenience, $KONSOLE_DBUS_WINDOW can be used to refer to the dbus
object corresponding to the Konsole window containing current session.
Note, that environment variable does not work well with detaching and
draging. Maybe it should not be added at all.

CCBUG:276912
CCBUG:281513
CCBUG:292309

REVIEW:103790
 2012-02-09 01:50:43 +08:00
Jekyll Wu
52f656663f Add dbus method for returning the name of the default profile 
FEATURE:252532
FIXED-IN:4.9
 2012-02-07 19:16:49 +08:00
Jekyll Wu
6b6a5944f6 Prefer foreach(...) over while(...) for simplicity and readability 2012-01-22 10:21:45 +08:00
Jekyll Wu
56f3805ac1 Move options influencing tabbar from profiles into global setting 2012-01-22 10:21:44 +08:00
Jekyll Wu
e3e960ab95 Move the 'show menubar' option from profiles into global settings 2012-01-22 10:21:29 +08:00
Jekyll Wu
6bf0fcf565 Remove two unnecessary calls to the applyProfileToContainer() method. 
That method only needs to be called once when the Container is created,
or when the related settings has changed.
 2012-01-16 23:32:13 +08:00
Jekyll Wu
455909a42c Dbus method profileList() should not list hidden profiles 2012-01-16 15:04:29 +08:00
Jekyll Wu
81167d1084 Move the logic of ensuring all profiles are loaded into SessionManager itself. 
The idea of delaying loading all profiles until needed is an internal
optimization, and should be hidden to the users of SessionManager.
 2012-01-16 14:58:46 +08:00
Jekyll Wu
3191cd00b4 Ensure the dbus method profileList() will list all profiles 2012-01-16 13:17:01 +08:00
Jekyll Wu
c6bb999066 Less explict call of session->run() 2012-01-15 22:34:56 +08:00
Jekyll Wu
3d8da1f878 Make 'foreach(...)' more readable 2012-01-14 22:54:56 +08:00
Kurt Hindenburg
1baa56feda White space changes - astyle and Qt normalize don't like each other. 
Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
 2011-12-25 13:13:55 -05:00
Kurt Hindenburg
59db5e74d2 Apply astyle-kdelibs 
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
 2011-12-24 11:41:55 -05:00
Kurt Hindenburg
bc087ae51b Remove unused KDebug includes 2011-12-18 00:01:32 -05:00
Jekyll Wu
b95f9443a0 Trivial change on #include 2011-11-16 13:31:24 +08:00
Jekyll Wu
ba3e2b4448 Use the bracket form for including konsoleadaptor.h 
I'm not sure which form is the right one, but at least it should be
consistent.
 2011-11-15 02:19:43 +08:00
Jekyll Wu
125e2c7bd2 Declare pointer and reference in a consistent way 
Most code use the "const QString& text" form, instead of the "const
QString &text" form. So change the minority to be consistent with
the majority.
 2011-11-06 06:13:28 +08:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
3432eaf388 Move code around and adjust whitespace 2011-11-03 18:04:13 +08:00
Jekyll Wu
e825a8e0b6 Prefer forward declaration when it is enough 2011-11-01 13:41:54 +08:00
Jekyll Wu
b485852440 use NotifyBell by default 2011-10-20 10:41:44 +08:00
Jekyll Wu
20572f6f48 Rename 'info' to 'profile' 2011-10-13 16:51:52 +08:00
Jekyll Wu
0c0bce4b55 Remove the duplicated comparison: _navigationMethod != NoNavigation 2011-10-13 16:41:40 +08:00
Jekyll Wu
15b1c1c812 Simplify the code for setting up shortcuts 2011-10-13 16:12:34 +08:00
Jekyll Wu
bed5144bab Disable 'expand/shrink-active-view' actions explicitly at first 
This makes them consistent with other multiViewOnlyActions.
 2011-10-13 15:41:57 +08:00
Jekyll Wu
89e7e20436 update containers only when there is only one session. 2011-10-10 19:31:17 +08:00
Jekyll Wu
da1bbbdb46 Minor change on comment and indentation. 2011-10-10 17:36:35 +08:00
Jekyll Wu
dcd042270f Remove duplicated and hardcoded callings. 
Such settings about TerminalDisplay should go into applyProfileToView(),
and refers the profile for right value(if possible).
 2011-10-10 17:28:40 +08:00
Jekyll Wu
b83b0c5419 Fix the inconsisten name/value between two scrollback emums. 
TODO: it does not feel good to have two essentially the same enums
in two different places.
 2011-10-10 17:25:41 +08:00
Jekyll Wu
2d7a67cc88 Remove memeber _terminalSizeStartup and related methods/calls. 
That member was meant to control whether showing size hint on startup,
while it is actually only used to avoid showing size hint on startup.
That job can be done by a static variable within showResizeNotification()
 2011-10-10 16:45:19 +08:00
Jekyll Wu
9ea9d62785 Reimplement the feature of "show/hide the size widget after resising" 
This is a follow up of commit b40a006d which closees BUG 169054.
It turns out the old code already has most parts of similar logic.
So remove duplicated logic in the code.
 2011-10-10 16:23:22 +08:00
Jekyll Wu
714ec30c32 Rename for consistency and clarity 2011-10-10 14:35:30 +08:00
Jekyll Wu
593186603b Make dbus method newSession(profile,directory) works as expected 
BUG:222233
FIXED-IN: 4.8
 2011-10-08 18:00:33 +08:00
Kurt Hindenburg
3fc7f9c147 Add some i18nc KUIT context. 2011-10-04 13:46:53 -09:00