Previous code just deleted the end characters; new code puts in spaces
with current attributes at the end of the line.
Thanks to Igor Kostromin elwood.su@gmail.com for bug, research + patch
See bko for test code + more info
BUG: 330214
FIXED-IN: 2.13
(cherry picked from commit 427de88cc1)
A lot of crashes in copyLineToStream _screenLines[screenLine]; this
likely needs to be a container, for now add an extra variable to watch
the size.
I still can't reproduce it though a lot of people can doing various
things.
319888, 313711, 312006, 306939, 304837
In the ongoing issue with spaces at the end of lines, this allows for
an option to trim the spaces. By default, it is disabled so only
people who need this will be affected.
Many thanks to David Smid <david@smidovi.eu>
CCBUG: 188528
A new 'isRealCharacter' flag is added into the 'Character' class
to distinguish real characters and charaters used as place holders.
The code is a bit ugly now. Should improve it later when the idea and
implementation are proven to be feasible and cause no regression.
CCBUG: 188528
"cat"ing binary files often crashes Konsole. This patch checks the
indicies.
Note that there are tons of 'undecodable sequences' that also print
out. These likely should not be displayed unless debugging.
BUG: 184964
FIXED-IN: 4.8
If you get a combining character as first "character" of a new line
what we used to go was go to the previous line and combine with the character of the end
This assumption is wrong as sometimes a combining character may appear "on its own" without nothing to combine with
If someone has time it is worth investigating what is the correct behaviour in those cases as it seems gnome-terminal shows the character even if it has nothing to combine with
To compare the result of a method only with a calculated value, there
is no need for a local variable. Let the compiler create itself the
value in the best place, stack or registry.
The current behavior is bold(1) will toggle the intensity of an
intensive color(93), so the result is a normal color. This is
counter-intuitive. Xterm, rxvt, and all vte-base emulators generate
intensive color in this case.
BUG: 274603
FIXED-IN: 4.8
REVIEW: 102554
Currently, when users use ctrl+mouse to select and copy multiple lines,
those lines are joined into single line in a seamless way. LINEBREAK is
simply removed, thus the first character of second line will be
positioned right after the last character of the first line. This patch
replaces the LINEBREAK with a SPACE.
Thanks to Jekyll Wu (adaptee@gmail.com) for patch and research.
BUG: 136730
FIXED-IN: 4.8
