Commit Graph

194 Commits

Author SHA1 Message Date
Alex Richardson
a3ce74d4eb Convert to Qt5 signal slot syntax
REVIEW: 117482
2014-04-30 19:16:54 +02:00
Kurt Hindenburg
91fb70992b Remove commented code and dead-code that was used in commented code
(cherry picked from commit ffd9e56cce)
2014-04-16 21:39:11 -04:00
Kurt Hindenburg
fdfeae05c1 Add some commented-out code about using QFileSystemModel + QCompleter
This needs looked at later.

The below causes a noticable delay when opening the dialog - I'm not
entirely sure this is the best way to handle this.
Issue is QLineEdit->SetCompleter() won't work w/ KDE's KUrlCompletion
2014-03-30 18:17:40 -04:00
Kurt Hindenburg
8c6c87f368 remove #pragma about kfiledialog crashing 2014-03-30 15:04:37 -04:00
Kurt Hindenburg
522e4a57ba Allow konsole to store terminal size in the profile.
This removes the profile setting to 'Save window size upon exit'.  Now
it is in the Konsole settings; each profile can now set desired column
and row size.

Konsole Settings->Configure Konsole->General->Use current window size
on next startup:
Enabled - ignores all profile size settings - uses previous window size
Disabled - profile size settings are used - set via Edit Current
 Profile 1st tab

Only new windows will use "new" col/row/size settings.

BUG: 152385
REVIEW: 115628
FIXED-IN: 2.13
(cherry picked from commit 931d64df81)
2014-02-17 09:26:18 -05:00
Kurt Hindenburg
57dc36b9d6 s/KLineEdit/QLineEdit 2014-01-18 14:42:02 -05:00
Kurt Hindenburg
597d4657a7 s/kde4_add_ui_files/qt5_wrap_ui cmake fix 2014-01-12 10:22:51 -05:00
Kurt Hindenburg
1ea501da62 remove include moc from .cpp files - removes build warnings 2013-10-22 20:07:23 -04:00
Kurt Hindenburg
a07533a91d Fix a few llvm scanner issues - pointer is null and dead assignment
llvm's scan-build likes to check object is not null before calling
method and removed one dead assignment.
(cherry picked from commit 1be837a6aa)
2013-09-23 09:03:18 -04:00
Kurt Hindenburg
6656338961 Add pragma to keep track of KFileDialog crashes 2013-09-17 13:44:16 -04:00
Kurt Hindenburg
b0b27355f1 Revert "Hide EditProfileDialog when ColorSchemeEditor is visible"
This reverts commit a6d76a08c1.

This worked while testing but now the ColorScheme dialog isn't
shown.

CCBUG: 324874
(cherry picked from commit f3dc509400)
2013-09-17 10:45:10 -04:00
Alex Richardson
a83db71590 Port to KF5/Qt5
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937
2013-08-20 23:34:35 +02:00
Alex Richardson
ab5e15b1b7 Revert "Port to KF5/Qt5"
This reverts commit 4adfbe84bd.

This work will go into a new branch instead
2013-08-13 23:26:19 +02:00
Alex Richardson
4adfbe84bd Port to KF5/Qt5
To build for KF5 pass the option -DQT5_BUILD=ON to CMake

TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937
2013-08-13 21:26:59 +02:00
Kurt Hindenburg
4884fcdcd3 Remove color scheme dialog animation
This animation has been in here for ages (2007).  I don't actually
see any reason for it.

Thanks to Harald Hvaal metellius@gmail.com

REVIEW: 111764
2013-08-11 17:47:54 -04:00
Kurt Hindenburg
bf89bf16dc normalize the connect signals/slots again 2013-05-24 09:15:11 -04:00
Kurt Hindenburg
a6d76a08c1 Hide EditProfileDialog when ColorSchemeEditor is visible
Hide EditProfileDialog when opening ColorSchemeEditor.  When the color
scheme is open, the terminal is usually blocked by the EditProfile
dialog.  So users have to move that dialog to see the terminal.  This
patch hides the EditProfile dialog.

Patch by renan fargetton renan.fargetton@gmail.com

REVIEW: 110536
2013-05-23 08:55:02 -04:00
Kurt Hindenburg
47e25b4c4c normalize the connect signals/slots 2013-05-23 08:53:08 -04:00
Kurt Hindenburg
2b8d43ef48 Transform ColorSchemeEditor class from QWidget to KDialog
Move some code from EditProfileDialog::showColorSchemeEditor
* a part went in the slot EditProfileDialog::saveColorScheme
* a part becomes obsolete since ColorSchemeEditor is the whole KDialog
* a small part went into ColorSchemeEditor constructor

Make ColorSchemeEditor a non-modal dialog : The terminal is not frozen
when the dialog is open
 - The Kdialog has an Apply button
 - Some safeguard to check that there is only one ColorSchemeEditor open
 - Use reference rather than pointer in ColorSchemeEditor interface

Thanks to Renan for improving on Konsole's ColorScheme.

Patch by renan fargetton renan.fargetton@gmail.com

REVIEW: 110560
GUI:
2013-05-22 09:23:42 -04:00
Kurt Hindenburg
fae004a827 Add _IsNewScheme bool member
Add _isNewScheme bool as private member in ColorSchemeEditor class,
making the dialog aware if it correspond to a new theme or not.

Patch by renan fargetton renan.fargetton@gmail.com
REVIEW: 110534
2013-05-20 10:05:12 -04:00
Kurt Hindenburg
a091014a14 Changing styling in accordance with KDE styling guidelines + comments
Patch by renan fargetton renan.fargetton@gmail.com

REVIEW: 110532
2013-05-20 09:43:57 -04:00
Kurt Hindenburg
18d5231443 Add GUI to alter profile setting handling Page Up/Down
This adds the GUI to setup the page up/down scrolling to either full
or half height.

The non-GUI code was in 3cd4d2e440

FEATURE: 280637
GUI:
2013-05-18 11:02:24 -04:00
Kurt Hindenburg
417af269e5 Add option to disable ctrl+<mouse-wheel> zooming
The built-in behavior of Ctrl+<Mouse Wheel> to zoom in/out the terminal
can not be disabled. This patch adds an option to disable this
behavior. (Default to the original behavior).

Original patch by Yichao Yu yyc1992@gmail.com
I made some changes - bugs are mine as usual
REVIEW: 107281
FIXED-IN: 4.11
GUI:
2012-12-28 09:51:34 -05:00
Kurt Hindenburg
9e25784d6d A few more c style casts -> static_casts 2012-12-24 09:55:58 -05:00
Kurt Hindenburg
eaeff78f51 Add i18n context markers for tooltips 2012-12-23 21:26:11 -05:00
Kurt Hindenburg
cdf2b2bc78 Switch from c-style casting to c++ casting via static_cast 2012-12-19 21:20:18 -05:00
Jekyll Wu
6bf21efc99 <kcodecaction.h> ==> <KCodecAction> 2012-11-17 15:01:47 +08:00
Jekyll Wu
1751840e5e Make keytab description non-editable in the keyboard tab
Note, this doesn't mean the description can't be edited. It just can't
be changed in that UI.

Thanks to Yichao Yu for the spotting and the patch.

REVIEW: 107289
2012-11-14 12:06:44 +08:00
Kurt Hindenburg
ca9dd11bf5 Allow option to trim spaces at end of line
In the ongoing issue with spaces at the end of lines, this allows for
an option to trim the spaces.  By default, it is disabled so only
people who need this will be affected.

Many thanks to David Smid <david@smidovi.eu>

CCBUG: 188528
2012-09-09 19:10:41 -04:00
Jekyll Wu
131091c983 Adjust including form for some Qt headers as preparation for Qt5
So if someone notices later some Qt header is included in the form
of "#include <Class>" instead of the more common form of "#include
<Module/Class>", do not rush changing it.

REVIEW: 105819
2012-08-14 17:32:06 +08:00
Kurt Hindenburg
52a1d835a3 Allow font size to a be double (1 digit) instead of an integer.
A previous commit make the font size an integer.  Per Christoph Feck
there are valid reasons to allow x.y font sizes.  This patch restores
that ability.

An update/fix to ebc594cdf6

CCMAIL: christoph@maxiom.de
2012-08-04 16:06:01 -04:00
Kurt Hindenburg
ebc594cdf6 Use a number input instead of a slider to pick text size
This replaces the text size slider by a number input w/ arrows. The
slider is awkard to change the size.  Instead of fixing the slider, the
input arrows seem a better choice.  The KIntNumInput has a slider that
could be enabled we want to enable it.

REVIEW: 105796
2012-08-01 08:56:17 -04:00
Francesco Cecconi
6b878d167a Fix issue where new profiles are not saved correctly
Due to new code untranslatedName, the saving of the profile was not
correct.  This patch fixes that.

BUG: 303354
REVIEW: 105648
FIXED-IN: 4.9.0
2012-07-24 19:15:39 +02:00
Jekyll Wu
248f2c3cc9 Add profile option for opening URL by direct click(off by default)
Thanks to Asko Eronen<asko.eronen@gmail.com> for the idea and patch

REVIEW: 105282
FEATURE:
DIGEST:
2012-07-15 01:41:13 +08:00
Kurt Hindenburg
57994c1d5d Provide GUI to change line spacing
This provides a profile GUI to change the line spacing  (0-5).  Due to
the Qt4.8/BIDI issues, allowing the user to  change the spacing allows
the user to fix any issues w/ the font they are using.

FEATURE: 279490
REVIEW: 105478
FIXED-IN: 4.10
2012-07-10 10:41:38 -04:00
Kurt Hindenburg
ed31a8b0aa Provde a GUI option to disable requiring CTRL to dnd text
This adds a GUI checkbox per profile to enable/disable requiring the
CTRL key to drag-n-drop text.
The default is to require the CTRL key as before.

Thanks to Scott Kitterman (kde@kitterman.com) for patch.

BUG: 165923
REVIEW: 105423
FIXED-IN: 4.10
2012-07-06 16:37:27 -04:00
Kurt Hindenburg
c9e2b4a094 escape the \ so it is displayed in the test font text 2012-05-13 12:59:16 -04:00
Kurt Hindenburg
bee9aa8f78 minor style fixes - remove empty lines start/end code blocks 2012-05-13 10:08:05 -04:00
Kurt Hindenburg
9f5877bdfc minor whitespace style changes 2012-05-13 08:51:27 -04:00
Jekyll Wu
e6ba69b36a UI string: Edit Font ==> Select Font
It feels strange and misleading to use "Edit". Clearly konsole won't
modify the listed fonts.
2012-05-08 04:27:57 +08:00
Jekyll Wu
b1b7f65146 Fix my stupid spelling error 2012-05-08 04:04:55 +08:00
Jekyll Wu
89a17cba37 Use customized caption "Select Fixed With Font" for the KFontDialog
The idea is to give users better hint that Konsole requires fixed-width font,
so only valid fixed-width fonts are listed. That should help reducing the
common question: "Why font <xyz> is not listed in konsole?"
2012-05-08 03:54:16 +08:00
Jekyll Wu
bb818010b4 Add two profile options for the copy & paste behavior of mouse
* support "automatially copy selected text into clipboard"
  * mouse middle button can be customized to paste from selectio or
    clipboard

The first feature might look like a unnecessary duplicate of the
"synchronize selection and clipboard" feature of Klipper. However, that
klipper feature is generally problematic, while doing it only in Konsole
is generally useful and harmless.

FEATURE: 183490
FIXED-IN: 4.9.0
REVIEW: 103861
DIGEST:
2012-04-25 12:55:38 +08:00
Kurt Hindenburg
ba34c4ebe2 normalize SIGNALS
It is annoying that kdelibs-style and Qt normalize conflict
2012-04-06 08:57:47 -04:00
Kurt Hindenburg
5b083640ce whitespace and style fixes
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
2012-04-05 11:08:53 -04:00
Jekyll Wu
d51fe86819 QList<String> ==> QStringList 2012-04-05 04:32:02 +08:00
Jekyll Wu
193777e21a Split class SessionManager into ProfileMananger and SessionManager
REVIEW: 104425
2012-03-30 01:23:28 +08:00
Jekyll Wu
af51e0ffcb Refacotr tab format related UI components into RenameTabWidget
This make EditProfileDialog and RenameTabsDialog reuse the same
widget, instead of duplicating each other in its own code or .ui file.
RenameTabsDialog is now just a simple container of RenameTabWidget
2012-03-26 21:14:02 +08:00
Jekyll Wu
c5f0c6794d Prefer the convenient methods for accesing profile options 2012-03-21 06:08:23 +08:00
Jekyll Wu
5c28f79f0e Revert "Rename: defaultTranslator ==> fallbackTranslator"
I was stupid

This reverts commit 912e52b12a.
2012-03-21 03:41:06 +08:00