Commit Graph

348 Commits

Author SHA1 Message Date
Kurt Hindenburg
57a5f23f1b Enable wordwrap on suspended message to avoid window resize
BUG: 333890
FIXED-IN: 2.13.1
(cherry picked from commit 24c90c36e7)
2014-05-08 21:53:22 -04:00
Alex Richardson
a3ce74d4eb Convert to Qt5 signal slot syntax
REVIEW: 117482
2014-04-30 19:16:54 +02:00
Kurt Hindenburg
e550e5cd7d Remove old code dealing with --no-resize option
In KDE 3.5, there used to be a --no-resize option; it was never
ported/used in KDE 4.x

(cherry picked from commit b180a6ac08)
2014-02-17 09:26:36 -05:00
Kurt Hindenburg
0f84f38c0a All 'select line' for use with shortcut
Select entire line from a shortcut.

Patch by Christian Couder chriscool@tuxfamily.org

BUG: 327395
FIXED-IN: 2.13
(cherry picked from commit 7cf548bea8)
2014-02-17 09:23:01 -05:00
Kurt Hindenburg
801d4d4b8c Add parameter to selectLine for selecting entire line
This will allow selectLine() to be called outside of using the Enum::
SelectWholeLine and SelectForwardsFromCursor.  If more Enums are added
this code will need adjusted.

CCBUG: 327395
(cherry picked from commit ce55487204)
2014-02-17 09:22:51 -05:00
Kurt Hindenburg
931cf74e63 Split mouseTripleClickEvent method into selectLine()
Use a helper method selectLine() which is most of the
mouseTripleClickEvent().  Also, in preparation for upcoming patch to
allow selectLine per shortcut.

CCBUG: 327395
(cherry picked from commit c5beb59032)
2014-02-17 09:22:42 -05:00
Kurt Hindenburg
aa766e57ab Add #if for MacOS to ignore opacity - it only adjusts brightness
CompositionMode doesn't work on MacOSX - since changing the opacity
just altered the brightness, #if def it.

(cherry picked from commit c05eda634a)
2014-02-17 09:17:18 -05:00
Kurt Hindenburg
d5d2d9ef0d Allow transparency to work when using images as backgrounds.
Previously when using an image as the background, the opacity was
ignored.  This patch corrects that.

Many thanks for patch to Wolfgang Brehm  wolfgang brehm gmail com

BUG: 312843
FIXED-IN: 2.13
(cherry picked from commit 09ca63dbb6)
2014-02-17 09:17:07 -05:00
Kurt Hindenburg
74ee063ea8 Dismiss flow control message after a few seconds
With flow control enabled, the first line of terminal is hidden with
the message about flow control.  This messsage will be dismissed after
10 seconds.

FIXED-IN: 2.13
BUG: 327281
REVIEW: 115607
(cherry picked from commit db8877db55)
2014-02-10 09:25:45 -05:00
Kurt Hindenburg
914067d14a Fix double click can only select text within visible region
Double-clicking on text will highlight text not on the visible screen.
This is the 2nd part of this patch.  The first part for triple clicking
highlighting the entire line is already in 2.12.

Thanks to Yichao Yu yyc1992@gmail.com for this big patch.

REVIEW: 111441
BUG: 319260
FIXED-IN: 2.13
(cherry picked from commit 0b69bdcd40)
2014-02-07 08:58:16 -05:00
Albert Astals Cid
0bd7b93744 Unset pointing hand cursor if set and not over a link
Acked by Martin Sandsmark

REVIEW: 114147
(cherry picked from commit be6bf3a1d4)
2014-01-11 18:54:40 -05:00
Kurt Hindenburg
92247161a9 Update link for flow control
(cherry picked from commit 15c968e7c1)
2014-01-11 18:53:54 -05:00
Martin T. H. Sandsmark
9e8235cb45 Allow control click to open URLs
When you hold down control, show a hand cursor and allow single clicks
when over links.

(cherry picked from commit e27279d28c)
2014-01-11 18:53:40 -05:00
Kurt Hindenburg
886f12d730 Add xterm's bracketed paste mode
Allow xterm's bracketed paste mode to work

When enabled by '\e[?2004h', pasted data is surrounded by \e[200~ and
\e[201~. This is mainly for text editors to temporarily switch off
autoindent and line wrapping.

http://invisible-island.net/xterm/ctlseqs/ctlseqs.html

This page have a .vimrc that will trigger this
https://bugzilla.gnome.org/show_bug.cgi?id=605299

Thanks to Egmont Koblinger for patch
BUG: 324946
FEATURE: 4.13

(cherry picked from commit 8082bcd2ef)
2014-01-11 18:46:03 -05:00
Kurt Hindenburg
1ea501da62 remove include moc from .cpp files - removes build warnings 2013-10-22 20:07:23 -04:00
Kurt Hindenburg
7d57334fcf fix build due to netaccess.h
still doesn't build due to kparts
2013-09-24 22:58:33 -04:00
Sebastian Kügler
b820dbf715 netaccess has moved to kde4support 2013-09-18 16:53:13 +02:00
Kurt Hindenburg
b3dcab9cdd very minor style issues w/ spaces
(cherry picked from commit f9e20a6042)
2013-08-26 08:33:20 -04:00
Kurt Hindenburg
a0326b4db7 update the findLineStart/End method docs
(cherry picked from commit 9a1d7dd502)
2013-08-26 08:33:07 -04:00
Kurt Hindenburg
674d580a81 fix a crash in my re-coding of findLineStart()
(cherry picked from commit fb60833d09)
2013-08-26 08:32:54 -04:00
Kurt Hindenburg
4284d9984f Use the new findLineStart/End for triple mouse click
follow up to the 2 previous commits - for bko 319260
(cherry picked from commit aeb3e9f178)
2013-08-26 08:32:43 -04:00
Kurt Hindenburg
da08042571 Implement new findLineStart/End methods
These 2 new methods are rewrites by me of the rb patch - if there are
issues, compare these two commits
(cherry picked from commit 18ed8d2fe3)
2013-08-26 08:32:30 -04:00
Kurt Hindenburg
6df0b5bf78 Start to fix selection issue when part of line/word is off-screen
This is from rb 111441- however that patch is so big it is difficult
to follow.  I'm breaking it up into smaller parts.  This commit is
just for findLineStart/End and only for extending the selection.

Thanks to Yichao Yu yyc1992@gmail.com
(cherry picked from commit 8976d35cfd)
2013-08-26 08:32:16 -04:00
Harald Hvaal
473f48f371 Various search improvements
- Do not automatically reset the search start line on search hits
    This was causing the annoying behavior that if you were to pause while typing
    in a search term, and it would actually find a hit, then you would be searching
    for the term a second time once you finish typing.

    This commit introduces two new behaviors:
    1. When you show the search bar, all searching will be done from the first
        visible line in the terminal.
    2. This start position is only reset when you
        advance to the next result, by pressing "next", "previous", or the shortcuts
        RETURN or SHIFT-RETURN

- When the view scrolls to a result, it will appear centered.
- When showing the search bar, do not invoke a search, only apply the highlight filters
- Add "search from beginning/end" button
    This will scroll to the top/bottom before searching
    Ctrl+return is also bound to this action
- Text highlighted by mouse will be set as the current search text when the incremental
    search bar is opened
- Add "Search backwards" to search bar options
    Button text is swapped according to reverse search switch

(cherry picked from commit aa42a27ef3)
2013-08-23 20:49:57 -04:00
Alex Richardson
a83db71590 Port to KF5/Qt5
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937
2013-08-20 23:34:35 +02:00
Alex Richardson
ab5e15b1b7 Revert "Port to KF5/Qt5"
This reverts commit 4adfbe84bd.

This work will go into a new branch instead
2013-08-13 23:26:19 +02:00
Alex Richardson
4adfbe84bd Port to KF5/Qt5
To build for KF5 pass the option -DQT5_BUILD=ON to CMake

TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937
2013-08-13 21:26:59 +02:00
Kurt Hindenburg
e5b7480966 Fix 'extend Selection' bug for apps not interested in mouse
New feature in 4.11 allows Shift+Click to extend the selection.
However, for programs not interested in mouse (vim, mc, etc) this
causes issues.  Fix is to ignore extending selection for those apps.

BUG: 321516
FIXED-IN: 4.11
2013-06-23 12:37:14 -04:00
Kurt Hindenburg
c56db4cfd0 Use QRect instead of manually handling terminal margins
Instead of keeping track of constants and +1 -1, use a QRect to handle
the terminal margins.  There is no GUI for this currently and the
margins are hard-coded to what they are now.  Code to center the
terminal is also include (w/o GUI).

This patch comes from review 109891 w/ a few changes from me.
Thanks to Mariusz Glebocki mglb@arccos-1.net
2013-05-18 07:51:29 -04:00
Kurt Hindenburg
5a85ef48fe Remove underline from an active link upon leaving terminal area
Patch from portion review 109891 by Mariusz Glebocki mglb@arccos-1.net
2013-04-10 10:34:36 -04:00
Kurt Hindenburg
a88f9cb417 Check boundary of image to get valid Character
This crash in isSpace() is due to invalid Character; check for valid
array size before grabbing it.  No one can reproduce the crash but this
can't hurt hopefully.

CCBUG: 309954
2013-03-16 19:06:28 -04:00
Kurt Hindenburg
b5dbf6b32f minor space/tab fixes 2013-03-16 12:36:05 -04:00
Francesco Cecconi
c45d07698f Prevent the opening of two or more "edit profile dialogs" per session.
Fixing the wrong behaviour to open two or more "edit dialog" for
one session/tab with the same profile, and the crash with two or
more "edit dialog", one for different session(tabs) with the same profile.

BUG: 311270
REVIEW: 107640
FIXED-IN: 4.11
2013-03-14 17:40:04 +01:00
Kurt Hindenburg
3cd4d2e440 Add profile option to scroll full/half height via Page Up/Down keys
The default is still half page - there is no GUI to change this;
either use konsoleprofile or change the .profile manually.

CCBUG: 280637
2013-02-24 12:03:46 -05:00
Kurt Hindenburg
68a98ed770 Add support for ANSI SGR escape code 3 (italics)
Adds support for escape sequences \e[3m and \e[23m (to turn italics on
and off respectively).
http://en.wikipedia.org/wiki/ANSI_escape_code#CSI_codes

Patch by Jem Orgun jeorgun@gmail.com
FEATURE: 314410
REVIEW: 108844
FIXED-IN: 4.11
2013-02-14 14:53:49 -05:00
Kurt Hindenburg
8b3bbae85f Extend selection only if Shift+click is pressed
Follow up to 9a3d588d0e - previously
any modifier+shift+click would extend selections which is not want we
want.
2013-02-10 13:20:42 -05:00
Kurt Hindenburg
88dc51d75c Make LibKonq an optional library
A few versions ago we added LibKonq to handle drag-n-drop menus.  There
are times when this library is not available or the user/distro might
want to disable (cmake option -DWITH_LibKonq=OFF). With this off, any
drag-n-drop will just paste the link.

FIXED-IN: 4.11
REVIEW: 108461
2013-02-09 11:45:06 -05:00
Kurt Hindenburg
7c81b2f790 very minor change to not set variable since it is ignored
via cppcheck
2013-01-31 10:55:17 -05:00
Kurt Hindenburg
7a2a5beb00 Correct spelling errors/word usage
All these are in the comments - no code changes
2013-01-09 22:07:11 -05:00
Yuri Chornoivan
4f888b1088 Pluralize the message (some languages have different plural forms for translation of quanities > 1) 2013-01-08 19:28:01 +02:00
Kurt Hindenburg
9a3d588d0e Implement Shift+click to extend selection
Add ability to press Shift+Click to extend the mouse selection.  In
KDE3 there was the menu option to 'Set Selection End' which this mimics.

REVIEW: 107566
FIXED-IN: 4.11
BUG: 123755
2012-12-28 10:05:40 -05:00
Kurt Hindenburg
417af269e5 Add option to disable ctrl+<mouse-wheel> zooming
The built-in behavior of Ctrl+<Mouse Wheel> to zoom in/out the terminal
can not be disabled. This patch adds an option to disable this
behavior. (Default to the original behavior).

Original patch by Yichao Yu yyc1992@gmail.com
I made some changes - bugs are mine as usual
REVIEW: 107281
FIXED-IN: 4.11
GUI:
2012-12-28 09:51:34 -05:00
Kurt Hindenburg
92019daad5 Add Dialog warning when huge amounts of text is about to be pasted
Currently there is no way to stop an accidently paste into the terminal.
This patch adds a dialog when 8000+ characters are pasted asking if
the user really wants to do this.  At most the user will see this once
as there is a "Don't show again" box.

Previously commit trigger a sysadmin issue.

FEATURE: 162625
REVIEW: 107570
FIXED-IN: 4.11
GUI:
2012-12-21 22:13:41 -05:00
Kurt Hindenburg
983efbc5a8 Add braces around if/else for readability 2012-12-19 23:41:09 -05:00
Kurt Hindenburg
cdf2b2bc78 Switch from c-style casting to c++ casting via static_cast 2012-12-19 21:20:18 -05:00
Amandeep Singh
f0e3b42188 Removing call to updateAccessibility for TextInserted
REVIEW: 106113
2012-09-23 00:06:40 +05:30
Kurt Hindenburg
ca9dd11bf5 Allow option to trim spaces at end of line
In the ongoing issue with spaces at the end of lines, this allows for
an option to trim the spaces.  By default, it is disabled so only
people who need this will be affected.

Many thanks to David Smid <david@smidovi.eu>

CCBUG: 188528
2012-09-09 19:10:41 -04:00
Kurt Hindenburg
c83e7b638d Add support for xterm's 1006 mouse extension
The extension committed in bko 285984 (invented by urxvt's author)
allows the terminal to report coordinates beyond 223. However, for
multiple reasons, xterm's author decided to come up with another
extnsion, addressing the same issue and more.

See more info on this bko 304686

An followup to bko 285984, b876f2a3ed
Patch by Egmont Koblinger egmont@gmail.com

FEATURE: 304686
FIXED-IN: 4.10
2012-09-03 17:07:24 -04:00
Kurt Hindenburg
21a8b063a7 astyle format fixes - whitespace and { 2012-09-03 14:15:47 -04:00
Kurt Hindenburg
5526c75fb2 Reimplement KDE3's print screen functionality
Add File->Print Screen menu option

Patch by Kasper Laudrup laudrup@stacktrace.dk

FEATURE: 249084
FIXED-IN: 4.10
2012-09-03 12:26:31 -04:00