That option is broken for a long time (at least since KDE 4.6.2), yet
there is not a single bug report against it. That is a strong evince
that option is seldom used.
The ideal situation is whenever compositing is available, Konsole
supports translucent background out of box without user guidance.
One typical option is "--display", because two konsole windows
belonging to the same process are destined to be shown in the same
display, which defeats the purpose of the "--display" option
CCBUG: 297224
BUG: 179010
BUG: 297801
FIXED-IN: 4.9.0
REVIEW: 104653
The intention of using --nofork with Konsole is to start Konsole in
foreground and wait for it to finish, so the only logical behavior is
using new process instead of reusing existing process.
CCBUG: 288200
The old way of calling isatty() is problmatic, because the checked
file descriptor might be redirected by users. For example, 'konsole <
/dev/null > /dev/null 2> /dev/null' will make that method fail.
The better way is trying to open /dev/tty to see whether we have
controlling terminal.
Thanks to Askar Safin <safinaskar@mail.ru> for pointing this out.
It is possible that users invoke konsole from terminal in the form of
'konsole &> /dev/null' to get rid of warning messages. Checking stdout
won't give expected result.
On the other hand, 'konsole < ....' is almost never used. So checking
stdin should be more reliable.
That function just reports whether new konsole process should be use. It
has no side effect and does not create new process, while the old name
may give the impression that it does.
--nofork is under --help-kde which is often overlooked by users.
Placing a comment under --help should cause less problems for users.
CCBUG: 217357
CCBUG: 262169
CCBUG: 173697
Also fixed a few typos where I noticed them.
Please don't do huge sweeping changes of KAboutData things without talking to the authors first. I'm sure they don't appreciate having their names removed from the about dialogs.
Note that
(a) the unicode copyright character is no more enforcible than (c)
(b) while "the KDE developers" is not a legal entity, neither is "Dolphin authors"
(c) it was decided a while back that we don't care about whether the copyrights in about dialogs are meaningful, since they can't hope to encompass everyone who holds copyrights on the application code or any of the libraries it is linked to; the copyright headers in the source files are the important ones.
I realise that I'm reverting more than necessary, but that's just a reason for breaking up commits :-)
CCMAIL: kamikazow@web.de
CCMAIL: kde-licensing@kde.org
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1154884
