Kurt Hindenburg
8b4cbcaf7a
Use constuctor initialization list for all members
2018-04-01 11:30:45 -04:00
Kurt Hindenburg
5b6ba95255
Do not setShortcut() on the OK button on dialogs
...
using okButton->setShortcut(Konsole::ACCEL | Qt::Key_Return); causes
the Alt+O to not work on the OK button. Both Ctrl+Return and Alt+O
now work to close the dialog.
BUG: 364716
FIXED-IN: 18.04
2018-02-28 21:14:42 -05:00
Kurt Hindenburg
99835ba4e9
uncrustify using kf5 config
2017-05-29 17:25:47 -04:00
Kurt Hindenburg
2b586e6ff8
use auto
2017-03-28 11:25:26 -04:00
R.J.V. Bertin
378518ea4b
shortcut adaptation to platform standards on Mac
...
REVIEW: 120323
2016-11-24 17:35:31 +01:00
Kurt Hindenburg
ff66b231bf
Remove unneeded includes
2015-09-16 23:34:40 -04:00
Montel Laurent
83515eafbc
Port to new connect api
2014-10-18 14:11:18 +02:00
Montel Laurent
b9c664bfce
Convert to QDialog
2014-10-17 13:45:30 +02:00
Kurt Hindenburg
597d4657a7
s/kde4_add_ui_files/qt5_wrap_ui cmake fix
2014-01-12 10:22:51 -05:00
Kurt Hindenburg
1ea501da62
remove include moc from .cpp files - removes build warnings
2013-10-22 20:07:23 -04:00
Kurt Hindenburg
bee9aa8f78
minor style fixes - remove empty lines start/end code blocks
2012-05-13 10:08:05 -04:00
Jekyll Wu
db4471ef1a
Krazy Fix: add one KUIT tag
2012-04-04 02:09:25 +08:00
Kurt Hindenburg
d1ac153ba6
Convert the HistorySizeDialog to .ui
2012-04-03 10:15:03 -04:00
Jekyll Wu
6d43f0ca77
Refacotr history size related UI components into HistorySizeWidget
...
This make EditProfileDialog and HistorySizeDialog reuse the same
widget, instead of duplicating each other in its own code or .ui file.
HistorySizeDialog is now just a simple container of HistorySizeWidget
2012-03-21 00:49:24 +08:00
Jekyll Wu
683f2c9ec5
Merge Profile::HistoryModeEnum and HistorySizeDialog::HistoryMode into Enum::HistoryMode Enum
2012-03-19 16:07:27 +08:00
Jekyll Wu
25b8b5353c
Trivial style change: remove extra blank lines
2012-03-17 19:53:21 +08:00
Kurt Hindenburg
ae83273c95
-Wshadow fixes to parameter names and variable names
2012-03-06 09:23:36 -05:00
Jekyll Wu
f42fd4721b
Clean up unneeded #includes
2012-02-20 19:41:38 +08:00
Jekyll Wu
090d379f09
Show the unit of scrollback within the spinbox
2012-01-12 19:01:58 +08:00
Kurt Hindenburg
a511cb046f
Apply astyle-kdelibs
...
Over the years, the coding style is all over the place.
Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-24 10:33:19 -05:00
Jekyll Wu
330de6c6f4
Fix some spelling problems
2011-11-06 03:41:20 +08:00
Kurt Hindenburg
9e147814dc
Remove Q_ASSERT to the dialog will be shown.
2011-10-29 14:49:22 -04:00
Jekyll Wu
f948623ee0
Refine the warning label
2011-10-28 22:42:02 +08:00
Jekyll Wu
b58739e6bd
Remove unused #include
2011-10-28 01:40:08 +08:00
Jekyll Wu
266e18fe3e
minor change on code style
2011-10-28 01:37:37 +08:00
Jekyll Wu
e2d56c1ad0
Prefer using static member for a const value
2011-10-28 01:31:44 +08:00
Jekyll Wu
8f7be18a64
Simplify the scrollback setting dialog to avoid potential confusion.
...
- the change is not saved into profile and only influences current tab
- remove the 'Save to current profile' checkbox
- remove the 'Defaults' button
- change dialog title from "Scrollback Options" to "Adjust Scrollback"
- change action from "Scrollback Options..." to "Adjust Scrollback..."
The new dialog makes the "Adjust Scrollback..." action more consistent with most
of other actions in the context menu, since they only influence or work in the
context of current tab.
The UI change is not quite satisfactory. Feel free to refine the UI part
to make it more clear and elegant.
BUG: 227144
FIXED-IN : 4.8
REVIEW: 102688
2011-10-25 19:24:15 +08:00
Jekyll Wu
da7c9d254a
Set the incremental step of HistorySize as 1/10 of current value.
2011-10-06 21:21:34 +08:00
Jekyll Wu
1b5d836219
Add KDialog:: prefix for ButtonCode.
...
Ok, Cancel and Default are so generic that they look ambiguous without
the KDialog:: prefix.
2011-09-06 01:25:15 +08:00
Jekyll Wu
d99422730f
Less one-liner definitions for class methods .
...
This really hurts readability, especially when they appear successively.
2011-09-06 00:32:53 +08:00
Jekyll Wu
976077e37f
Do not select the fixed size mode by default.
...
Current code always sets the line count spinbox as focused and selected,
even when the current setting of history size is no history or unlimited
history. This is counter-intuitive and may confuse users.
2011-09-05 23:28:14 +08:00
Jekyll Wu
0012355e2e
slight adjustment of code layout. No functionality changes.
2011-09-05 23:06:08 +08:00
Andrius Štikonas
4961215664
Use KIntSpinBox instead of QSpinBox for better integration with KDE. As a bonus this allows to use plural suffix in spinboxes since KDE 4.3 if necessary.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=989742
2009-06-30 20:09:04 +00:00
Kurt Hindenburg
ef7c91b1d2
Add checkbox to allow Scrollback->Scrollback Options dialog to save to current profile.
...
FEATURE: 155580
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=920007
2009-02-02 05:24:53 +00:00
Robert Knight
5d9997446e
Update copyright year to 2008. Remove '(C)' from copyright lines.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=800631
2008-04-24 14:53:43 +00:00
Robert Knight
d1040daec5
Revert part of #760591 which was committed unintentionally.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=760592
2008-01-13 01:16:12 +00:00
Robert Knight
cb1504de10
Minor style cleanup. if..elseif to switch. #include <kio/job.h> -> #include <KIO/Job>
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=760591
2008-01-13 01:13:52 +00:00
Robert Knight
dcdf9e76b3
Rename History to Scrollback in the UI, to avoid confusion with shell's command history. Fixes to color scheme previewing in Edit Profile Dialog. Add a few icons here and there. Add full screen menu item.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=665834
2007-05-18 05:26:40 +00:00
Dirk Mueller
9ea3227384
include cleanup
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=663054
2007-05-09 22:23:52 +00:00
Robert Knight
33c913383d
EBN fixes. Mostly copyright and implementations including their own headers first.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=662726
2007-05-09 00:01:01 +00:00
Stephan Binner
c7debcd41a
i18n style guide fixes
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=662510
2007-05-08 13:19:53 +00:00
Robert Knight
8a2bf09d96
Make history options, manage profiles and edit current profile dialog non-modal as suggested.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=662230
2007-05-07 17:06:31 +00:00
Robert Knight
622cae74e5
Methods to set and get the settings used when clicking on the 'Defaults' button in the History Options dialog. Eventually this should mean using the current profile's history settings.
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=661704
2007-05-06 12:33:18 +00:00
Laurent Montel
a95ff80555
Make default button works
...
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=661686
2007-05-06 11:31:50 +00:00
Robert Knight
19a29d182a
Rename directories for clarity. konsole -> src , other -> data.
...
svn path=/branches/work/konsole-split-view/; revision=661562
2007-05-05 23:33:05 +00:00