Commit Graph

165 Commits

Author SHA1 Message Date
Jekyll Wu
8e5b0c3c51 Improve the accelerators in the confirmation dilaog
Note, KStandardGuiItem::closeWindow and KStandardGuiItem::close uses the
same accelerator, so here I use a variant of KStandardGuiItem::closeWindow
insteand of itself.
2012-12-20 14:42:45 +08:00
Kurt Hindenburg
21a8b063a7 astyle format fixes - whitespace and { 2012-09-03 14:15:47 -04:00
Kurt Hindenburg
69dcbd3406 astyle fixes - spaces/{ 2012-09-02 17:28:43 -04:00
Kurt Hindenburg
ad50620f09 Add comments about why --notransparency is still needed
Thanks to Matthias Kretz kretz@kde.org for patch/info.
2012-08-26 09:23:21 -04:00
Kurt Hindenburg
a70f507b67 Restore --notransparency option for NVIDIA users
Some NVIDIA users still require this option for Konsole to work as
expected

This reverts 66b4a96e93

Thanks to Matthias Kretz kretz@kde.org for patch/info.
BUG: 305307
FIXED-IN: 4.10
2012-08-26 09:13:16 -04:00
Jekyll Wu
131091c983 Adjust including form for some Qt headers as preparation for Qt5
So if someone notices later some Qt header is included in the form
of "#include <Class>" instead of the more common form of "#include
<Module/Class>", do not rush changing it.

REVIEW: 105819
2012-08-14 17:32:06 +08:00
Kurt Hindenburg
32af61fba8 Leave the bookmark shortcut set to what user changed it to
Only reset the bookmark shortcut to Ctrl+Shift+B if the user didn't
change it to something else.

BUG: 303747
FIXED-IN: 4.10
2012-07-20 09:19:26 -04:00
Jekyll Wu
dd440409cf Fix the wrong KGuiItem in the confirmation dialog for closing window
That dialog is only about closing one Konsole window , so it should use
KStandardGuiItem::closeWindow() instead of KStandardGuiItem::quit(),
which is for quitting the whole application.
2012-06-15 07:27:03 +08:00
Jekyll Wu
1ab2fc1b20 Do not ask for confirmation of closing when logging out.
This effectively reverts the change which was made to ask for
confirmation when powering off. That issue needs to be reworked in
next feature release, but for now just revert it since the current
implementation should cause more annoyance than benefit.

BUG: 301458
FIXED-IN: 4.9.0
CCBUG: 127194
2012-06-10 06:14:19 +08:00
Jekyll Wu
85d787e928 Remove unneeded #include 2012-06-03 07:46:41 +08:00
Kurt Hindenburg
1f4b0d7100 Add note about KWindowSystem calls being mostly implmented only in x11 2012-06-02 16:02:55 -04:00
Kurt Hindenburg
bee9aa8f78 minor style fixes - remove empty lines start/end code blocks 2012-05-13 10:08:05 -04:00
Kurt Hindenburg
9f5877bdfc minor whitespace style changes 2012-05-13 08:51:27 -04:00
Jekyll Wu
3ddc6496b6 Add cmdline options for the visibility of menubar and tabbar
Since the menubar and tarbar settings are now global instead of per
profile , those cmdline options are useful to allow users to override
the defautl behavior.

The --hide-menubar and --hide-tabbar options can be used together
to simulate the miminal interface of xterm. I'm not sure whether
--show-menubar and --show-tabbar will be widely used , but add them at
the moment for the sake of completeness.
2012-05-13 03:06:14 +08:00
Jekyll Wu
927848c580 Make sure the translucent background is available whenever possible
Now the Qt::WA_TranslucentBackground attribute is always set for the
mainwindow of konsole(regardless of whether compositing is available
when the window is created), just like in konsolepart.

I'm not 100% sure this approach is problem-free, but it works for me so
far under various environments and conditions. Do not hesihate to revert
it if you notice it causes big trouble.
2012-05-12 23:39:28 +08:00
Jekyll Wu
66b4a96e93 Remove the --notransparency option
See http://lists.kde.org/?t=133668415200007&r=1&w=2 for the discussion
2012-05-12 21:53:36 +08:00
Jekyll Wu
6c62114529 Remove the long broken --force-transparency option
That option is broken for a long time (at least since KDE 4.6.2), yet
there is not a single bug report against it. That is a strong evince
that option is seldom used.

The ideal situation is whenever compositing is available, Konsole
supports translucent background out of box without user guidance.
2012-05-12 21:53:29 +08:00
Jekyll Wu
9476fd14a4 Just rename 2012-05-11 14:18:34 +08:00
Jekyll Wu
acc238bcd7 Add comments to make translucent-related code easier to understand 2012-05-10 21:06:24 +08:00
Jekyll Wu
cf24bea6ab Add one global option for customizing the stylesheet of the tabbar
Note: this is just an experimental idea, so no GUI is added. It might
rename or disappear later.
2012-05-08 21:37:40 +08:00
Jekyll Wu
cf5ccf5f65 Ensure the confirmation dialog for closing window is visible to users
FEATURE: 163677
FIXED-IN: 4.9.0
2012-04-22 13:37:37 +08:00
Kurt Hindenburg
5b083640ce whitespace and style fixes
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
2012-04-05 11:08:53 -04:00
Jekyll Wu
37ac9e3f9a Rename: sessionListChanged ==> profileListChanged 2012-04-02 20:58:42 +08:00
Kurt Hindenburg
e63b1f0f51 Add 2 KUIT tags 2012-03-31 09:55:40 -04:00
Jekyll Wu
193777e21a Split class SessionManager into ProfileMananger and SessionManager
REVIEW: 104425
2012-03-30 01:23:28 +08:00
Kurt Hindenburg
6e93204ae5 /s/NULL/0 2012-03-20 09:13:55 -04:00
Jekyll Wu
33678e7ca4 Add more convenient methods for accessing profile option 2012-03-19 18:29:44 +08:00
Kurt Hindenburg
e0862c603a Style fixes - separte commands - remove 2 ; - align { elses 2012-03-18 15:57:48 -04:00
Kurt Hindenburg
519e2614d6 Style fixes - remove spaces before ; and add spaces in for loops 2012-03-18 15:11:06 -04:00
Jekyll Wu
663e342aa8 Krazy fix: add the missing KUIT context marker 2012-03-18 22:57:32 +08:00
Jekyll Wu
25b8b5353c Trivial style change: remove extra blank lines 2012-03-17 19:53:21 +08:00
Jekyll Wu
57c2ae6e1e Rename global option: ShowMenuBar ==> ShowMenuBarByDefault
Sorry for the possible trouble of "resetting" caused by this commit,
but it does not pay off to write extra code dealing with such rename in
master branch
2012-03-13 13:40:16 +08:00
Kurt Hindenburg
e471ba72ec -Wshadow fixes to variable names 2012-03-05 11:23:27 -05:00
Jekyll Wu
9f52714558 Application should not know about anying about ViewManager
The changes are basically adding a few small helper methods into
MainWindow to hide the existense of ViewManager to Application.
2012-02-27 02:28:37 +08:00
Jekyll Wu
7ccbfac499 Move the code for creating tab/session from Application into MainWindow
This is the first step toward to making ViewManager hidden to Application.
2012-02-27 01:09:36 +08:00
Jekyll Wu
e958267ef4 Trivial modification of code style 2012-02-26 21:55:29 +08:00
Jekyll Wu
ff88a65ccd Move some code into MainWindow and make it internal stuff
That MainWindow uses ProfileList is an internal implementation detail.
The Higher lever Application does not need to know about it.
2012-02-25 16:02:49 +08:00
Jekyll Wu
2af5c3b921 Another unneeded #include 2012-02-23 06:41:27 +08:00
Jekyll Wu
f42fd4721b Clean up unneeded #includes 2012-02-20 19:41:38 +08:00
Yuri Chornoivan
fea58cc6bf Pluralize message for translation into the languages with more than 2 plural forms. 2012-02-19 10:37:19 +02:00
Jekyll Wu
4fb4da4c75 Add global option for showing window title on titlebar
When the window title from current session is emtpy, fallback to using
tab title.

CCBUG: 162326
REVIEW: 103978
2012-02-19 15:23:48 +08:00
Kurt Hindenburg
34759f1ef1 Mention the # of open tabs in close dialog
Thanks to Vishesh Handa for patch.  I changed it slightly.

REVIEW: 104002
FIXED-IN: 2.9
2012-02-18 15:38:37 -05:00
Jekyll Wu
3f64589b7e Less unneeded #includes 2012-02-17 06:23:22 +08:00
Jekyll Wu
1e888799df Remove unnecessary calling for setAutoSaveSettings() in constructor
In current code, that method will be effectively called each time a new
session is created. That makes calling setAutoSaveSettings() in the
constructor of MainWindow basically meaningless.
2012-02-12 18:14:48 +08:00
Jekyll Wu
2301ab5b81 Rearrange the 'File' menu
* Rename "Quit" to "Close Window" for accuracy
  * Move "Close Tab" downwards to be adjacent to "Close Window"

REVIEW:103920
2012-02-12 00:46:44 +08:00
Jekyll Wu
56acddac93 Add 'Clone Tab' action for cloning current tab
This action will create new tab/session using the same settings(command,
colors, etc) used in current tab/session.

At this moment, this action does not always clone current tab/session
100%. For example, If you change the scrollback setting of current
session temporarily through context menu or dbus method, this action
won't clone the temporary change. Another example is the tab title.

On the other hand, this action works quite well with command line
options(-e, -p, etc) and the 'konsoleprofile' utility.

FEATURE:254976
FEATURE:292518
FIXED-IN:4.9.0

REVIEW:103859

DIGEST:
2012-02-11 02:38:42 +08:00
Jekyll Wu
39a857b037 Rename for clarity 2012-02-08 03:07:44 +08:00
Jekyll Wu
117a3b297c Trivial changes with comment and code style 2012-02-08 02:50:34 +08:00
Jekyll Wu
ce7b593ec8 Minor fix with comments 2012-02-04 14:47:26 +08:00
Jekyll Wu
ba84ff30fa Get rid of _defaultProfile from class MainWindow
REVIEW:103819
2012-02-04 00:58:51 +08:00