mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-01 11:15:29 -04:00
Code Issues Packages Projects Releases Wiki Activity
4,429 Commits 139 Branches 416 Tags
9f52714558039fefed63b72ff35b724fcb3a4cb2
Commit Graph

101 Commits

Author SHA1 Message Date
Jekyll Wu
9f52714558 Application should not know about anying about ViewManager 
The changes are basically adding a few small helper methods into
MainWindow to hide the existense of ViewManager to Application.
 2012-02-27 02:28:37 +08:00
Jekyll Wu
7cdd8129f1 Move code around for better organization 2012-02-27 01:19:54 +08:00
Jekyll Wu
7ccbfac499 Move the code for creating tab/session from Application into MainWindow 
This is the first step toward to making ViewManager hidden to Application.
 2012-02-27 01:09:36 +08:00
Jekyll Wu
b400690c5d Make WindowSystemInfo::HAVE_TRANSPARENCY const and initialize implicitly 
This avoids the explicit assignment in Application and Part. The result
might look a little strange, but that is basicaly what the old code does
and what that variable intends to be (all capitalized letter)
 2012-02-25 21:47:29 +08:00
Jekyll Wu
ef62a0002b Move TerminalDisplay::HAVE_TRANSPARNCEY into its own dedicated class 
TerminalDisplay.h is a big header. It is not good for several files to
include that big header only in order to use one of its static member.
 2012-02-25 21:10:09 +08:00
Jekyll Wu
ff88a65ccd Move some code into MainWindow and make it internal stuff 
That MainWindow uses ProfileList is an internal implementation detail.
The Higher lever Application does not need to know about it.
 2012-02-25 16:02:49 +08:00
Jekyll Wu
cc1142c59d Prepare the whole command before sending it by calling Session::sendText() 
That reduces the number of calling, and also make the code easier to
debug if something goes wrong with the command

TODO: there is code duplication between class Application and class
SessionController on how to compose and send ssh command based upon a
KUrl using the ssh:// protocol.
 2012-02-23 07:37:07 +08:00
Jekyll Wu
31798bb122 upate TerminalDisplay::HAVE_TRANSPARENCY directly 
It does not make mush sense to update that public & static member
by calling another method, and such change is effectively needed
only once.
 2012-02-18 07:08:19 +08:00
Jekyll Wu
b0206a7713 Remove unneeded #include 2012-02-18 03:50:05 +08:00
Jekyll Wu
f810b3bf3b update the inline document for the --tabs-from-profile option 2012-02-09 04:06:03 +08:00
Jekyll Wu
07cddfe302 Create dbus object for each Konsole window respectively 
Its naming scheme is "/Windows/N", similar to "/Sessions/N" for
sessions. That is not the final decision and might change before next
major release.

The old "/Konsole" dbus object is still available at this moment, but
it might disappear or be used for something different in the future, so
it is better to use "/Windows/N" from now on.

For convenience, $KONSOLE_DBUS_WINDOW can be used to refer to the dbus
object corresponding to the Konsole window containing current session.
Note, that environment variable does not work well with detaching and
draging. Maybe it should not be added at all.

CCBUG:276912
CCBUG:281513
CCBUG:292309

REVIEW:103790
 2012-02-09 01:50:43 +08:00
Jekyll Wu
39a857b037 Rename for clarity 2012-02-08 03:07:44 +08:00
Jekyll Wu
8012d47170 Make --tabs-from-file support command arguements containing ':' 
A simple example:

title: vim ;; command: vim file:///path/to/file.txt
 2012-02-07 20:39:33 +08:00
Jekyll Wu
2a4795c509 Fix typo of BKO number in comment 2012-02-07 06:17:47 +08:00
Jekyll Wu
60449c95c1 Ensure tab title is displayed when using --tabs-from-file option 2012-02-07 06:09:11 +08:00
Jekyll Wu
0dc3ba1c26 Add support for 'profile' field for the --tabs-from-file option 2012-02-07 03:03:32 +08:00
Jekyll Wu
b57cccd5a1 Revert "Manual resizing is only needs to be checked and performed once" 
Well, I was stupid :(

This reverts commit a66098d9b3.
 2012-02-06 23:53:26 +08:00
Jekyll Wu
fec744bfed Make sure empty lines are really ignored 2012-02-06 23:38:31 +08:00
Jekyll Wu
a66098d9b3 Manual resizing is only needs to be checked and performed once 2012-02-06 23:38:27 +08:00
Jekyll Wu
fcd8d7e57d Use customized tab title only when explicitly requested by users 2012-02-06 22:54:44 +08:00
Jekyll Wu
02b72b7f8e Prefer foreach over manual loop 2012-02-06 18:10:26 +08:00
Jekyll Wu
09940ed95f Suppress the warning for unused variable 2012-02-05 01:06:37 +08:00
Jekyll Wu
14bcc3366f Use NewProfile only when needed 
This fixes the problme of empty profile name when invoking konsole in
the simplest way.

This is a follow-up of commit ba84ff30fa
 2012-02-05 01:06:26 +08:00
Jekyll Wu
588aa92a21 A little more constness 2012-02-04 15:48:12 +08:00
Jekyll Wu
4156806b73 Make the definition of static member outstanding 2012-02-04 15:32:51 +08:00
Jekyll Wu
837ab5a664 Revert the boolean logic to make the code more natural 2012-02-04 15:30:13 +08:00
Jekyll Wu
28741c9153 Deal with option "-e" in a more profile-oriented way 
Since "New Tab" always use default profile now, we can deal with that
option in a more elegant way, instead of a hack.

This basically revert commit 35fae00159
 2012-02-04 01:10:44 +08:00
Jekyll Wu
ba84ff30fa Get rid of _defaultProfile from class MainWindow 
REVIEW:103819
 2012-02-04 00:58:51 +08:00
Jekyll Wu
6b6a5944f6 Prefer foreach(...) over while(...) for simplicity and readability 2012-01-22 10:21:45 +08:00
Jekyll Wu
40f8bf736a Rename for clarity: closeAll() ==> closeAllSessions() 2012-01-16 13:31:04 +08:00
Jekyll Wu
48abb9d99f Be consistent: do not call session->run() directly in stand-alone Konsole 
This is a follow up for the commit fixing BKO 176902.

For konsolepart, need more investigation.
 2012-01-15 19:49:56 +08:00
Jekyll Wu
3ae465cedf Change the default global shortcut for --background-mode from F12 to Ctrl+Shift+F12 
F12 is too common. Change it to reduce the chance of conflict
 2012-01-12 16:19:50 +08:00
Jekyll Wu
37fc995af4 Show the global shortcut for background window in the shortcuts dialog 
I'm not sure whether that can be called as improvement. That global
shortcut has always been configurable through systemsettings. Now the
global shortcut is also configurable thourgh shoutcuts dialog, but it
is only available in the background window when it is shown.

I wonder how many users know and really use the --background-mode
option. It feels to me more like a clever trick than a mature feature.
 2012-01-12 15:31:54 +08:00
Kurt Hindenburg
bb3805de2e Remove unused ::self() 2012-01-03 11:48:08 -05:00
Kurt Hindenburg
ba77864413 Minor style changes 
Use 'git diff -w --ignore-all-space' for non-whitespace changes.
 2012-01-03 11:37:27 -05:00
Kurt Hindenburg
c11ab0ecc4 Minor whitespace change. 
Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
 2011-12-30 10:28:53 -05:00
Kurt Hindenburg
1baa56feda White space changes - astyle and Qt normalize don't like each other. 
Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
 2011-12-25 13:13:55 -05:00
Kurt Hindenburg
75d2260534 Keep lines < 80 columns for readability; minor style changes. 2011-12-24 18:51:10 -05:00
Kurt Hindenburg
e1d23238ee Apply astyle-kdelibs 
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
 2011-12-23 22:37:55 -05:00
Jekyll Wu
903dbe1b7f Make the code slightly more readable 2011-11-06 05:26:54 +08:00
Jekyll Wu
330de6c6f4 Fix some spelling problems 2011-11-06 03:41:20 +08:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
e825a8e0b6 Prefer forward declaration when it is enough 2011-11-01 13:41:54 +08:00
Jekyll Wu
ae44eb4c4b Save default-profile/favorites/shortcuts settings into disk ASAP. 
Those settings are now synced into disk right after the
ManageProfilesDialog is closed.

BUG: 200987
FIXED-IN: 4.8
REVIEW:102781
 2011-10-06 17:48:25 +08:00
Kurt Hindenburg
0c0874f98a On MacOSX, put menus inside konsole window. 
KDE's menuBar()->isTopLevelMenu() hasn't worked for a while.  Without a
replacement, let's just put the menus inside the main window.  This
also makes the keyboard shortcut to show menus look reasonable (instead
of floating).
 2011-09-24 09:31:58 -04:00
Jekyll Wu
cd2e674d21 Rename to avoid confusion. 
It is confusing to name a ViewManager* pointer as 'view', especially
when it is used in 'view->createView()'.
 2011-09-15 15:11:27 +08:00
Kurt Hindenburg
35fae00159 When using -e <command> don't save to profile for new tabs. 
Currently using -e <command> will cause all new tabs/windows to run
    <command>.  This patch fixes that such that new tabs/windows will start
    the default profile.

    Patch by Gu Rui <chaos.proton@gmail.com> with minor edit by self.
    FIXED-IN: 4.8
    REVIEW: 102602
    CCBUG: 192212
 2011-09-13 18:26:15 -09:00
Jekyll Wu
de61d40c63 Include Qt headers in the form of "#include <Module/Class>" 2011-09-06 06:42:42 +08:00
Jekyll Wu
2d8b4a0a63 Delete one line of no use. 2011-08-30 07:57:55 +08:00
Jekyll Wu
a52cd60e9e Delete 2 un-used member variables. 2011-08-30 07:47:36 +08:00