Commit Graph

40 Commits

Author SHA1 Message Date
Francesco Cecconi
e63780b7eb Update 'UrlFilter' regular expression.
Fix issues with URLs that end with ')' and ':'.

BUG: 210871
FIXED-IN: 4.9.4

REVIEW: 107340
2012-11-16 20:59:55 +01:00
Jekyll Wu
131091c983 Adjust including form for some Qt headers as preparation for Qt5
So if someone notices later some Qt header is included in the form
of "#include <Class>" instead of the more common form of "#include
<Module/Class>", do not rush changing it.

REVIEW: 105819
2012-08-14 17:32:06 +08:00
Kurt Hindenburg
5b083640ce whitespace and style fixes
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
2012-04-05 11:08:53 -04:00
Kurt Hindenburg
e0862c603a Style fixes - separte commands - remove 2 ; - align { elses 2012-03-18 15:57:48 -04:00
Jekyll Wu
25b8b5353c Trivial style change: remove extra blank lines 2012-03-17 19:53:21 +08:00
Kurt Hindenburg
7fd6cddb82 Remove unused link tooltip code 2012-03-06 23:35:11 -05:00
Jekyll Wu
f4fb943132 Most of time we only need <KLocalizedString> instead of <KLocale> 2012-03-07 06:48:26 +08:00
Kurt Hindenburg
9d7033df52 Add TODO about link tooltips 2012-03-06 11:36:59 -05:00
Jekyll Wu
bf18e339f2 Fix the crash when hovering over URL
That crash is introduced by a recent commit 90469a, which is supposed to
be trivial and harmless. I made the mistake of not trying the code
enough before pushing it, again!
2012-03-06 23:52:28 +08:00
Jekyll Wu
90469a094a Add more constness 2012-03-06 02:00:15 +08:00
Jekyll Wu
3b7e953523 Yet another around of cleaning up #includes 2012-02-22 07:18:30 +08:00
Jekyll Wu
f42fd4721b Clean up unneeded #includes 2012-02-20 19:41:38 +08:00
Jekyll Wu
a730d311ae Rename and move around 2012-02-10 21:38:24 +08:00
Jekyll Wu
a20a84abb0 Remove one line of no use 2012-02-10 21:14:11 +08:00
Jekyll Wu
6b6a5944f6 Prefer foreach(...) over while(...) for simplicity and readability 2012-01-22 10:21:45 +08:00
Kurt Hindenburg
cfdc70642c Apply astyle-kdelibs
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-24 10:24:30 -05:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Laurent Montel
dd46511de1 Use QLatin1String in setObjectName (added with a script)
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1178049
2010-09-22 07:35:22 +00:00
Wang Kai
b986ccbac4 BUG: 154689
use QRegion instead of QRect to represent each HotSpot's valid region 
when a link spans over multiple lines
calculate the unites of QRects as this HotSpot's region
so the link get underlined properly

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=906906
2009-01-07 02:45:46 +00:00
Wang Kai
3fb6cb83eb correctly compute startColumn, endColumn
fix a bug when highlight/underline HotSpot contains characters which displayed with two bytes' width(most CJK characters)

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=906433
2009-01-06 09:23:44 +00:00
Robert Knight
956277c014 Convert tabs to 4 spaces to match kdelibs conventions. Previously
there was a mix of tabs and spaces for indentation.

CCMAIL:Stefan.Becker@nokia.com


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=863326
2008-09-21 20:06:58 +00:00
Kurt Hindenburg
43c29e47b9 Fix crash for regexp's that return matchLength() == 0 such as \b
BUG: 168434

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=845891
2008-08-12 15:11:51 +00:00
Robert Knight
5d9997446e Update copyright year to 2008. Remove '(C)' from copyright lines.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=800631
2008-04-24 14:53:43 +00:00
Robert Knight
971a5315f9 Remove debugging messages.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=800628
2008-04-24 14:52:39 +00:00
Robert Knight
5f2f814443 Fix a performance problem with the email address matching filter. The email address regular expression was very general and could match very long pieces of text which were not actually email addresses. Adding word boundary markers improves this significantly. See the python xample code here for a test case: http://bugzilla.gnome.org/show_bug.cgi?id=350015
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=756554
2008-01-03 12:19:27 +00:00
Robert Knight
46cfc108d3 * Replace all usage of qDebug() with kDebug(), since kDebug() provides information about
which part of the code the message came from and allows filtering of output
  using kdebugdialog
* Remove explicit creation of singleton classes SessionManager,ColorSchemeManager and
  KeyboardTranslatorManager and automate it with K_GLOBAL_STATIC.
  This ensures that the singleton destructors are called appropriately by KPart clients
  when they unload the libkonsolepart library.


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=754334
2007-12-29 16:07:31 +00:00
Robert Knight
e37fe69431 * Fix problem where selection background and other text with non-standard background
colors was not readable with terminal display transparency enabled.

* Transparency works again, but requires --enable-transparency argument passed to command-line
  due to artifacts that appear otherwise.
  Re-enable the code which searches for a suitable display, visual and colormap when
  starting the application in an environment which supports compositing.  Still
  need to resolve with other developers exactly how this will be done in KDE 4.0

* Fix problem where flow control warning banner was always displayed when 
  Ctrl+S, Ctrl+Q were pressed, regardless of whether flow control was 
  actually enabled.

* Fix artifacts when scrolling whilst the flow control warning banner was 
  visible.  Scrolling optimisations in the terminal display are disabled whilst
  the warning banner is being shown.

* Fix links which wrapped over more than one line being cut-off at the end of the line
  (eg. when parsing "http://www.kd <END OF LINE> e.org" the link address would be reported
   as "http://www.kd" instead of "http://www.kde.org").  The link underlining is not yet 
   corrected, only the part of the link on the first line is highlighted.  

* Implement code to load and use a built-in keyboard translator for fallback purposes
  in case no .keytab files exist.  The actual translator text (in DefaultTranslatorText.h)
  is currently incomplete. 

* Replace hard-coded colors for flow control warning label with colors from
  KColorScheme

* Replace hard-coded colors in incremental search line edit when a match is not found
  with colors from KColorScheme

* Remove un-used variables in TerminalDisplay class, rename enums to match
  CamelCase naming style used elsewhere.

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=748936
2007-12-15 23:07:20 +00:00
Robert Knight
2809fc00c9 Remove tooltips for links which are now incorrect. Avoid un-setting the cursor when moving away from a link now that we no longer set the cursor to a pointing hand when moving over it.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=741931
2007-11-26 19:07:07 +00:00
Hoàng Đức Hiếu
4ff466f4f8 exclude also <, as seen in <a href='http://example.org'>http://example.org</a>
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=732048
2007-11-02 17:02:23 +00:00
Hoàng Đức Hiếu
fa7f07a3f4 Remove ) from URL delimiting characters because XPointer uses it. See some examples at <http://student.kuleuven.be/~s0159198/xpointer/>
XPointer also uses ' in URL, but I leave it in for now. I think XML and HTML docs are more popular than XPointer URLs.

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=731977
2007-11-02 12:41:50 +00:00
Hoàng Đức Hiếu
6c42600828 Improve URL matching regexp, match based on invalid characters
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=724666
2007-10-12 23:25:13 +00:00
Robert Knight
42dce0374c Changes:
* Add a passive warning widget which is displayed when a color scheme is selected which 
  uses transparency but the system does not support transparency 
* Always show the vertical scroll bar in the color scheme list
* Remove quotes around links and email addresses in mouse-over tooltip

Bug Fixes:

* Fix a few odd behaviours with the live color scheme preview
* Fix the 'Show in Menu' status of newly added profiles not being
  saved when Konsole exits.

  ( Update Profile's path property when saving the profile to 
    a new location )


Internal: 

* Removed many debugging statements and dead / commented out code
* Fix several unused parameter warnings
* API documentation corrections in Emulation class

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=706986
2007-08-31 17:56:35 +00:00
Arto Hytönen
d0e0ca3c4f this should clean-up kdebase of all of overkills of krazy:exclude of QString::null lines.
as long as C++ std clause 6.8 states (if I get it right), the diff should be OK, still can only compile with gcc-4.2...

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=701136
2007-08-17 12:14:28 +00:00
Arto Hytönen
7021299cfb further elimination/cancellation of QString::null.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=700742
2007-08-16 10:44:18 +00:00
Robert Knight
37088799cf * Update the regular expression for the Url filter. Anything in the form
letters://any-non-whitespace-characters is treated as a Url

* Correct the test which compares the old and new values and ranges when
  updating the terminal display's scroll bar.  
  This fixes the scroll bar being repainted unnecessarily often.  Found
  with the nifty QT_FLUSH_PAINT debugging tool.

* Select the profile name (set to "New Profile" by default) and focus the 
  profile name edit area when showing the Edit Profile dialog for a new
  profile to allow the user to easily set the name.

* Always use color scheme list animation, not just when the Edit Profile 
  dialog is first displayed as per richmoore's suggestion. 

* Update Edit Profile dialog caption when profile name is changed.

* Update favorite status icon in Manage Profiles dialog when the favorite
  status is changed by another object.

* Add disabled menu item which is shown in the 'Change Profile' list
  when there are no other profiles there

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=683787
2007-07-05 09:51:06 +00:00
Robert Knight
72241ef4a6 * Comment out many debugging messages
* Experimental optimization, disable kerning since this is not required
  with the mono-spaced fonts which are used in the terminal.

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=682702
2007-07-03 09:14:21 +00:00
Robert Knight
82ac07fec2 Change the character -> text decoding API so that Konsole can produce better quality HTML when output is saved. Fix crashing when resizing display introduced in yesterday's scrolling changes and add assertions to catch invalid memory accesses.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=669305
2007-05-28 23:58:31 +00:00
Dirk Mueller
9ea3227384 include cleanup
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=663054
2007-05-09 22:23:52 +00:00
Robert Knight
33c913383d EBN fixes. Mostly copyright and implementations including their own headers first.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=662726
2007-05-09 00:01:01 +00:00
Robert Knight
19a29d182a Rename directories for clarity. konsole -> src , other -> data.
svn path=/branches/work/konsole-split-view/; revision=661562
2007-05-05 23:33:05 +00:00