Commit Graph

320 Commits

Author SHA1 Message Date
Kurt Hindenburg
c56db4cfd0 Use QRect instead of manually handling terminal margins
Instead of keeping track of constants and +1 -1, use a QRect to handle
the terminal margins.  There is no GUI for this currently and the
margins are hard-coded to what they are now.  Code to center the
terminal is also include (w/o GUI).

This patch comes from review 109891 w/ a few changes from me.
Thanks to Mariusz Glebocki mglb@arccos-1.net
2013-05-18 07:51:29 -04:00
Kurt Hindenburg
5a85ef48fe Remove underline from an active link upon leaving terminal area
Patch from portion review 109891 by Mariusz Glebocki mglb@arccos-1.net
2013-04-10 10:34:36 -04:00
Kurt Hindenburg
a88f9cb417 Check boundary of image to get valid Character
This crash in isSpace() is due to invalid Character; check for valid
array size before grabbing it.  No one can reproduce the crash but this
can't hurt hopefully.

CCBUG: 309954
2013-03-16 19:06:28 -04:00
Kurt Hindenburg
b5dbf6b32f minor space/tab fixes 2013-03-16 12:36:05 -04:00
Francesco Cecconi
c45d07698f Prevent the opening of two or more "edit profile dialogs" per session.
Fixing the wrong behaviour to open two or more "edit dialog" for
one session/tab with the same profile, and the crash with two or
more "edit dialog", one for different session(tabs) with the same profile.

BUG: 311270
REVIEW: 107640
FIXED-IN: 4.11
2013-03-14 17:40:04 +01:00
Kurt Hindenburg
3cd4d2e440 Add profile option to scroll full/half height via Page Up/Down keys
The default is still half page - there is no GUI to change this;
either use konsoleprofile or change the .profile manually.

CCBUG: 280637
2013-02-24 12:03:46 -05:00
Kurt Hindenburg
68a98ed770 Add support for ANSI SGR escape code 3 (italics)
Adds support for escape sequences \e[3m and \e[23m (to turn italics on
and off respectively).
http://en.wikipedia.org/wiki/ANSI_escape_code#CSI_codes

Patch by Jem Orgun jeorgun@gmail.com
FEATURE: 314410
REVIEW: 108844
FIXED-IN: 4.11
2013-02-14 14:53:49 -05:00
Kurt Hindenburg
8b3bbae85f Extend selection only if Shift+click is pressed
Follow up to 9a3d588d0e - previously
any modifier+shift+click would extend selections which is not want we
want.
2013-02-10 13:20:42 -05:00
Kurt Hindenburg
88dc51d75c Make LibKonq an optional library
A few versions ago we added LibKonq to handle drag-n-drop menus.  There
are times when this library is not available or the user/distro might
want to disable (cmake option -DWITH_LibKonq=OFF). With this off, any
drag-n-drop will just paste the link.

FIXED-IN: 4.11
REVIEW: 108461
2013-02-09 11:45:06 -05:00
Kurt Hindenburg
7c81b2f790 very minor change to not set variable since it is ignored
via cppcheck
2013-01-31 10:55:17 -05:00
Kurt Hindenburg
7a2a5beb00 Correct spelling errors/word usage
All these are in the comments - no code changes
2013-01-09 22:07:11 -05:00
Yuri Chornoivan
4f888b1088 Pluralize the message (some languages have different plural forms for translation of quanities > 1) 2013-01-08 19:28:01 +02:00
Kurt Hindenburg
9a3d588d0e Implement Shift+click to extend selection
Add ability to press Shift+Click to extend the mouse selection.  In
KDE3 there was the menu option to 'Set Selection End' which this mimics.

REVIEW: 107566
FIXED-IN: 4.11
BUG: 123755
2012-12-28 10:05:40 -05:00
Kurt Hindenburg
417af269e5 Add option to disable ctrl+<mouse-wheel> zooming
The built-in behavior of Ctrl+<Mouse Wheel> to zoom in/out the terminal
can not be disabled. This patch adds an option to disable this
behavior. (Default to the original behavior).

Original patch by Yichao Yu yyc1992@gmail.com
I made some changes - bugs are mine as usual
REVIEW: 107281
FIXED-IN: 4.11
GUI:
2012-12-28 09:51:34 -05:00
Kurt Hindenburg
92019daad5 Add Dialog warning when huge amounts of text is about to be pasted
Currently there is no way to stop an accidently paste into the terminal.
This patch adds a dialog when 8000+ characters are pasted asking if
the user really wants to do this.  At most the user will see this once
as there is a "Don't show again" box.

Previously commit trigger a sysadmin issue.

FEATURE: 162625
REVIEW: 107570
FIXED-IN: 4.11
GUI:
2012-12-21 22:13:41 -05:00
Kurt Hindenburg
983efbc5a8 Add braces around if/else for readability 2012-12-19 23:41:09 -05:00
Kurt Hindenburg
cdf2b2bc78 Switch from c-style casting to c++ casting via static_cast 2012-12-19 21:20:18 -05:00
Amandeep Singh
f0e3b42188 Removing call to updateAccessibility for TextInserted
REVIEW: 106113
2012-09-23 00:06:40 +05:30
Kurt Hindenburg
ca9dd11bf5 Allow option to trim spaces at end of line
In the ongoing issue with spaces at the end of lines, this allows for
an option to trim the spaces.  By default, it is disabled so only
people who need this will be affected.

Many thanks to David Smid <david@smidovi.eu>

CCBUG: 188528
2012-09-09 19:10:41 -04:00
Kurt Hindenburg
c83e7b638d Add support for xterm's 1006 mouse extension
The extension committed in bko 285984 (invented by urxvt's author)
allows the terminal to report coordinates beyond 223. However, for
multiple reasons, xterm's author decided to come up with another
extnsion, addressing the same issue and more.

See more info on this bko 304686

An followup to bko 285984, b876f2a3ed
Patch by Egmont Koblinger egmont@gmail.com

FEATURE: 304686
FIXED-IN: 4.10
2012-09-03 17:07:24 -04:00
Kurt Hindenburg
21a8b063a7 astyle format fixes - whitespace and { 2012-09-03 14:15:47 -04:00
Kurt Hindenburg
5526c75fb2 Reimplement KDE3's print screen functionality
Add File->Print Screen menu option

Patch by Kasper Laudrup laudrup@stacktrace.dk

FEATURE: 249084
FIXED-IN: 4.10
2012-09-03 12:26:31 -04:00
Jason A. Donenfeld
b121a10af0 KPart: support KNotification of bell events.
This is merely adding a comment to inform future maintainers that
applications rely on these event names being kept stable. This is a
necessary precaution before other applications use this event.
2012-08-17 06:35:41 +02:00
Jekyll Wu
131091c983 Adjust including form for some Qt headers as preparation for Qt5
So if someone notices later some Qt header is included in the form
of "#include <Class>" instead of the more common form of "#include
<Module/Class>", do not rush changing it.

REVIEW: 105819
2012-08-14 17:32:06 +08:00
Kurt Hindenburg
e02fea6e17 astyle fixes
use git diff -w --ignore-all-space to see non-space changes
2012-08-05 13:35:03 -04:00
Jekyll Wu
248f2c3cc9 Add profile option for opening URL by direct click(off by default)
Thanks to Asko Eronen<asko.eronen@gmail.com> for the idea and patch

REVIEW: 105282
FEATURE:
DIGEST:
2012-07-15 01:41:13 +08:00
Kurt Hindenburg
ed31a8b0aa Provde a GUI option to disable requiring CTRL to dnd text
This adds a GUI checkbox per profile to enable/disable requiring the
CTRL key to drag-n-drop text.
The default is to require the CTRL key as before.

Thanks to Scott Kitterman (kde@kitterman.com) for patch.

BUG: 165923
REVIEW: 105423
FIXED-IN: 4.10
2012-07-06 16:37:27 -04:00
Kurt Hindenburg
6dcc2874c0 Use static_cast instead of c-style casting 2012-07-05 13:34:26 -04:00
Kurt Hindenburg
564e5f5f30 cppcheck - minor scope fix 2012-06-26 10:12:13 -04:00
Jekyll Wu
e61588a595 Remove the #ifdef for working around contextMenuEvent on Mac OS X
The code within contextMenuEvent() works correctly on Mac OS X
now.

This effectively reverts commit 683566cee3
2012-06-24 21:02:16 +08:00
Jekyll Wu
b464d031d5 Do not show context menu when right click in midnight commander
BUG: 302427
FIXED-IN: 4.9.0
2012-06-24 12:31:41 +08:00
Kurt Hindenburg
6367e80002 use switch/case for Bell code 2012-06-17 19:01:23 -04:00
Kurt Hindenburg
9e7daa966a On MacOS add comment that transparency doesn't work ATM. 2012-06-02 17:54:37 -04:00
Jekyll Wu
4289c5782a Just a few renames 2012-05-23 18:44:31 +08:00
Kurt Hindenburg
f5eb5ce5e9 minor comment spelling fix 2012-05-20 13:14:09 -04:00
Jekyll Wu
1a134198b9 Move blinking related code closer 2012-05-18 16:55:10 +08:00
Jekyll Wu
9686fa13a6 Add more asserts to enforce stronger assumption 2012-05-18 16:22:37 +08:00
Jekyll Wu
9914b2de07 Restart the text blinking timer more conservatively 2012-05-18 16:05:42 +08:00
Jekyll Wu
84ee57f386 More asserts and more comments 2012-05-18 15:41:43 +08:00
Jekyll Wu
8838cf0f50 Less magic number 2012-05-18 15:27:05 +08:00
Jekyll Wu
bf067f0e8b Define the interval for blinking in one place to avoid duplication 2012-05-18 15:15:22 +08:00
Jekyll Wu
56184193d9 Add more asserts as safeguard 2012-05-18 15:05:43 +08:00
Jekyll Wu
693e9b23b6 Add some comment to make the code easier to follow 2012-05-18 15:02:50 +08:00
Jekyll Wu
306fc4962a Remove logically redundant 'else' clause 2012-05-18 14:21:07 +08:00
Jekyll Wu
08fbe6ec0c Move code around 2012-05-18 14:19:30 +08:00
Jekyll Wu
2d34272a2a Remove some non-working code for not showing the size hint
The intention of the code is fine: when konsole is just started, do not
show the size hint since it could be boring and confusing. However, the
code just doesn't work, and using a static variable is definitely a
mistake here.
2012-05-18 12:35:52 +08:00
Jekyll Wu
a123872f29 Process the double-click event triggered by successive middle buttons
BUG: 280332
FIXED-IN: 4.9.0
2012-05-17 05:30:26 +08:00
Kurt Hindenburg
ad52474e0c minor style changes - remove spaces 2012-05-13 12:33:35 -04:00
Kurt Hindenburg
bee9aa8f78 minor style fixes - remove empty lines start/end code blocks 2012-05-13 10:08:05 -04:00
Jekyll Wu
f148185e3c Make the bell code really work.
_bellMasked is mistakenly set as true initially, which make it stay as
true forever. So bell never happens .

This is a follow up of commit 67e0e16e8f
2012-05-13 21:53:50 +08:00