Commit Graph

78 Commits

Author SHA1 Message Date
Alex Richardson
a83db71590 Port to KF5/Qt5
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937
2013-08-20 23:34:35 +02:00
Alex Richardson
ab5e15b1b7 Revert "Port to KF5/Qt5"
This reverts commit 4adfbe84bd.

This work will go into a new branch instead
2013-08-13 23:26:19 +02:00
Alex Richardson
4adfbe84bd Port to KF5/Qt5
To build for KF5 pass the option -DQT5_BUILD=ON to CMake

TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes

REVIEW: 111937
2013-08-13 21:26:59 +02:00
Kurt Hindenburg
ddda4bb01e Add a limit to the sscanf
Add %2x - [0] and [1] are manually set so this is minor
2013-04-27 11:26:11 -04:00
Kurt Hindenburg
983efbc5a8 Add braces around if/else for readability 2012-12-19 23:41:09 -05:00
Kurt Hindenburg
cdf2b2bc78 Switch from c-style casting to c++ casting via static_cast 2012-12-19 21:20:18 -05:00
Jekyll Wu
95bae78c6a Read .keytab files with respect to local encoding.
Thanks to Yichao Yu for the investigation and the patch.

BUG: 310069
FIXED-IN: 4.9.4

REVIEW: 107286
2012-11-14 12:31:38 +08:00
Kurt Hindenburg
bee9aa8f78 minor style fixes - remove empty lines start/end code blocks 2012-05-13 10:08:05 -04:00
Jekyll Wu
11814cbf94 More constness 2012-04-25 00:05:29 +08:00
Jekyll Wu
18b3696dfa more TODO 2012-04-24 12:11:56 +08:00
Jekyll Wu
d52ca4d72c More blank lines 2012-04-23 01:07:50 +08:00
Kurt Hindenburg
5b083640ce whitespace and style fixes
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
2012-04-05 11:08:53 -04:00
Jekyll Wu
d8bc9b48f9 Add class FallbackKeyboardTranslator
One benifit is the fallback translator is now defined upon semantic,
independent upon the format of .keytab file.
2012-03-21 04:31:49 +08:00
Kurt Hindenburg
e0862c603a Style fixes - separte commands - remove 2 ; - align { elses 2012-03-18 15:57:48 -04:00
Kurt Hindenburg
519e2614d6 Style fixes - remove spaces before ; and add spaces in for loops 2012-03-18 15:11:06 -04:00
Jekyll Wu
16a470abe5 Split class KeyboardTranslatorManager into its own files 2012-03-18 15:14:10 +08:00
Jekyll Wu
25b8b5353c Trivial style change: remove extra blank lines 2012-03-17 19:53:21 +08:00
Jekyll Wu
f4fb943132 Most of time we only need <KLocalizedString> instead of <KLocale> 2012-03-07 06:48:26 +08:00
Jekyll Wu
78dbf8f1c1 Remove the left-over & unused code for supporting "Scroll Lock" key
It is decided to not reimplement this feature in KDE4 konsole:

  * It is non-trivial work to implement it correctly
  * It annoyed some users when it was available in KDE3 konsole
  * Not many users want this feature back

This is a follow up of commit cee0ce539b

CCBUG:172271
REVIEW:104156
2012-03-05 08:29:12 +08:00
Kurt Hindenburg
7a5476e420 -Wshadow fixes to parameter names 2012-03-04 18:02:51 -05:00
Jekyll Wu
f0529c1c02 Prefer foreach(..) over iterating manually for readability 2012-02-13 21:28:48 +08:00
Kurt Hindenburg
898d889890 Apply astyle-kdelibs a little more
Use 'diff -w --ignore-all-space' to see non-whitespace changes.
2012-01-08 09:57:12 -05:00
Kurt Hindenburg
d8e05a0672 Use the Qt versions of strlen, strncpy, strncmp 2012-01-03 23:29:05 -05:00
Kurt Hindenburg
9cc6f440e2 Give more info about bad keytab entries. 2011-12-31 22:20:16 -05:00
Kurt Hindenburg
03d2f81d99 Apply astyle-kdelibs
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-24 10:42:18 -05:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
9971d3d117 prefer using convenient method KStandardDirs::locate() . 2011-09-03 16:37:05 +08:00
Jaime Torres
f1ae6db882 return the rigth value for the rigth value
Use the right command value instead of a duplicated.
2011-08-31 19:20:48 +02:00
Kurt Hindenburg
9cf9557c8f Add shortcuts to jump to top & bottom of history.
The shortcut of jumping to top of history is for the request of #45950

The shortcut of jumping to bottom of history is added not only for
consistency, but also to be used for #38390, especially its comment #9
 and #10.

Patch by Jekyll Wu <adaptee@gmail.com>

FEATURE: 38390
FEATURE: 45950
FIXED-IN: 4.8
REVIEW: 102124
2011-08-01 23:19:08 -04:00
Kurt Hindenburg
19a60fc577 Use kWarnings for error messages
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1148435
2010-07-10 16:49:58 +00:00
Kurt Hindenburg
c4e62b067b Move the defaultTranslatorText to QByteArray and put it inside the .cpp file.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1108108
2010-03-27 20:41:17 +00:00
Friedrich W. H. Kossebau
1cf6ef9365 changed: made static const data symbols really static const
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1080302
2010-01-26 02:57:09 +00:00
Robert Knight
2780a44d4a Fix crash if key bindings specified in profile cannot be found. Improve
KeyboardTranslator::defaultTranslator() to try loading "default.keytab" if
first before falling back to the hard-coded one.

BUG:181205


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=913176
2009-01-18 21:30:24 +00:00
Albert Astals Cid
b3c542cf08 qDelete knows how to delete the values without creating a temporary list
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=890897
2008-11-30 16:08:47 +00:00
Robert Knight
91c507a816 Add support for 'AnyModifier' and 'AppCursorKeys' as alternative names for 'AnyMod' and 'AppCuKeys' flags in keyboard translator files.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=864900
2008-09-25 21:34:32 +00:00
Robert Knight
433f520781 Tidy up keyboard translator code.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=864317
2008-09-24 13:07:38 +00:00
Robert Knight
c705a18b27 Allow bindings for +-.* keys to be defined in keyboard translator file.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=864011
2008-09-23 18:24:05 +00:00
Robert Knight
e97de774be Add support for producing different output when keypad buttons are
pressed in Application or Normal mode (set using 'ESC =' and 'ESC >' escape sequences.)

Added support for 'AppKeypad' modifier in keyboard translator files to specify that the 
sequence only applies when the terminal is in application keypad mode (+AppKeyPad) or is 
not in application keypad mode (-AppKeyPad) 

Added support for producing different output from number keys along top of keyboard versus
keypad keys via new 'keypad' modifier in keyboard translator files (+KeyPad to require keypad 
key, -KeyPad to require a non-keypad key or left out to accept either)

CCBUG: 170220
CCBUG: 37652
CCBUG: 165169


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=863985
2008-09-23 17:12:37 +00:00
Robert Knight
956277c014 Convert tabs to 4 spaces to match kdelibs conventions. Previously
there was a mix of tabs and spaces for indentation.

CCMAIL:Stefan.Becker@nokia.com


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=863326
2008-09-21 20:06:58 +00:00
Robert Knight
cc78f9909b Better comment parsing in keyboard binding files.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=808721
2008-05-17 12:23:55 +00:00
Dirk Mueller
06785749a0 fix scanf format string warning
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=808158
2008-05-15 20:13:11 +00:00
Robert Knight
5d9997446e Update copyright year to 2008. Remove '(C)' from copyright lines.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=800631
2008-04-24 14:53:43 +00:00
Albert Astals Cid
f52cceaf9e remove duplicate includes
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=796409
2008-04-13 14:38:26 +00:00
Robert Knight
75ac16607a Replace qWarning() with kWarning(), which provides additional information about the context of the warnings.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=754559
2007-12-30 08:32:50 +00:00
Robert Knight
46cfc108d3 * Replace all usage of qDebug() with kDebug(), since kDebug() provides information about
which part of the code the message came from and allows filtering of output
  using kdebugdialog
* Remove explicit creation of singleton classes SessionManager,ColorSchemeManager and
  KeyboardTranslatorManager and automate it with K_GLOBAL_STATIC.
  This ensures that the singleton destructors are called appropriately by KPart clients
  when they unload the libkonsolepart library.


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=754334
2007-12-29 16:07:31 +00:00
Robert Knight
c0b14ce83e Add support for 'Erase' command in .keytab files which echos the OS/terminal type appropriate erase character to the terminal, previously always '\b' in Konsole.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=750287
2007-12-19 02:43:41 +00:00
Robert Knight
7b77ff1684 When checking for a match against an entry with the AnyModifier state, the keypad modifier is not counted.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=748997
2007-12-16 07:06:17 +00:00
Robert Knight
f93ae9c23a Add support for the keypad modifier in .keytab files. This makes it possible to produce different output for a key on the keypad and its semantic equivalent elsewhere on the keyboard. The modifier can be required or banned using 'key+keypad','key-keypad' etc. in the key bindings list, as with any other modifier.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=748996
2007-12-16 06:59:47 +00:00
Robert Knight
a140e9078f Fix Ctrl+Space key combination with default keytab: Fixed bug where unescaping the character sequences '\x0' or '\x00' from a .keytab entry failed because the result was '0', which was also the value used to mean that escaping the sequence failed. Use a separate boolean variable to track whether the escaping succeeds or not instead.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=748987
2007-12-16 05:00:21 +00:00
Robert Knight
e37fe69431 * Fix problem where selection background and other text with non-standard background
colors was not readable with terminal display transparency enabled.

* Transparency works again, but requires --enable-transparency argument passed to command-line
  due to artifacts that appear otherwise.
  Re-enable the code which searches for a suitable display, visual and colormap when
  starting the application in an environment which supports compositing.  Still
  need to resolve with other developers exactly how this will be done in KDE 4.0

* Fix problem where flow control warning banner was always displayed when 
  Ctrl+S, Ctrl+Q were pressed, regardless of whether flow control was 
  actually enabled.

* Fix artifacts when scrolling whilst the flow control warning banner was 
  visible.  Scrolling optimisations in the terminal display are disabled whilst
  the warning banner is being shown.

* Fix links which wrapped over more than one line being cut-off at the end of the line
  (eg. when parsing "http://www.kd <END OF LINE> e.org" the link address would be reported
   as "http://www.kd" instead of "http://www.kde.org").  The link underlining is not yet 
   corrected, only the part of the link on the first line is highlighted.  

* Implement code to load and use a built-in keyboard translator for fallback purposes
  in case no .keytab files exist.  The actual translator text (in DefaultTranslatorText.h)
  is currently incomplete. 

* Replace hard-coded colors for flow control warning label with colors from
  KColorScheme

* Replace hard-coded colors in incremental search line edit when a match is not found
  with colors from KColorScheme

* Remove un-used variables in TerminalDisplay class, rename enums to match
  CamelCase naming style used elsewhere.

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=748936
2007-12-15 23:07:20 +00:00