It is problematic to use "isEmpty()" to check whether the information
has been read. That would defeat the purpose of reading it only once
when the user has explicitly set that list as empty.
The main consideration is it is more often confusing than helpful for
average users, especially when this feature was hidden, undocumented and
enabled by default.
The "CommonDirNames" list in the code is now empty by default , instead
of a list of hardcoded common names.
To enable and customize this advanced and potentally confusing feature,
edit $KDEHOME/usr/share/config/konsolerc and add the following lines:
[ProcessInfo]
CommonDirNames=name1,name2,name3...
For konsolepart users, edit the config file of the hosting application.
I'll add related information for this hidden & advanced feature into
handbook later.
BUG:190281
FIXED-IN:4.9.0
REVIEW: 103949
CCMAIL: robertknight@gmail.com
Those two formatters have never been actually implemented or revealed to
users. It is quite hard to infer what they are supposed to do based upon
exising code and commit history
In '-p 2222', -p is the option and 2222 is its argument.
noOptionsArguments ==> noArgumentOptions
singleOptionArguments ==> singleArgumentOptions
argChar ==> optionChar
The old code updates the argument list when it is asked to refresh
process info, but it calls ProcessInfo::addArgument() without ever
clearing existing arguements first. This means the argument list will
grow longer and longer for ever. For a long-running shell session in
which user has executed thousands of commands, that will waste quite
amount of memory, not to metion the logic error itself.
The reaseon why this bug keeps hidden is that the %c and %C formatter
have never been revealed to users, which are not implemented yet.
If this information is put anywhere it should be in a single file instead
of duplicated for each file. In fact, it shouldn't be needed at all since
we have the same rules on tabs and tab sizes as most other parts of kdebase
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=946369
Patch from Stefan Becker <stefan.becker@nokia.com>
Thank-you very much Stefan!
CCBUG: 152761
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=867323
* Re-organise CMakeLists.txt
Squashed commit of the following:
commit 7de6492753607603675729844520c89d914294eb
Author: Robert Knight <robertknight@gmail.com>
Date: Wed Jun 25 22:46:06 2008 +0100
Formatting. Clarify comments.
commit 5e419ee80316fc523d6809f0b5f7112aca565d19
Author: Robert Knight <robertknight@gmail.com>
Date: Wed Jun 25 22:35:23 2008 +0100
Fix compilation of ProcessInfo.cpp under Linux. Add missing members to dummy psinfo struct. Create instance of correct ProcessInfo sub-class depending on whether OS is Linux or Solaris.
commit 08d0ce320761bf2beedeb463a01bcb0a3e426439
Author: Robert Knight <robertknight@gmail.com>
Date: Wed Jun 25 22:34:11 2008 +0100
Re-organise the CMakeLists.txt to avoid duplicating the list of sources for the part and the application.
commit 7b84b5ebb7422f8e87dbc2e224ebc2405355e262
Author: Robert Knight <robertknight@gmail.com>
Date: Wed Jun 25 17:28:47 2008 +0100
Support for reading process information under Solaris. Patch from Adriaan de Groot.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=824517