Kurt Hindenburg
bed548e85a
sync declarations with definitions (have .h and .cpp variable names match)
2018-01-06 16:39:16 -05:00
Kurt Hindenburg
c696e06e33
Use Q_DECL_OVERRIDE for non-Linux systems
2017-07-22 12:50:18 -04:00
Kurt Hindenburg
2a2a56d73c
modernize use nullptr
2017-07-15 23:28:32 -04:00
Kurt Hindenburg
4c5f7f6764
uncrustify using kf5 config
2017-06-28 10:09:34 -04:00
Pino Toscano
3d19a44661
libprocstat does not seem to be used on FreeBSD
2017-06-26 06:50:02 +02:00
Kurt Hindenburg
8e2a1e5a08
DragonflyBSD doesn't need/have libprocstat.h
2017-06-25 12:23:23 -04:00
Pino Toscano
690e1d2882
include <errno.h> where errno is used
2017-06-19 22:45:40 +02:00
Kurt Hindenburg
8f010c7cc5
fix *BSD code build with QT_NO_CAST_FROM_ASCII
...
Tested on FreeBSD 11 - guessing on OpenBSD and DragonflyBSD
2017-06-18 14:19:09 -04:00
R.J.V. Bertin
4cd725ffbe
use the proper Mac platform token
2017-06-15 18:30:43 +02:00
R.J.V. Bertin
923231329b
make Mac-specific code build with QT_NO_CAST_FROM_ASCII
2017-06-15 18:29:15 +02:00
Kurt Hindenburg
eade05a4bd
Do not specify Qt modules in includes
2017-04-26 21:33:34 -04:00
Kurt Hindenburg
b92d563cd3
Since we ignore return value of readProcessInfo(), change to void
2017-04-22 00:44:15 -04:00
Kurt Hindenburg
a540e6fdd0
Fix readability-implicit-bool-cast issues using nullptr
2017-04-21 10:51:31 -04:00
Kurt Hindenburg
21cc5c1fed
Use QLatin1* to handle casts from ascii
2017-04-16 14:26:39 -04:00
Kurt Hindenburg
accf076104
Use member initializer lists in constructors
2017-04-11 12:07:34 -04:00
Kurt Hindenburg
dfafff97d4
remove QDebug/qWarning and use QCDebug
2017-03-31 21:06:18 -04:00
Kurt Hindenburg
cf06fa08b3
rearrange code placment to keep related items together
2017-03-31 08:58:19 -04:00
Kurt Hindenburg
66044df34b
fix a lot of issues of readability-implicit-bool-cast
2017-03-29 08:32:59 -04:00
Kurt Hindenburg
7c8815f5e0
simplify if()s for readability
2017-03-27 11:08:31 -04:00
Kurt Hindenburg
35d419e734
Add Q_DECL_OVERRIDE via clang-tidy
2017-03-26 00:01:57 -04:00
Kurt Hindenburg
49f6216e6a
Add static_cast to show conversions
2017-02-18 15:18:07 -05:00
Kurt Hindenburg
edcb028d29
const & foreach loop
2016-09-04 17:27:12 -04:00
Martin T. H. Sandsmark
e7770aba9f
Avoid polling processes if they report what we need with OCS7
...
This is apparently what the OCS7 stuff is supposed to solve, so let's
use it if we can.
REVIEW: 128784
BUG: 325442
2016-08-28 17:04:18 +02:00
Martin T. H. Sandsmark
392ee33cf8
Don't re-read process information that should be static
...
This changes the process info code to only update the information that
can change about a process when updating information about a process.
CCBUG: 325442
REVIEW: 128777
2016-08-27 22:41:18 +02:00
Martin T. H. Sandsmark
e07a62ede3
Remove unused environment reading code
...
REVIEW: 128674
CCBUG: 325442
2016-08-27 13:26:06 +02:00
Kurt Hindenburg
a805f856ff
For remote ssh processes, add %U which gets replaced by user@ if present
...
Add a new string replacement %U for remote tabs, which evaluates
to _user@ if user is non-empty, and the empty string otherwise.
Patch by Tobias Berner tcberner gmail com
Part of REVIEW 127525
2016-07-09 18:45:39 -04:00
Kurt Hindenburg
d424d1457d
Try to catch ssh command arguments for tab titles
...
When using 'ssh server command args', try to gather the command args
for use in the tab titles. This doesn't work 100% and suggest using
quotes around the ssh command.
Patch by Tobias Berner tcberner gmail com
Part of REVIEW 127525
2016-07-09 18:30:53 -04:00
Kurt Hindenburg
2c93676978
Fix FreeBSD readArguments and implement its readEnvironment
...
* FreeBSD's readArguments() implementation was broken:
It read the wrong sysctl.
Also the string processing did not work as expected.
* FreeBSD's readEnvironment() was not implemented.
This provides an implementation using libprocstat's
procstat_getenvv
Tested on my system w/ FreeBSD 11.0-CURRENT
Patch by Tobias Berner tcberner gmail com
Part of REVIEW 127525
2016-07-09 13:58:43 -04:00
Kurt Hindenburg
272c8f7fd8
Q_OS_MAC -> Q_OS_OSX
...
Q_OS_MAC includes OSX and iOS
Patch from rjvbertin gmail com
2016-07-07 15:53:57 -04:00
Kurt Hindenburg
527d2606be
Port KDE_struct_stat to QT_STATBUF; KDE::stat to QT_STAT
...
Re-commit this patch from Feb 2015; I was told it caused Konsole to not
build on Mac OSX. However, it builds now fine on my system.
For Q_OS_MAC only
2016-07-07 15:25:59 -04:00
Kurt Hindenburg
0edded4975
Only readUserName if tab title format has %u
...
readUserName() reads /etc/passwd every few seconds. Change it to only
do this if we need to replace %u with the user name in the tab title.
A temporary helper as this doesn't really fix the underlining issue.
ProcessInfo really needs re-worked.
CCBUG: 325442
2016-05-30 19:58:03 -04:00
Kurt Hindenburg
bdee35bf38
Use QStringLiteral and QLatin1String
2015-10-15 16:25:32 -04:00
Kurt Hindenburg
0fdc52b222
Use QFlags:: for Field enum
2015-10-10 20:23:09 -04:00
Kurt Hindenburg
f5bb2f1c5d
For MacOSX, get it so that it builds
...
Remove kde_file and comment out parts that used it. Konsole currently
builds on OSX but dies upon startup
kdelibs4support/src/kdecore/kcmdlineargs.cpp +1492
2015-09-13 17:26:30 -07:00
Kurt Hindenburg
15a903a6d1
Revert "Port KDE_struct_stat to QT_STATBUF; KDE::stat to QT_STAT"
...
This was only for the MAC and I've been told it doesn't compile.
I will research later.
This reverts commit 142727dd67 .
2015-02-10 13:16:10 -10:00
Kurt Hindenburg
142727dd67
Port KDE_struct_stat to QT_STATBUF; KDE::stat to QT_STAT
...
For Q_OS_MAC only
2015-02-08 09:52:29 -10:00
Kurt Hindenburg
be2b2b4b2e
call readLine() without arg to be set maxlen=0 as default
...
Qt dev overloads readline()
call to member function 'readLine' is ambiguous
Thanks to Takahiro Hashimoto for report and fix
BUG: 343851
2015-02-07 09:37:56 -10:00
Montel Laurent
5d4cda3e2f
kdelibs4support--
2014-10-18 13:03:41 +02:00
Montel Laurent
0acf9a7712
Remove kdelibs4support
2014-10-17 13:40:30 +02:00
Montel Laurent
8182ac8edc
Port to QDebug
2014-10-17 09:09:20 +02:00
Kurt Hindenburg
b9b17cae4d
Clarify QFile:: error enums
2014-04-15 10:33:06 -04:00
Kurt Hindenburg
99059278ca
Clarify enums for ProcessInfo - possible match w/ QFile's enums
2014-04-15 10:09:19 -04:00
Patrick Spendrin
b79701cefd
do not build UnixProcessInfo on Windows
2013-11-26 21:00:10 +01:00
Kurt Hindenburg
08fb406533
Use cmake to check if we're on DragonFly BSD instead of __DragonFly__
...
builds on dragonfly 3.4-RELEASE DragonFly
2013-09-13 23:45:34 -04:00
Kurt Hindenburg
93186a2d53
On MacOSX setPid - strange I never notice this was missing before
2013-09-07 13:08:52 -04:00
Pino Toscano
f72af085ae
ProcessInfo: isolate all the platform-specific *ProcessInfo implementations
...
compile all the platform-specific *ProcessInfo implementations only
in the OS they belong to, basically extending this conditional
compilation also to the Linux and Solaris implementations.
This allows to use proper OS-specific API/etc in each, removing quirks
(like the one for the Solaris psinfo struct) to emulate such APIs on
other OSes.
2013-08-01 16:53:06 +02:00
Kurt Hindenburg
86880dff46
Fix a minor krazy issue about dup #include
2013-07-12 10:27:02 -04:00
Kurt Hindenburg
f051b6cd20
minor style fixes
...
GIT_SILENT
2013-04-27 09:25:04 -04:00
Kurt Hindenburg
160ac87b59
Remove unnecessary Q_OS_MAC checks and includes
...
This compiles under 10.8.x - I don't have a 10.7 system to check
2013-04-13 15:39:42 -04:00
Kurt Hindenburg
2c686b7afe
Minor warning fixes when running under FreeBSD
2013-02-23 10:00:25 -05:00