Commit Graph

24 Commits

Author SHA1 Message Date
Kurt Hindenburg
9e147814dc Remove Q_ASSERT to the dialog will be shown. 2011-10-29 14:49:22 -04:00
Jekyll Wu
f948623ee0 Refine the warning label 2011-10-28 22:42:02 +08:00
Jekyll Wu
b58739e6bd Remove unused #include 2011-10-28 01:40:08 +08:00
Jekyll Wu
266e18fe3e minor change on code style 2011-10-28 01:37:37 +08:00
Jekyll Wu
e2d56c1ad0 Prefer using static member for a const value 2011-10-28 01:31:44 +08:00
Jekyll Wu
8f7be18a64 Simplify the scrollback setting dialog to avoid potential confusion.
- the change is not saved into profile and only influences current tab
  - remove the 'Save to current profile' checkbox
  - remove the 'Defaults' button
  - change dialog title from "Scrollback Options" to "Adjust Scrollback"
  - change action from "Scrollback Options..." to "Adjust Scrollback..."

The new dialog makes the "Adjust Scrollback..." action more consistent with most
of other actions in the context menu, since they only influence or work in the
context of current tab.

The UI change is not quite satisfactory. Feel free to refine the UI part
to make it more clear and elegant.

BUG: 227144
FIXED-IN : 4.8
REVIEW: 102688
2011-10-25 19:24:15 +08:00
Jekyll Wu
da7c9d254a Set the incremental step of HistorySize as 1/10 of current value. 2011-10-06 21:21:34 +08:00
Jekyll Wu
1b5d836219 Add KDialog:: prefix for ButtonCode.
Ok, Cancel and Default are so generic that they look ambiguous without
the KDialog:: prefix.
2011-09-06 01:25:15 +08:00
Jekyll Wu
d99422730f Less one-liner definitions for class methods .
This really hurts readability, especially when they appear successively.
2011-09-06 00:32:53 +08:00
Jekyll Wu
976077e37f Do not select the fixed size mode by default.
Current code always sets the line count spinbox as focused and selected,
even when the current setting of history size is no history or unlimited
history. This is counter-intuitive and may confuse users.
2011-09-05 23:28:14 +08:00
Jekyll Wu
0012355e2e slight adjustment of code layout. No functionality changes. 2011-09-05 23:06:08 +08:00
Andrius Štikonas
4961215664 Use KIntSpinBox instead of QSpinBox for better integration with KDE. As a bonus this allows to use plural suffix in spinboxes since KDE 4.3 if necessary.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=989742
2009-06-30 20:09:04 +00:00
Kurt Hindenburg
ef7c91b1d2 Add checkbox to allow Scrollback->Scrollback Options dialog to save to current profile.
FEATURE: 155580

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=920007
2009-02-02 05:24:53 +00:00
Robert Knight
5d9997446e Update copyright year to 2008. Remove '(C)' from copyright lines.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=800631
2008-04-24 14:53:43 +00:00
Robert Knight
d1040daec5 Revert part of #760591 which was committed unintentionally.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=760592
2008-01-13 01:16:12 +00:00
Robert Knight
cb1504de10 Minor style cleanup. if..elseif to switch. #include <kio/job.h> -> #include <KIO/Job>
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=760591
2008-01-13 01:13:52 +00:00
Robert Knight
dcdf9e76b3 Rename History to Scrollback in the UI, to avoid confusion with shell's command history. Fixes to color scheme previewing in Edit Profile Dialog. Add a few icons here and there. Add full screen menu item.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=665834
2007-05-18 05:26:40 +00:00
Dirk Mueller
9ea3227384 include cleanup
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=663054
2007-05-09 22:23:52 +00:00
Robert Knight
33c913383d EBN fixes. Mostly copyright and implementations including their own headers first.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=662726
2007-05-09 00:01:01 +00:00
Stephan Binner
c7debcd41a i18n style guide fixes
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=662510
2007-05-08 13:19:53 +00:00
Robert Knight
8a2bf09d96 Make history options, manage profiles and edit current profile dialog non-modal as suggested.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=662230
2007-05-07 17:06:31 +00:00
Robert Knight
622cae74e5 Methods to set and get the settings used when clicking on the 'Defaults' button in the History Options dialog. Eventually this should mean using the current profile's history settings.
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=661704
2007-05-06 12:33:18 +00:00
Laurent Montel
a95ff80555 Make default button works
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=661686
2007-05-06 11:31:50 +00:00
Robert Knight
19a29d182a Rename directories for clarity. konsole -> src , other -> data.
svn path=/branches/work/konsole-split-view/; revision=661562
2007-05-05 23:33:05 +00:00