For now revert this, on non X11 systems it causes:
FAILURE (KCmdLineArgs):
Application requests for isSet("display") but the "display" option
has never been specified via addCmdLineOptions( ... )
This reverts commit d42ef186c8.
This allows both these lines to work:
konsole -e man ls
konsole -e "man ls"
Thanks to Mark Raymond markr raymonds org uk for patch/testing.
CCBUG: 295648
REVIEW: 120001
FIXED-IN: 4.14.2
(cherry picked from commit bd56dba1a9)
* frameworks: (200 commits)
We can increase minimum version
Fix Bug 318453 - Blinking cursor of "fullwidth" character are "halfwidth"
Issue a warning when not matching a font exactly
ki18n_wrap_ui
l10n fixes
Use QStringLiteral instead of QLatin1Literal
Set the component name if a KPart
setXMLFile doesn't need the path to "konsole/" after the adjustment to KXMLGUI_INSTALL_DIR
Use xi18n when markup
remove accel markers
Use KXMLGUI_INSTALL_DIR
Fix crash in Manage Profile Dialog
Fix crash on close
update boxs.txt which uses more box lines for testing purposes
Correct line drawing characters U+2532, U+2544, U+2546, U+2560
Fix spacing so next cherry-pick will apply
Fix translucency support.
Enable wordwrap on suspended message to avoid window resize
Update dependency: KDE4Support to KDELibs4Support
Convert to Qt5 signal slot syntax
...
Conflicts:
CMakeLists.txt
desktop/CMakeLists.txt
desktop/konsolerun.desktop
desktop/org.kde.konsole.desktop
src/Application.cpp
src/CharacterColor.h
src/EditProfileDialog.cpp
src/EditProfileDialog.ui
src/Emulation.cpp
src/IncrementalSearchBar.cpp
src/IncrementalSearchBar.h
src/LineFont.h
src/MainWindow.cpp
src/ScreenWindow.h
src/Session.cpp
src/SessionController.cpp
src/TerminalCharacterDecoder.cpp
src/TerminalDisplay.cpp
src/autotests/ShellCommandTest.cpp
src/autotests/TerminalCharacterDecoderTest.cpp
src/config-konsole.h.cmake
src/fontembedder.cpp
src/main.cpp
src/settings/GeneralSettings.cpp
src/tests/CMakeLists.txt
src/tests/PartManualTest.cpp
When setting a font for the terminal, if it is not found properly by the
system, Qt attempts to use another font which is not an exact match. It
happens that the other font is not fixed-pitch, so konsole ends up using
an unsupported variable-pitch font for the terminal.
Place a warning when an exact match for the desired font has not been
found.
Move code responsible for 'forgetting' a view outside of code responding to the
TerminalDisplay deletion.
This avoids a loop like this:
~MainWindow
=> ~QStackedWidget
=> ~TerminalDisplay
=> QObject::destroyed
=> ViewContainer::viewDestroyed
=> ViewContainer::removeViewWidget
- internal cleanup
- try to remove TerminalDisplay from QStackedWidget which is being deleted and
crash
Instead the code now does:
~MainWindow
=> ~QStackedWidget
=> ~TerminalDisplay
=> QObject::destroyed
=> ViewContainer::viewDestroyed
=> ViewContainer::forgetView (does the internal clean up)
And if one tries to explicitly remove a view, sequence is:
ViewContainer::removeView
=> ViewContainer::forgetView
=> ViewContainer::removeViewWidget
The patch also removes ViewManager::focusActiveView() because it causes a crash
when closing a TerminalDisplay as it tries to put the focus on the deleted
TerminalDisplay. I initially called it through a queued connection, but realized
it is actually not needed for focus to be passed to the correct view, so just
removed it.
BUG: 331724
REVIEW: 118839
Fix box lines - using kmag is a great help
Thanks to Egmont Koblinger egmont gmail com for report and patch
BUG: 335339
FIXED-IN: 4.13.2
(cherry picked from commit 58d79e3624)
