mirror/konsole
1
0
Fork 0
mirror of https://github.com/KDE/konsole.git synced 2026-05-04 20:55:56 -04:00
Code Issues Packages Projects Releases Wiki Activity
4,868 Commits 139 Branches 416 Tags
e02fea6e17ece6d5b7437c74aed28bfbb07d918e
Commit Graph

78 Commits

Author SHA1 Message Date
Kurt Hindenburg
569ffb37e4 remove kWarning 2012-06-18 09:16:18 -04:00
Kurt Hindenburg
1ce424142f Use readlink instead of QFileInfo to prevent non-responsive issues. 
The current code using QFileInfo on the /proc/%pid/cwd and for some
situations, this may cause issues as QFileInfo hangs if unable to read that
file.  The new code uses readlink which appears to work w/o issue.

The Solaris  code needs fixed as well.

CCBUG: 251351
 2012-06-18 08:56:11 -04:00
Jekyll Wu
a3b73317fd Small krazy fix for including header 2012-06-14 16:20:47 +08:00
Kurt Hindenburg
bee9aa8f78 minor style fixes - remove empty lines start/end code blocks 2012-05-13 10:08:05 -04:00
Jekyll Wu
fd11d1cccf Add missing ssh commandline options 
The new options are take from the manual of openssh-6.0
 2012-05-06 04:43:42 +08:00
Jekyll Wu
59c635f552 Add formatter %h which expands to local hostname in local session 
Note: this %h is different from the %h which expands to remote hostname
in remote session.

REVIEW: 104490
 2012-04-09 22:50:23 +08:00
Kurt Hindenburg
5b083640ce whitespace and style fixes 
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
 2012-04-05 11:08:53 -04:00
Kurt Hindenburg
f28b60ba09 Fix crash for 'ssh -t localhost bash -l' 
This needs to be handled better but for now stop crashing.

BUG: 297156
 2012-03-30 21:21:56 -04:00
Kurt Hindenburg
519e2614d6 Style fixes - remove spaces before ; and add spaces in for loops 2012-03-18 15:11:06 -04:00
Jekyll Wu
25b8b5353c Trivial style change: remove extra blank lines 2012-03-17 19:53:21 +08:00
Kurt Hindenburg
c272fb2c15 Remove krazy lines 2012-03-08 23:16:44 -05:00
Kurt Hindenburg
8613e562ce -Wshadow fixes to parameter names and variable names (pid) 2012-03-07 09:48:49 -05:00
Jekyll Wu
ba8452e5c2 Ensure reading the CommonDirNames information only once. 
It is problematic to use "isEmpty()" to check whether the information
has been read. That would defeat the purpose of reading it only once
when the user has explicitly set that list as empty.
 2012-03-06 02:21:05 +08:00
Jekyll Wu
90469a094a Add more constness 2012-03-06 02:00:15 +08:00
Jekyll Wu
5a936adb20 Disable the advanced feature of "CommonDirNames" for "%d" by default 
The main consideration is it is more often confusing than helpful for
average users, especially when this feature was hidden, undocumented and
enabled by default.

The "CommonDirNames" list in the code is now empty by default , instead
of a list of hardcoded common names.

To enable and customize this advanced and potentally confusing feature,
edit $KDEHOME/usr/share/config/konsolerc and add the following lines:

    [ProcessInfo]
    CommonDirNames=name1,name2,name3...

For konsolepart users, edit the config file of the hosting application.

I'll add related information for this hidden & advanced feature into
handbook later.

BUG:190281
FIXED-IN:4.9.0

REVIEW: 103949
CCMAIL: robertknight@gmail.com
 2012-02-26 04:14:27 +08:00
Jekyll Wu
f42fd4721b Clean up unneeded #includes 2012-02-20 19:41:38 +08:00
Jekyll Wu
97ce14afef Remove code for tab title formatter %c and %C. 
Those two formatters have never been actually implemented or revealed to
users. It is quite hard to infer what they are supposed to do based upon
exising code and commit history
 2012-02-13 06:21:28 +08:00
Jekyll Wu
5cf3b4fa00 Remove dead code 2012-02-12 18:27:33 +08:00
Kurt Hindenburg
6d31f70160 Apply astyle-kdelibs 
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
 2011-12-24 11:03:54 -05:00
Jekyll Wu
125e2c7bd2 Declare pointer and reference in a consistent way 
Most code use the "const QString& text" form, instead of the "const
QString &text" form. So change the minority to be consistent with
the majority.
 2011-11-06 06:13:28 +08:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
1772401647 Rename for consistency 
In '-p 2222', -p is the option and 2222 is its argument.

noOptionsArguments   ==> noArgumentOptions
singleOptionArguments ==> singleArgumentOptions
argChar ==> optionChar
 2011-09-09 23:10:13 +08:00
Jekyll Wu
c4ab3d6c6d Make the parsing of ssh command more robust, or more complicated. 
It now can deal with both '-p 2222' and '-p2222'.

This is a follow up of 869cdb1090

CCBUG: 281621
 2011-09-09 21:23:12 +08:00
Jekyll Wu
e828def700 Reorgnazie some #include. 2011-09-06 06:53:38 +08:00
Jekyll Wu
869cdb1090 support -p port in ssh command for specifying non-default port. 2011-08-21 09:17:42 +08:00
Jekyll Wu
cc36502516 make %u work for ssh connection where '-l user' is used . 
FEATURE: 197345
FIXED-IN: 4.8
 2011-08-20 23:07:43 +08:00
Jekyll Wu
967c927b04 Disables the code for replacing the %c and %C formatter. 
%c and %C are not implemented yet, and are unkonwn to users.
 2011-08-20 19:34:35 +08:00
Jekyll Wu
20e9274943 Fix a hidden bug which makes argument list grow longer for ever. 
The old code updates the argument list when it is asked to refresh
process info, but it calls ProcessInfo::addArgument() without ever
clearing existing arguements first. This means the argument list will
grow longer and longer for ever. For a long-running shell session in
which user has executed thousands of commands, that will waste quite
amount of memory, not to metion the logic error itself.

The reaseon why this bug keeps hidden is that the %c and %C formatter
have never been revealed to users, which are not implemented yet.
 2011-08-20 19:23:17 +08:00
Kurt Hindenburg
f5feeba821 Check getpwuid_r return value. 2011-04-02 17:43:56 -04:00
Kurt Hindenburg
cacfb081bb Use KDE::'s stat and chmod 2011-04-01 10:37:53 -04:00
Kurt Hindenburg
e865acedb8 Add cwd support for DragonFly. Patch by Alex Hornung. 
It compiles under Linux.

BUG: 259970

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1210984
 2011-01-02 21:13:06 +00:00
Kurt Hindenburg
b216cb9daf In the tab title, for %D change the user's home path with a ~ if it starts at the 
beginning.

FEATURE: 206316
FIXED-IN: 4.6

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1185589
 2010-10-13 19:58:43 +00:00
Kurt Hindenburg
71a9a5d3d8 For Q_OS_MAC, obtain the current directory. There is still the issue of when it is a 
symlink that the linked directory is given, not the symlink.


svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1185298
 2010-10-12 21:11:17 +00:00
Kurt Hindenburg
eef7bc702e Dragonfly patch to build - patch by Alex Hornung 
BUG: 247626

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1173677
 2010-09-10 03:21:07 +00:00
Kurt Hindenburg
6b2440e2c2 comment out kDebugs - change some to kWarnings 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1148447
 2010-07-10 17:22:28 +00:00
Kurt Hindenburg
cf2522f6e9 quite unused variables 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1115193
 2010-04-15 15:33:21 +00:00
Kurt Hindenburg
3138e80fd6 minor krazy fixes 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1108151
 2010-03-28 00:13:13 +00:00
Kurt Hindenburg
00acf5ca59 Change quotes to brackets for config-konsole.h includes 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1107712
 2010-03-26 15:16:51 +00:00
Benjamin Reed
459a5cda2f merge 1099510 from 4.4: test for sys/proc_info.h and sys/proc.h 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1099511
 2010-03-05 17:56:08 +00:00
Kurt Hindenburg
762b0eeaaa This time use the correct portable struct for stat 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1079207
 2010-01-23 20:48:46 +00:00
Kurt Hindenburg
799c55e83c use portable struct for stat 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1079177
 2010-01-23 19:39:57 +00:00
Kurt Hindenburg
31aea137a8 Fix some build warning and a krazy issue. 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1033923
 2009-10-11 15:42:12 +00:00
Kurt Hindenburg
e6f2f19a70 Use getpwuid_r instead of getpwuid in the Linux portion. 
Possible reports: 195265, 201119, 209544

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1032293
 2009-10-07 13:52:17 +00:00
Kurt Hindenburg
fd19e735aa Change how /proc/%pid/status is read on Linux and add more error checking in hopes of avoiding crashes. 
Possible reports: 195265, 201119, 209544

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1031794
 2009-10-06 05:24:31 +00:00
Raphael Kubo da Costa
f2d94b2b51 Save one pointer in FreeBSD::readCurrentDir(). 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1018644
 2009-09-02 01:20:26 +00:00
Raphael Kubo da Costa
384792f0ea Implement readArguments() for FreeBSDProcessInfo. 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1018643
 2009-09-02 01:17:44 +00:00
Raphael Kubo da Costa
f0cf4e52b5 Return false for methods not implemented in Solaris. 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1017794
 2009-08-31 14:32:53 +00:00
Raphael Kubo da Costa
750dc4fa90 Add support for retrieving process information for FreeBSD. 
REVIEW: 1485
BUG: 205648

svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1017793
 2009-08-31 14:31:23 +00:00
Kurt Hindenburg
a8c7c1de89 Fix an issue with my 1017187 commit and fix 1 krazy2 issue 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1017606
 2009-08-31 00:25:54 +00:00
Kurt Hindenburg
163df68298 Fix some code issues that krazy2 found when running on MacOS. 
svn path=/trunk/KDE/kdebase/apps/konsole/; revision=1017187
 2009-08-29 21:55:19 +00:00