Commit Graph

138 Commits

Author SHA1 Message Date
Kurt Hindenburg
e0862c603a Style fixes - separte commands - remove 2 ; - align { elses 2012-03-18 15:57:48 -04:00
Kurt Hindenburg
519e2614d6 Style fixes - remove spaces before ; and add spaces in for loops 2012-03-18 15:11:06 -04:00
Jekyll Wu
663e342aa8 Krazy fix: add the missing KUIT context marker 2012-03-18 22:57:32 +08:00
Jekyll Wu
25b8b5353c Trivial style change: remove extra blank lines 2012-03-17 19:53:21 +08:00
Jekyll Wu
57c2ae6e1e Rename global option: ShowMenuBar ==> ShowMenuBarByDefault
Sorry for the possible trouble of "resetting" caused by this commit,
but it does not pay off to write extra code dealing with such rename in
master branch
2012-03-13 13:40:16 +08:00
Kurt Hindenburg
e471ba72ec -Wshadow fixes to variable names 2012-03-05 11:23:27 -05:00
Jekyll Wu
9f52714558 Application should not know about anying about ViewManager
The changes are basically adding a few small helper methods into
MainWindow to hide the existense of ViewManager to Application.
2012-02-27 02:28:37 +08:00
Jekyll Wu
7ccbfac499 Move the code for creating tab/session from Application into MainWindow
This is the first step toward to making ViewManager hidden to Application.
2012-02-27 01:09:36 +08:00
Jekyll Wu
e958267ef4 Trivial modification of code style 2012-02-26 21:55:29 +08:00
Jekyll Wu
ff88a65ccd Move some code into MainWindow and make it internal stuff
That MainWindow uses ProfileList is an internal implementation detail.
The Higher lever Application does not need to know about it.
2012-02-25 16:02:49 +08:00
Jekyll Wu
2af5c3b921 Another unneeded #include 2012-02-23 06:41:27 +08:00
Jekyll Wu
f42fd4721b Clean up unneeded #includes 2012-02-20 19:41:38 +08:00
Yuri Chornoivan
fea58cc6bf Pluralize message for translation into the languages with more than 2 plural forms. 2012-02-19 10:37:19 +02:00
Jekyll Wu
4fb4da4c75 Add global option for showing window title on titlebar
When the window title from current session is emtpy, fallback to using
tab title.

CCBUG: 162326
REVIEW: 103978
2012-02-19 15:23:48 +08:00
Kurt Hindenburg
34759f1ef1 Mention the # of open tabs in close dialog
Thanks to Vishesh Handa for patch.  I changed it slightly.

REVIEW: 104002
FIXED-IN: 2.9
2012-02-18 15:38:37 -05:00
Jekyll Wu
3f64589b7e Less unneeded #includes 2012-02-17 06:23:22 +08:00
Jekyll Wu
1e888799df Remove unnecessary calling for setAutoSaveSettings() in constructor
In current code, that method will be effectively called each time a new
session is created. That makes calling setAutoSaveSettings() in the
constructor of MainWindow basically meaningless.
2012-02-12 18:14:48 +08:00
Jekyll Wu
2301ab5b81 Rearrange the 'File' menu
* Rename "Quit" to "Close Window" for accuracy
  * Move "Close Tab" downwards to be adjacent to "Close Window"

REVIEW:103920
2012-02-12 00:46:44 +08:00
Jekyll Wu
56acddac93 Add 'Clone Tab' action for cloning current tab
This action will create new tab/session using the same settings(command,
colors, etc) used in current tab/session.

At this moment, this action does not always clone current tab/session
100%. For example, If you change the scrollback setting of current
session temporarily through context menu or dbus method, this action
won't clone the temporary change. Another example is the tab title.

On the other hand, this action works quite well with command line
options(-e, -p, etc) and the 'konsoleprofile' utility.

FEATURE:254976
FEATURE:292518
FIXED-IN:4.9.0

REVIEW:103859

DIGEST:
2012-02-11 02:38:42 +08:00
Jekyll Wu
39a857b037 Rename for clarity 2012-02-08 03:07:44 +08:00
Jekyll Wu
117a3b297c Trivial changes with comment and code style 2012-02-08 02:50:34 +08:00
Jekyll Wu
ce7b593ec8 Minor fix with comments 2012-02-04 14:47:26 +08:00
Jekyll Wu
ba84ff30fa Get rid of _defaultProfile from class MainWindow
REVIEW:103819
2012-02-04 00:58:51 +08:00
Jekyll Wu
5450060f6f 'New Tab' and 'New Window' should always use the default profile
REVIEW: 103809
2012-01-29 07:33:53 +08:00
Kurt Hindenburg
3309e5b122 Open close query when logging out with >1 sessions running.
This causes the close query dialog to be display when exiting Konsole
and logging off the system.

Ideally we should be looking on what's running, not the # of sessions.

FEATURE: 127194
FIXED-IN: 4.9
2012-01-28 08:15:36 -10:00
Jekyll Wu
f942ce8065 Update comment to follow up the change of code 2012-01-22 21:43:49 +08:00
Jekyll Wu
9b20b22360 Move the TODO comment to a more appropriate place 2012-01-22 19:24:15 +08:00
Jekyll Wu
df0d8b96d4 Change the icon of the 'General' page in global settings 2012-01-22 10:21:45 +08:00
Jekyll Wu
fb22325528 Rename for clarity :
AppSettings.kcfgc ==> KonsoleSettings.kfgc
class AppSettings ==> class KonsoleSettings
2012-01-22 10:21:44 +08:00
Jekyll Wu
56f3805ac1 Move options influencing tabbar from profiles into global setting 2012-01-22 10:21:44 +08:00
Jekyll Wu
ed16320579 Enable or disable menu accelerators at realtime 2012-01-22 10:21:44 +08:00
Jekyll Wu
b6590f8fb1 Attempt to allow user to choose whether disabling menu accelerators 2012-01-22 10:21:29 +08:00
Jekyll Wu
e3e960ab95 Move the 'show menubar' option from profiles into global settings 2012-01-22 10:21:29 +08:00
Jekyll Wu
3524588a2e Prepare for adding functionality code 2012-01-22 10:21:29 +08:00
Jekyll Wu
67fcfd4c29 add page for tabbar settings 2012-01-22 10:21:29 +08:00
Jekyll Wu
1726ec83f0 start point of global settings 2012-01-22 10:21:29 +08:00
Jekyll Wu
3d8da1f878 Make 'foreach(...)' more readable 2012-01-14 22:54:56 +08:00
Jekyll Wu
e8718d5293 Remove unnecesary #include and add small constness 2012-01-14 18:57:31 +08:00
Kurt Hindenburg
c11c22a7b4 Apply astyle-kdelibs
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-24 10:47:48 -05:00
Jekyll Wu
b95f9443a0 Trivial change on #include 2011-11-16 13:31:24 +08:00
Jekyll Wu
125e2c7bd2 Declare pointer and reference in a consistent way
Most code use the "const QString& text" form, instead of the "const
QString &text" form. So change the minority to be consistent with
the majority.
2011-11-06 06:13:28 +08:00
Jekyll Wu
330de6c6f4 Fix some spelling problems 2011-11-06 03:41:20 +08:00
Jekyll Wu
02377dabf5 Minor change on layout and whitespace 2011-11-02 10:22:42 +08:00
Jekyll Wu
1cbe3c3104 Minor change on names
- rename "activate_menu" to "activiate-menu"
  - use the "action" local variable consistently
2011-10-26 08:33:30 +08:00
Kurt Hindenburg
fd0d6e5bb6 Minor spelling fixes. 2011-10-17 06:35:27 -09:00
Jekyll Wu
105043b75c Shift+Tab should not cause implicit focus switching in stand-alone konsole
This allows passing Shift+Tab to the terminal process when split view is in
use and the shortcut of "Next View Container" action is set as "None".

BUG: 244514
FIXED-IN:4.8
REVIEW:102834
2011-10-16 11:47:23 +08:00
Jekyll Wu
e3a09c9c4d Close session reliably when the session process doesn't die with SIGHUP.
BUG:241709
BUG:251566
CCBUG:254600
FIXED-IN: 4.8
REVIEW:102239
2011-10-03 12:40:04 +08:00
Jekyll Wu
0165f45402 Rename 'Configure Profiles...' into 'Manage Profiles...'
The makes the action consistent with the opened ManageProfilesDialog.
2011-10-01 14:08:45 +08:00
Jekyll Wu
b5dc6891a8 The initial visibility of menubar should be determined by profile option.
BUG: 186561
FIXED-IN: 4.8
REVIEW: 102502
2011-09-25 06:01:47 +08:00
Kurt Hindenburg
127c2b523e Don't show the default profile in list when no others are listed.
When user selects only 1 profile to be listed in menu, it makes the
'New Tab->' list unnecessary.  No profile will listed if the only
selected profile is the default one.

Patch by Francesco Cecconi <francesco.cecconi@gmail.com>

BUG: 245478
REVIEW: 102670
FIXED-IN: 4.8
2011-09-24 16:17:45 -04:00