This reverts commit f96deb39aa.
This was anti-optimization.
QStringLiteral is a QString created at build time. Initialization of
QString with it has no overhead.
QLatin1String is 8 bit C string wrapper which needs run-time conversion
to 16 bit encoding used in QString.
This commit breaks sessionProfileCommandReceived
causing crashes in programs such as nvim.
I'm reverting it for now while I can't dig deeper.
This reverts commit 99f233b9a1.
Summary:
There's no point in returning null if we have a default
and we would check for null and query for the default
in all cases that we used it.
Export the private header ColorScheme
It's going to be used from Parts and App
Add ColorScheme() to the Profile
The profile used to hold the ColorScheme name, but if you
want to query for the ColorScheme you had to call ViewManager
but there's a class ColorSchemeManager that ViewManager used to call
Just make things simple:
- Profile has a colorScheme that it queries from the ColorSchemeManager
- Use profile->colorScheme() when you wanna something from the
colorScheme at the profile.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D13854
Summary:
schemes are supplied by `Konsole Color Scheme` category on store.kde.org
https://store.kde.org/p/1216368/
- new manager helpers to unload a theme and check a file's name validity
- new Get New.. button to start the KNS download dialog
- upon KNS completion we'll attempt to load all installed files as schemes
- for KNS entities which failed to load anything we'll show a warning as
the theme is malformed
- for removal we'll first try to remove schemes through KNS to avoid its
registry going out of sync with the on-disk "installedness" of an entity
- properly disable copying of the scheme manager (needs to be private)
FEATURE: 18.04.0
CHANGELOG: Support for downloading color schemes from the KDE store
Test Plan:
category is T8053 (can also use `KDE Color Scheme KDE4` for testing)
- get new -> install scheme -> close -> shows up in list
- remove from list -> get new -> not listed as installed
- install random stuff from kde color scheme category -> close ->
warning should be displayed
- install scheme -> get new -> remove scheme via dialog -> close ->
not listed as installed
Reviewers: hindenburg
Subscribers: #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D10766
This fixes some infinite loops and other issues when file names have
multiple dots in their file name.
Patch by ahmadsamir
BUG: 343071
Differential Revision: https://phabricator.kde.org/D10439
If an user has alter the system-side color schemes, Konsole saves
thoses changes in the user's local folder. This patch allows that
local user file to be deleted, thus resetting the color scheme to the
default system-wide file.
Patch by ahmadsamir
BUG: 369481
FIXED-IN: 18.04
Differential Revision: https://phabricator.kde.org/D9568
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
To build for KF5 pass the option -DQT5_BUILD=ON to CMake
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
A fix to prevent an infinite loop if user puts / in ColorScheme name;
Konsole will create a sub-folder in that case.
More code will have to go in to prevent the users from doing that.
FIXED-IN: 4.11
BUG: 315086
class KDE3ColorSchemeReader is also moved since it is supposed to an
compatibility helpr of which class ColorScheme does not need to know,
and eventualy it should be removed
