When user switches focus (even using mouse) between tabs/windows
of konsole, ibus will trigger inputMethodEvent(). Most of the time
commitString() will be empty. Do not emit keyPressedSignal in such case,
otherwise konsole will scroll active view to bottom. See bug #236733.
The side effect is when inputmethod is activated, the active view
will not scroll to bottom on keystroke until user has committed
some string.
BUG: 236733
REVIEW: 102238
FIXED-IN : 4.8
This is a temporary revert. Previous commit did not take split view
into account and puts new tab in weird order when used in split view.
A improved version will be commit shortly after.
This reverts commit 676df0c26e.
The original method is splitted into applyProfileToView() which applies
view-specific settings to TerminalDisplay, and applyProfileToContainer()
which applies container-specific settings to ViewContainer.
This comes as preparation for fixing bug #207213.
REVIEW: 102321
Restore KDE3 popup menu when any file is dropped into Konsole.
The popup menu allows to Copy, Move or Link the file into the current
working directory or to simply paste its URL as text (the latter being
the current behaviour in KDE4).
For non-local files, the URL is pasted as text.
Note that this adds a konq dependency - KonqOperations:doDrop
Patch by Frank Roscher
FEATURE: 160583
FIXED-IN: 4.8
REVIEW: 4600
This is to avoid the confusion users might have: "Why can't I delete
the 'Shell' profile when the UI implies I can ?". Users tend to think
konsole is broken in that situation.
Current implementation follows a stupid logic:
1). When multiple profiles are selecte, always enable the delete button.
2). When single profile is selected, disable it if user has no
permission to delete that profile.
The old code will cause problem if the loaded profile does not specify
its parent explicitly. That loaded profile will have current default
profile as its parent, which means its behavior changes if another
profile is set as the default profile . A good example is the 'Shell'
profile.
The new code initially sets fallback profile as parent, which guarantees
the behavior of 'Shell' profile is stable.
BUG: 279863
Whenever TeminalDisplay is resized, konsole tells the underlying
pty device its new size by calling Pty::setWindowSize(). However,
current code can't guarantee when the terminal process starts and
queries the pty device about its size, the pty device already has the
right info. This has caused some long known bugs, such as #176902.
This patch tries to guarantee that important assumption. It currently
uses a hard-coded small delay, which works pretty well in practice
although not that elegant.
Patch by Jekyll Wu <adaptee@gmail.com>
I think this is better than leaving the situation as it is. This may
be backported if no issues are found.
BUG: 173999
BUG: 176902
BUG: 203185
BUG: 229058
REVIEW: 102061
FIXED-IN: 4.8
The shortcut of jumping to top of history is for the request of #45950
The shortcut of jumping to bottom of history is added not only for
consistency, but also to be used for #38390, especially its comment #9
and #10.
Patch by Jekyll Wu <adaptee@gmail.com>
FEATURE: 38390
FEATURE: 45950
FIXED-IN: 4.8
REVIEW: 102124
Re-add the KDE 3 option to show/hide the size widget when the window is
changed.
Patch is years old from Chali Ahmul M.P.U <chali.ahmul@atlas.cz>
FEATURE: 169054
FIXED-IN: 4.8
%d will shorten the directory name whereas %D will not. For some
users, having %d as the default is confusing as they don't understand
why some directories are not displaying correctly in the tab text.
Currently there is no UI to examine or change which folder names will be
shorten.
CCBUG: 190281
--nofork is under --help-kde which is often overlooked by users.
Placing a comment under --help should cause less problems for users.
CCBUG: 217357
CCBUG: 262169
CCBUG: 173697
This will allow the user to better understand what the format strings
refer to.
Patch by Jekyll Wu <adaptee@gmail.com>
FEATURE: 228130
FIXED-IN: 2.8
REVIEW: 102141
Currently, when users use ctrl+mouse to select and copy multiple lines,
those lines are joined into single line in a seamless way. LINEBREAK is
simply removed, thus the first character of second line will be
positioned right after the last character of the first line. This patch
replaces the LINEBREAK with a SPACE.
Thanks to Jekyll Wu (adaptee@gmail.com) for patch and research.
BUG: 136730
FIXED-IN: 4.8
The non-zero notification was being displayed for zero exit codes.
Thanks again to Jekyll Wu (adaptee@gmail.com) for patch and research.
BUG: 221726
FIXED-IN: 2.8
Keep track of any changes to the Profile and only enable the Apply
button when something has really changed.
Patch by Jekyll Wu adaptee@gmail.com
Might backport to 4.7 if there are no concerns.
BUG: 274501
FIXED-IN: 4.8
REVIEW: 101904
