This patch allows the dnd menu to be disabled, making it possible to
drag and drop URLs as text by default.
Thanks to Peter Wu peter lekensteyn nl for patch
REVIEW: 124908
BUG: 304290
Move code responsible for 'forgetting' a view outside of code responding to the
TerminalDisplay deletion.
This avoids a loop like this:
~MainWindow
=> ~QStackedWidget
=> ~TerminalDisplay
=> QObject::destroyed
=> ViewContainer::viewDestroyed
=> ViewContainer::removeViewWidget
- internal cleanup
- try to remove TerminalDisplay from QStackedWidget which is being deleted and
crash
Instead the code now does:
~MainWindow
=> ~QStackedWidget
=> ~TerminalDisplay
=> QObject::destroyed
=> ViewContainer::viewDestroyed
=> ViewContainer::forgetView (does the internal clean up)
And if one tries to explicitly remove a view, sequence is:
ViewContainer::removeView
=> ViewContainer::forgetView
=> ViewContainer::removeViewWidget
The patch also removes ViewManager::focusActiveView() because it causes a crash
when closing a TerminalDisplay as it tries to put the focus on the deleted
TerminalDisplay. I initially called it through a queued connection, but realized
it is actually not needed for focus to be passed to the correct view, so just
removed it.
BUG: 331724
REVIEW: 118839
New feature in 2.13 allows columns/rows in profiles; however, the
rows would be incorrect depending on if tabbar was visible. Ideally,
this should not be needed but I would guess this won't get fixed
correctly until frameworks timeframe.
This calculation can still be wrong if ShowNavigationAsNeeded and
perhaps other times depending on height of tabbar.
FIXED: 2.13
(cherry picked from commit 73e1db3e3b)
With the recent new code, profiles can have the terminal col/rows.
Everyone will notice that the rows won't match what Konsole uses.
(cherry picked from commit 90691643fb)
This removes the profile setting to 'Save window size upon exit'. Now
it is in the Konsole settings; each profile can now set desired column
and row size.
Konsole Settings->Configure Konsole->General->Use current window size
on next startup:
Enabled - ignores all profile size settings - uses previous window size
Disabled - profile size settings are used - set via Edit Current
Profile 1st tab
Only new windows will use "new" col/row/size settings.
BUG: 152385
REVIEW: 115628
FIXED-IN: 2.13
(cherry picked from commit 931d64df81)
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
To build for KF5 pass the option -DQT5_BUILD=ON to CMake
TerminalDisplayAccessible is disabled for Qt5 currently since I don't
have any experience with accessible stuff and it is more complicated
than just changing a few includes
REVIEW: 111937
Instead of keeping track of constants and +1 -1, use a QRect to handle
the terminal margins. There is no GUI for this currently and the
margins are hard-coded to what they are now. Code to center the
terminal is also include (w/o GUI).
This patch comes from review 109891 w/ a few changes from me.
Thanks to Mariusz Glebocki mglb@arccos-1.net
The built-in behavior of Ctrl+<Mouse Wheel> to zoom in/out the terminal
can not be disabled. This patch adds an option to disable this
behavior. (Default to the original behavior).
Original patch by Yichao Yu yyc1992@gmail.com
I made some changes - bugs are mine as usual
REVIEW: 107281
FIXED-IN: 4.11
GUI:
In the ongoing issue with spaces at the end of lines, this allows for
an option to trim the spaces. By default, it is disabled so only
people who need this will be affected.
Many thanks to David Smid <david@smidovi.eu>
CCBUG: 188528
So if someone notices later some Qt header is included in the form
of "#include <Class>" instead of the more common form of "#include
<Module/Class>", do not rush changing it.
REVIEW: 105819
This provides a profile GUI to change the line spacing (0-5). Due to
the Qt4.8/BIDI issues, allowing the user to change the spacing allows
the user to fix any issues w/ the font they are using.
FEATURE: 279490
REVIEW: 105478
FIXED-IN: 4.10
This adds a GUI checkbox per profile to enable/disable requiring the
CTRL key to drag-n-drop text.
The default is to require the CTRL key as before.
Thanks to Scott Kitterman (kde@kitterman.com) for patch.
BUG: 165923
REVIEW: 105423
FIXED-IN: 4.10
Since the menubar and tarbar settings are now global instead of per
profile , those cmdline options are useful to allow users to override
the defautl behavior.
The --hide-menubar and --hide-tabbar options can be used together
to simulate the miminal interface of xterm. I'm not sure whether
--show-menubar and --show-tabbar will be widely used , but add them at
the moment for the sake of completeness.
* support "automatially copy selected text into clipboard"
* mouse middle button can be customized to paste from selectio or
clipboard
The first feature might look like a unnecessary duplicate of the
"synchronize selection and clipboard" feature of Klipper. However, that
klipper feature is generally problematic, while doing it only in Konsole
is generally useful and harmless.
FEATURE: 183490
FIXED-IN: 4.9.0
REVIEW: 103861
DIGEST:
There is a submenu in the context menu for searching selected text using
any of the enabled search provider and opening the result in the default
web browser.
This could be useful for searching compilation failure messages, warning
messages in logfile, etc.
DIGEST:
FEATURE:
FIXED-IN: 4.9.0
REVIEW: 104493
Unfortunately, that commit makes all tabs in the restored Konsole window
show fallback tab until you switch to it.
Cleearly, the way when and how to start a session is messy.
Note: reverting does means calling session->run() explicitly is the
OK way.
This reverts commit c6bb999066.
The old code always set the hardcoded 80x40 size.
Two profile options are added under the "General" group:
* TerminalColumns
* terminalRows
Note: Due to the way KMainWindow works, those profile options may not
work :(. Do not take this commit as something completed.
