Commit Graph

122 Commits

Author SHA1 Message Date
Kurt Hindenburg
ffc8294806 Comment out background-mode shortcut ATM doesn't work 2014-02-07 09:31:30 -05:00
Kurt Hindenburg
cdfe235784 Restore --background-mode
For now restore this option that was removed for 2.11.  This option
is somewhat a hack and abnormal feature.  However, it seems a number
of people use it and I can see how it would be useful.  So instead of
spending a lot of time right now trying to correct the issues, just
restore the previous code.
Ideally for KDE 5, this portion of the code can be better handled.

35bb9cf9e7

BUG: 320783
FIXED-IN: 2.13#
(cherry picked from commit cfbfb0fd8c)

Conflicts:
	src/Application.cpp
2014-02-07 09:00:51 -05:00
Kurt Hindenburg
1ea501da62 remove include moc from .cpp files - removes build warnings 2013-10-22 20:07:23 -04:00
Kurt Hindenburg
cb4ca01e8b Add a --fallback-profile which uses the internal basic profile
If an user had only one profile and accidently puts a non-interactive
program (eg pwd) in the Command section it will start, run command and
then close.
The FALLBACK/ profile is the internal basic profile.

REVIEW: 109558
FIXED-IN: 4.11
2013-04-06 13:41:35 -04:00
Kurt Hindenburg
b5dbf6b32f minor space/tab fixes 2013-03-16 12:36:05 -04:00
Kurt Hindenburg
35bb9cf9e7 Remove the the immature --background-mode option
See http://lists.kde.org/?l=konsole-devel&m=135316608321148&w=2 for
details.

FIXED-IN: 4.11
BUG: 310433
2013-02-24 12:27:54 -05:00
Kurt Hindenburg
8241682b8b Add --fullscreen command line option
Add option to go into full screen mode via command line.

FEATURE: 312378
REVIEW: 109042
FIXED-IN: 4.11
2013-02-21 08:31:36 -05:00
Kurt Hindenburg
7a2a5beb00 Correct spelling errors/word usage
All these are in the comments - no code changes
2013-01-09 22:07:11 -05:00
Jekyll Wu
4d194b20c0 Revert the support for konsole -e "command arguemnts"
Although that looks like a nice feature, it makes the code more
complicated and causes problems when that command is an absolute path
containing spaces.

So for now the only supported way is:

   konsole -e command arguments

CCBUG: 295648

This reverts commit aa75fc8fee
2012-11-01 13:35:17 +08:00
Kurt Hindenburg
bee9aa8f78 minor style fixes - remove empty lines start/end code blocks 2012-05-13 10:08:05 -04:00
Jekyll Wu
3ddc6496b6 Add cmdline options for the visibility of menubar and tabbar
Since the menubar and tarbar settings are now global instead of per
profile , those cmdline options are useful to allow users to override
the defautl behavior.

The --hide-menubar and --hide-tabbar options can be used together
to simulate the miminal interface of xterm. I'm not sure whether
--show-menubar and --show-tabbar will be widely used , but add them at
the moment for the sake of completeness.
2012-05-13 03:06:14 +08:00
Jekyll Wu
63b489443c No need to check for Qt version higher than 4.6
It is safe to assume Qt-4.6+ everywhere now. And kdelibs now requires Qt-4.7
as minimal version .
2012-05-11 15:50:53 +08:00
Jekyll Wu
5a92546d24 Allow the format used by --tabs-from-file to define working directory 2012-04-09 09:03:36 +08:00
Kurt Hindenburg
5b083640ce whitespace and style fixes
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
2012-04-05 11:08:53 -04:00
Jekyll Wu
d51fe86819 QList<String> ==> QStringList 2012-04-05 04:32:02 +08:00
Jekyll Wu
193777e21a Split class SessionManager into ProfileMananger and SessionManager
REVIEW: 104425
2012-03-30 01:23:28 +08:00
Kurt Hindenburg
ea3458de92 /s/streams/printf/ for --list-profiles and --list-profile-properties
For these 2 usages, use printf instead of streams
2012-03-19 22:23:06 -04:00
Kurt Hindenburg
e0862c603a Style fixes - separte commands - remove 2 ; - align { elses 2012-03-18 15:57:48 -04:00
Kurt Hindenburg
519e2614d6 Style fixes - remove spaces before ; and add spaces in for loops 2012-03-18 15:11:06 -04:00
Jekyll Wu
aa75fc8fee konsole -e 'man ls' should work as expected
BUG: 295648
FIXED-IN: 4.9.0
2012-03-10 13:22:14 +08:00
Kurt Hindenburg
137ddd9b1e -Wshadow fixes to variable names 2012-03-05 11:31:40 -05:00
Jekyll Wu
9f52714558 Application should not know about anying about ViewManager
The changes are basically adding a few small helper methods into
MainWindow to hide the existense of ViewManager to Application.
2012-02-27 02:28:37 +08:00
Jekyll Wu
7cdd8129f1 Move code around for better organization 2012-02-27 01:19:54 +08:00
Jekyll Wu
7ccbfac499 Move the code for creating tab/session from Application into MainWindow
This is the first step toward to making ViewManager hidden to Application.
2012-02-27 01:09:36 +08:00
Jekyll Wu
b400690c5d Make WindowSystemInfo::HAVE_TRANSPARENCY const and initialize implicitly
This avoids the explicit assignment in Application and Part. The result
might look a little strange, but that is basicaly what the old code does
and what that variable intends to be (all capitalized letter)
2012-02-25 21:47:29 +08:00
Jekyll Wu
ef62a0002b Move TerminalDisplay::HAVE_TRANSPARNCEY into its own dedicated class
TerminalDisplay.h is a big header. It is not good for several files to
include that big header only in order to use one of its static member.
2012-02-25 21:10:09 +08:00
Jekyll Wu
ff88a65ccd Move some code into MainWindow and make it internal stuff
That MainWindow uses ProfileList is an internal implementation detail.
The Higher lever Application does not need to know about it.
2012-02-25 16:02:49 +08:00
Jekyll Wu
cc1142c59d Prepare the whole command before sending it by calling Session::sendText()
That reduces the number of calling, and also make the code easier to
debug if something goes wrong with the command

TODO: there is code duplication between class Application and class
SessionController on how to compose and send ssh command based upon a
KUrl using the ssh:// protocol.
2012-02-23 07:37:07 +08:00
Jekyll Wu
31798bb122 upate TerminalDisplay::HAVE_TRANSPARENCY directly
It does not make mush sense to update that public & static member
by calling another method, and such change is effectively needed
only once.
2012-02-18 07:08:19 +08:00
Jekyll Wu
b0206a7713 Remove unneeded #include 2012-02-18 03:50:05 +08:00
Jekyll Wu
f810b3bf3b update the inline document for the --tabs-from-profile option 2012-02-09 04:06:03 +08:00
Jekyll Wu
07cddfe302 Create dbus object for each Konsole window respectively
Its naming scheme is "/Windows/N", similar to "/Sessions/N" for
sessions. That is not the final decision and might change before next
major release.

The old "/Konsole" dbus object is still available at this moment, but
it might disappear or be used for something different in the future, so
it is better to use "/Windows/N" from now on.

For convenience, $KONSOLE_DBUS_WINDOW can be used to refer to the dbus
object corresponding to the Konsole window containing current session.
Note, that environment variable does not work well with detaching and
draging. Maybe it should not be added at all.

CCBUG:276912
CCBUG:281513
CCBUG:292309

REVIEW:103790
2012-02-09 01:50:43 +08:00
Jekyll Wu
39a857b037 Rename for clarity 2012-02-08 03:07:44 +08:00
Jekyll Wu
8012d47170 Make --tabs-from-file support command arguements containing ':'
A simple example:

title: vim ;; command: vim file:///path/to/file.txt
2012-02-07 20:39:33 +08:00
Jekyll Wu
2a4795c509 Fix typo of BKO number in comment 2012-02-07 06:17:47 +08:00
Jekyll Wu
60449c95c1 Ensure tab title is displayed when using --tabs-from-file option 2012-02-07 06:09:11 +08:00
Jekyll Wu
0dc3ba1c26 Add support for 'profile' field for the --tabs-from-file option 2012-02-07 03:03:32 +08:00
Jekyll Wu
b57cccd5a1 Revert "Manual resizing is only needs to be checked and performed once"
Well, I was stupid :(

This reverts commit a66098d9b3.
2012-02-06 23:53:26 +08:00
Jekyll Wu
fec744bfed Make sure empty lines are really ignored 2012-02-06 23:38:31 +08:00
Jekyll Wu
a66098d9b3 Manual resizing is only needs to be checked and performed once 2012-02-06 23:38:27 +08:00
Jekyll Wu
fcd8d7e57d Use customized tab title only when explicitly requested by users 2012-02-06 22:54:44 +08:00
Jekyll Wu
02b72b7f8e Prefer foreach over manual loop 2012-02-06 18:10:26 +08:00
Jekyll Wu
09940ed95f Suppress the warning for unused variable 2012-02-05 01:06:37 +08:00
Jekyll Wu
14bcc3366f Use NewProfile only when needed
This fixes the problme of empty profile name when invoking konsole in
the simplest way.

This is a follow-up of commit ba84ff30fa
2012-02-05 01:06:26 +08:00
Jekyll Wu
588aa92a21 A little more constness 2012-02-04 15:48:12 +08:00
Jekyll Wu
4156806b73 Make the definition of static member outstanding 2012-02-04 15:32:51 +08:00
Jekyll Wu
837ab5a664 Revert the boolean logic to make the code more natural 2012-02-04 15:30:13 +08:00
Jekyll Wu
28741c9153 Deal with option "-e" in a more profile-oriented way
Since "New Tab" always use default profile now, we can deal with that
option in a more elegant way, instead of a hack.

This basically revert commit 35fae00159
2012-02-04 01:10:44 +08:00
Jekyll Wu
ba84ff30fa Get rid of _defaultProfile from class MainWindow
REVIEW:103819
2012-02-04 00:58:51 +08:00
Jekyll Wu
6b6a5944f6 Prefer foreach(...) over while(...) for simplicity and readability 2012-01-22 10:21:45 +08:00