133 Commits

Author SHA1 Message Date
Kurt Hindenburg
205a51839c Disable detaching when on Darwin (MacOSX)
Too many issues/crashes for too long when detaching on MacOSX.  You
can still some strange things but I can't get it to crash now.
2013-08-15 22:26:59 -04:00
Francesco Cecconi
194a852d33 Prevent the dragging of the last tab in a split view.
BUG: 210871
REVIEW: 107640
FIXED-IN: 4.12
2013-08-15 23:14:17 +02:00
Kurt Hindenburg
7a2a5beb00 Correct spelling errors/word usage
All these are in the comments - no code changes
2013-01-09 22:07:11 -05:00
Kurt Hindenburg
21a8b063a7 astyle format fixes - whitespace and { 2012-09-03 14:15:47 -04:00
Jekyll Wu
131091c983 Adjust including form for some Qt headers as preparation for Qt5
So if someone notices later some Qt header is included in the form
of "#include <Class>" instead of the more common form of "#include
<Module/Class>", do not rush changing it.

REVIEW: 105819
2012-08-14 17:32:06 +08:00
Kurt Hindenburg
e02fea6e17 astyle fixes
use git diff -w --ignore-all-space to see non-space changes
2012-08-05 13:35:03 -04:00
Kurt Hindenburg
d7f55a2079 remove space 2012-06-17 19:09:11 -04:00
Jekyll Wu
6c41493db0 Make sure the 'New' and 'Close' buttons never get keyboard focus
This is mostly extra safeguard, since they alreayd do not get keyboard focus
in the current code.
2012-06-03 07:46:41 +08:00
Jekyll Wu
627a511daa Move the code for submenu of 'New Tab' button into class ViewContainer
This might feel like slight de-optimization of current code. However, it
helps abstracting and refactoring the code for the future.
2012-05-24 05:03:58 +08:00
Jekyll Wu
4a38fc1d9d Move class ViewContainerTabbar into its own files 2012-05-23 00:52:07 +08:00
Jekyll Wu
ef43864923 The tabbar code does not directly depend on TabbedViewContainer anymore 2012-05-22 23:09:24 +08:00
Jekyll Wu
d040c1c722 Remove another hard dependency on TabbedViewContainer in the tabbar code 2012-05-22 22:23:03 +08:00
Jekyll Wu
ab96666965 Stop using hardcoded ViewProperties::mimeType() within tabbar code 2012-05-22 21:23:14 +08:00
Jekyll Wu
73d7da6d87 Make ViewContainerTabBar and TabbedViewContainer less coupled
In general, those two classes are coupled too closely. Ideally,
TabbedViewContainer should be transformed into a generic enhanced tabbar
which knows nothing about TabbedViewContainer or its user.
2012-05-22 20:43:57 +08:00
Jekyll Wu
daa99b67fd Dragging tab onto its existing position should not make it detach
This is a follow up of commit b8b8ef74, which adds the support of
dragging tab out of current window and into its own window.
2012-05-22 20:32:07 +08:00
Jekyll Wu
5c7e39368c More constness 2012-05-22 17:06:36 +08:00
Jekyll Wu
eec927bd88 Add "What's this" for the tabbar and new/close buttons
There could be more, but I thik they are the most important ones.

BUG: 257914
FIXED-IN: 4.9.0
2012-05-15 03:48:06 +08:00
Jekyll Wu
b8b8ef7405 Support dragging tab out of current window and into its own window
Thanks to makis marimpis<makhsm@gmail.com> for the patch!

REVIEW: 104933
FEATURE: 56749
FIXED-IN: 4.9.0
2012-05-14 15:16:50 +08:00
Kurt Hindenburg
bee9aa8f78 minor style fixes - remove empty lines start/end code blocks 2012-05-13 10:08:05 -04:00
Jekyll Wu
cf24bea6ab Add one global option for customizing the stylesheet of the tabbar
Note: this is just an experimental idea, so no GUI is added. It might
rename or disappear later.
2012-05-08 21:37:40 +08:00
Kurt Hindenburg
ba34c4ebe2 normalize SIGNALS
It is annoying that kdelibs-style and Qt normalize conflict
2012-04-06 08:57:47 -04:00
Kurt Hindenburg
5b083640ce whitespace and style fixes
Use 'git diff -w --ignore-all-space' to see non-whitespace changes
2012-04-05 11:08:53 -04:00
Jekyll Wu
c81b292c91 Krazy fix: QTabBar => KTabBar 2012-04-04 02:21:04 +08:00
Jekyll Wu
ee26801157 Refactor the code for setting up the layout of the tabbed ViewContainer
The refactor is simple and stupid. The important thing is reducing
duplicated logic
2012-04-02 19:47:49 +08:00
Jekyll Wu
22ac363c2d More constness 2012-03-21 01:56:05 +08:00
Kurt Hindenburg
519e2614d6 Style fixes - remove spaces before ; and add spaces in for loops 2012-03-18 15:11:06 -04:00
Jekyll Wu
663e342aa8 Krazy fix: add the missing KUIT context marker 2012-03-18 22:57:32 +08:00
Jekyll Wu
5ebbba6efb Rename for clarity and consitency 2012-03-16 20:21:39 +08:00
Jekyll Wu
3bf91d969e Remove unused #include 2012-03-16 01:36:50 +08:00
Jekyll Wu
b379b9e155 Simple refactor of method TabbedViewContainer::openTabContextMenu() 2012-03-12 17:49:38 +08:00
Jekyll Wu
ef9599d792 Add separator between 'Raname' and 'Close' in the context menu of tabbar 2012-03-12 16:29:32 +08:00
Kurt Hindenburg
c272fb2c15 Remove krazy lines 2012-03-08 23:16:44 -05:00
Jekyll Wu
f4fb943132 Most of time we only need <KLocalizedString> instead of <KLocale> 2012-03-07 06:48:26 +08:00
Jekyll Wu
1db211ef0c Add tooltip for the quick buttons on the tabbar
Well, maybe this is more helpful than annoying for Konsole users.
2012-02-21 20:05:23 +08:00
Jekyll Wu
c6826ebdc3 Forward declaration 2012-02-20 20:11:25 +08:00
Jekyll Wu
f42fd4721b Clean up unneeded #includes 2012-02-20 19:41:38 +08:00
Jekyll Wu
bd4a77ed0b Move codes setting basic property of tabbar into its constructor 2012-02-20 04:39:32 +08:00
Jekyll Wu
bebb3ad895 Remove unneeded interal class TabbedViewContainerLayout
That internal class was used to workaround the problem that
QBoxLayout::insertItem() is a protected method. Since the current codo
does not use that method any more, no need to keep and use that internal
class anymore. Just use QVboxLayout directly.
2012-02-20 02:57:40 +08:00
Jekyll Wu
1f796f8358 Remove/Comment out currently unused #includes 2012-02-19 06:08:43 +08:00
Jekyll Wu
a93a2670bf Add missing "#include <KIcon>" 2012-02-19 06:03:43 +08:00
Jekyll Wu
af325e2942 Add missing icon for the 'Rename Tab...' action in context menu 2012-02-11 17:56:15 +08:00
Jekyll Wu
6b6a5944f6 Prefer foreach(...) over while(...) for simplicity and readability 2012-01-22 10:21:45 +08:00
Kurt Hindenburg
1baa56feda White space changes - astyle and Qt normalize don't like each other.
Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-25 13:13:55 -05:00
Kurt Hindenburg
f8ed7666c3 Apply astyle-kdelibs
Over the years, the coding style is all over the place.

Use 'git diff -w --ignore-all-space' to see non-whitespace changes.
2011-12-24 11:40:38 -05:00
Kurt Hindenburg
bc087ae51b Remove unused KDebug includes 2011-12-18 00:01:32 -05:00
Jekyll Wu
b95f9443a0 Trivial change on #include 2011-11-16 13:31:24 +08:00
Jekyll Wu
e9e729074b Remove unnecessary '#include <QtGUI/QLineEdit' 2011-11-14 03:42:09 +08:00
Jekyll Wu
125e2c7bd2 Declare pointer and reference in a consistent way
Most code use the "const QString& text" form, instead of the "const
QString &text" form. So change the minority to be consistent with
the majority.
2011-11-06 06:13:28 +08:00
Jekyll Wu
cf92cece2b Remove leading white spaces in blank lines to make them really empty 2011-11-05 07:29:21 +08:00
Jekyll Wu
8c6e41c607 Refactor the visibility change of new & close buttons into an separate method. 2011-09-27 09:59:42 +08:00