From 0661f65703fd0dfdd1f367a3e369a9e876ca6798 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julio=20L=C3=B3pez?= <1953782+julio-lopez@users.noreply.github.com> Date: Mon, 6 Apr 2026 21:38:59 -0700 Subject: [PATCH] chore(cli): handle potential conversion overflow when setting progress default (#5271) --- cli/cli_progress.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cli/cli_progress.go b/cli/cli_progress.go index 3b4d689c1..02a1d5170 100644 --- a/cli/cli_progress.go +++ b/cli/cli_progress.go @@ -31,9 +31,10 @@ type progressFlags struct { } func (p *progressFlags) setup(svc appServices, app *kingpin.Application) { - progressDefault := "true" - if !term.IsTerminal(int(os.Stdout.Fd())) { - progressDefault = "false" + progressDefault := "false" + + if fd, err := intFd(os.Stdout); err == nil && term.IsTerminal(fd) { + progressDefault = "true" } app.Flag("progress", "Enable progress output").Default(progressDefault).BoolVar(&p.enableProgress)