From a9ad321f60d7a9444a6ddc45bbcbbde9da70040b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julio=20L=C3=B3pez?= <1953782+julio-lopez@users.noreply.github.com> Date: Tue, 10 Feb 2026 22:49:46 -0800 Subject: [PATCH] test(providers): notify after releasing the lock (#5154) Following the recommended pattern with the expectation of reducing potential deadlocks in future changes. --- repo/blob/filesystem/filesystem_storage_sync_test.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/repo/blob/filesystem/filesystem_storage_sync_test.go b/repo/blob/filesystem/filesystem_storage_sync_test.go index 548f657fc..ba907b733 100644 --- a/repo/blob/filesystem/filesystem_storage_sync_test.go +++ b/repo/blob/filesystem/filesystem_storage_sync_test.go @@ -48,12 +48,14 @@ func (vf *verifySyncBeforeCloseFile) Sync() error { } func (vf *verifySyncBeforeCloseFile) Close() error { - vf.mu.Lock() - defer vf.mu.Unlock() + dirty, err := func() (bool, error) { + vf.mu.Lock() + defer vf.mu.Unlock() - err := vf.osWriteFile.Close() + return vf.dirty, vf.osWriteFile.Close() + }() - if vf.dirty { + if dirty { vf.notifyDirtyClose() }