From fa24dfc7054fd3d7de7e00db4013351812a266e1 Mon Sep 17 00:00:00 2001 From: Julio Lopez <1953782+julio-lopez@users.noreply.github.com> Date: Sat, 2 Dec 2023 17:34:00 -0800 Subject: [PATCH] chore(general): cleanup nits (#3481) - rename variable - clarify comment --- repo/blob/azure/azure_storage.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/repo/blob/azure/azure_storage.go b/repo/blob/azure/azure_storage.go index 732ed503b..55464bd91 100644 --- a/repo/blob/azure/azure_storage.go +++ b/repo/blob/azure/azure_storage.go @@ -137,17 +137,17 @@ func (az *azStorage) PutBlob(ctx context.Context, b blob.ID, data blob.Bytes, op return errors.Wrap(blob.ErrUnsupportedPutBlobOption, "do-not-recreate") } - hardcodedOpts := blob.PutOptions{ + o := blob.PutOptions{ RetentionPeriod: opts.RetentionPeriod, SetModTime: opts.SetModTime, GetModTime: opts.GetModTime, } if opts.HasRetentionOptions() { - hardcodedOpts.RetentionMode = blob.Locked // override Compliance/Governance to be Locked for Azure + o.RetentionMode = blob.Locked // override Compliance/Governance to be Locked for Azure } - _, err := az.putBlob(ctx, b, data, hardcodedOpts) + _, err := az.putBlob(ctx, b, data, o) return err } @@ -280,7 +280,7 @@ func (az *azStorage) putBlob(ctx context.Context, b blob.ID, data blob.Bytes, op } if opts.HasRetentionOptions() { - // kopia delete marker blob can be Unlocked rather than Compliance + // kopia delete marker blob must be "Unlocked", thus it cannot be overridden to "Locked" here. mode := azblobblob.ImmutabilityPolicySetting(opts.RetentionMode) retainUntilDate := clock.Now().Add(opts.RetentionPeriod).UTC() uo.ImmutabilityPolicyMode = &mode