- use struct field initialization idiom
- clarify error message
- directly use s.rootctx in server request processing
- refactor: use require in e2e ACL test
- inline constant definition
- modernize with `strings.Cut`
- modernize with slices.Backward
- simplify timeFormat initialization
- refactor testing: check `Scanner.Err()` in testenv
- remove spurious parenthesis
- trueStr and falseStr consts
- use inheritPolicyString
- use const in cache info
- "bytes" const in ui task counters
- use common consts in gettool
Minor improvements:
Refactor the construction of a test string with many control characters in `TestJSONWriter_StringEscapingPerformanceWithManyControlChars` by using a `strings.Builder`.
Rationale: address a future `modernize` linter warning. While this is also "more" efficient, it does not make any practical difference in this context.
Simplify the conversion of a short flag to a string in `emitFlags` by removing an unnecessary byte slice conversion (`tools/cli2md/cli2md.go`).
Rationale: simplify the expression for clarity and address a future linter warning.
- Ref: #5247
- upgrade to golangci-lint 2.6.1
- updates for gosec
- updates for govet
- updates for perfsprint
- updates modernize
Leaves out modernize:omitempty due to conflicts with tests
* fix(site): escape flags with backticks
In the generated markdown docs, flags like `--foo` inside
help texts currently get pretty-printed as `–foo` with an em-dash.
This change applies backticks via a regex replacement, so that
they appear as `--foo` in the docs but remain as --foo in the
CLI output.
---------
Co-authored-by: Julio Lopez <1953782+julio-lopez@users.noreply.github.com>
* chore(ci): upgraded linter to 1.53.3
This flagged a bunch of unused parameters, so the PR is larger than
usual, but 99% mechanical.
* separate lint CI task
* run Lint in separate CI
* chore(site): upgraded site to latest hugo and removed vendored files
This switches to using github.com/google/docsy as a Hugo module,
so we don't need to vendor the theme anymore or its dependencies.
* layout
* more style, edit MD support
* style
* style
* fixed linter errors
* update text
Julio López