mirror of
https://github.com/kopia/kopia.git
synced 2026-03-01 12:58:30 -05:00
26e6f59b2b
* kopia format upgrade lock * Update cli/command_repository_set_parameters_test.go Co-authored-by: Ali Dowair <adowair@umich.edu> * Update cli/command_repository_upgrade.go Co-authored-by: Ali Dowair <adowair@umich.edu> * Update cli/command_repository_upgrade.go Co-authored-by: Ali Dowair <adowair@umich.edu> * pr feedback * pr feedback * add a min drain time check * env var for io-drain-timeout * fix: add more doctext around upgrade phases * build: wrap with EnvName * add experimental warning * protect upgrade cli behind env varible * fix conflicts after relocating the upgrade lock * generalize the command args * drop certain features as per feedback * sub-divide the upgrade command into begin and rollback * Update cli/command_repository_upgrade.go Co-authored-by: Julio Lopez <1953782+julio-lopez@users.noreply.github.com> * Update cli/command_repository_upgrade.go Co-authored-by: Julio Lopez <1953782+julio-lopez@users.noreply.github.com> * missing return * rename force flag to allow-unsafe-upgrade Co-authored-by: Shikhar Mall <shikhar@kasten.io> Co-authored-by: Ali Dowair <adowair@umich.edu> Co-authored-by: Shikhar Mall <small@kopia.io> Co-authored-by: Julio Lopez <1953782+julio-lopez@users.noreply.github.com>
186 lines
7.8 KiB
Go
186 lines
7.8 KiB
Go
package cli_test
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/kopia/kopia/cli"
|
|
"github.com/kopia/kopia/internal/blobtesting"
|
|
"github.com/kopia/kopia/internal/repotesting"
|
|
"github.com/kopia/kopia/repo/blob"
|
|
"github.com/kopia/kopia/repo/content"
|
|
"github.com/kopia/kopia/tests/testenv"
|
|
)
|
|
|
|
func (s *formatSpecificTestSuite) setupInMemoryRepo(t *testing.T) *testenv.CLITest {
|
|
t.Helper()
|
|
|
|
runner := testenv.NewInProcRunner(t)
|
|
env := testenv.NewCLITest(t, s.formatFlags, runner)
|
|
st := repotesting.NewReconnectableStorage(t, blobtesting.NewVersionedMapStorage(nil))
|
|
|
|
env.RunAndExpectSuccess(t, "repo", "create", "in-memory", "--uuid",
|
|
st.ConnectionInfo().Config.(*repotesting.ReconnectableStorageOptions).UUID)
|
|
|
|
return env
|
|
}
|
|
|
|
func (s *formatSpecificTestSuite) TestRepositorySetParameters(t *testing.T) {
|
|
env := s.setupInMemoryRepo(t)
|
|
out := env.RunAndExpectSuccess(t, "repository", "status")
|
|
|
|
// default values
|
|
require.Contains(t, out, "Max pack length: 20 MiB")
|
|
require.Contains(t, out, fmt.Sprintf("Format version: %d", s.formatVersion))
|
|
|
|
// failure cases
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters")
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters", "--index-version=33")
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters", "--max-pack-size-mb=9")
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters", "--max-pack-size-mb=121")
|
|
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--index-version=2", "--max-pack-size-mb=33")
|
|
out = env.RunAndExpectSuccess(t, "repository", "status")
|
|
require.Contains(t, out, "Max pack length: 33 MiB")
|
|
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--max-pack-size-mb=44")
|
|
out = env.RunAndExpectSuccess(t, "repository", "status")
|
|
require.Contains(t, out, "Max pack length: 44 MiB")
|
|
}
|
|
|
|
func (s *formatSpecificTestSuite) TestRepositorySetParametersRetention(t *testing.T) {
|
|
env := s.setupInMemoryRepo(t)
|
|
|
|
// set retention
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--retention-mode", blob.Compliance.String(),
|
|
"--retention-period", "24h")
|
|
|
|
out := env.RunAndExpectSuccess(t, "repository", "status")
|
|
require.Contains(t, out, "Blob retention mode: COMPLIANCE")
|
|
require.Contains(t, out, "Blob retention period: 24h0m0s")
|
|
|
|
// update retention
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--retention-mode", blob.Governance.String(),
|
|
"--retention-period", "24h1m")
|
|
|
|
out = env.RunAndExpectSuccess(t, "repository", "status")
|
|
require.Contains(t, out, "Blob retention mode: GOVERNANCE")
|
|
require.Contains(t, out, "Blob retention period: 24h1m0s")
|
|
|
|
// clear retention settings
|
|
_, out = env.RunAndExpectSuccessWithErrOut(t, "repository", "set-parameters", "--retention-mode", "none")
|
|
require.Contains(t, out, "disabling blob retention")
|
|
|
|
out = env.RunAndExpectSuccess(t, "repository", "status")
|
|
require.NotContains(t, out, "Blob retention mode")
|
|
require.NotContains(t, out, "Blob retention period")
|
|
|
|
// invalid retention settings
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters", "--retention-mode", "invalid-mode")
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters", "--retention-mode", "COMPLIANCE", "--retention-period", "0h")
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters", "--retention-mode", "COMPLIANCE", "--retention-period", "6h") // less than 24hr
|
|
|
|
// set retention again after clear
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--retention-mode", "COMPLIANCE", "--retention-period", "24h")
|
|
out = env.RunAndExpectSuccess(t, "repository", "status")
|
|
require.Contains(t, out, "Blob retention mode: COMPLIANCE")
|
|
require.Contains(t, out, "Blob retention period: 24h0m0s")
|
|
|
|
// update without period
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--retention-period", "25h")
|
|
out = env.RunAndExpectSuccess(t, "repository", "status")
|
|
require.Contains(t, out, "Blob retention mode: COMPLIANCE")
|
|
require.Contains(t, out, "Blob retention period: 25h0m0s")
|
|
|
|
// update without mode
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--retention-mode", "GOVERNANCE")
|
|
out = env.RunAndExpectSuccess(t, "repository", "status")
|
|
require.Contains(t, out, "Blob retention mode: GOVERNANCE")
|
|
require.Contains(t, out, "Blob retention period: 25h0m0s")
|
|
|
|
// update retention (use days, weeks, nanoseconds)
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--retention-mode", blob.Compliance.String(),
|
|
"--retention-period", "1w2d6h3ns")
|
|
|
|
out = env.RunAndExpectSuccess(t, "repository", "status")
|
|
require.Contains(t, out, "Blob retention mode: COMPLIANCE")
|
|
require.Contains(t, out, "Blob retention period: 222h0m0.000000003s")
|
|
|
|
// update retention (use days)
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--retention-mode", blob.Compliance.String(),
|
|
"--retention-period", "7d")
|
|
|
|
out = env.RunAndExpectSuccess(t, "repository", "status")
|
|
require.Contains(t, out, "Blob retention mode: COMPLIANCE")
|
|
require.Contains(t, out, "Blob retention period: 168h0m0s")
|
|
}
|
|
|
|
func (s *formatSpecificTestSuite) TestRepositorySetParametersUpgrade(t *testing.T) {
|
|
env := s.setupInMemoryRepo(t)
|
|
out := env.RunAndExpectSuccess(t, "repository", "status")
|
|
|
|
// default values
|
|
require.Contains(t, out, "Max pack length: 20 MiB")
|
|
|
|
switch s.formatVersion {
|
|
case content.FormatVersion1:
|
|
require.Contains(t, out, "Format version: 1")
|
|
require.Contains(t, out, "Epoch Manager: disabled")
|
|
env.RunAndExpectFailure(t, "index", "epoch", "list")
|
|
case content.FormatVersion2:
|
|
require.Contains(t, out, "Format version: 2")
|
|
require.Contains(t, out, "Epoch Manager: enabled")
|
|
env.RunAndExpectSuccess(t, "index", "epoch", "list")
|
|
default:
|
|
require.Contains(t, out, "Format version: 3")
|
|
require.Contains(t, out, "Epoch Manager: enabled")
|
|
env.RunAndExpectSuccess(t, "index", "epoch", "list")
|
|
}
|
|
|
|
env.Environment["KOPIA_UPGRADE_LOCK_ENABLED"] = "1"
|
|
|
|
{
|
|
cmd := []string{
|
|
"repository", "upgrade",
|
|
"--upgrade-owner-id", "owner",
|
|
"--io-drain-timeout", "1s", "--allow-unsafe-upgrade",
|
|
"--status-poll-interval", "1s",
|
|
}
|
|
|
|
cli.MaxPermittedClockDrift = func() time.Duration { return time.Second }
|
|
|
|
// You can only upgrade when you are not already upgraded
|
|
if s.formatVersion < content.MaxFormatVersion {
|
|
env.RunAndExpectSuccess(t, cmd...)
|
|
} else {
|
|
env.RunAndExpectFailure(t, cmd...)
|
|
}
|
|
}
|
|
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--upgrade")
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--epoch-min-duration", "3h")
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--epoch-cleanup-safety-margin", "23h")
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--epoch-advance-on-size-mb", "77")
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--epoch-advance-on-count", "22")
|
|
env.RunAndExpectSuccess(t, "repository", "set-parameters", "--epoch-checkpoint-frequency", "9")
|
|
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters", "--epoch-min-duration", "1s")
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters", "--epoch-refresh-frequency", "10h")
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters", "--epoch-checkpoint-frequency", "-10")
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters", "--epoch-cleanup-safety-margin", "10s")
|
|
env.RunAndExpectFailure(t, "repository", "set-parameters", "--epoch-advance-on-count", "1")
|
|
|
|
out = env.RunAndExpectSuccess(t, "repository", "status")
|
|
require.Contains(t, out, "Epoch Manager: enabled")
|
|
require.Contains(t, out, "Index Format: v2")
|
|
require.Contains(t, out, "Format version: 3")
|
|
require.Contains(t, out, "Epoch cleanup margin: 23h0m0s")
|
|
require.Contains(t, out, "Epoch advance on: 22 blobs or 77 MiB, minimum 3h0m0s")
|
|
require.Contains(t, out, "Epoch checkpoint every: 9 epochs")
|
|
|
|
env.RunAndExpectSuccess(t, "index", "epoch", "list")
|
|
}
|