mirror of
https://github.com/kopia/kopia.git
synced 2026-01-02 19:47:51 -05:00
9bf9cac7fb
* refactor(repository): ensure we always parse content.ID and object.ID
This changes the types to be incompatible with string to prevent direct
conversion to and from string.
This has the additional benefit of reducing number of memory allocations
and bytes for all IDs.
content.ID went from 2 allocations to 1:
typical case 32 characters + 16 bytes per-string overhead
worst-case 65 characters + 16 bytes per-string overhead
now: 34 bytes
object.ID went from 2 allocations to 1:
typical case 32 characters + 16 bytes per-string overhead
worst-case 65 characters + 16 bytes per-string overhead
now: 36 bytes
* move index.{ID,IDRange} methods to separate files
* replaced index.IDFromHash with content.IDFromHash externally
* minor tweaks and additional tests
* Update repo/content/index/id_test.go
Co-authored-by: Julio Lopez <1953782+julio-lopez@users.noreply.github.com>
* Update repo/content/index/id_test.go
Co-authored-by: Julio Lopez <1953782+julio-lopez@users.noreply.github.com>
* pr feedback
* post-merge fixes
* pr feedback
* pr feedback
* fixed subtle regression in sortedContents()
This was actually not producing invalid results because of how base36
works, just not sorting as efficiently as it could.
Co-authored-by: Julio Lopez <1953782+julio-lopez@users.noreply.github.com>
41 lines
870 B
Go
41 lines
870 B
Go
package cli
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/pkg/errors"
|
|
|
|
"github.com/kopia/kopia/repo"
|
|
)
|
|
|
|
type commandContentDelete struct {
|
|
ids []string
|
|
|
|
svc appServices
|
|
}
|
|
|
|
func (c *commandContentDelete) setup(svc appServices, parent commandParent) {
|
|
cmd := parent.Command("delete", "Remove content").Alias("remove").Alias("rm")
|
|
cmd.Arg("id", "IDs of content to remove").Required().StringsVar(&c.ids)
|
|
cmd.Action(svc.directRepositoryWriteAction(c.run))
|
|
|
|
c.svc = svc
|
|
}
|
|
|
|
func (c *commandContentDelete) run(ctx context.Context, rep repo.DirectRepositoryWriter) error {
|
|
c.svc.advancedCommand(ctx)
|
|
|
|
contentIDs, err := toContentIDs(c.ids)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
for _, contentID := range contentIDs {
|
|
if err := rep.ContentManager().DeleteContent(ctx, contentID); err != nil {
|
|
return errors.Wrapf(err, "error deleting content %v", contentID)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|