Files
kopia/cli/command_repository_upgrade_test.go
Aaron Alpar 02ecd0d5a7 feat(repository): Allow clock drift to be specified on upgrade. (#2357)
* add max-clock-drift flag

* fixups

* module dependencies

* package fixup
2022-09-26 18:28:56 -07:00

148 lines
6.0 KiB
Go

package cli_test
import (
"testing"
"time"
"github.com/stretchr/testify/require"
"github.com/kopia/kopia/repo/format"
"github.com/kopia/kopia/tests/testenv"
)
func (s *formatSpecificTestSuite) TestRepositoryUpgrade(t *testing.T) {
env := testenv.NewCLITest(t, s.formatFlags, testenv.NewInProcRunner(t))
env.RunAndExpectSuccess(t, "repo", "create", "filesystem", "--path", env.RepoDir)
out := env.RunAndExpectSuccess(t, "repository", "status", "--upgrade-no-block")
env.Environment["KOPIA_UPGRADE_LOCK_ENABLED"] = "1"
switch s.formatVersion {
case format.FormatVersion1:
require.Contains(t, out, "Format version: 1")
_, stderr := env.RunAndExpectSuccessWithErrOut(t, "repository", "upgrade",
"--upgrade-owner-id", "owner",
"--io-drain-timeout", "1s", "--allow-unsafe-upgrade",
"--status-poll-interval", "1s",
"--max-permitted-clock-drift", "1s")
require.Contains(t, stderr, "Repository indices have been upgraded.")
require.Contains(t, stderr, "Repository has been successfully upgraded.")
case format.FormatVersion2:
require.Contains(t, out, "Format version: 2")
_, stderr := env.RunAndExpectSuccessWithErrOut(t, "repository", "upgrade",
"--upgrade-owner-id", "owner",
"--io-drain-timeout", "1s", "--allow-unsafe-upgrade",
"--status-poll-interval", "1s",
"--max-permitted-clock-drift", "1s")
require.Contains(t, stderr, "Repository indices have already been migrated to the epoch format, no need to drain other clients")
require.Contains(t, stderr, "Repository has been successfully upgraded.")
default:
require.Contains(t, out, "Format version: 3")
env.RunAndExpectFailure(t, "repository", "upgrade",
"--upgrade-owner-id", "owner",
"--io-drain-timeout", "1s", "--allow-unsafe-upgrade",
"--status-poll-interval", "1s",
"--max-permitted-clock-drift", "1s")
}
out = env.RunAndExpectSuccess(t, "repository", "status", "--upgrade-no-block")
require.Contains(t, out, "Epoch Manager: enabled")
require.Contains(t, out, "Index Format: v2")
require.Contains(t, out, "Format version: 3")
}
func lockRepositoryForUpgrade(t *testing.T, env *testenv.CLITest) {
t.Helper()
t.Log("Placing upgrade lock ...")
env.RunAndExpectSuccess(t, "repository", "upgrade",
"--upgrade-owner-id", "owner",
"--io-drain-timeout", "30s", "--allow-unsafe-upgrade",
"--status-poll-interval", "1s", "--lock-only",
"--max-permitted-clock-drift", "1s")
}
func (s *formatSpecificTestSuite) TestRepositoryUpgradeStatusWhileLocked(t *testing.T) {
env := testenv.NewCLITest(t, s.formatFlags, testenv.NewInProcRunner(t))
env.RunAndExpectSuccess(t, "repo", "create", "filesystem", "--path", env.RepoDir)
out := env.RunAndExpectSuccess(t, "repository", "status", "--upgrade-no-block")
env.Environment["KOPIA_UPGRADE_LOCK_ENABLED"] = "1"
switch s.formatVersion {
case format.FormatVersion1:
require.Contains(t, out, "Format version: 1")
lockRepositoryForUpgrade(t, env)
// verify that non-owner clients will fail to connect/upgrade
env.RunAndExpectFailure(t, "repository", "upgrade",
"--upgrade-owner-id", "non-owner",
"--io-drain-timeout", "15s", "--allow-unsafe-upgrade",
"--status-poll-interval", "1s", "--upgrade-no-block",
"--max-permitted-clock-drift", "1s")
// until we drain, we would be able to see the upgrade status as
// "Draining"
out = env.RunAndExpectSuccess(t, "repository", "status", "--upgrade-no-block", "--upgrade-owner-id", "owner")
require.Contains(t, out, "Ongoing upgrade: Upgrading from format version 1 -> 3")
require.Contains(t, out, "Upgrade lock: Locked")
require.Contains(t, out, "Lock status: Draining")
// attempt to rollback the upgrade and restart
env.RunAndExpectSuccess(t, "repository", "upgrade", "rollback", "--force", "--upgrade-owner-id", "owner")
lockRepositoryForUpgrade(t, env)
// drain all clients
t.Log("Waiting to drain all clients ...")
// drain time [30 (io-drain-timeout) * 2 + 1(max clock drift)] + buffer [1 sec]
time.Sleep(62 * time.Second)
// verify that access is denied after we drain
env.RunAndExpectFailure(t, "repository", "status", "--upgrade-no-block")
// verify that owner clients can check status
out = env.RunAndExpectSuccess(t, "repository", "status", "--upgrade-owner-id", "owner")
require.Contains(t, out, "Ongoing upgrade: Upgrading from format version 1 -> 3")
require.Contains(t, out, "Upgrade lock: Locked")
require.Contains(t, out, "Lock status: Fully Established")
// finalize the upgrade
_, stderr := env.RunAndExpectSuccessWithErrOut(t, "repository", "upgrade",
"--upgrade-owner-id", "owner",
"--io-drain-timeout", "15s", "--allow-unsafe-upgrade",
"--status-poll-interval", "1s",
"--max-permitted-clock-drift", "1s")
require.Contains(t, stderr, "Repository has been successfully upgraded.")
// verify that non-owner clients can resume access
env.RunAndExpectSuccess(t, "repository", "status", "--upgrade-no-block")
case format.FormatVersion2:
require.Contains(t, out, "Format version: 2")
// perform the upgrade
_, stderr := env.RunAndExpectSuccessWithErrOut(t, "repository", "upgrade",
"--upgrade-owner-id", "owner",
"--io-drain-timeout", "1s", "--allow-unsafe-upgrade",
"--status-poll-interval", "1s",
"--max-permitted-clock-drift", "1s")
require.Contains(t, stderr, "Repository has been successfully upgraded.")
// verify that non-owner clients can resume access
env.RunAndExpectSuccess(t, "repository", "status", "--upgrade-no-block")
default:
require.Contains(t, out, "Format version: 3")
env.RunAndExpectFailure(t, "repository", "upgrade",
"--upgrade-owner-id", "owner",
"--io-drain-timeout", "1s", "--allow-unsafe-upgrade",
"--status-poll-interval", "1s",
"--max-permitted-clock-drift", "1s")
}
out = env.RunAndExpectSuccess(t, "repository", "status", "--upgrade-no-block")
require.Contains(t, out, "Epoch Manager: enabled")
require.Contains(t, out, "Index Format: v2")
require.Contains(t, out, "Format version: 3")
}