From 19d9bc36c8cbc939a1a5dc7e12d5ccfbe8b44f1b Mon Sep 17 00:00:00 2001 From: pippotadde Date: Tue, 23 Dec 2025 14:23:03 +0100 Subject: [PATCH] Frontend: guard empty search input --- static/skin/viewer.js | 1 + test/server.cpp | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/static/skin/viewer.js b/static/skin/viewer.js index d8c87686..fde3cdb1 100644 --- a/static/skin/viewer.js +++ b/static/skin/viewer.js @@ -83,6 +83,7 @@ function quasiUriEncode(s, specialSymbols) { function performSearch() { const searchbox = document.getElementById('kiwixsearchbox'); + if (!searchbox.value.trim()) { return;} const q = encodeURIComponent(searchbox.value); gotoUrl(`/search?books.name=${currentBook}&pattern=${q}&userlang=${viewerState.uiLanguage}`); } diff --git a/test/server.cpp b/test/server.cpp index 8e77c102..db5e582d 100644 --- a/test/server.cpp +++ b/test/server.cpp @@ -77,7 +77,7 @@ const ResourceCollection resources200Compressible{ { DYNAMIC_CONTENT, "/ROOT%23%3F/skin/taskbar.css" }, { STATIC_CONTENT, "/ROOT%23%3F/skin/taskbar.css?cacheid=42e90cb9" }, { DYNAMIC_CONTENT, "/ROOT%23%3F/skin/viewer.js" }, - { STATIC_CONTENT, "/ROOT%23%3F/skin/viewer.js?cacheid=00e0fdf3" }, + { STATIC_CONTENT, "/ROOT%23%3F/skin/viewer.js?cacheid=6192cae1" }, { DYNAMIC_CONTENT, "/ROOT%23%3F/skin/fonts/Poppins.ttf" }, { STATIC_CONTENT, "/ROOT%23%3F/skin/fonts/Poppins.ttf?cacheid=af705837" }, { DYNAMIC_CONTENT, "/ROOT%23%3F/skin/fonts/Roboto.ttf" }, @@ -338,7 +338,7 @@ R"EXPECTEDRESULT( - + const blankPageUrl = root + "/skin/blank.html?cacheid=6b1fa032";