mirror/libkiwix
1
0 Fork 0
mirror of https://github.com/kiwix/libkiwix.git synced 2026-10-11 04:17:28 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixed deadlock in Library::writeBookmarksToFile()

Browse Source
This commit is contained in:
Veloman Yunkan committed 2021-12-05 20:31:21 +04:00
1 parent fa8d0f8e07
commit e1db9164c8
2 files changed
+3 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/library.cpp
+2 -5
View File
@@ -274,11 +274,8 @@ bool Library::writeToFile(const std::string& path) const
bool Library::writeBookmarksToFile(const std::string& path) const
{
LibXMLDumper dumper(this);
std::string xml;
{
std::lock_guard<std::mutex> lock(m_mutex);
xml = dumper.dumpLibXMLBookmark();
};
// NOTE: LibXMLDumper::dumpLibXMLBookmark uses Library in a thread-safe way
const std::string xml = dumper.dumpLibXMLBookmark();
return writeTextFile(path, xml);
}