From 28ec71f91a37844012a2f2f84729419c73426f3b Mon Sep 17 00:00:00 2001 From: Levin Oehlmann Date: Sun, 26 Jun 2022 08:48:24 +0200 Subject: [PATCH] clang-tidy: Apply modernize-use-equals-default everywhere (#6450) --- include/AudioAlsa.h | 2 +- include/AudioDeviceSetupWidget.h | 2 +- include/AudioDummy.h | 4 +--- include/AudioEngineProfiler.h | 2 +- include/AudioSdl.h | 2 +- include/AudioSndio.h | 2 +- include/AudioSoundIo.h | 2 +- include/AutomatableSlider.h | 2 +- include/AutomationClipView.h | 2 +- include/AutomationEditor.h | 2 +- include/BandLimitedWave.h | 4 ++-- include/BasicFilters.h | 6 +++--- include/CPULoadWidget.h | 2 +- include/CaptionMenu.h | 2 +- include/ColorChooser.h | 2 +- include/ComboBox.h | 2 +- include/ControllerDialog.h | 2 +- include/ControllerRackView.h | 2 +- include/Controls.h | 10 ++++----- include/DataFile.h | 2 +- include/DetuningHelper.h | 4 +--- include/DrumSynth.h | 2 +- include/DummyEffect.h | 8 ++----- include/DummyInstrument.h | 4 +--- include/DummyPlugin.h | 4 +--- include/Editor.h | 2 +- include/EffectControlDialog.h | 2 +- include/EffectControls.h | 4 +--- include/EnvelopeAndLfoParameters.h | 8 ++----- include/ExportFilter.h | 2 +- include/FadeButton.h | 2 +- include/ImportFilter.h | 2 +- include/InstrumentFunctions.h | 4 ++-- include/InstrumentMidiIOView.h | 2 +- include/InstrumentPlayHandle.h | 4 +--- include/InstrumentSoundShaping.h | 2 +- include/InstrumentView.h | 2 +- include/Ladspa2LMMS.h | 2 +- include/LadspaControl.h | 2 +- include/LadspaControlView.h | 2 +- include/LinkedModelGroupViews.h | 2 +- include/LinkedModelGroups.h | 2 +- include/LmmsPalette.h | 2 +- include/LmmsStyle.h | 4 +--- include/LocklessAllocator.h | 4 +--- include/LocklessRingBuffer.h | 2 +- include/Lv2Ports.h | 6 +++--- include/Lv2ViewBase.h | 2 +- include/MeterDialog.h | 2 +- include/MeterModel.h | 4 ++-- include/MicroTimer.h | 2 +- include/MidiClient.h | 6 +++--- include/MidiController.h | 2 +- include/MidiDummy.h | 8 ++----- include/MidiEvent.h | 11 +--------- include/MidiEventProcessor.h | 8 ++----- include/MidiPortMenu.h | 2 +- include/Mixer.h | 2 +- include/MixerLineLcdSpinBox.h | 2 +- include/Model.h | 4 +--- include/ModelVisitor.h | 4 ++-- include/PatternEditor.h | 2 +- include/PatternStore.h | 2 +- include/PeakController.h | 2 +- include/PianoRoll.h | 2 +- include/PixmapButton.h | 2 +- include/Plugin.h | 6 ++---- include/PluginFactory.h | 2 +- include/ProjectJournal.h | 2 +- include/ProjectNotes.h | 2 +- include/ProjectRenderer.h | 2 +- include/RemotePluginBase.h | 6 +----- include/RenameDialog.h | 2 +- include/Rubberband.h | 6 ++---- include/SampleTrackWindow.h | 2 +- include/SideBar.h | 2 +- include/SideBarWidget.h | 2 +- include/SongEditor.h | 2 +- include/SweepOscillator.h | 4 +--- include/TabButton.h | 4 +--- include/TempoSyncKnobModel.h | 2 +- include/TextFloat.h | 4 +--- include/ToolPlugin.h | 2 +- include/TrackContainerView.h | 2 +- include/TrackContentWidget.h | 2 +- include/TrackLabelButton.h | 2 +- include/TrackOperationsWidget.h | 2 +- include/TrackView.h | 2 +- include/ValueBuffer.h | 2 +- include/embed.h | 4 +--- include/shared_object.h | 4 +--- plugins/Amplifier/Amplifier.cpp | 3 --- plugins/Amplifier/Amplifier.h | 2 +- plugins/Amplifier/AmplifierControlDialog.h | 4 +--- plugins/Amplifier/AmplifierControls.h | 4 +--- .../AudioFileProcessor/AudioFileProcessor.cpp | 3 --- .../AudioFileProcessor/AudioFileProcessor.h | 2 +- plugins/BassBooster/BassBooster.cpp | 3 --- plugins/BassBooster/BassBooster.h | 2 +- .../BassBooster/BassBoosterControlDialog.h | 4 +--- plugins/BassBooster/BassBoosterControls.h | 4 +--- plugins/BitInvader/BitInvader.cpp | 4 ---- plugins/BitInvader/BitInvader.h | 4 ++-- plugins/Bitcrush/BitcrushControlDialog.h | 4 +--- plugins/Bitcrush/BitcrushControls.cpp | 3 --- plugins/Bitcrush/BitcrushControls.h | 2 +- plugins/Compressor/Compressor.cpp | 5 ----- plugins/Compressor/Compressor.h | 2 +- .../CrossoverEQ/CrossoverEQControlDialog.h | 4 +--- plugins/CrossoverEQ/CrossoverEQControls.h | 2 +- plugins/Delay/DelayControls.h | 4 +--- plugins/Delay/DelayControlsDialog.h | 6 ++---- plugins/Delay/Lfo.h | 4 +--- plugins/DualFilter/DualFilterControlDialog.h | 4 +--- plugins/DualFilter/DualFilterControls.h | 4 +--- .../DynamicsProcessorControlDialog.h | 4 +--- .../DynamicsProcessorControls.h | 4 +--- plugins/Eq/EqControls.h | 4 +--- plugins/Eq/EqControlsDialog.h | 4 +--- plugins/Eq/EqEffect.cpp | 7 ------- plugins/Eq/EqEffect.h | 2 +- plugins/Eq/EqFader.h | 4 +--- plugins/Eq/EqSpectrumView.h | 4 +--- plugins/Flanger/FlangerControls.h | 4 +--- plugins/Flanger/FlangerControlsDialog.h | 4 +--- plugins/FreeBoy/FreeBoy.cpp | 10 --------- plugins/FreeBoy/FreeBoy.h | 4 ++-- plugins/FreeBoy/Gb_Apu_Buffer.cpp | 3 --- plugins/FreeBoy/Gb_Apu_Buffer.h | 4 ++-- plugins/GigPlayer/GigPlayer.cpp | 7 ------- plugins/GigPlayer/GigPlayer.h | 2 +- plugins/GigPlayer/PatchesDialog.cpp | 8 ------- plugins/GigPlayer/PatchesDialog.h | 2 +- plugins/HydrogenImport/HydrogenImport.cpp | 3 --- plugins/HydrogenImport/HydrogenImport.h | 2 +- plugins/Kicker/Kicker.cpp | 14 ------------- plugins/Kicker/Kicker.h | 4 ++-- plugins/Kicker/KickerOsc.h | 4 +--- plugins/LadspaBrowser/LadspaBrowser.cpp | 14 ------------- plugins/LadspaBrowser/LadspaBrowser.h | 4 ++-- plugins/LadspaBrowser/LadspaDescription.cpp | 7 ------- plugins/LadspaBrowser/LadspaDescription.h | 2 +- plugins/LadspaBrowser/LadspaPortDialog.cpp | 5 ----- plugins/LadspaBrowser/LadspaPortDialog.h | 2 +- plugins/LadspaEffect/LadspaControlDialog.cpp | 7 ------- plugins/LadspaEffect/LadspaControlDialog.h | 2 +- plugins/Lb302/Lb302.cpp | 5 ----- plugins/Lb302/Lb302.h | 4 ++-- plugins/MidiExport/MidiExport.cpp | 6 ------ plugins/MidiExport/MidiExport.h | 2 +- plugins/MidiImport/MidiImport.cpp | 7 ------- plugins/MidiImport/MidiImport.h | 2 +- plugins/MidiImport/portsmf/allegro.h | 10 ++++----- plugins/MidiImport/portsmf/allegrosmfwr.cpp | 7 +------ plugins/Monstro/Monstro.cpp | 15 ------------- plugins/Monstro/Monstro.h | 6 +++--- .../MultitapEcho/MultitapEchoControlDialog.h | 4 +--- plugins/MultitapEcho/MultitapEchoControls.cpp | 5 ----- plugins/MultitapEcho/MultitapEchoControls.h | 2 +- plugins/Nes/Nes.cpp | 15 ------------- plugins/Nes/Nes.h | 6 +++--- plugins/Organic/Organic.cpp | 7 ------- plugins/Organic/Organic.h | 6 ++---- plugins/Patman/Patman.cpp | 7 ------- plugins/Patman/Patman.h | 2 +- .../PeakControllerEffectControlDialog.h | 4 +--- .../PeakControllerEffectControls.h | 4 +--- plugins/ReverbSC/ReverbSCControlDialog.h | 4 +--- plugins/ReverbSC/ReverbSCControls.h | 4 +--- plugins/Sf2Player/PatchesDialog.cpp | 6 ------ plugins/Sf2Player/PatchesDialog.h | 2 +- plugins/Sf2Player/Sf2Player.cpp | 7 ------- plugins/Sf2Player/Sf2Player.h | 2 +- plugins/Sfxr/Sfxr.cpp | 15 ------------- plugins/Sfxr/Sfxr.h | 6 +++--- plugins/Sid/SidInstrument.cpp | 14 ------------- plugins/Sid/SidInstrument.h | 10 ++++----- plugins/SpectrumAnalyzer/SaControls.h | 2 +- plugins/SpectrumAnalyzer/SaControlsDialog.h | 2 +- plugins/SpectrumAnalyzer/SaSpectrumView.h | 2 +- plugins/SpectrumAnalyzer/SaWaterfallView.h | 2 +- .../StereoEnhancerControlDialog.h | 4 +--- .../StereoEnhancer/StereoEnhancerControls.h | 4 +--- plugins/StereoMatrix/StereoMatrix.cpp | 6 ------ plugins/StereoMatrix/StereoMatrix.h | 2 +- .../StereoMatrix/StereoMatrixControlDialog.h | 4 +--- plugins/StereoMatrix/StereoMatrixControls.h | 4 +--- plugins/Stk/Mallets/Mallets.cpp | 13 ------------ plugins/Stk/Mallets/Mallets.h | 4 ++-- plugins/TripleOscillator/TripleOscillator.cpp | 14 ------------- plugins/TripleOscillator/TripleOscillator.h | 8 +++---- plugins/Vectorscope/VecControls.h | 2 +- plugins/Vectorscope/VecControlsDialog.h | 2 +- plugins/Vectorscope/VectorView.h | 2 +- plugins/Vectorscope/Vectorscope.h | 2 +- plugins/Vestige/Vestige.cpp | 11 +--------- plugins/Vestige/Vestige.h | 2 +- plugins/Vibed/Vibed.h | 2 +- plugins/VstEffect/VstEffect.cpp | 7 ------- plugins/VstEffect/VstEffect.h | 2 +- plugins/Watsyn/Watsyn.cpp | 11 ---------- plugins/Watsyn/Watsyn.h | 4 ++-- plugins/WaveShaper/WaveShaper.cpp | 7 ------- plugins/WaveShaper/WaveShaper.h | 2 +- plugins/WaveShaper/WaveShaperControlDialog.h | 4 +--- plugins/WaveShaper/WaveShaperControls.h | 4 +--- src/common/SharedMemory.cpp | 5 ++--- src/core/AudioEngineProfiler.cpp | 5 ----- src/core/DataFile.cpp | 6 ------ src/core/ImportFilter.cpp | 6 ------ src/core/InstrumentFunctions.cpp | 9 -------- src/core/InstrumentSoundShaping.cpp | 5 ----- src/core/Ladspa2LMMS.cpp | 6 ------ src/core/LadspaControl.cpp | 7 ------- src/core/LinkedModelGroups.cpp | 5 ----- src/core/MeterModel.cpp | 9 -------- src/core/MicroTimer.cpp | 4 ---- src/core/Mixer.cpp | 5 ----- src/core/ModelVisitor.cpp | 4 ---- src/core/PatternStore.cpp | 7 ------- src/core/Plugin.cpp | 7 ------- src/core/PluginFactory.cpp | 4 ---- src/core/PresetPreviewPlayHandle.cpp | 4 +--- src/core/ProjectJournal.cpp | 7 ------- src/core/ProjectRenderer.cpp | 7 ------- src/core/TempoSyncKnobModel.cpp | 7 ------- src/core/ToolPlugin.cpp | 7 ------- src/core/ValueBuffer.cpp | 3 --- src/core/audio/AudioSdl.cpp | 7 ------- src/core/audio/AudioSndio.cpp | 6 ------ src/core/audio/AudioSoundIo.cpp | 4 ---- src/core/lv2/Lv2ControlBase.cpp | 2 +- src/core/lv2/Lv2Ports.cpp | 9 -------- src/core/lv2/Lv2Proc.cpp | 4 +--- src/core/midi/MidiClient.cpp | 21 ------------------- src/core/midi/MidiController.cpp | 7 ------- src/gui/AudioDeviceSetupWidget.cpp | 4 ---- src/gui/ControllerDialog.cpp | 6 ------ src/gui/ControllerRackView.cpp | 7 ------- src/gui/Controls.cpp | 16 -------------- src/gui/EffectControlDialog.cpp | 7 ------- src/gui/LadspaControlView.cpp | 6 ------ src/gui/LinkedModelGroupViews.cpp | 5 ----- src/gui/LmmsPalette.cpp | 4 ---- src/gui/Lv2ViewBase.cpp | 5 ----- src/gui/MixerView.cpp | 2 +- src/gui/PeakControllerDialog.cpp | 6 ------ src/gui/ProjectNotes.cpp | 7 ------- src/gui/SampleTrackWindow.cpp | 5 ----- src/gui/SideBar.cpp | 7 ------- src/gui/SideBarWidget.cpp | 7 ------- src/gui/clips/AutomationClipView.cpp | 7 ------- src/gui/editors/AutomationEditor.cpp | 5 ----- src/gui/editors/Editor.cpp | 5 ----- src/gui/editors/PatternEditor.cpp | 5 ----- src/gui/editors/PianoRoll.cpp | 5 ----- src/gui/editors/Rubberband.cpp | 7 ------- src/gui/editors/SongEditor.cpp | 4 ---- src/gui/editors/TrackContainerView.cpp | 7 ------- src/gui/instrument/InstrumentMidiIOView.cpp | 6 ------ src/gui/instrument/InstrumentView.cpp | 4 ---- src/gui/menus/MidiPortMenu.cpp | 6 ------ src/gui/modals/ControllerConnectionDialog.cpp | 4 +--- src/gui/modals/RenameDialog.cpp | 6 ------ src/gui/tracks/FadeButton.cpp | 5 ----- src/gui/tracks/TrackContentWidget.cpp | 8 ------- src/gui/tracks/TrackLabelButton.cpp | 5 ----- src/gui/tracks/TrackOperationsWidget.cpp | 7 ------- src/gui/tracks/TrackView.cpp | 6 ------ src/gui/widgets/AutomatableSlider.cpp | 4 ---- src/gui/widgets/CPULoadWidget.cpp | 4 ---- src/gui/widgets/CaptionMenu.cpp | 4 ---- src/gui/widgets/ComboBox.cpp | 4 ---- src/gui/widgets/MeterDialog.cpp | 4 ---- src/gui/widgets/PixmapButton.cpp | 4 ---- 275 files changed, 223 insertions(+), 1034 deletions(-) diff --git a/include/AudioAlsa.h b/include/AudioAlsa.h index 6bbd4aecd..7149aa320 100644 --- a/include/AudioAlsa.h +++ b/include/AudioAlsa.h @@ -54,7 +54,7 @@ public: m_deviceName(deviceName), m_deviceDescription(deviceDescription) {} - ~DeviceInfo() {} + ~DeviceInfo() = default; QString const & getDeviceName() const { return m_deviceName; } QString const & getDeviceDescription() const { return m_deviceDescription; } diff --git a/include/AudioDeviceSetupWidget.h b/include/AudioDeviceSetupWidget.h index 392cbd3a4..e984651e4 100644 --- a/include/AudioDeviceSetupWidget.h +++ b/include/AudioDeviceSetupWidget.h @@ -36,7 +36,7 @@ class AudioDeviceSetupWidget : public TabWidget public: AudioDeviceSetupWidget( const QString & _caption, QWidget * _parent ); - ~AudioDeviceSetupWidget() override; + ~AudioDeviceSetupWidget() override = default; virtual void saveSettings() = 0; diff --git a/include/AudioDummy.h b/include/AudioDummy.h index 3677bf451..30b125b3a 100644 --- a/include/AudioDummy.h +++ b/include/AudioDummy.h @@ -62,9 +62,7 @@ public: { } - ~setupWidget() override - { - } + ~setupWidget() override = default; void saveSettings() override { diff --git a/include/AudioEngineProfiler.h b/include/AudioEngineProfiler.h index 136c6dbea..38631c6a9 100644 --- a/include/AudioEngineProfiler.h +++ b/include/AudioEngineProfiler.h @@ -37,7 +37,7 @@ class AudioEngineProfiler { public: AudioEngineProfiler(); - ~AudioEngineProfiler(); + ~AudioEngineProfiler() = default; void startPeriod() { diff --git a/include/AudioSdl.h b/include/AudioSdl.h index c3b9d27d3..7e7710a2f 100644 --- a/include/AudioSdl.h +++ b/include/AudioSdl.h @@ -61,7 +61,7 @@ public: { public: setupWidget( QWidget * _parent ); - ~setupWidget() override; + ~setupWidget() override = default; void saveSettings() override; diff --git a/include/AudioSndio.h b/include/AudioSndio.h index 993a44432..b2da8eac0 100644 --- a/include/AudioSndio.h +++ b/include/AudioSndio.h @@ -63,7 +63,7 @@ public: { public: setupWidget( QWidget * _parent ); - ~setupWidget() override; + ~setupWidget() override = default; void saveSettings() override; diff --git a/include/AudioSoundIo.h b/include/AudioSoundIo.h index c85f13252..dc9afe7e4 100644 --- a/include/AudioSoundIo.h +++ b/include/AudioSoundIo.h @@ -51,7 +51,7 @@ class AudioSoundIoSetupUtil : public QObject { Q_OBJECT public: - virtual ~AudioSoundIoSetupUtil(); + virtual ~AudioSoundIoSetupUtil() = default; void *m_setupWidget; public slots: diff --git a/include/AutomatableSlider.h b/include/AutomatableSlider.h index cadaaf8db..1c74a05ad 100644 --- a/include/AutomatableSlider.h +++ b/include/AutomatableSlider.h @@ -39,7 +39,7 @@ class AutomatableSlider : public QSlider, public IntModelView Q_OBJECT public: AutomatableSlider( QWidget * _parent, const QString & _name = QString() ); - ~AutomatableSlider() override; + ~AutomatableSlider() override = default; bool showStatus() { diff --git a/include/AutomationClipView.h b/include/AutomationClipView.h index 1a2e80248..b4de7839c 100644 --- a/include/AutomationClipView.h +++ b/include/AutomationClipView.h @@ -45,7 +45,7 @@ class AutomationClipView : public ClipView public: AutomationClipView( AutomationClip * _clip, TrackView * _parent ); - ~AutomationClipView() override; + ~AutomationClipView() override = default; public slots: /// Opens this view's clip in the global automation editor diff --git a/include/AutomationEditor.h b/include/AutomationEditor.h index c710c5007..dfb983e9a 100644 --- a/include/AutomationEditor.h +++ b/include/AutomationEditor.h @@ -255,7 +255,7 @@ class AutomationEditorWindow : public Editor static const int INITIAL_HEIGHT = 480; public: AutomationEditorWindow(); - ~AutomationEditorWindow() override; + ~AutomationEditorWindow() override = default; void setCurrentClip(AutomationClip* clip); const AutomationClip* currentClip(); diff --git a/include/BandLimitedWave.h b/include/BandLimitedWave.h index 30d28d4a1..c65505327 100644 --- a/include/BandLimitedWave.h +++ b/include/BandLimitedWave.h @@ -97,8 +97,8 @@ public: NumBLWaveforms }; - BandLimitedWave() {}; - virtual ~BandLimitedWave() {}; + BandLimitedWave() = default; + virtual ~BandLimitedWave() = default; /*! \brief This method converts frequency to wavelength. The oscillate function takes wavelength as argument so * use this to convert your note frequency to wavelength before using it. diff --git a/include/BasicFilters.h b/include/BasicFilters.h index 10b5b24b7..da64c3bc5 100644 --- a/include/BasicFilters.h +++ b/include/BasicFilters.h @@ -58,7 +58,7 @@ public: m_sampleRate = sampleRate; clearHistory(); } - virtual ~LinkwitzRiley() {} + virtual ~LinkwitzRiley() = default; inline void clearHistory() { @@ -152,7 +152,7 @@ public: { clearHistory(); } - virtual ~BiQuad() {} + virtual ~BiQuad() = default; inline void setCoeffs( float a1, float a2, float b0, float b1, float b2 ) { @@ -200,7 +200,7 @@ public: m_z1[i] = 0.0; } } - virtual ~OnePole() {} + virtual ~OnePole() = default; inline void setCoeffs( float a0, float b1 ) { diff --git a/include/CPULoadWidget.h b/include/CPULoadWidget.h index 31aecb016..dd2747ef2 100644 --- a/include/CPULoadWidget.h +++ b/include/CPULoadWidget.h @@ -43,7 +43,7 @@ class CPULoadWidget : public QWidget Q_OBJECT public: CPULoadWidget( QWidget * _parent ); - ~CPULoadWidget() override; + ~CPULoadWidget() override = default; protected: diff --git a/include/CaptionMenu.h b/include/CaptionMenu.h index a3724e127..f6a2fff25 100644 --- a/include/CaptionMenu.h +++ b/include/CaptionMenu.h @@ -41,7 +41,7 @@ class LMMS_EXPORT CaptionMenu : public QMenu Q_OBJECT public: CaptionMenu( const QString & _title, QWidget * _parent = 0 ); - ~CaptionMenu() override; + ~CaptionMenu() override = default; } ; diff --git a/include/ColorChooser.h b/include/ColorChooser.h index 9b3389c47..5482a9a03 100644 --- a/include/ColorChooser.h +++ b/include/ColorChooser.h @@ -40,7 +40,7 @@ public: ColorChooser(const QColor &initial, QWidget *parent): QColorDialog(initial, parent) {}; ColorChooser(QWidget *parent): QColorDialog(parent) {}; //! For getting a color without having to initialise a color dialog - ColorChooser() {}; + ColorChooser() = default; enum class Palette {Default, Track, Mixer}; //! Set global palette via array, checking bounds void setPalette (QVector); diff --git a/include/ComboBox.h b/include/ComboBox.h index 9b51d87ab..9a0e5a517 100644 --- a/include/ComboBox.h +++ b/include/ComboBox.h @@ -40,7 +40,7 @@ class LMMS_EXPORT ComboBox : public QWidget, public IntModelView Q_OBJECT public: ComboBox( QWidget* parent = nullptr, const QString& name = QString() ); - ~ComboBox() override; + ~ComboBox() override = default; ComboBoxModel* model() { diff --git a/include/ControllerDialog.h b/include/ControllerDialog.h index 351afd66a..4f496ad77 100644 --- a/include/ControllerDialog.h +++ b/include/ControllerDialog.h @@ -44,7 +44,7 @@ class ControllerDialog : public QWidget, public ModelView public: ControllerDialog( Controller * _controller, QWidget * _parent ); - ~ControllerDialog() override; + ~ControllerDialog() override = default; signals: diff --git a/include/ControllerRackView.h b/include/ControllerRackView.h index a522071c8..904e523dd 100644 --- a/include/ControllerRackView.h +++ b/include/ControllerRackView.h @@ -53,7 +53,7 @@ class ControllerRackView : public QWidget, public SerializingObject Q_OBJECT public: ControllerRackView(); - ~ControllerRackView() override; + ~ControllerRackView() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override; void loadSettings( const QDomElement & _this ) override; diff --git a/include/Controls.h b/include/Controls.h index af2a5fa71..9ffed465e 100644 --- a/include/Controls.h +++ b/include/Controls.h @@ -66,7 +66,7 @@ public: virtual AutomatableModel* model() = 0; virtual AutomatableModelView* modelView() = 0; - virtual ~Control(); + virtual ~Control() = default; }; @@ -83,7 +83,7 @@ public: AutomatableModelView* modelView() override; KnobControl(QWidget* parent = nullptr); - ~KnobControl() override; + ~KnobControl() override = default; }; @@ -102,7 +102,7 @@ public: AutomatableModelView* modelView() override; ComboControl(QWidget* parent = nullptr); - ~ComboControl() override; + ~ComboControl() override = default; }; @@ -119,7 +119,7 @@ public: AutomatableModelView* modelView() override; LcdControl(int numDigits, QWidget* parent = nullptr); - ~LcdControl() override; + ~LcdControl() override = default; }; @@ -138,7 +138,7 @@ public: AutomatableModelView* modelView() override; CheckControl(QWidget* parent = nullptr); - ~CheckControl() override; + ~CheckControl() override = default; }; diff --git a/include/DataFile.h b/include/DataFile.h index c17b3546f..42dc2eabd 100644 --- a/include/DataFile.h +++ b/include/DataFile.h @@ -67,7 +67,7 @@ public: DataFile( const QByteArray& data ); DataFile( Type type ); - virtual ~DataFile(); + virtual ~DataFile() = default; /// /// \brief validate diff --git a/include/DetuningHelper.h b/include/DetuningHelper.h index c67ae41c6..f90af3697 100644 --- a/include/DetuningHelper.h +++ b/include/DetuningHelper.h @@ -42,9 +42,7 @@ public: { } - ~DetuningHelper() override - { - } + ~DetuningHelper() override = default; float defaultValue() const override { diff --git a/include/DrumSynth.h b/include/DrumSynth.h index 28121fc75..98574f2d2 100644 --- a/include/DrumSynth.h +++ b/include/DrumSynth.h @@ -37,7 +37,7 @@ namespace lmms class DrumSynth { public: - DrumSynth() {}; + DrumSynth() = default; int GetDSFileSamples(QString dsfile, int16_t *&wave, int channels, sample_rate_t Fs); private: diff --git a/include/DummyEffect.h b/include/DummyEffect.h index 637feaba1..675249865 100644 --- a/include/DummyEffect.h +++ b/include/DummyEffect.h @@ -60,9 +60,7 @@ public: { } - ~DummyEffectControls() override - { - } + ~DummyEffectControls() override = default; int controlCount() override { @@ -102,9 +100,7 @@ public: setName(); } - ~DummyEffect() override - { - } + ~DummyEffect() override = default; EffectControls * controls() override { diff --git a/include/DummyInstrument.h b/include/DummyInstrument.h index 7f85d83b5..a40d8338f 100644 --- a/include/DummyInstrument.h +++ b/include/DummyInstrument.h @@ -47,9 +47,7 @@ public: { } - ~DummyInstrument() override - { - } + ~DummyInstrument() override = default; void playNote( NotePlayHandle *, sampleFrame * buffer ) override { diff --git a/include/DummyPlugin.h b/include/DummyPlugin.h index fd98b831c..cf36d2159 100644 --- a/include/DummyPlugin.h +++ b/include/DummyPlugin.h @@ -41,9 +41,7 @@ public: { } - ~DummyPlugin() override - { - } + ~DummyPlugin() override = default; void saveSettings( QDomDocument &, QDomElement & ) override { diff --git a/include/Editor.h b/include/Editor.h index 60760f2b4..1a39ea72f 100644 --- a/include/Editor.h +++ b/include/Editor.h @@ -81,7 +81,7 @@ protected: /// \param record If set true, the editor's toolbar will contain record /// buttons in addition to the play and stop buttons. Editor(bool record = false, bool record_step = false); - ~Editor() override; + ~Editor() override = default; DropToolBar* m_toolBar; diff --git a/include/EffectControlDialog.h b/include/EffectControlDialog.h index 59e422264..6389db4a3 100644 --- a/include/EffectControlDialog.h +++ b/include/EffectControlDialog.h @@ -44,7 +44,7 @@ class LMMS_EXPORT EffectControlDialog : public QWidget, public ModelView Q_OBJECT public: EffectControlDialog( EffectControls * _controls ); - ~EffectControlDialog() override; + ~EffectControlDialog() override = default; virtual bool isResizable() const {return false;} diff --git a/include/EffectControls.h b/include/EffectControls.h index 95ef0039c..994145a40 100644 --- a/include/EffectControls.h +++ b/include/EffectControls.h @@ -51,9 +51,7 @@ public: { } - ~EffectControls() override - { - } + ~EffectControls() override = default; virtual int controlCount() = 0; virtual gui::EffectControlDialog * createView() = 0; diff --git a/include/EnvelopeAndLfoParameters.h b/include/EnvelopeAndLfoParameters.h index 7b630b1b0..042068cce 100644 --- a/include/EnvelopeAndLfoParameters.h +++ b/include/EnvelopeAndLfoParameters.h @@ -50,13 +50,9 @@ public: class LfoInstances { public: - LfoInstances() - { - } + LfoInstances() = default; - ~LfoInstances() - { - } + ~LfoInstances() = default; inline bool isEmpty() const { diff --git a/include/ExportFilter.h b/include/ExportFilter.h index 3aaa2f986..29efef539 100644 --- a/include/ExportFilter.h +++ b/include/ExportFilter.h @@ -40,7 +40,7 @@ class LMMS_EXPORT ExportFilter : public Plugin { public: ExportFilter( const Descriptor * _descriptor ) : Plugin( _descriptor, nullptr ) {} - ~ExportFilter() override {} + ~ExportFilter() override = default; virtual bool tryExport(const TrackContainer::TrackList &tracks, diff --git a/include/FadeButton.h b/include/FadeButton.h index b4a78d5ee..d33900913 100644 --- a/include/FadeButton.h +++ b/include/FadeButton.h @@ -44,7 +44,7 @@ public: const QColor & _hold_color, QWidget * _parent ); - ~FadeButton() override; + ~FadeButton() override = default; void setActiveColor( const QColor & activated_color ); diff --git a/include/ImportFilter.h b/include/ImportFilter.h index 9635fedb5..b7a910e5d 100644 --- a/include/ImportFilter.h +++ b/include/ImportFilter.h @@ -42,7 +42,7 @@ class LMMS_EXPORT ImportFilter : public Plugin public: ImportFilter( const QString & _file_name, const Descriptor * _descriptor ); - ~ImportFilter() override; + ~ImportFilter() override = default; // tries to import given file to given track-container by having all diff --git a/include/InstrumentFunctions.h b/include/InstrumentFunctions.h index 76e522bc5..ede54144f 100644 --- a/include/InstrumentFunctions.h +++ b/include/InstrumentFunctions.h @@ -58,7 +58,7 @@ private: public: InstrumentFunctionNoteStacking( Model * _parent ); - ~InstrumentFunctionNoteStacking() override; + ~InstrumentFunctionNoteStacking() override = default; void processNote( NotePlayHandle* n ); @@ -180,7 +180,7 @@ public: } ; InstrumentFunctionArpeggio( Model * _parent ); - ~InstrumentFunctionArpeggio() override; + ~InstrumentFunctionArpeggio() override = default; void processNote( NotePlayHandle* n ); diff --git a/include/InstrumentMidiIOView.h b/include/InstrumentMidiIOView.h index 821488390..81feee082 100644 --- a/include/InstrumentMidiIOView.h +++ b/include/InstrumentMidiIOView.h @@ -50,7 +50,7 @@ class InstrumentMidiIOView : public QWidget, public ModelView Q_OBJECT public: InstrumentMidiIOView( QWidget* parent ); - ~InstrumentMidiIOView() override; + ~InstrumentMidiIOView() override = default; private: diff --git a/include/InstrumentPlayHandle.h b/include/InstrumentPlayHandle.h index 2935d36ba..e9516ab19 100644 --- a/include/InstrumentPlayHandle.h +++ b/include/InstrumentPlayHandle.h @@ -38,9 +38,7 @@ class LMMS_EXPORT InstrumentPlayHandle : public PlayHandle public: InstrumentPlayHandle( Instrument * instrument, InstrumentTrack* instrumentTrack ); - ~InstrumentPlayHandle() override - { - } + ~InstrumentPlayHandle() override = default; void play( sampleFrame * _working_buffer ) override diff --git a/include/InstrumentSoundShaping.h b/include/InstrumentSoundShaping.h index 1df6b858b..11ed4f1c4 100644 --- a/include/InstrumentSoundShaping.h +++ b/include/InstrumentSoundShaping.h @@ -46,7 +46,7 @@ class InstrumentSoundShaping : public Model, public JournallingObject Q_OBJECT public: InstrumentSoundShaping( InstrumentTrack * _instrument_track ); - ~InstrumentSoundShaping() override; + ~InstrumentSoundShaping() override = default; void processAudioBuffer( sampleFrame * _ab, const fpp_t _frames, NotePlayHandle * _n ); diff --git a/include/InstrumentView.h b/include/InstrumentView.h index 695e8c477..ab18465eb 100644 --- a/include/InstrumentView.h +++ b/include/InstrumentView.h @@ -70,7 +70,7 @@ class LMMS_EXPORT InstrumentViewFixedSize : public InstrumentView public: using InstrumentView::InstrumentView; - ~InstrumentViewFixedSize() override; + ~InstrumentViewFixedSize() override = default; } ; diff --git a/include/Ladspa2LMMS.h b/include/Ladspa2LMMS.h index b1a21de70..4b7eb2482 100644 --- a/include/Ladspa2LMMS.h +++ b/include/Ladspa2LMMS.h @@ -68,7 +68,7 @@ public: private: Ladspa2LMMS(); - ~Ladspa2LMMS() override; + ~Ladspa2LMMS() override = default; l_sortable_plugin_t m_instruments; l_sortable_plugin_t m_validEffects; diff --git a/include/LadspaControl.h b/include/LadspaControl.h index 3a0ea5cc8..712c1ba1e 100644 --- a/include/LadspaControl.h +++ b/include/LadspaControl.h @@ -52,7 +52,7 @@ class LMMS_EXPORT LadspaControl : public Model, public JournallingObject public: LadspaControl( Model * _parent, port_desc_t * _port, bool _link = false ); - ~LadspaControl() override; + ~LadspaControl() override = default; LADSPA_Data value(); ValueBuffer * valueBuffer(); diff --git a/include/LadspaControlView.h b/include/LadspaControlView.h index c36135986..5dafa4e5c 100644 --- a/include/LadspaControlView.h +++ b/include/LadspaControlView.h @@ -43,7 +43,7 @@ class LMMS_EXPORT LadspaControlView : public QWidget, public ModelView Q_OBJECT public: LadspaControlView( QWidget * _parent, LadspaControl * _ctl ); - ~LadspaControlView() override; + ~LadspaControlView() override = default; private: LadspaControl * m_ctl; diff --git a/include/LinkedModelGroupViews.h b/include/LinkedModelGroupViews.h index 91a8d53ca..72598281b 100644 --- a/include/LinkedModelGroupViews.h +++ b/include/LinkedModelGroupViews.h @@ -70,7 +70,7 @@ public: */ LinkedModelGroupView(QWidget* parent, LinkedModelGroup* model, std::size_t colNum); - ~LinkedModelGroupView() override; + ~LinkedModelGroupView() override = default; //! Reconnect models if model changed void modelChanged(LinkedModelGroup* linkedModelGroup); diff --git a/include/LinkedModelGroups.h b/include/LinkedModelGroups.h index 9fa0fefa6..84a216f30 100644 --- a/include/LinkedModelGroups.h +++ b/include/LinkedModelGroups.h @@ -155,7 +155,7 @@ private: class LinkedModelGroups { public: - virtual ~LinkedModelGroups(); + virtual ~LinkedModelGroups() = default; void linkAllModels(); diff --git a/include/LmmsPalette.h b/include/LmmsPalette.h index 1840fb3eb..b07aa5c84 100644 --- a/include/LmmsPalette.h +++ b/include/LmmsPalette.h @@ -50,7 +50,7 @@ class LMMS_EXPORT LmmsPalette : public QWidget public: LmmsPalette( QWidget * parent, QStyle * stylearg ); - ~LmmsPalette() override; + ~LmmsPalette() override = default; #define ACCESSMET( read, write ) \ QColor read () const; \ diff --git a/include/LmmsStyle.h b/include/LmmsStyle.h index cfab2cd66..ae5b65f99 100644 --- a/include/LmmsStyle.h +++ b/include/LmmsStyle.h @@ -66,9 +66,7 @@ public: }; LmmsStyle(); - ~LmmsStyle() override - { - } + ~LmmsStyle() override = default; QPalette standardPalette() const override; diff --git a/include/LocklessAllocator.h b/include/LocklessAllocator.h index 054bb91e8..adde5fe6f 100644 --- a/include/LocklessAllocator.h +++ b/include/LocklessAllocator.h @@ -67,9 +67,7 @@ public: { } - ~LocklessAllocatorT() override - { - } + ~LocklessAllocatorT() override = default; T * alloc() { diff --git a/include/LocklessRingBuffer.h b/include/LocklessRingBuffer.h index 60f8ab989..e77c62ccb 100644 --- a/include/LocklessRingBuffer.h +++ b/include/LocklessRingBuffer.h @@ -46,7 +46,7 @@ public: { m_buffer.touch(); // reserve storage space before realtime operation starts } - ~LocklessRingBuffer() {}; + ~LocklessRingBuffer() = default; std::size_t capacity() const {return m_buffer.maximum_eventual_write_space();} std::size_t free() const {return m_buffer.write_space();} diff --git a/include/Lv2Ports.h b/include/Lv2Ports.h index 22a051a21..48c46dfb1 100644 --- a/include/Lv2Ports.h +++ b/include/Lv2Ports.h @@ -92,7 +92,7 @@ struct ConstVisitor virtual void visit(const Lv2Ports::AtomSeq& ) {} virtual void visit(const Lv2Ports::Unknown& ) {} - virtual ~ConstVisitor(); + virtual ~ConstVisitor() = default; }; struct Visitor @@ -104,7 +104,7 @@ struct Visitor virtual void visit(Lv2Ports::AtomSeq& ) {} virtual void visit(Lv2Ports::Unknown& ) {} - virtual ~Visitor(); + virtual ~Visitor() = default; }; struct Meta @@ -139,7 +139,7 @@ struct PortBase : public Meta QString name() const; QString uri() const; - virtual ~PortBase(); + virtual ~PortBase() = default; }; template diff --git a/include/Lv2ViewBase.h b/include/Lv2ViewBase.h index 2be5d72a4..605440814 100644 --- a/include/Lv2ViewBase.h +++ b/include/Lv2ViewBase.h @@ -58,7 +58,7 @@ class Lv2ViewProc : public LinkedModelGroupView public: //! @param colNum numbers of columns for the controls Lv2ViewProc(QWidget *parent, Lv2Proc *ctrlBase, int colNum); - ~Lv2ViewProc() override; + ~Lv2ViewProc() override = default; private: static AutoLilvNode uri(const char *uriStr); diff --git a/include/MeterDialog.h b/include/MeterDialog.h index e744ea9d4..67dca2568 100644 --- a/include/MeterDialog.h +++ b/include/MeterDialog.h @@ -41,7 +41,7 @@ class MeterDialog : public QWidget, public ModelView Q_OBJECT public: MeterDialog( QWidget * _parent, bool _simple = false ); - ~MeterDialog() override; + ~MeterDialog() override = default; void modelChanged() override; diff --git a/include/MeterModel.h b/include/MeterModel.h index 8ed4ba1aa..c2e715b79 100644 --- a/include/MeterModel.h +++ b/include/MeterModel.h @@ -31,14 +31,14 @@ namespace lmms { -class MeterModel : public Model +class LMMS_EXPORT MeterModel : public Model { Q_OBJECT mapPropertyFromModel(int,getNumerator,setNumerator,m_numeratorModel); mapPropertyFromModel(int,getDenominator,setDenominator,m_denominatorModel); public: MeterModel( Model * _parent ); - ~MeterModel() override; + ~MeterModel() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _this, const QString & _name ); diff --git a/include/MicroTimer.h b/include/MicroTimer.h index 4daf28edd..ea74e964d 100644 --- a/include/MicroTimer.h +++ b/include/MicroTimer.h @@ -36,7 +36,7 @@ class MicroTimer public: MicroTimer(); - ~MicroTimer(); + ~MicroTimer() = default; void reset(); int elapsed() const; diff --git a/include/MidiClient.h b/include/MidiClient.h index f5efc659a..954cd5ef5 100644 --- a/include/MidiClient.h +++ b/include/MidiClient.h @@ -45,7 +45,7 @@ class TimePos; class MidiClient { public: - MidiClient(); + MidiClient() = default; virtual ~MidiClient(); // to be implemented by sub-classes @@ -124,8 +124,8 @@ const uint32_t RAW_MIDI_PARSE_BUF_SIZE = 16; class MidiClientRaw : public MidiClient { public: - MidiClientRaw(); - ~MidiClientRaw() override; + MidiClientRaw() = default; + ~MidiClientRaw() override = default; // we are raw-clients for sure! bool isRaw() const override diff --git a/include/MidiController.h b/include/MidiController.h index 8b1db0476..500acc5f8 100644 --- a/include/MidiController.h +++ b/include/MidiController.h @@ -49,7 +49,7 @@ class MidiController : public Controller, public MidiEventProcessor Q_OBJECT public: MidiController( Model * _parent ); - ~MidiController() override; + ~MidiController() override = default; void processInEvent( const MidiEvent & _me, const TimePos & _time, f_cnt_t offset = 0 ) override; diff --git a/include/MidiDummy.h b/include/MidiDummy.h index e1c0e3e6a..67a91e326 100644 --- a/include/MidiDummy.h +++ b/include/MidiDummy.h @@ -35,12 +35,8 @@ namespace lmms class MidiDummy : public MidiClientRaw { public: - MidiDummy() - { - } - ~MidiDummy() override - { - } + MidiDummy() = default; + ~MidiDummy() override = default; inline static QString name() { diff --git a/include/MidiEvent.h b/include/MidiEvent.h index e73a7d1a8..6c2bfdd55 100644 --- a/include/MidiEvent.h +++ b/include/MidiEvent.h @@ -66,16 +66,7 @@ public: m_data.m_sysExDataLen = dataLen; } - MidiEvent( const MidiEvent& other ) : - m_type( other.m_type ), - m_metaEvent( other.m_metaEvent ), - m_channel( other.m_channel ), - m_data( other.m_data ), - m_sysExData( other.m_sysExData ), - m_sourcePort(other.m_sourcePort), - m_source(other.m_source) - { - } + MidiEvent( const MidiEvent& other ) = default; MidiEventTypes type() const { diff --git a/include/MidiEventProcessor.h b/include/MidiEventProcessor.h index 1398f4b6d..132a5fc42 100644 --- a/include/MidiEventProcessor.h +++ b/include/MidiEventProcessor.h @@ -37,13 +37,9 @@ class MidiEventProcessor { MM_OPERATORS public: - MidiEventProcessor() - { - } + MidiEventProcessor() = default; - virtual ~MidiEventProcessor() - { - } + virtual ~MidiEventProcessor() = default; // to be implemented by inheriting classes virtual void processInEvent( const MidiEvent& event, const TimePos& time = TimePos(), f_cnt_t offset = 0 ) = 0; diff --git a/include/MidiPortMenu.h b/include/MidiPortMenu.h index eb44ace57..215a73d06 100644 --- a/include/MidiPortMenu.h +++ b/include/MidiPortMenu.h @@ -41,7 +41,7 @@ class MidiPortMenu : public QMenu, public ModelView Q_OBJECT public: MidiPortMenu( MidiPort::Modes _mode ); - ~MidiPortMenu() override; + ~MidiPortMenu() override = default; public slots: diff --git a/include/Mixer.h b/include/Mixer.h index e6fdb2b06..efc103695 100644 --- a/include/Mixer.h +++ b/include/Mixer.h @@ -102,7 +102,7 @@ class MixerRoute : public QObject Q_OBJECT public: MixerRoute( MixerChannel * from, MixerChannel * to, float amount ); - ~MixerRoute() override; + ~MixerRoute() override = default; mix_ch_t senderIndex() const { diff --git a/include/MixerLineLcdSpinBox.h b/include/MixerLineLcdSpinBox.h index 51c7ab938..bfd6cd5c9 100644 --- a/include/MixerLineLcdSpinBox.h +++ b/include/MixerLineLcdSpinBox.h @@ -41,7 +41,7 @@ public: MixerLineLcdSpinBox(int numDigits, QWidget * parent, const QString& name, TrackView * tv = nullptr) : LcdSpinBox(numDigits, parent, name), m_tv(tv) {} - ~MixerLineLcdSpinBox() override {} + ~MixerLineLcdSpinBox() override = default; void setTrackView(TrackView * tv); diff --git a/include/Model.h b/include/Model.h index 1621d77e8..567d4ffd7 100644 --- a/include/Model.h +++ b/include/Model.h @@ -45,9 +45,7 @@ public: { } - ~Model() override - { - } + ~Model() override = default; bool isDefaultConstructed() { diff --git a/include/ModelVisitor.h b/include/ModelVisitor.h index cf0740b1c..8805e30e2 100644 --- a/include/ModelVisitor.h +++ b/include/ModelVisitor.h @@ -47,7 +47,7 @@ public: virtual void visit(FloatModel& m); virtual void visit(ComboBoxModel& m); virtual void visit(TempoSyncKnobModel& m); - virtual ~ModelVisitor(); + virtual ~ModelVisitor() = default; }; class ConstModelVisitor @@ -62,7 +62,7 @@ public: virtual void visit(const FloatModel& m); virtual void visit(const ComboBoxModel& m); virtual void visit(const TempoSyncKnobModel& m); - virtual ~ConstModelVisitor(); + virtual ~ConstModelVisitor() = default; }; diff --git a/include/PatternEditor.h b/include/PatternEditor.h index 15b141580..ffe08e335 100644 --- a/include/PatternEditor.h +++ b/include/PatternEditor.h @@ -80,7 +80,7 @@ class PatternEditorWindow : public Editor Q_OBJECT public: PatternEditorWindow(PatternStore* ps); - ~PatternEditorWindow(); + ~PatternEditorWindow() = default; QSize sizeHint() const override; diff --git a/include/PatternStore.h b/include/PatternStore.h index 58791e40d..7bd377941 100644 --- a/include/PatternStore.h +++ b/include/PatternStore.h @@ -68,7 +68,7 @@ class LMMS_EXPORT PatternStore : public TrackContainer mapPropertyFromModel(int, currentPattern, setCurrentPattern, m_patternComboBoxModel); public: PatternStore(); - ~PatternStore() override; + ~PatternStore() override = default; virtual bool play(TimePos start, const fpp_t frames, const f_cnt_t frameBase, int clipNum = -1); diff --git a/include/PeakController.h b/include/PeakController.h index 2999c5a2b..d8f721ea7 100644 --- a/include/PeakController.h +++ b/include/PeakController.h @@ -92,7 +92,7 @@ class PeakControllerDialog : public ControllerDialog Q_OBJECT public: PeakControllerDialog( Controller * _controller, QWidget * _parent ); - ~PeakControllerDialog() override; + ~PeakControllerDialog() override = default; protected: void contextMenuEvent( QContextMenuEvent * _me ) override; diff --git a/include/PianoRoll.h b/include/PianoRoll.h index 3d74a79d6..60cf01e1d 100644 --- a/include/PianoRoll.h +++ b/include/PianoRoll.h @@ -298,7 +298,7 @@ private: PianoRoll(); PianoRoll( const PianoRoll & ); - ~PianoRoll() override; + ~PianoRoll() override = default; void autoScroll(const TimePos & t ); diff --git a/include/PixmapButton.h b/include/PixmapButton.h index ec5ac1b28..6c37f9112 100644 --- a/include/PixmapButton.h +++ b/include/PixmapButton.h @@ -40,7 +40,7 @@ class LMMS_EXPORT PixmapButton : public AutomatableButton public: PixmapButton( QWidget * _parent, const QString & _name = QString() ); - ~PixmapButton() override; + ~PixmapButton() override = default; void setActiveGraphic( const QPixmap & _pm ); void setInactiveGraphic( const QPixmap & _pm, bool _update = true ); diff --git a/include/Plugin.h b/include/Plugin.h index da2deeaed..43164e0a5 100644 --- a/include/Plugin.h +++ b/include/Plugin.h @@ -187,9 +187,7 @@ public: { } - virtual ~SubPluginFeatures() - { - } + virtual ~SubPluginFeatures() = default; virtual void fillDescriptionWidget( QWidget *, const Key * ) const { @@ -244,7 +242,7 @@ public: //! See the key() function Plugin(const Descriptor * descriptor, Model * parent, const Descriptor::SubPluginFeatures::Key *key = nullptr); - ~Plugin() override; + ~Plugin() override = default; //! Return display-name out of sub plugin or descriptor QString displayName() const override; diff --git a/include/PluginFactory.h b/include/PluginFactory.h index c0e2ff8e0..2aa618f25 100644 --- a/include/PluginFactory.h +++ b/include/PluginFactory.h @@ -57,7 +57,7 @@ public: typedef QMultiMap DescriptorMap; PluginFactory(); - ~PluginFactory(); + ~PluginFactory() = default; static void setupSearchPaths(); diff --git a/include/ProjectJournal.h b/include/ProjectJournal.h index 69e0752cb..25207867b 100644 --- a/include/ProjectJournal.h +++ b/include/ProjectJournal.h @@ -46,7 +46,7 @@ public: static const int MAX_UNDO_STATES; ProjectJournal(); - virtual ~ProjectJournal(); + virtual ~ProjectJournal() = default; void undo(); void redo(); diff --git a/include/ProjectNotes.h b/include/ProjectNotes.h index 384f24f79..4b9476616 100644 --- a/include/ProjectNotes.h +++ b/include/ProjectNotes.h @@ -44,7 +44,7 @@ class LMMS_EXPORT ProjectNotes : public QMainWindow, public SerializingObject Q_OBJECT public: ProjectNotes(); - ~ProjectNotes() override; + ~ProjectNotes() override = default; void clear(); void setText( const QString & _text ); diff --git a/include/ProjectRenderer.h b/include/ProjectRenderer.h index 9fa0bc507..75537ed69 100644 --- a/include/ProjectRenderer.h +++ b/include/ProjectRenderer.h @@ -64,7 +64,7 @@ public: const OutputSettings & _os, ExportFileFormats _file_format, const QString & _out_file ); - ~ProjectRenderer() override; + ~ProjectRenderer() override = default; bool isReady() const { diff --git a/include/RemotePluginBase.h b/include/RemotePluginBase.h index 2abe59132..c5bf35bcb 100644 --- a/include/RemotePluginBase.h +++ b/include/RemotePluginBase.h @@ -390,11 +390,7 @@ public: { } - message( const message & _m ) : - id( _m.id ), - data( _m.data ) - { - } + message( const message & _m ) = default; message( int _id ) : id( _id ), diff --git a/include/RenameDialog.h b/include/RenameDialog.h index f2a289ee0..b543963d7 100644 --- a/include/RenameDialog.h +++ b/include/RenameDialog.h @@ -40,7 +40,7 @@ class RenameDialog : public QDialog Q_OBJECT public: RenameDialog( QString & _string ); - ~RenameDialog() override; + ~RenameDialog() override = default; protected: diff --git a/include/Rubberband.h b/include/Rubberband.h index b00d10dd6..d35233b4f 100644 --- a/include/Rubberband.h +++ b/include/Rubberband.h @@ -44,9 +44,7 @@ public: { } - ~selectableObject() override - { - } + ~selectableObject() override = default; inline void setSelected(bool selected) { @@ -80,7 +78,7 @@ class RubberBand : public QRubberBand { public: RubberBand( QWidget * _parent ); - ~RubberBand() override; + ~RubberBand() override = default; QVector selectedObjects() const; QVector selectableObjects() const; diff --git a/include/SampleTrackWindow.h b/include/SampleTrackWindow.h index fb4e3f5e8..d302b2c44 100644 --- a/include/SampleTrackWindow.h +++ b/include/SampleTrackWindow.h @@ -50,7 +50,7 @@ class SampleTrackWindow : public QWidget, public ModelView, public SerializingOb Q_OBJECT public: SampleTrackWindow(SampleTrackView * tv); - ~SampleTrackWindow() override; + ~SampleTrackWindow() override = default; SampleTrack * model() { diff --git a/include/SideBar.h b/include/SideBar.h index ba9fe11a6..6f1b15770 100644 --- a/include/SideBar.h +++ b/include/SideBar.h @@ -42,7 +42,7 @@ class SideBar : public QToolBar Q_OBJECT public: SideBar( Qt::Orientation _orientation, QWidget * _parent ); - ~SideBar() override; + ~SideBar() override = default; void appendTab( SideBarWidget * _sbw ); diff --git a/include/SideBarWidget.h b/include/SideBarWidget.h index 4b7ff4b2d..5df3ccb7a 100644 --- a/include/SideBarWidget.h +++ b/include/SideBarWidget.h @@ -41,7 +41,7 @@ class SideBarWidget : public QWidget public: SideBarWidget( const QString & _title, const QPixmap & _icon, QWidget * _parent ); - ~SideBarWidget() override; + ~SideBarWidget() override = default; inline const QPixmap & icon() const { diff --git a/include/SongEditor.h b/include/SongEditor.h index b848fe776..ea57cc125 100644 --- a/include/SongEditor.h +++ b/include/SongEditor.h @@ -66,7 +66,7 @@ public: }; SongEditor( Song * song ); - ~SongEditor() override; + ~SongEditor() override = default; void saveSettings( QDomDocument& doc, QDomElement& element ) override; void loadSettings( const QDomElement& element ) override; diff --git a/include/SweepOscillator.h b/include/SweepOscillator.h index 2e795be3b..f113ea0fa 100644 --- a/include/SweepOscillator.h +++ b/include/SweepOscillator.h @@ -41,9 +41,7 @@ public: { } - virtual ~SweepOscillator() - { - } + virtual ~SweepOscillator() = default; void update( sampleFrame* buf, const fpp_t frames, const float freq1, const float freq2, const float sampleRate ) { diff --git a/include/TabButton.h b/include/TabButton.h index 6d58cc10e..938230a91 100644 --- a/include/TabButton.h +++ b/include/TabButton.h @@ -45,9 +45,7 @@ public: SLOT( slotClicked() ) ); } - ~TabButton() override - { - } + ~TabButton() override = default; signals: diff --git a/include/TempoSyncKnobModel.h b/include/TempoSyncKnobModel.h index 1e6decfb9..1a18486ff 100644 --- a/include/TempoSyncKnobModel.h +++ b/include/TempoSyncKnobModel.h @@ -63,7 +63,7 @@ public: const float _max, const float _step, const float _scale, Model * _parent, const QString & _display_name = QString() ); - ~TempoSyncKnobModel() override; + ~TempoSyncKnobModel() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _this, const QString& name ) override; void loadSettings( const QDomElement & _this, const QString& name ) override; diff --git a/include/TextFloat.h b/include/TextFloat.h index 8a5ad9685..9fdabc06b 100644 --- a/include/TextFloat.h +++ b/include/TextFloat.h @@ -39,9 +39,7 @@ class LMMS_EXPORT TextFloat : public QWidget Q_OBJECT public: TextFloat(); - ~TextFloat() override - { - } + ~TextFloat() override = default; void setTitle( const QString & _title ); void setText( const QString & _text ); diff --git a/include/ToolPlugin.h b/include/ToolPlugin.h index 311757cf4..38f4d87b1 100644 --- a/include/ToolPlugin.h +++ b/include/ToolPlugin.h @@ -38,7 +38,7 @@ class LMMS_EXPORT ToolPlugin : public Plugin { public: ToolPlugin( const Descriptor * _descriptor, Model * _parent ); - ~ToolPlugin() override; + ~ToolPlugin() override = default; // instantiate tool-plugin with given name or return NULL // on failure diff --git a/include/TrackContainerView.h b/include/TrackContainerView.h index 7d9a648aa..7bc367c37 100644 --- a/include/TrackContainerView.h +++ b/include/TrackContainerView.h @@ -184,7 +184,7 @@ private: { public: scrollArea( TrackContainerView* parent ); - ~scrollArea() override; + ~scrollArea() override = default; protected: void wheelEvent( QWheelEvent * _we ) override; diff --git a/include/TrackContentWidget.h b/include/TrackContentWidget.h index 4fad4ceb0..bde2de33e 100644 --- a/include/TrackContentWidget.h +++ b/include/TrackContentWidget.h @@ -56,7 +56,7 @@ class TrackContentWidget : public QWidget, public JournallingObject public: TrackContentWidget( TrackView * parent ); - ~TrackContentWidget() override; + ~TrackContentWidget() override = default; /*! \brief Updates the background tile pixmap. */ void updateBackground(); diff --git a/include/TrackLabelButton.h b/include/TrackLabelButton.h index 30dd60d59..1a8d05e71 100644 --- a/include/TrackLabelButton.h +++ b/include/TrackLabelButton.h @@ -41,7 +41,7 @@ class TrackLabelButton : public QToolButton Q_OBJECT public: TrackLabelButton( TrackView * _tv, QWidget * _parent ); - ~TrackLabelButton() override; + ~TrackLabelButton() override = default; public slots: diff --git a/include/TrackOperationsWidget.h b/include/TrackOperationsWidget.h index 08b3e599e..edd9796ac 100644 --- a/include/TrackOperationsWidget.h +++ b/include/TrackOperationsWidget.h @@ -40,7 +40,7 @@ class TrackOperationsWidget : public QWidget Q_OBJECT public: TrackOperationsWidget( TrackView * parent ); - ~TrackOperationsWidget() override; + ~TrackOperationsWidget() override = default; protected: diff --git a/include/TrackView.h b/include/TrackView.h index f98579201..4b02c8015 100644 --- a/include/TrackView.h +++ b/include/TrackView.h @@ -64,7 +64,7 @@ class TrackView : public QWidget, public ModelView, public JournallingObject Q_OBJECT public: TrackView( Track * _track, TrackContainerView* tcv ); - ~TrackView() override; + ~TrackView() override = default; inline const Track * getTrack() const { diff --git a/include/ValueBuffer.h b/include/ValueBuffer.h index 24c8e0daa..950ad06f0 100644 --- a/include/ValueBuffer.h +++ b/include/ValueBuffer.h @@ -39,7 +39,7 @@ class LMMS_EXPORT ValueBuffer : public std::vector { MM_OPERATORS public: - ValueBuffer(); + ValueBuffer() = default; ValueBuffer(int length); void fill(float value); diff --git a/include/embed.h b/include/embed.h index d26fd643a..c8914ba47 100644 --- a/include/embed.h +++ b/include/embed.h @@ -96,9 +96,7 @@ public: return( QPixmap() ); } - virtual ~PixmapLoader() - { - } + virtual ~PixmapLoader() = default; virtual QString pixmapName() const { diff --git a/include/shared_object.h b/include/shared_object.h index e68186336..ac45d6cd7 100644 --- a/include/shared_object.h +++ b/include/shared_object.h @@ -39,9 +39,7 @@ public: { } - virtual ~sharedObject() - { - } + virtual ~sharedObject() = default; template static T* ref( T* object ) diff --git a/plugins/Amplifier/Amplifier.cpp b/plugins/Amplifier/Amplifier.cpp index 1212bcd6a..3fb03d3d9 100644 --- a/plugins/Amplifier/Amplifier.cpp +++ b/plugins/Amplifier/Amplifier.cpp @@ -60,9 +60,6 @@ AmplifierEffect::AmplifierEffect( Model* parent, const Descriptor::SubPluginFeat -AmplifierEffect::~AmplifierEffect() -{ -} diff --git a/plugins/Amplifier/Amplifier.h b/plugins/Amplifier/Amplifier.h index cc973cc27..38fd07c6f 100644 --- a/plugins/Amplifier/Amplifier.h +++ b/plugins/Amplifier/Amplifier.h @@ -37,7 +37,7 @@ class AmplifierEffect : public Effect { public: AmplifierEffect( Model* parent, const Descriptor::SubPluginFeatures::Key* key ); - ~AmplifierEffect() override; + ~AmplifierEffect() override = default; bool processAudioBuffer( sampleFrame* buf, const fpp_t frames ) override; EffectControls* controls() override diff --git a/plugins/Amplifier/AmplifierControlDialog.h b/plugins/Amplifier/AmplifierControlDialog.h index fd2c7a338..ad0ed50ca 100644 --- a/plugins/Amplifier/AmplifierControlDialog.h +++ b/plugins/Amplifier/AmplifierControlDialog.h @@ -42,9 +42,7 @@ class AmplifierControlDialog : public EffectControlDialog Q_OBJECT public: AmplifierControlDialog( AmplifierControls* controls ); - ~AmplifierControlDialog() override - { - } + ~AmplifierControlDialog() override = default; } ; diff --git a/plugins/Amplifier/AmplifierControls.h b/plugins/Amplifier/AmplifierControls.h index 6382b27fe..573f6f896 100644 --- a/plugins/Amplifier/AmplifierControls.h +++ b/plugins/Amplifier/AmplifierControls.h @@ -45,9 +45,7 @@ class AmplifierControls : public EffectControls Q_OBJECT public: AmplifierControls( AmplifierEffect* effect ); - ~AmplifierControls() override - { - } + ~AmplifierControls() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override; void loadSettings( const QDomElement & _this ) override; diff --git a/plugins/AudioFileProcessor/AudioFileProcessor.cpp b/plugins/AudioFileProcessor/AudioFileProcessor.cpp index 3d4319dd3..9f01a6499 100644 --- a/plugins/AudioFileProcessor/AudioFileProcessor.cpp +++ b/plugins/AudioFileProcessor/AudioFileProcessor.cpp @@ -559,9 +559,6 @@ AudioFileProcessorView::AudioFileProcessorView( Instrument * _instrument, -AudioFileProcessorView::~AudioFileProcessorView() -{ -} diff --git a/plugins/AudioFileProcessor/AudioFileProcessor.h b/plugins/AudioFileProcessor/AudioFileProcessor.h index 30fcbc502..18edd2b4a 100644 --- a/plugins/AudioFileProcessor/AudioFileProcessor.h +++ b/plugins/AudioFileProcessor/AudioFileProcessor.h @@ -130,7 +130,7 @@ class AudioFileProcessorView : public gui::InstrumentViewFixedSize Q_OBJECT public: AudioFileProcessorView( Instrument * _instrument, QWidget * _parent ); - virtual ~AudioFileProcessorView(); + virtual ~AudioFileProcessorView() = default; void newWaveView(); protected slots: diff --git a/plugins/BassBooster/BassBooster.cpp b/plugins/BassBooster/BassBooster.cpp index 280accddb..77667c121 100644 --- a/plugins/BassBooster/BassBooster.cpp +++ b/plugins/BassBooster/BassBooster.cpp @@ -65,9 +65,6 @@ BassBoosterEffect::BassBoosterEffect( Model* parent, const Descriptor::SubPlugin -BassBoosterEffect::~BassBoosterEffect() -{ -} diff --git a/plugins/BassBooster/BassBooster.h b/plugins/BassBooster/BassBooster.h index 19eb9c50e..ea3ba2d98 100644 --- a/plugins/BassBooster/BassBooster.h +++ b/plugins/BassBooster/BassBooster.h @@ -37,7 +37,7 @@ class BassBoosterEffect : public Effect { public: BassBoosterEffect( Model* parent, const Descriptor::SubPluginFeatures::Key* key ); - ~BassBoosterEffect() override; + ~BassBoosterEffect() override = default; bool processAudioBuffer( sampleFrame* buf, const fpp_t frames ) override; EffectControls* controls() override diff --git a/plugins/BassBooster/BassBoosterControlDialog.h b/plugins/BassBooster/BassBoosterControlDialog.h index 968db7e60..6c510282e 100644 --- a/plugins/BassBooster/BassBoosterControlDialog.h +++ b/plugins/BassBooster/BassBoosterControlDialog.h @@ -40,9 +40,7 @@ class BassBoosterControlDialog : public EffectControlDialog Q_OBJECT public: BassBoosterControlDialog( BassBoosterControls* controls ); - ~BassBoosterControlDialog() override - { - } + ~BassBoosterControlDialog() override = default; } ; diff --git a/plugins/BassBooster/BassBoosterControls.h b/plugins/BassBooster/BassBoosterControls.h index 099862a02..bd93a5eb7 100644 --- a/plugins/BassBooster/BassBoosterControls.h +++ b/plugins/BassBooster/BassBoosterControls.h @@ -39,9 +39,7 @@ class BassBoosterControls : public EffectControls Q_OBJECT public: BassBoosterControls( BassBoosterEffect* effect ); - ~BassBoosterControls() override - { - } + ~BassBoosterControls() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override; void loadSettings( const QDomElement & _this ) override; diff --git a/plugins/BitInvader/BitInvader.cpp b/plugins/BitInvader/BitInvader.cpp index 0bf063461..e319a9c24 100644 --- a/plugins/BitInvader/BitInvader.cpp +++ b/plugins/BitInvader/BitInvader.cpp @@ -171,10 +171,6 @@ BitInvader::BitInvader( InstrumentTrack * _instrument_track ) : -BitInvader::~BitInvader() -{ -} - diff --git a/plugins/BitInvader/BitInvader.h b/plugins/BitInvader/BitInvader.h index debdd37ea..a08640e99 100644 --- a/plugins/BitInvader/BitInvader.h +++ b/plugins/BitInvader/BitInvader.h @@ -74,7 +74,7 @@ class BitInvader : public Instrument Q_OBJECT public: BitInvader(InstrumentTrack * _instrument_track ); - ~BitInvader() override; + ~BitInvader() override = default; void playNote( NotePlayHandle * _n, sampleFrame * _working_buffer ) override; @@ -124,7 +124,7 @@ public: BitInvaderView( Instrument * _instrument, QWidget * _parent ); - ~BitInvaderView() override {}; + ~BitInvaderView() override = default; protected slots: //void sampleSizeChanged( float _new_sample_length ); diff --git a/plugins/Bitcrush/BitcrushControlDialog.h b/plugins/Bitcrush/BitcrushControlDialog.h index 9649d50f2..ac409c0ab 100644 --- a/plugins/Bitcrush/BitcrushControlDialog.h +++ b/plugins/Bitcrush/BitcrushControlDialog.h @@ -43,9 +43,7 @@ class BitcrushControlDialog : public EffectControlDialog Q_OBJECT public: BitcrushControlDialog( BitcrushControls * controls ); - ~BitcrushControlDialog() override - { - } + ~BitcrushControlDialog() override = default; }; diff --git a/plugins/Bitcrush/BitcrushControls.cpp b/plugins/Bitcrush/BitcrushControls.cpp index 9acd7d7c0..163c2c924 100644 --- a/plugins/Bitcrush/BitcrushControls.cpp +++ b/plugins/Bitcrush/BitcrushControls.cpp @@ -53,9 +53,6 @@ BitcrushControls::BitcrushControls( BitcrushEffect * eff ) : connect( Engine::audioEngine(), SIGNAL( sampleRateChanged() ), this, SLOT( sampleRateChanged() ) ); } -BitcrushControls::~BitcrushControls() -{ -} void BitcrushControls::saveSettings( QDomDocument & doc, QDomElement & elem ) { diff --git a/plugins/Bitcrush/BitcrushControls.h b/plugins/Bitcrush/BitcrushControls.h index 963fb298e..7514baae9 100644 --- a/plugins/Bitcrush/BitcrushControls.h +++ b/plugins/Bitcrush/BitcrushControls.h @@ -40,7 +40,7 @@ class BitcrushControls : public EffectControls Q_OBJECT public: BitcrushControls( BitcrushEffect * eff ); - ~BitcrushControls() override; + ~BitcrushControls() override = default; void saveSettings( QDomDocument & doc, QDomElement & elem ) override; void loadSettings( const QDomElement & elem ) override; diff --git a/plugins/Compressor/Compressor.cpp b/plugins/Compressor/Compressor.cpp index bf6928e21..312a40d3d 100755 --- a/plugins/Compressor/Compressor.cpp +++ b/plugins/Compressor/Compressor.cpp @@ -97,11 +97,6 @@ CompressorEffect::CompressorEffect(Model* parent, const Descriptor::SubPluginFea -CompressorEffect::~CompressorEffect() -{ -} - - float CompressorEffect::msToCoeff(float ms) { // Convert time in milliseconds to applicable lowpass coefficient diff --git a/plugins/Compressor/Compressor.h b/plugins/Compressor/Compressor.h index 9b81d9b70..121e0b88f 100755 --- a/plugins/Compressor/Compressor.h +++ b/plugins/Compressor/Compressor.h @@ -42,7 +42,7 @@ class CompressorEffect : public Effect Q_OBJECT public: CompressorEffect(Model* parent, const Descriptor::SubPluginFeatures::Key* key); - ~CompressorEffect() override; + ~CompressorEffect() override = default; bool processAudioBuffer(sampleFrame* buf, const fpp_t frames) override; EffectControls* controls() override diff --git a/plugins/CrossoverEQ/CrossoverEQControlDialog.h b/plugins/CrossoverEQ/CrossoverEQControlDialog.h index bad64a8bb..9ddb5d9bf 100644 --- a/plugins/CrossoverEQ/CrossoverEQControlDialog.h +++ b/plugins/CrossoverEQ/CrossoverEQControlDialog.h @@ -45,9 +45,7 @@ class CrossoverEQControlDialog : public EffectControlDialog Q_OBJECT public: CrossoverEQControlDialog( CrossoverEQControls * controls ); - ~CrossoverEQControlDialog() override - { - } + ~CrossoverEQControlDialog() override = default; private: QPixmap m_fader_bg; diff --git a/plugins/CrossoverEQ/CrossoverEQControls.h b/plugins/CrossoverEQ/CrossoverEQControls.h index 458300d89..715311aba 100644 --- a/plugins/CrossoverEQ/CrossoverEQControls.h +++ b/plugins/CrossoverEQ/CrossoverEQControls.h @@ -40,7 +40,7 @@ class CrossoverEQControls : public EffectControls Q_OBJECT public: CrossoverEQControls( CrossoverEQEffect * eff ); - ~CrossoverEQControls() override {} + ~CrossoverEQControls() override = default; void saveSettings( QDomDocument & doc, QDomElement & elem ) override; void loadSettings( const QDomElement & elem ) override; diff --git a/plugins/Delay/DelayControls.h b/plugins/Delay/DelayControls.h index 3d9393b76..b9eb663fc 100644 --- a/plugins/Delay/DelayControls.h +++ b/plugins/Delay/DelayControls.h @@ -40,9 +40,7 @@ class DelayControls : public EffectControls Q_OBJECT public: DelayControls( DelayEffect* effect ); - ~DelayControls() override - { - } + ~DelayControls() override = default; void saveSettings( QDomDocument& doc, QDomElement& parent ) override; void loadSettings( const QDomElement& _this ) override; inline QString nodeName() const override diff --git a/plugins/Delay/DelayControlsDialog.h b/plugins/Delay/DelayControlsDialog.h index 115287cda..c7ab58f45 100644 --- a/plugins/Delay/DelayControlsDialog.h +++ b/plugins/Delay/DelayControlsDialog.h @@ -42,9 +42,7 @@ class DelayControlsDialog : public EffectControlDialog Q_OBJECT public: DelayControlsDialog( DelayControls* controls ); - ~DelayControlsDialog() override - { - } + ~DelayControlsDialog() override = default; }; class XyPad : public QWidget @@ -52,7 +50,7 @@ class XyPad : public QWidget Q_OBJECT public: XyPad( QWidget *parent = 0, FloatModel *xModel = 0, FloatModel *yModel = 0 ); - ~XyPad() override {} + ~XyPad() override = default; protected: void paintEvent ( QPaintEvent * event ) override; diff --git a/plugins/Delay/Lfo.h b/plugins/Delay/Lfo.h index cb2d13f11..ea8435d13 100644 --- a/plugins/Delay/Lfo.h +++ b/plugins/Delay/Lfo.h @@ -36,9 +36,7 @@ class Lfo { public: Lfo( int samplerate ); - ~Lfo() - { - } + ~Lfo() = default; diff --git a/plugins/DualFilter/DualFilterControlDialog.h b/plugins/DualFilter/DualFilterControlDialog.h index 88b3fe17a..629eb2d9a 100644 --- a/plugins/DualFilter/DualFilterControlDialog.h +++ b/plugins/DualFilter/DualFilterControlDialog.h @@ -43,9 +43,7 @@ class DualFilterControlDialog : public EffectControlDialog Q_OBJECT public: DualFilterControlDialog( DualFilterControls* controls ); - ~DualFilterControlDialog() override - { - } + ~DualFilterControlDialog() override = default; } ; diff --git a/plugins/DualFilter/DualFilterControls.h b/plugins/DualFilter/DualFilterControls.h index a3676295d..379f96e32 100644 --- a/plugins/DualFilter/DualFilterControls.h +++ b/plugins/DualFilter/DualFilterControls.h @@ -42,9 +42,7 @@ class DualFilterControls : public EffectControls Q_OBJECT public: DualFilterControls( DualFilterEffect* effect ); - ~DualFilterControls() override - { - } + ~DualFilterControls() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override; void loadSettings( const QDomElement & _this ) override; diff --git a/plugins/DynamicsProcessor/DynamicsProcessorControlDialog.h b/plugins/DynamicsProcessor/DynamicsProcessorControlDialog.h index 8b755620e..37608d4a3 100644 --- a/plugins/DynamicsProcessor/DynamicsProcessorControlDialog.h +++ b/plugins/DynamicsProcessor/DynamicsProcessorControlDialog.h @@ -43,9 +43,7 @@ class DynProcControlDialog : public EffectControlDialog Q_OBJECT public: DynProcControlDialog( DynProcControls * _controls ); - ~DynProcControlDialog() override - { - } + ~DynProcControlDialog() override = default; private: diff --git a/plugins/DynamicsProcessor/DynamicsProcessorControls.h b/plugins/DynamicsProcessor/DynamicsProcessorControls.h index c68bdcc0c..cbe109eaf 100644 --- a/plugins/DynamicsProcessor/DynamicsProcessorControls.h +++ b/plugins/DynamicsProcessor/DynamicsProcessorControls.h @@ -49,9 +49,7 @@ public: NumStereoModes }; DynProcControls( DynProcEffect * _eff ); - ~DynProcControls() override - { - } + ~DynProcControls() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override; void loadSettings( const QDomElement & _this ) override; diff --git a/plugins/Eq/EqControls.h b/plugins/Eq/EqControls.h index 9b0d67742..6db82f3e3 100644 --- a/plugins/Eq/EqControls.h +++ b/plugins/Eq/EqControls.h @@ -44,9 +44,7 @@ class EqControls : public EffectControls Q_OBJECT public: explicit EqControls( EqEffect* effect ); - ~EqControls() override - { - } + ~EqControls() override = default; void saveSettings ( QDomDocument& doc, QDomElement& parent ) override; diff --git a/plugins/Eq/EqControlsDialog.h b/plugins/Eq/EqControlsDialog.h index 1ec7e3e9a..52bb2ae19 100644 --- a/plugins/Eq/EqControlsDialog.h +++ b/plugins/Eq/EqControlsDialog.h @@ -47,9 +47,7 @@ class EqControlsDialog : public EffectControlDialog Q_OBJECT public: EqControlsDialog( EqControls * controls ); - ~EqControlsDialog() override - { - } + ~EqControlsDialog() override = default; EqBand * setBand( EqControls * controls ); diff --git a/plugins/Eq/EqEffect.cpp b/plugins/Eq/EqEffect.cpp index 12a10061b..be74defba 100644 --- a/plugins/Eq/EqEffect.cpp +++ b/plugins/Eq/EqEffect.cpp @@ -64,13 +64,6 @@ EqEffect::EqEffect( Model *parent, const Plugin::Descriptor::SubPluginFeatures:: -EqEffect::~EqEffect() -{ -} - - - - bool EqEffect::processAudioBuffer( sampleFrame *buf, const fpp_t frames ) { const int sampleRate = Engine::audioEngine()->processingSampleRate(); diff --git a/plugins/Eq/EqEffect.h b/plugins/Eq/EqEffect.h index e3bf6fd54..2d54c42a2 100644 --- a/plugins/Eq/EqEffect.h +++ b/plugins/Eq/EqEffect.h @@ -36,7 +36,7 @@ class EqEffect : public Effect { public: EqEffect( Model * parent , const Descriptor::SubPluginFeatures::Key * key ); - ~EqEffect() override; + ~EqEffect() override = default; bool processAudioBuffer( sampleFrame * buf, const fpp_t frames ) override; EffectControls * controls() override { diff --git a/plugins/Eq/EqFader.h b/plugins/Eq/EqFader.h index aec6a9e18..9db0fbe2d 100644 --- a/plugins/Eq/EqFader.h +++ b/plugins/Eq/EqFader.h @@ -72,9 +72,7 @@ public: - ~EqFader() override - { - } + ~EqFader() override = default; private slots: diff --git a/plugins/Eq/EqSpectrumView.h b/plugins/Eq/EqSpectrumView.h index f0a8fda3c..947c55434 100644 --- a/plugins/Eq/EqSpectrumView.h +++ b/plugins/Eq/EqSpectrumView.h @@ -74,9 +74,7 @@ class EqSpectrumView : public QWidget Q_OBJECT public: explicit EqSpectrumView( EqAnalyser *b, QWidget *_parent = 0 ); - ~EqSpectrumView() override - { - } + ~EqSpectrumView() override = default; QColor getColor() const; void setColor( const QColor &value ); diff --git a/plugins/Flanger/FlangerControls.h b/plugins/Flanger/FlangerControls.h index b004e5e33..079497962 100644 --- a/plugins/Flanger/FlangerControls.h +++ b/plugins/Flanger/FlangerControls.h @@ -39,9 +39,7 @@ class FlangerControls : public EffectControls Q_OBJECT public: FlangerControls( FlangerEffect* effect ); - ~FlangerControls() override - { - } + ~FlangerControls() override = default; void saveSettings ( QDomDocument& doc, QDomElement& parent ) override; void loadSettings ( const QDomElement &_this ) override; inline QString nodeName() const override diff --git a/plugins/Flanger/FlangerControlsDialog.h b/plugins/Flanger/FlangerControlsDialog.h index 587046ad7..47f746ef3 100644 --- a/plugins/Flanger/FlangerControlsDialog.h +++ b/plugins/Flanger/FlangerControlsDialog.h @@ -42,9 +42,7 @@ class FlangerControlsDialog : public EffectControlDialog Q_OBJECT public: FlangerControlsDialog( FlangerControls* controls ); - ~FlangerControlsDialog() override - { - } + ~FlangerControlsDialog() override = default; }; diff --git a/plugins/FreeBoy/FreeBoy.cpp b/plugins/FreeBoy/FreeBoy.cpp index 9f7085444..3829d691a 100644 --- a/plugins/FreeBoy/FreeBoy.cpp +++ b/plugins/FreeBoy/FreeBoy.cpp @@ -125,11 +125,6 @@ FreeBoyInstrument::FreeBoyInstrument( InstrumentTrack * _instrument_track ) : } -FreeBoyInstrument::~FreeBoyInstrument() -{ -} - - void FreeBoyInstrument::saveSettings( QDomDocument & _doc, QDomElement & _this ) { @@ -684,11 +679,6 @@ FreeBoyInstrumentView::FreeBoyInstrumentView( Instrument * _instrument, } -FreeBoyInstrumentView::~FreeBoyInstrumentView() -{ -} - - void FreeBoyInstrumentView::modelChanged() { FreeBoyInstrument * p = castModel(); diff --git a/plugins/FreeBoy/FreeBoy.h b/plugins/FreeBoy/FreeBoy.h index 8b46a5e68..aecd2b188 100644 --- a/plugins/FreeBoy/FreeBoy.h +++ b/plugins/FreeBoy/FreeBoy.h @@ -52,7 +52,7 @@ class FreeBoyInstrument : public Instrument public: FreeBoyInstrument( InstrumentTrack * _instrument_track ); - ~FreeBoyInstrument() override; + ~FreeBoyInstrument() override = default; void playNote( NotePlayHandle * _n, sampleFrame * _working_buffer ) override; @@ -129,7 +129,7 @@ class FreeBoyInstrumentView : public InstrumentViewFixedSize Q_OBJECT public: FreeBoyInstrumentView( Instrument * _instrument, QWidget * _parent ); - ~FreeBoyInstrumentView() override; + ~FreeBoyInstrumentView() override = default; private: void modelChanged() override; diff --git a/plugins/FreeBoy/Gb_Apu_Buffer.cpp b/plugins/FreeBoy/Gb_Apu_Buffer.cpp index f261bc9c0..ec1a36479 100644 --- a/plugins/FreeBoy/Gb_Apu_Buffer.cpp +++ b/plugins/FreeBoy/Gb_Apu_Buffer.cpp @@ -26,9 +26,6 @@ namespace lmms { -Gb_Apu_Buffer::Gb_Apu_Buffer() {} -Gb_Apu_Buffer::~Gb_Apu_Buffer() {} - void Gb_Apu_Buffer::end_frame(blip_time_t end_time) { Gb_Apu::end_frame(end_time); m_buf.end_frame(end_time); diff --git a/plugins/FreeBoy/Gb_Apu_Buffer.h b/plugins/FreeBoy/Gb_Apu_Buffer.h index 0b025bea0..980dfa3e5 100644 --- a/plugins/FreeBoy/Gb_Apu_Buffer.h +++ b/plugins/FreeBoy/Gb_Apu_Buffer.h @@ -34,8 +34,8 @@ namespace lmms class Gb_Apu_Buffer : public Gb_Apu { MM_OPERATORS public: - Gb_Apu_Buffer(); - ~Gb_Apu_Buffer(); + Gb_Apu_Buffer() = default; + ~Gb_Apu_Buffer() = default; void end_frame(blip_time_t); diff --git a/plugins/GigPlayer/GigPlayer.cpp b/plugins/GigPlayer/GigPlayer.cpp index 81a571ac7..5a6f39cc6 100644 --- a/plugins/GigPlayer/GigPlayer.cpp +++ b/plugins/GigPlayer/GigPlayer.cpp @@ -988,13 +988,6 @@ GigInstrumentView::GigInstrumentView( Instrument * _instrument, QWidget * _paren -GigInstrumentView::~GigInstrumentView() -{ -} - - - - void GigInstrumentView::modelChanged() { GigInstrument * k = castModel(); diff --git a/plugins/GigPlayer/GigPlayer.h b/plugins/GigPlayer/GigPlayer.h index 5adeddc3e..20058424b 100644 --- a/plugins/GigPlayer/GigPlayer.h +++ b/plugins/GigPlayer/GigPlayer.h @@ -352,7 +352,7 @@ class GigInstrumentView : public InstrumentViewFixedSize public: GigInstrumentView( Instrument * _instrument, QWidget * _parent ); - ~GigInstrumentView() override; + ~GigInstrumentView() override = default; private: void modelChanged() override; diff --git a/plugins/GigPlayer/PatchesDialog.cpp b/plugins/GigPlayer/PatchesDialog.cpp index 3f7035c61..c78c99f2c 100644 --- a/plugins/GigPlayer/PatchesDialog.cpp +++ b/plugins/GigPlayer/PatchesDialog.cpp @@ -107,14 +107,6 @@ PatchesDialog::PatchesDialog( QWidget * pParent, Qt::WindowFlags wflags ) -// Destructor. -PatchesDialog::~PatchesDialog() -{ -} - - - - // Dialog setup loader. void PatchesDialog::setup( GigInstance * pSynth, int iChan, const QString & chanName, diff --git a/plugins/GigPlayer/PatchesDialog.h b/plugins/GigPlayer/PatchesDialog.h index 4912f2bc1..c4aed9102 100644 --- a/plugins/GigPlayer/PatchesDialog.h +++ b/plugins/GigPlayer/PatchesDialog.h @@ -50,7 +50,7 @@ public: PatchesDialog(QWidget * pParent = 0, Qt::WindowFlags wflags = QFlag(0)); // Destructor. - ~PatchesDialog() override; + ~PatchesDialog() override = default; void setup( GigInstance * pSynth, int iChan, const QString & chanName, diff --git a/plugins/HydrogenImport/HydrogenImport.cpp b/plugins/HydrogenImport/HydrogenImport.cpp index 657597471..2f3a27e1f 100644 --- a/plugins/HydrogenImport/HydrogenImport.cpp +++ b/plugins/HydrogenImport/HydrogenImport.cpp @@ -134,9 +134,6 @@ HydrogenImport::HydrogenImport( const QString & _file ) : -HydrogenImport::~HydrogenImport() -{ -} Instrument * ins; bool HydrogenImport::readSong() { diff --git a/plugins/HydrogenImport/HydrogenImport.h b/plugins/HydrogenImport/HydrogenImport.h index a9398d18f..de4709051 100644 --- a/plugins/HydrogenImport/HydrogenImport.h +++ b/plugins/HydrogenImport/HydrogenImport.h @@ -15,7 +15,7 @@ public: HydrogenImport( const QString & _file ); bool readSong(); - ~HydrogenImport() override; + ~HydrogenImport() override = default; gui::PluginView* instantiateView( QWidget * ) override { diff --git a/plugins/Kicker/Kicker.cpp b/plugins/Kicker/Kicker.cpp index 6a3c0823a..f9f781aed 100644 --- a/plugins/Kicker/Kicker.cpp +++ b/plugins/Kicker/Kicker.cpp @@ -85,13 +85,6 @@ KickerInstrument::KickerInstrument( InstrumentTrack * _instrument_track ) : -KickerInstrument::~KickerInstrument() -{ -} - - - - void KickerInstrument::saveSettings( QDomDocument & _doc, QDomElement & _this ) { @@ -342,13 +335,6 @@ KickerInstrumentView::KickerInstrumentView( Instrument * _instrument, -KickerInstrumentView::~KickerInstrumentView() -{ -} - - - - void KickerInstrumentView::modelChanged() { KickerInstrument * k = castModel(); diff --git a/plugins/Kicker/Kicker.h b/plugins/Kicker/Kicker.h index 10c77fe0f..22413c4db 100644 --- a/plugins/Kicker/Kicker.h +++ b/plugins/Kicker/Kicker.h @@ -54,7 +54,7 @@ class KickerInstrument : public Instrument Q_OBJECT public: KickerInstrument( InstrumentTrack * _instrument_track ); - ~KickerInstrument() override; + ~KickerInstrument() override = default; void playNote( NotePlayHandle * _n, sampleFrame * _working_buffer ) override; @@ -109,7 +109,7 @@ class KickerInstrumentView : public InstrumentViewFixedSize Q_OBJECT public: KickerInstrumentView( Instrument * _instrument, QWidget * _parent ); - ~KickerInstrumentView() override; + ~KickerInstrumentView() override = default; private: void modelChanged() override; diff --git a/plugins/Kicker/KickerOsc.h b/plugins/Kicker/KickerOsc.h index 3a263ffc8..1accb50a4 100644 --- a/plugins/Kicker/KickerOsc.h +++ b/plugins/Kicker/KickerOsc.h @@ -60,9 +60,7 @@ public: { } - virtual ~KickerOsc() - { - } + virtual ~KickerOsc() = default; void update( sampleFrame* buf, const fpp_t frames, const float sampleRate ) { diff --git a/plugins/LadspaBrowser/LadspaBrowser.cpp b/plugins/LadspaBrowser/LadspaBrowser.cpp index cd10b47fd..503aa7443 100644 --- a/plugins/LadspaBrowser/LadspaBrowser.cpp +++ b/plugins/LadspaBrowser/LadspaBrowser.cpp @@ -82,13 +82,6 @@ LadspaBrowser::LadspaBrowser() : -LadspaBrowser::~LadspaBrowser() -{ -} - - - - QString LadspaBrowser::nodeName() const { return ladspabrowser_plugin_descriptor.name; @@ -166,13 +159,6 @@ LadspaBrowserView::LadspaBrowserView( ToolPlugin * _tool ) : -LadspaBrowserView::~LadspaBrowserView() -{ -} - - - - QWidget * LadspaBrowserView::createTab( QWidget * _parent, const QString & _txt, LadspaPluginType _type ) { diff --git a/plugins/LadspaBrowser/LadspaBrowser.h b/plugins/LadspaBrowser/LadspaBrowser.h index 93533906e..faf1136dd 100644 --- a/plugins/LadspaBrowser/LadspaBrowser.h +++ b/plugins/LadspaBrowser/LadspaBrowser.h @@ -46,7 +46,7 @@ class LadspaBrowserView : public ToolPluginView Q_OBJECT public: LadspaBrowserView( ToolPlugin * _tool ); - ~LadspaBrowserView() override; + ~LadspaBrowserView() override = default; public slots: @@ -69,7 +69,7 @@ class LadspaBrowser : public ToolPlugin { public: LadspaBrowser(); - ~LadspaBrowser() override; + ~LadspaBrowser() override = default; gui::PluginView* instantiateView( QWidget * ) override { diff --git a/plugins/LadspaBrowser/LadspaDescription.cpp b/plugins/LadspaBrowser/LadspaDescription.cpp index 5b2364d6f..b94490e52 100644 --- a/plugins/LadspaBrowser/LadspaDescription.cpp +++ b/plugins/LadspaBrowser/LadspaDescription.cpp @@ -116,13 +116,6 @@ LadspaDescription::LadspaDescription( QWidget * _parent, -LadspaDescription::~LadspaDescription() -{ -} - - - - void LadspaDescription::update( const ladspa_key_t & _key ) { QWidget * description = new QWidget; diff --git a/plugins/LadspaBrowser/LadspaDescription.h b/plugins/LadspaBrowser/LadspaDescription.h index 1d2b03fac..14fcf7d62 100644 --- a/plugins/LadspaBrowser/LadspaDescription.h +++ b/plugins/LadspaBrowser/LadspaDescription.h @@ -44,7 +44,7 @@ class LadspaDescription : public QWidget Q_OBJECT public: LadspaDescription( QWidget * _parent, LadspaPluginType _type ); - ~LadspaDescription() override; + ~LadspaDescription() override = default; signals: diff --git a/plugins/LadspaBrowser/LadspaPortDialog.cpp b/plugins/LadspaBrowser/LadspaPortDialog.cpp index ab542ce00..12706ca89 100644 --- a/plugins/LadspaBrowser/LadspaPortDialog.cpp +++ b/plugins/LadspaBrowser/LadspaPortDialog.cpp @@ -168,9 +168,4 @@ LadspaPortDialog::LadspaPortDialog( const ladspa_key_t & _key ) -LadspaPortDialog::~LadspaPortDialog() -{ -} - - } // namespace lmms::gui \ No newline at end of file diff --git a/plugins/LadspaBrowser/LadspaPortDialog.h b/plugins/LadspaBrowser/LadspaPortDialog.h index 3f7d83df7..946531de8 100644 --- a/plugins/LadspaBrowser/LadspaPortDialog.h +++ b/plugins/LadspaBrowser/LadspaPortDialog.h @@ -40,7 +40,7 @@ class LadspaPortDialog : public QDialog Q_OBJECT public: LadspaPortDialog( const ladspa_key_t & _key ); - ~LadspaPortDialog() override; + ~LadspaPortDialog() override = default; }; diff --git a/plugins/LadspaEffect/LadspaControlDialog.cpp b/plugins/LadspaEffect/LadspaControlDialog.cpp index 199982bb0..5774fcc11 100644 --- a/plugins/LadspaEffect/LadspaControlDialog.cpp +++ b/plugins/LadspaEffect/LadspaControlDialog.cpp @@ -67,13 +67,6 @@ LadspaControlDialog::LadspaControlDialog( LadspaControls * _ctl ) : -LadspaControlDialog::~LadspaControlDialog() -{ -} - - - - void LadspaControlDialog::updateEffectView( LadspaControls * _ctl ) { QList list = findChildren(); diff --git a/plugins/LadspaEffect/LadspaControlDialog.h b/plugins/LadspaEffect/LadspaControlDialog.h index 25df5ee11..8b7adb3aa 100644 --- a/plugins/LadspaEffect/LadspaControlDialog.h +++ b/plugins/LadspaEffect/LadspaControlDialog.h @@ -50,7 +50,7 @@ class LadspaControlDialog : public EffectControlDialog Q_OBJECT public: LadspaControlDialog( LadspaControls * _ctl ); - ~LadspaControlDialog() override; + ~LadspaControlDialog() override = default; private slots: diff --git a/plugins/Lb302/Lb302.cpp b/plugins/Lb302/Lb302.cpp index 8ebfe2d47..3621e034c 100644 --- a/plugins/Lb302/Lb302.cpp +++ b/plugins/Lb302/Lb302.cpp @@ -1010,11 +1010,6 @@ Lb302SynthView::Lb302SynthView( Instrument * _instrument, QWidget * _parent ) : } -Lb302SynthView::~Lb302SynthView() -{ -} - - void Lb302SynthView::modelChanged() { Lb302Synth * syn = castModel(); diff --git a/plugins/Lb302/Lb302.h b/plugins/Lb302/Lb302.h index 57acb9ef3..3abece98f 100644 --- a/plugins/Lb302/Lb302.h +++ b/plugins/Lb302/Lb302.h @@ -71,7 +71,7 @@ class Lb302Filter { public: Lb302Filter(Lb302FilterKnobState* p_fs); - virtual ~Lb302Filter() {}; + virtual ~Lb302Filter() = default; virtual void recalc(); virtual void envRecalc(); @@ -277,7 +277,7 @@ class Lb302SynthView : public InstrumentViewFixedSize public: Lb302SynthView( Instrument * _instrument, QWidget * _parent ); - ~Lb302SynthView() override; + ~Lb302SynthView() override = default; private: void modelChanged() override; diff --git a/plugins/MidiExport/MidiExport.cpp b/plugins/MidiExport/MidiExport.cpp index 1fde83f06..23164276c 100644 --- a/plugins/MidiExport/MidiExport.cpp +++ b/plugins/MidiExport/MidiExport.cpp @@ -67,12 +67,6 @@ MidiExport::MidiExport() : ExportFilter( &midiexport_plugin_descriptor) -MidiExport::~MidiExport() -{ -} - - - bool MidiExport::tryExport(const TrackContainer::TrackList &tracks, const TrackContainer::TrackList &patternStoreTracks, int tempo, int masterPitch, const QString &filename) diff --git a/plugins/MidiExport/MidiExport.h b/plugins/MidiExport/MidiExport.h index ccbb370ca..29306b903 100644 --- a/plugins/MidiExport/MidiExport.h +++ b/plugins/MidiExport/MidiExport.h @@ -63,7 +63,7 @@ class MidiExport: public ExportFilter // Q_OBJECT public: MidiExport(); - ~MidiExport() override; + ~MidiExport() override = default; gui::PluginView* instantiateView(QWidget *) override { diff --git a/plugins/MidiImport/MidiImport.cpp b/plugins/MidiImport/MidiImport.cpp index 73ea4d8c2..282bfa03b 100644 --- a/plugins/MidiImport/MidiImport.cpp +++ b/plugins/MidiImport/MidiImport.cpp @@ -90,13 +90,6 @@ MidiImport::MidiImport( const QString & _file ) : -MidiImport::~MidiImport() -{ -} - - - - bool MidiImport::tryImport( TrackContainer* tc ) { if( openFile() == false ) diff --git a/plugins/MidiImport/MidiImport.h b/plugins/MidiImport/MidiImport.h index 0d7c0e99e..12cfb46ae 100644 --- a/plugins/MidiImport/MidiImport.h +++ b/plugins/MidiImport/MidiImport.h @@ -41,7 +41,7 @@ class MidiImport : public ImportFilter Q_OBJECT public: MidiImport( const QString & _file ); - ~MidiImport() override; + ~MidiImport() override = default; gui::PluginView* instantiateView( QWidget * ) override { diff --git a/plugins/MidiImport/portsmf/allegro.h b/plugins/MidiImport/portsmf/allegro.h index e21a8f817..ca5859aef 100644 --- a/plugins/MidiImport/portsmf/allegro.h +++ b/plugins/MidiImport/portsmf/allegro.h @@ -287,7 +287,7 @@ public: const char *GetDescription(); // computes a text description of this event // the result is in a static buffer, not thread-safe, just for debugging. Alg_event() { selected = false; } - virtual ~Alg_event() {} + virtual ~Alg_event() = default; } *Alg_event_ptr; @@ -306,7 +306,7 @@ public: typedef class Alg_update : public Alg_event { public: - ~Alg_update() override {}; + ~Alg_update() override = default; Alg_update(Alg_update *); // copy constructor Alg_parameter parameter; // an update contains one attr/value pair @@ -437,7 +437,7 @@ typedef class Alg_beat { public: Alg_beat(double t, double b) { time = t; beat = b; } - Alg_beat() {}; + Alg_beat() = default; double time; double beat; } *Alg_beat_ptr; @@ -535,7 +535,7 @@ class Serial_buffer { ptr = nullptr; len = 0; } - virtual ~Serial_buffer() { } + virtual ~Serial_buffer() = default; long get_posn() { return (long) (ptr - buffer); } long get_len() { return len; } @@ -548,7 +548,7 @@ public: // setting buffer, but it is not the Serial_read_buffer's responsibility // to delete the buffer (owner might want to reuse it), so the destructor // does nothing. - ~Serial_read_buffer() override { } + ~Serial_read_buffer() override = default; #if defined(_WIN32) //#pragma warning(disable: 546) // cast to int is OK, we only want low 7 bits //#pragma warning(disable: 4311) // type cast pointer to long warning diff --git a/plugins/MidiImport/portsmf/allegrosmfwr.cpp b/plugins/MidiImport/portsmf/allegrosmfwr.cpp index fefccf12d..eadb4c3ae 100644 --- a/plugins/MidiImport/portsmf/allegrosmfwr.cpp +++ b/plugins/MidiImport/portsmf/allegrosmfwr.cpp @@ -29,7 +29,7 @@ public: class Alg_smf_write { public: Alg_smf_write(Alg_seq_ptr seq); - ~Alg_smf_write(); + ~Alg_smf_write() = default; long channels_per_track; // used to encode track number into chan field // chan is actual_channel + channels_per_track * track_number // default is 100, set this to 0 to merge all tracks to 16 channels @@ -98,11 +98,6 @@ Alg_smf_write::Alg_smf_write(Alg_seq_ptr a_seq) } -Alg_smf_write::~Alg_smf_write() -{ -} - - // sorting is quite subtle due to rounding // For example, suppose times from a MIDI file are exact, but in // decimal round to TW0.4167 Q0.3333. Since the time in whole notes diff --git a/plugins/Monstro/Monstro.cpp b/plugins/Monstro/Monstro.cpp index d5ad851ee..b5fc5545f 100644 --- a/plugins/Monstro/Monstro.cpp +++ b/plugins/Monstro/Monstro.cpp @@ -111,11 +111,6 @@ MonstroSynth::MonstroSynth( MonstroInstrument * _i, NotePlayHandle * _nph ) : } -MonstroSynth::~MonstroSynth() -{ -} - - void MonstroSynth::renderOutput( fpp_t _frames, sampleFrame * _buf ) { float modtmp; // temp variable for freq modulation @@ -1029,11 +1024,6 @@ MonstroInstrument::MonstroInstrument( InstrumentTrack * _instrument_track ) : } -MonstroInstrument::~MonstroInstrument() -{ -} - - void MonstroInstrument::playNote( NotePlayHandle * _n, sampleFrame * _working_buffer ) { @@ -1490,11 +1480,6 @@ MonstroView::MonstroView( Instrument * _instrument, } -MonstroView::~MonstroView() -{ -} - - void MonstroView::updateLayout() { switch( m_selectedViewGroup->model()->value() ) diff --git a/plugins/Monstro/Monstro.h b/plugins/Monstro/Monstro.h index 52f607a32..319b7e000 100644 --- a/plugins/Monstro/Monstro.h +++ b/plugins/Monstro/Monstro.h @@ -176,7 +176,7 @@ class MonstroSynth MM_OPERATORS public: MonstroSynth( MonstroInstrument * _i, NotePlayHandle * _nph ); - virtual ~MonstroSynth(); + virtual ~MonstroSynth() = default; void renderOutput( fpp_t _frames, sampleFrame * _buf ); @@ -355,7 +355,7 @@ class MonstroInstrument : public Instrument public: MonstroInstrument( InstrumentTrack * _instrument_track ); - ~MonstroInstrument() override; + ~MonstroInstrument() override = default; void playNote( NotePlayHandle * _n, sampleFrame * _working_buffer ) override; @@ -593,7 +593,7 @@ class MonstroView : public InstrumentViewFixedSize public: MonstroView( Instrument * _instrument, QWidget * _parent ); - ~MonstroView() override; + ~MonstroView() override = default; protected slots: void updateLayout(); diff --git a/plugins/MultitapEcho/MultitapEchoControlDialog.h b/plugins/MultitapEcho/MultitapEchoControlDialog.h index 0989046c1..e016d1372 100644 --- a/plugins/MultitapEcho/MultitapEchoControlDialog.h +++ b/plugins/MultitapEcho/MultitapEchoControlDialog.h @@ -44,9 +44,7 @@ class MultitapEchoControlDialog : public EffectControlDialog Q_OBJECT public: MultitapEchoControlDialog( MultitapEchoControls * controls ); - ~MultitapEchoControlDialog() override - { - } + ~MultitapEchoControlDialog() override = default; }; diff --git a/plugins/MultitapEcho/MultitapEchoControls.cpp b/plugins/MultitapEcho/MultitapEchoControls.cpp index 4382151af..19564ba8a 100644 --- a/plugins/MultitapEcho/MultitapEchoControls.cpp +++ b/plugins/MultitapEcho/MultitapEchoControls.cpp @@ -58,11 +58,6 @@ MultitapEchoControls::MultitapEchoControls( MultitapEchoEffect * eff ) : } -MultitapEchoControls::~MultitapEchoControls() -{ -} - - void MultitapEchoControls::saveSettings( QDomDocument & doc, QDomElement & parent ) { m_steps.saveSettings( doc, parent, "steps" ); diff --git a/plugins/MultitapEcho/MultitapEchoControls.h b/plugins/MultitapEcho/MultitapEchoControls.h index 7ded68cc8..bd345bfe5 100644 --- a/plugins/MultitapEcho/MultitapEchoControls.h +++ b/plugins/MultitapEcho/MultitapEchoControls.h @@ -41,7 +41,7 @@ class MultitapEchoControls : public EffectControls Q_OBJECT public: MultitapEchoControls( MultitapEchoEffect * eff ); - ~MultitapEchoControls() override; + ~MultitapEchoControls() override = default; void saveSettings( QDomDocument & doc, QDomElement & parent ) override; void loadSettings( const QDomElement & elem ) override; diff --git a/plugins/Nes/Nes.cpp b/plugins/Nes/Nes.cpp index f3537d88c..4e5fdc59a 100644 --- a/plugins/Nes/Nes.cpp +++ b/plugins/Nes/Nes.cpp @@ -103,11 +103,6 @@ NesObject::NesObject( NesInstrument * nes, const sample_rate_t samplerate, NoteP } -NesObject::~NesObject() -{ -} - - void NesObject::renderOutput( sampleFrame * buf, fpp_t frames ) { //////////////////////////////// @@ -551,11 +546,6 @@ NesInstrument::NesInstrument( InstrumentTrack * instrumentTrack ) : -NesInstrument::~NesInstrument() -{ -} - - void NesInstrument::playNote( NotePlayHandle * n, sampleFrame * workingBuffer ) { const fpp_t frames = n->framesLeftForCurrentPeriod(); @@ -854,11 +844,6 @@ NesInstrumentView::NesInstrumentView( Instrument * instrument, QWidget * parent -NesInstrumentView::~NesInstrumentView() -{ -} - - void NesInstrumentView::modelChanged() { NesInstrument * nes = castModel(); diff --git a/plugins/Nes/Nes.h b/plugins/Nes/Nes.h index 41e7b0d7f..91e5e556c 100644 --- a/plugins/Nes/Nes.h +++ b/plugins/Nes/Nes.h @@ -95,7 +95,7 @@ class NesObject MM_OPERATORS public: NesObject( NesInstrument * nes, const sample_rate_t samplerate, NotePlayHandle * nph ); - virtual ~NesObject(); + virtual ~NesObject() = default; void renderOutput( sampleFrame * buf, fpp_t frames ); void updateVibrato( float * freq ); @@ -211,7 +211,7 @@ class NesInstrument : public Instrument Q_OBJECT public: NesInstrument( InstrumentTrack * instrumentTrack ); - ~NesInstrument() override; + ~NesInstrument() override = default; void playNote( NotePlayHandle * n, sampleFrame * workingBuffer ) override; @@ -313,7 +313,7 @@ class NesInstrumentView : public InstrumentViewFixedSize public: NesInstrumentView( Instrument * instrument, QWidget * parent ); - ~NesInstrumentView() override; + ~NesInstrumentView() override = default; private: void modelChanged() override; diff --git a/plugins/Organic/Organic.cpp b/plugins/Organic/Organic.cpp index 6271f6c40..c22a12168 100644 --- a/plugins/Organic/Organic.cpp +++ b/plugins/Organic/Organic.cpp @@ -583,13 +583,6 @@ OscillatorObject::OscillatorObject( Model * _parent, int _index ) : -OscillatorObject::~OscillatorObject() -{ -} - - - - void OscillatorObject::oscButtonChanged() { diff --git a/plugins/Organic/Organic.h b/plugins/Organic/Organic.h index bc951ad49..057a4a5b4 100644 --- a/plugins/Organic/Organic.h +++ b/plugins/Organic/Organic.h @@ -105,7 +105,7 @@ private: float m_phaseOffsetRight; OscillatorObject( Model * _parent, int _index ); - ~OscillatorObject() override; + ~OscillatorObject() override = default; friend class OrganicInstrument; friend class gui::OrganicInstrumentView; @@ -211,9 +211,7 @@ private: m_detuneKnob( dt ) { } - OscillatorKnobs() - { - } + OscillatorKnobs() = default; Knob * m_harmKnob; Knob * m_volKnob; diff --git a/plugins/Patman/Patman.cpp b/plugins/Patman/Patman.cpp index 32e8372eb..8b502e93d 100644 --- a/plugins/Patman/Patman.cpp +++ b/plugins/Patman/Patman.cpp @@ -495,13 +495,6 @@ PatmanView::PatmanView( Instrument * _instrument, QWidget * _parent ) : -PatmanView::~PatmanView() -{ -} - - - - void PatmanView::openFile() { FileDialog ofd( nullptr, tr( "Open patch file" ) ); diff --git a/plugins/Patman/Patman.h b/plugins/Patman/Patman.h index 60276f5aa..89f7f7250 100644 --- a/plugins/Patman/Patman.h +++ b/plugins/Patman/Patman.h @@ -131,7 +131,7 @@ class PatmanView : public InstrumentViewFixedSize Q_OBJECT public: PatmanView( Instrument * _instrument, QWidget * _parent ); - ~PatmanView() override; + ~PatmanView() override = default; public slots: diff --git a/plugins/PeakControllerEffect/PeakControllerEffectControlDialog.h b/plugins/PeakControllerEffect/PeakControllerEffectControlDialog.h index 7ccb4a14c..9f5f45223 100644 --- a/plugins/PeakControllerEffect/PeakControllerEffectControlDialog.h +++ b/plugins/PeakControllerEffect/PeakControllerEffectControlDialog.h @@ -45,9 +45,7 @@ class PeakControllerEffectControlDialog : public EffectControlDialog public: PeakControllerEffectControlDialog( PeakControllerEffectControls * _controls ); - ~PeakControllerEffectControlDialog() override - { - } + ~PeakControllerEffectControlDialog() override = default; protected: diff --git a/plugins/PeakControllerEffect/PeakControllerEffectControls.h b/plugins/PeakControllerEffect/PeakControllerEffectControls.h index 6eb3dad44..3bd96b3f9 100644 --- a/plugins/PeakControllerEffect/PeakControllerEffectControls.h +++ b/plugins/PeakControllerEffect/PeakControllerEffectControls.h @@ -41,9 +41,7 @@ class PeakControllerEffectControls : public EffectControls Q_OBJECT public: PeakControllerEffectControls( PeakControllerEffect * _eff ); - ~PeakControllerEffectControls() override - { - } + ~PeakControllerEffectControls() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override; void loadSettings( const QDomElement & _this ) override; diff --git a/plugins/ReverbSC/ReverbSCControlDialog.h b/plugins/ReverbSC/ReverbSCControlDialog.h index 0c02d7865..0abc96896 100644 --- a/plugins/ReverbSC/ReverbSCControlDialog.h +++ b/plugins/ReverbSC/ReverbSCControlDialog.h @@ -42,9 +42,7 @@ class ReverbSCControlDialog : public EffectControlDialog Q_OBJECT public: ReverbSCControlDialog( ReverbSCControls* controls ); - ~ReverbSCControlDialog() override - { - } + ~ReverbSCControlDialog() override = default; } ; diff --git a/plugins/ReverbSC/ReverbSCControls.h b/plugins/ReverbSC/ReverbSCControls.h index b58254dcf..93f974a21 100644 --- a/plugins/ReverbSC/ReverbSCControls.h +++ b/plugins/ReverbSC/ReverbSCControls.h @@ -40,9 +40,7 @@ class ReverbSCControls : public EffectControls Q_OBJECT public: ReverbSCControls( ReverbSCEffect* effect ); - ~ReverbSCControls() override - { - } + ~ReverbSCControls() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override; void loadSettings( const QDomElement & _this ) override; diff --git a/plugins/Sf2Player/PatchesDialog.cpp b/plugins/Sf2Player/PatchesDialog.cpp index 082a15c04..9c9a689a0 100644 --- a/plugins/Sf2Player/PatchesDialog.cpp +++ b/plugins/Sf2Player/PatchesDialog.cpp @@ -111,12 +111,6 @@ PatchesDialog::PatchesDialog( QWidget *pParent, Qt::WindowFlags wflags ) } -// Destructor. -PatchesDialog::~PatchesDialog() -{ -} - - // Dialog setup loader. void PatchesDialog::setup ( fluid_synth_t * pSynth, int iChan, const QString & _chanName, diff --git a/plugins/Sf2Player/PatchesDialog.h b/plugins/Sf2Player/PatchesDialog.h index af1207ce1..5309ce0bf 100644 --- a/plugins/Sf2Player/PatchesDialog.h +++ b/plugins/Sf2Player/PatchesDialog.h @@ -50,7 +50,7 @@ public: PatchesDialog(QWidget *pParent = 0, Qt::WindowFlags wflags = QFlag(0)); // Destructor. - ~PatchesDialog() override; + ~PatchesDialog() override = default; void setup(fluid_synth_t *pSynth, int iChan, const QString & _chanName, diff --git a/plugins/Sf2Player/Sf2Player.cpp b/plugins/Sf2Player/Sf2Player.cpp index 291f7fb76..dae94a332 100644 --- a/plugins/Sf2Player/Sf2Player.cpp +++ b/plugins/Sf2Player/Sf2Player.cpp @@ -1055,13 +1055,6 @@ Sf2InstrumentView::Sf2InstrumentView( Instrument * _instrument, QWidget * _paren -Sf2InstrumentView::~Sf2InstrumentView() -{ -} - - - - void Sf2InstrumentView::modelChanged() { Sf2Instrument * k = castModel(); diff --git a/plugins/Sf2Player/Sf2Player.h b/plugins/Sf2Player/Sf2Player.h index 1ce6d0fdd..275d7494c 100644 --- a/plugins/Sf2Player/Sf2Player.h +++ b/plugins/Sf2Player/Sf2Player.h @@ -203,7 +203,7 @@ class Sf2InstrumentView : public InstrumentViewFixedSize public: Sf2InstrumentView( Instrument * _instrument, QWidget * _parent ); - ~Sf2InstrumentView() override; + ~Sf2InstrumentView() override = default; private: void modelChanged() override; diff --git a/plugins/Sfxr/Sfxr.cpp b/plugins/Sfxr/Sfxr.cpp index a8bb81219..605416520 100644 --- a/plugins/Sfxr/Sfxr.cpp +++ b/plugins/Sfxr/Sfxr.cpp @@ -88,14 +88,6 @@ SfxrSynth::SfxrSynth( const SfxrInstrument * s ): -SfxrSynth::~SfxrSynth() -{ - -} - - - - void SfxrSynth::resetSample( bool restart ) { if(!restart) @@ -362,13 +354,6 @@ SfxrInstrument::SfxrInstrument( InstrumentTrack * _instrument_track ) : -SfxrInstrument::~SfxrInstrument() -{ -} - - - - void SfxrInstrument::saveSettings( QDomDocument & _doc, QDomElement & _this ) { _this.setAttribute( "version", "1" ); diff --git a/plugins/Sfxr/Sfxr.h b/plugins/Sfxr/Sfxr.h index 6aafe9961..2011062d1 100644 --- a/plugins/Sfxr/Sfxr.h +++ b/plugins/Sfxr/Sfxr.h @@ -80,7 +80,7 @@ class SfxrSynth MM_OPERATORS public: SfxrSynth( const SfxrInstrument * s ); - virtual ~SfxrSynth(); + virtual ~SfxrSynth() = default; void resetSample( bool restart ); void update( sampleFrame * buffer, const int32_t frameNum ); @@ -176,7 +176,7 @@ class SfxrInstrument : public Instrument Q_OBJECT public: SfxrInstrument(InstrumentTrack * _instrument_track ); - ~SfxrInstrument() override; + ~SfxrInstrument() override = default; void playNote( NotePlayHandle * _n, sampleFrame * _working_buffer ) override; void deleteNotePluginData( NotePlayHandle * _n ) override; @@ -240,7 +240,7 @@ public: SfxrInstrumentView( Instrument * _instrument, QWidget * _parent ); - ~SfxrInstrumentView() override {}; + ~SfxrInstrumentView() override = default; protected slots: void genPickup(); diff --git a/plugins/Sid/SidInstrument.cpp b/plugins/Sid/SidInstrument.cpp index e075ed049..16710f4f9 100644 --- a/plugins/Sid/SidInstrument.cpp +++ b/plugins/Sid/SidInstrument.cpp @@ -116,11 +116,6 @@ VoiceObject::VoiceObject( Model * _parent, int _idx ) : } -VoiceObject::~VoiceObject() -{ -} - - SidInstrument::SidInstrument( InstrumentTrack * _instrument_track ) : Instrument( _instrument_track, &sid_plugin_descriptor ), // filter @@ -140,11 +135,6 @@ SidInstrument::SidInstrument( InstrumentTrack * _instrument_track ) : } -SidInstrument::~SidInstrument() -{ -} - - void SidInstrument::saveSettings( QDomDocument & _doc, QDomElement & _this ) { @@ -662,10 +652,6 @@ SidInstrumentView::SidInstrumentView( Instrument * _instrument, } -SidInstrumentView::~SidInstrumentView() -{ -} - void SidInstrumentView::updateKnobHint() { SidInstrument * k = castModel(); diff --git a/plugins/Sid/SidInstrument.h b/plugins/Sid/SidInstrument.h index 1c8fecc95..203e52e7b 100644 --- a/plugins/Sid/SidInstrument.h +++ b/plugins/Sid/SidInstrument.h @@ -58,7 +58,7 @@ public: NumWaveShapes }; VoiceObject( Model * _parent, int _idx ); - ~VoiceObject() override; + ~VoiceObject() override = default; private: @@ -97,7 +97,7 @@ public: SidInstrument( InstrumentTrack * _instrument_track ); - ~SidInstrument() override; + ~SidInstrument() override = default; void playNote( NotePlayHandle * _n, sampleFrame * _working_buffer ) override; @@ -147,7 +147,7 @@ class SidInstrumentView : public InstrumentViewFixedSize Q_OBJECT public: SidInstrumentView( Instrument * _instrument, QWidget * _parent ); - ~SidInstrumentView() override; + ~SidInstrumentView() override = default; private: void modelChanged() override; @@ -181,9 +181,7 @@ private: m_testButton( testb ) { } - voiceKnobs() - { - } + voiceKnobs() = default; Knob * m_attKnob; Knob * m_decKnob; Knob * m_sustKnob; diff --git a/plugins/SpectrumAnalyzer/SaControls.h b/plugins/SpectrumAnalyzer/SaControls.h index b2fc1cc87..48d8ee96e 100644 --- a/plugins/SpectrumAnalyzer/SaControls.h +++ b/plugins/SpectrumAnalyzer/SaControls.h @@ -49,7 +49,7 @@ class SaControls : public EffectControls Q_OBJECT public: explicit SaControls(Analyzer* effect); - ~SaControls() override {} + ~SaControls() override = default; gui::EffectControlDialog* createView() override; diff --git a/plugins/SpectrumAnalyzer/SaControlsDialog.h b/plugins/SpectrumAnalyzer/SaControlsDialog.h index ac28be4bf..83e12c1bf 100644 --- a/plugins/SpectrumAnalyzer/SaControlsDialog.h +++ b/plugins/SpectrumAnalyzer/SaControlsDialog.h @@ -47,7 +47,7 @@ class SaControlsDialog : public EffectControlDialog Q_OBJECT public: explicit SaControlsDialog(SaControls *controls, SaProcessor *processor); - ~SaControlsDialog() override {} + ~SaControlsDialog() override = default; bool isResizable() const override {return true;} QSize sizeHint() const override; diff --git a/plugins/SpectrumAnalyzer/SaSpectrumView.h b/plugins/SpectrumAnalyzer/SaSpectrumView.h index d50c893e5..e9bb47b1d 100644 --- a/plugins/SpectrumAnalyzer/SaSpectrumView.h +++ b/plugins/SpectrumAnalyzer/SaSpectrumView.h @@ -54,7 +54,7 @@ class SaSpectrumView : public QWidget Q_OBJECT public: explicit SaSpectrumView(SaControls *controls, SaProcessor *processor, QWidget *_parent = 0); - ~SaSpectrumView() override {} + ~SaSpectrumView() override = default; QSize sizeHint() const override {return QSize(400, 200);} diff --git a/plugins/SpectrumAnalyzer/SaWaterfallView.h b/plugins/SpectrumAnalyzer/SaWaterfallView.h index 2855eb925..5de00d7ad 100644 --- a/plugins/SpectrumAnalyzer/SaWaterfallView.h +++ b/plugins/SpectrumAnalyzer/SaWaterfallView.h @@ -49,7 +49,7 @@ class SaWaterfallView : public QWidget Q_OBJECT public: explicit SaWaterfallView(SaControls *controls, SaProcessor *processor, QWidget *_parent = 0); - ~SaWaterfallView() override {} + ~SaWaterfallView() override = default; QSize sizeHint() const override {return QSize(400, 350);} diff --git a/plugins/StereoEnhancer/StereoEnhancerControlDialog.h b/plugins/StereoEnhancer/StereoEnhancerControlDialog.h index 3f063ec63..459b1fa69 100644 --- a/plugins/StereoEnhancer/StereoEnhancerControlDialog.h +++ b/plugins/StereoEnhancer/StereoEnhancerControlDialog.h @@ -42,9 +42,7 @@ class StereoEnhancerControlDialog : public EffectControlDialog Q_OBJECT public: StereoEnhancerControlDialog( StereoEnhancerControls * _controls ); - ~StereoEnhancerControlDialog() override - { - } + ~StereoEnhancerControlDialog() override = default; }; diff --git a/plugins/StereoEnhancer/StereoEnhancerControls.h b/plugins/StereoEnhancer/StereoEnhancerControls.h index 0b016aa2b..dea356fdb 100644 --- a/plugins/StereoEnhancer/StereoEnhancerControls.h +++ b/plugins/StereoEnhancer/StereoEnhancerControls.h @@ -39,9 +39,7 @@ class StereoEnhancerControls : public EffectControls Q_OBJECT public: StereoEnhancerControls( StereoEnhancerEffect( * _eff ) ); - ~StereoEnhancerControls() override - { - } + ~StereoEnhancerControls() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override; void loadSettings( const QDomElement & _this ) override; diff --git a/plugins/StereoMatrix/StereoMatrix.cpp b/plugins/StereoMatrix/StereoMatrix.cpp index 34b2fc86b..2dff69b77 100644 --- a/plugins/StereoMatrix/StereoMatrix.cpp +++ b/plugins/StereoMatrix/StereoMatrix.cpp @@ -64,12 +64,6 @@ StereoMatrixEffect::StereoMatrixEffect( -StereoMatrixEffect::~StereoMatrixEffect() -{ -} - - - bool StereoMatrixEffect::processAudioBuffer( sampleFrame * _buf, const fpp_t _frames ) { diff --git a/plugins/StereoMatrix/StereoMatrix.h b/plugins/StereoMatrix/StereoMatrix.h index a8a373317..ae7a59724 100644 --- a/plugins/StereoMatrix/StereoMatrix.h +++ b/plugins/StereoMatrix/StereoMatrix.h @@ -38,7 +38,7 @@ class StereoMatrixEffect : public Effect public: StereoMatrixEffect( Model * parent, const Descriptor::SubPluginFeatures::Key * _key ); - ~StereoMatrixEffect() override; + ~StereoMatrixEffect() override = default; bool processAudioBuffer( sampleFrame * _buf, const fpp_t _frames ) override; diff --git a/plugins/StereoMatrix/StereoMatrixControlDialog.h b/plugins/StereoMatrix/StereoMatrixControlDialog.h index 41eb9cdb4..56592aa12 100644 --- a/plugins/StereoMatrix/StereoMatrixControlDialog.h +++ b/plugins/StereoMatrix/StereoMatrixControlDialog.h @@ -41,9 +41,7 @@ class StereoMatrixControlDialog : public EffectControlDialog Q_OBJECT public: StereoMatrixControlDialog( StereoMatrixControls * _controls ); - ~StereoMatrixControlDialog() override - { - } + ~StereoMatrixControlDialog() override = default; }; diff --git a/plugins/StereoMatrix/StereoMatrixControls.h b/plugins/StereoMatrix/StereoMatrixControls.h index 04a10f237..5eb506d16 100644 --- a/plugins/StereoMatrix/StereoMatrixControls.h +++ b/plugins/StereoMatrix/StereoMatrixControls.h @@ -39,9 +39,7 @@ class StereoMatrixControls : public EffectControls Q_OBJECT public: StereoMatrixControls( StereoMatrixEffect( * _eff ) ); - ~StereoMatrixControls() override - { - } + ~StereoMatrixControls() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override; void loadSettings( const QDomElement & _this ) override; diff --git a/plugins/Stk/Mallets/Mallets.cpp b/plugins/Stk/Mallets/Mallets.cpp index 4adfb5347..6dcd8f563 100644 --- a/plugins/Stk/Mallets/Mallets.cpp +++ b/plugins/Stk/Mallets/Mallets.cpp @@ -130,13 +130,6 @@ MalletsInstrument::MalletsInstrument( InstrumentTrack * _instrument_track ): -MalletsInstrument::~MalletsInstrument() -{ -} - - - - void MalletsInstrument::saveSettings( QDomDocument & _doc, QDomElement & _this ) { // ModalBar @@ -435,12 +428,6 @@ MalletsInstrumentView::MalletsInstrumentView( MalletsInstrument * _instrument, -MalletsInstrumentView::~MalletsInstrumentView() -{ -} - - - void MalletsInstrumentView::setWidgetBackground( QWidget * _widget, const QString & _pic ) { _widget->setAutoFillBackground( true ); diff --git a/plugins/Stk/Mallets/Mallets.h b/plugins/Stk/Mallets/Mallets.h index e8ec15360..4d5aed288 100644 --- a/plugins/Stk/Mallets/Mallets.h +++ b/plugins/Stk/Mallets/Mallets.h @@ -160,7 +160,7 @@ class MalletsInstrument : public Instrument Q_OBJECT public: MalletsInstrument( InstrumentTrack * _instrument_track ); - ~MalletsInstrument() override; + ~MalletsInstrument() override = default; void playNote( NotePlayHandle * _n, sampleFrame * _working_buffer ) override; @@ -219,7 +219,7 @@ class MalletsInstrumentView: public InstrumentViewFixedSize public: MalletsInstrumentView( MalletsInstrument * _instrument, QWidget * _parent ); - ~MalletsInstrumentView() override; + ~MalletsInstrumentView() override = default; public slots: void changePreset(); diff --git a/plugins/TripleOscillator/TripleOscillator.cpp b/plugins/TripleOscillator/TripleOscillator.cpp index f19754019..5a3a6d1dc 100644 --- a/plugins/TripleOscillator/TripleOscillator.cpp +++ b/plugins/TripleOscillator/TripleOscillator.cpp @@ -238,13 +238,6 @@ TripleOscillator::TripleOscillator( InstrumentTrack * _instrument_track ) : -TripleOscillator::~TripleOscillator() -{ -} - - - - void TripleOscillator::saveSettings( QDomDocument & _doc, QDomElement & _this ) { for( int i = 0; i < NUM_OF_OSCILLATORS; ++i ) @@ -714,13 +707,6 @@ TripleOscillatorView::TripleOscillatorView( Instrument * _instrument, -TripleOscillatorView::~TripleOscillatorView() -{ -} - - - - void TripleOscillatorView::modelChanged() { TripleOscillator * t = castModel(); diff --git a/plugins/TripleOscillator/TripleOscillator.h b/plugins/TripleOscillator/TripleOscillator.h index 0cb0e69a0..f3290153b 100644 --- a/plugins/TripleOscillator/TripleOscillator.h +++ b/plugins/TripleOscillator/TripleOscillator.h @@ -108,7 +108,7 @@ class TripleOscillator : public Instrument Q_OBJECT public: TripleOscillator( InstrumentTrack * _track ); - ~TripleOscillator() override; + ~TripleOscillator() override = default; void playNote( NotePlayHandle * _n, sampleFrame * _working_buffer ) override; @@ -157,7 +157,7 @@ class TripleOscillatorView : public InstrumentViewFixedSize Q_OBJECT public: TripleOscillatorView( Instrument * _instrument, QWidget * _parent ); - ~TripleOscillatorView() override; + ~TripleOscillatorView() override = default; private: @@ -191,9 +191,7 @@ private: m_multiBandWaveTableButton( wt ) { } - OscillatorKnobs() - { - } + OscillatorKnobs() = default; Knob * m_volKnob; Knob * m_panKnob; Knob * m_coarseKnob; diff --git a/plugins/Vectorscope/VecControls.h b/plugins/Vectorscope/VecControls.h index 76b0f388e..71b1c122e 100644 --- a/plugins/Vectorscope/VecControls.h +++ b/plugins/Vectorscope/VecControls.h @@ -47,7 +47,7 @@ class VecControls : public EffectControls Q_OBJECT public: explicit VecControls(Vectorscope *effect); - ~VecControls() override {} + ~VecControls() override = default; gui::EffectControlDialog* createView() override; diff --git a/plugins/Vectorscope/VecControlsDialog.h b/plugins/Vectorscope/VecControlsDialog.h index 616e55b44..8fee75b4b 100644 --- a/plugins/Vectorscope/VecControlsDialog.h +++ b/plugins/Vectorscope/VecControlsDialog.h @@ -43,7 +43,7 @@ class VecControlsDialog : public EffectControlDialog Q_OBJECT public: explicit VecControlsDialog(VecControls *controls); - ~VecControlsDialog() override {} + ~VecControlsDialog() override = default; bool isResizable() const override {return true;} QSize sizeHint() const override; diff --git a/plugins/Vectorscope/VectorView.h b/plugins/Vectorscope/VectorView.h index 347aa8a18..59ac99a77 100644 --- a/plugins/Vectorscope/VectorView.h +++ b/plugins/Vectorscope/VectorView.h @@ -44,7 +44,7 @@ class VectorView : public QWidget Q_OBJECT public: explicit VectorView(VecControls *controls, LocklessRingBuffer *inputBuffer, unsigned short displaySize, QWidget *parent = 0); - ~VectorView() override {} + ~VectorView() override = default; QSize sizeHint() const override {return QSize(300, 300);} diff --git a/plugins/Vectorscope/Vectorscope.h b/plugins/Vectorscope/Vectorscope.h index e3e92b205..54022ab90 100644 --- a/plugins/Vectorscope/Vectorscope.h +++ b/plugins/Vectorscope/Vectorscope.h @@ -37,7 +37,7 @@ class Vectorscope : public Effect { public: Vectorscope(Model *parent, const Descriptor::SubPluginFeatures::Key *key); - ~Vectorscope() override {}; + ~Vectorscope() override = default; bool processAudioBuffer(sampleFrame *buffer, const fpp_t frame_count) override; EffectControls *controls() override {return &m_controls;} diff --git a/plugins/Vestige/Vestige.cpp b/plugins/Vestige/Vestige.cpp index 30bef7141..7441370ec 100644 --- a/plugins/Vestige/Vestige.cpp +++ b/plugins/Vestige/Vestige.cpp @@ -103,9 +103,7 @@ public: setWindowFlags( Qt::WindowCloseButtonHint ); } - ~vstSubWin() override - { - } + ~vstSubWin() override = default; void closeEvent( QCloseEvent * e ) override { @@ -671,13 +669,6 @@ void VestigeInstrumentView::updateMenu( void ) } -VestigeInstrumentView::~VestigeInstrumentView() -{ -} - - - - void VestigeInstrumentView::modelChanged() { m_vi = castModel(); diff --git a/plugins/Vestige/Vestige.h b/plugins/Vestige/Vestige.h index 706e77b00..0a36c4924 100644 --- a/plugins/Vestige/Vestige.h +++ b/plugins/Vestige/Vestige.h @@ -150,7 +150,7 @@ class VestigeInstrumentView : public InstrumentViewFixedSize Q_OBJECT public: VestigeInstrumentView( Instrument * _instrument, QWidget * _parent ); - virtual ~VestigeInstrumentView(); + virtual ~VestigeInstrumentView() = default; protected slots: diff --git a/plugins/Vibed/Vibed.h b/plugins/Vibed/Vibed.h index c6fdee385..75f92157c 100644 --- a/plugins/Vibed/Vibed.h +++ b/plugins/Vibed/Vibed.h @@ -97,7 +97,7 @@ class VibedView : public InstrumentViewFixedSize public: VibedView( Instrument * _instrument, QWidget * _parent ); - ~VibedView() override {}; + ~VibedView() override = default; public slots: void showString( int _string ); diff --git a/plugins/VstEffect/VstEffect.cpp b/plugins/VstEffect/VstEffect.cpp index eee3919c4..c3e40cfa7 100644 --- a/plugins/VstEffect/VstEffect.cpp +++ b/plugins/VstEffect/VstEffect.cpp @@ -76,13 +76,6 @@ VstEffect::VstEffect( Model * _parent, -VstEffect::~VstEffect() -{ -} - - - - bool VstEffect::processAudioBuffer( sampleFrame * _buf, const fpp_t _frames ) { if( !isEnabled() || !isRunning () ) diff --git a/plugins/VstEffect/VstEffect.h b/plugins/VstEffect/VstEffect.h index 586d00d3b..987b1ecc2 100644 --- a/plugins/VstEffect/VstEffect.h +++ b/plugins/VstEffect/VstEffect.h @@ -43,7 +43,7 @@ class VstEffect : public Effect public: VstEffect( Model * _parent, const Descriptor::SubPluginFeatures::Key * _key ); - ~VstEffect() override; + ~VstEffect() override = default; bool processAudioBuffer( sampleFrame * _buf, const fpp_t _frames ) override; diff --git a/plugins/Watsyn/Watsyn.cpp b/plugins/Watsyn/Watsyn.cpp index 1c363d417..58f472edc 100644 --- a/plugins/Watsyn/Watsyn.cpp +++ b/plugins/Watsyn/Watsyn.cpp @@ -326,11 +326,6 @@ WatsynInstrument::WatsynInstrument( InstrumentTrack * _instrument_track ) : } -WatsynInstrument::~WatsynInstrument() -{ -} - - void WatsynInstrument::playNote( NotePlayHandle * _n, sampleFrame * _working_buffer ) { @@ -947,12 +942,6 @@ WatsynView::WatsynView( Instrument * _instrument, } -WatsynView::~WatsynView() -{ -} - - - void WatsynView::updateLayout() { switch( m_selectedGraphGroup->model()->value() ) diff --git a/plugins/Watsyn/Watsyn.h b/plugins/Watsyn/Watsyn.h index cee2d807b..3c69be06f 100644 --- a/plugins/Watsyn/Watsyn.h +++ b/plugins/Watsyn/Watsyn.h @@ -139,7 +139,7 @@ class WatsynInstrument : public Instrument Q_OBJECT public: WatsynInstrument( InstrumentTrack * _instrument_track ); - ~WatsynInstrument() override; + ~WatsynInstrument() override = default; void playNote( NotePlayHandle * _n, sampleFrame * _working_buffer ) override; @@ -310,7 +310,7 @@ class WatsynView : public InstrumentViewFixedSize public: WatsynView( Instrument * _instrument, QWidget * _parent ); - ~WatsynView() override; + ~WatsynView() override = default; protected slots: void updateLayout(); diff --git a/plugins/WaveShaper/WaveShaper.cpp b/plugins/WaveShaper/WaveShaper.cpp index 7f0cf732f..edbcb0ad8 100644 --- a/plugins/WaveShaper/WaveShaper.cpp +++ b/plugins/WaveShaper/WaveShaper.cpp @@ -66,13 +66,6 @@ WaveShaperEffect::WaveShaperEffect( Model * _parent, -WaveShaperEffect::~WaveShaperEffect() -{ -} - - - - bool WaveShaperEffect::processAudioBuffer( sampleFrame * _buf, const fpp_t _frames ) { diff --git a/plugins/WaveShaper/WaveShaper.h b/plugins/WaveShaper/WaveShaper.h index 075c0ec6b..4c63d5806 100644 --- a/plugins/WaveShaper/WaveShaper.h +++ b/plugins/WaveShaper/WaveShaper.h @@ -39,7 +39,7 @@ class WaveShaperEffect : public Effect public: WaveShaperEffect( Model * _parent, const Descriptor::SubPluginFeatures::Key * _key ); - ~WaveShaperEffect() override; + ~WaveShaperEffect() override = default; bool processAudioBuffer( sampleFrame * _buf, const fpp_t _frames ) override; diff --git a/plugins/WaveShaper/WaveShaperControlDialog.h b/plugins/WaveShaper/WaveShaperControlDialog.h index be3838f46..e76dcfccc 100644 --- a/plugins/WaveShaper/WaveShaperControlDialog.h +++ b/plugins/WaveShaper/WaveShaperControlDialog.h @@ -42,9 +42,7 @@ class WaveShaperControlDialog : public EffectControlDialog Q_OBJECT public: WaveShaperControlDialog( WaveShaperControls * _controls ); - ~WaveShaperControlDialog() override - { - } + ~WaveShaperControlDialog() override = default; private: diff --git a/plugins/WaveShaper/WaveShaperControls.h b/plugins/WaveShaper/WaveShaperControls.h index 2719514f5..9473aae5d 100644 --- a/plugins/WaveShaper/WaveShaperControls.h +++ b/plugins/WaveShaper/WaveShaperControls.h @@ -42,9 +42,7 @@ class WaveShaperControls : public EffectControls Q_OBJECT public: WaveShaperControls( WaveShaperEffect * _eff ); - ~WaveShaperControls() override - { - } + ~WaveShaperControls() override = default; void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override; void loadSettings( const QDomElement & _this ) override; diff --git a/src/common/SharedMemory.cpp b/src/common/SharedMemory.cpp index 5c944dfab..005e726ed 100644 --- a/src/common/SharedMemory.cpp +++ b/src/common/SharedMemory.cpp @@ -177,8 +177,7 @@ private: #endif -SharedMemoryData::SharedMemoryData() noexcept -{ } +SharedMemoryData::SharedMemoryData() noexcept = default; SharedMemoryData::SharedMemoryData(std::string&& key, bool readOnly) : m_key{std::move(key)}, @@ -192,7 +191,7 @@ SharedMemoryData::SharedMemoryData(std::string&& key, std::size_t size, bool rea m_ptr{m_impl->get()} { } -SharedMemoryData::~SharedMemoryData() { } +SharedMemoryData::~SharedMemoryData() = default; SharedMemoryData::SharedMemoryData(SharedMemoryData&& other) noexcept : m_key{std::move(other.m_key)}, diff --git a/src/core/AudioEngineProfiler.cpp b/src/core/AudioEngineProfiler.cpp index 24c4dc5ae..5fd5a813c 100644 --- a/src/core/AudioEngineProfiler.cpp +++ b/src/core/AudioEngineProfiler.cpp @@ -36,11 +36,6 @@ AudioEngineProfiler::AudioEngineProfiler() : -AudioEngineProfiler::~AudioEngineProfiler() -{ -} - - void AudioEngineProfiler::finishPeriod( sample_rate_t sampleRate, fpp_t framesPerPeriod ) { int periodElapsed = m_periodTimer.elapsed(); diff --git a/src/core/DataFile.cpp b/src/core/DataFile.cpp index 1cbacc2fd..3ae141281 100644 --- a/src/core/DataFile.cpp +++ b/src/core/DataFile.cpp @@ -176,12 +176,6 @@ DataFile::DataFile( const QByteArray & _data ) : -DataFile::~DataFile() -{ -} - - - bool DataFile::validate( QString extension ) { diff --git a/src/core/ImportFilter.cpp b/src/core/ImportFilter.cpp index 1caa62e7d..35c34078e 100644 --- a/src/core/ImportFilter.cpp +++ b/src/core/ImportFilter.cpp @@ -48,12 +48,6 @@ ImportFilter::ImportFilter( const QString & _file_name, -ImportFilter::~ImportFilter() -{ -} - - - void ImportFilter::import( const QString & _file_to_import, TrackContainer* tc ) diff --git a/src/core/InstrumentFunctions.cpp b/src/core/InstrumentFunctions.cpp index 27c9e4f66..1f49fc80a 100644 --- a/src/core/InstrumentFunctions.cpp +++ b/src/core/InstrumentFunctions.cpp @@ -221,10 +221,6 @@ InstrumentFunctionNoteStacking::InstrumentFunctionNoteStacking( Model * _parent -InstrumentFunctionNoteStacking::~InstrumentFunctionNoteStacking() -{ -} - @@ -334,11 +330,6 @@ InstrumentFunctionArpeggio::InstrumentFunctionArpeggio( Model * _parent ) : -InstrumentFunctionArpeggio::~InstrumentFunctionArpeggio() -{ -} - - void InstrumentFunctionArpeggio::processNote( NotePlayHandle * _n ) diff --git a/src/core/InstrumentSoundShaping.cpp b/src/core/InstrumentSoundShaping.cpp index a9765d256..edf3b403c 100644 --- a/src/core/InstrumentSoundShaping.cpp +++ b/src/core/InstrumentSoundShaping.cpp @@ -107,11 +107,6 @@ InstrumentSoundShaping::InstrumentSoundShaping( -InstrumentSoundShaping::~InstrumentSoundShaping() -{ -} - - float InstrumentSoundShaping::volumeLevel( NotePlayHandle* n, const f_cnt_t frame ) diff --git a/src/core/Ladspa2LMMS.cpp b/src/core/Ladspa2LMMS.cpp index e16f5c98c..8ac6c3d86 100644 --- a/src/core/Ladspa2LMMS.cpp +++ b/src/core/Ladspa2LMMS.cpp @@ -82,12 +82,6 @@ Ladspa2LMMS::Ladspa2LMMS() -Ladspa2LMMS::~Ladspa2LMMS() -{ -} - - - QString Ladspa2LMMS::getShortName( const ladspa_key_t & _key ) { QString name = getName( _key ); diff --git a/src/core/LadspaControl.cpp b/src/core/LadspaControl.cpp index b166ccf9e..7e8e92623 100644 --- a/src/core/LadspaControl.cpp +++ b/src/core/LadspaControl.cpp @@ -112,13 +112,6 @@ LadspaControl::LadspaControl( Model * _parent, port_desc_t * _port, -LadspaControl::~LadspaControl() -{ -} - - - - LADSPA_Data LadspaControl::value() { switch( m_port->data_type ) diff --git a/src/core/LinkedModelGroups.cpp b/src/core/LinkedModelGroups.cpp index 4fdf54fc0..83bebc2a0 100644 --- a/src/core/LinkedModelGroups.cpp +++ b/src/core/LinkedModelGroups.cpp @@ -140,11 +140,6 @@ bool LinkedModelGroup::containsModel(const QString &name) const -LinkedModelGroups::~LinkedModelGroups() {} - - - - void LinkedModelGroups::linkAllModels() { LinkedModelGroup* first = getGroup(0); diff --git a/src/core/MeterModel.cpp b/src/core/MeterModel.cpp index 3e24ae4d1..d9e5c0343 100644 --- a/src/core/MeterModel.cpp +++ b/src/core/MeterModel.cpp @@ -42,15 +42,6 @@ MeterModel::MeterModel( Model * _parent ) : } - - -MeterModel::~MeterModel() -{ -} - - - - void MeterModel::reset() { m_numeratorModel.setValue( 4 ); diff --git a/src/core/MicroTimer.cpp b/src/core/MicroTimer.cpp index 44506481e..499ba8dd3 100644 --- a/src/core/MicroTimer.cpp +++ b/src/core/MicroTimer.cpp @@ -14,10 +14,6 @@ MicroTimer::MicroTimer() reset(); } -MicroTimer::~MicroTimer() -{ -} - void MicroTimer::reset() { begin = steady_clock::now(); diff --git a/src/core/Mixer.cpp b/src/core/Mixer.cpp index 688190ee2..96d4fc8b2 100644 --- a/src/core/Mixer.cpp +++ b/src/core/Mixer.cpp @@ -51,11 +51,6 @@ MixerRoute::MixerRoute( MixerChannel * from, MixerChannel * to, float amount ) : } -MixerRoute::~MixerRoute() -{ -} - - void MixerRoute::updateName() { m_amount.setDisplayName( diff --git a/src/core/ModelVisitor.cpp b/src/core/ModelVisitor.cpp index 17e328587..665e16983 100644 --- a/src/core/ModelVisitor.cpp +++ b/src/core/ModelVisitor.cpp @@ -44,8 +44,4 @@ void ConstModelVisitor::visit(const FloatModel &m) { up(m); } void ConstModelVisitor::visit(const ComboBoxModel &m) { up(m); } void ConstModelVisitor::visit(const TempoSyncKnobModel &m) { up(m); } -ModelVisitor::~ModelVisitor() {} -ConstModelVisitor::~ConstModelVisitor() {} - - } // namespace lmms \ No newline at end of file diff --git a/src/core/PatternStore.cpp b/src/core/PatternStore.cpp index af1b9b3bb..f91c42b72 100644 --- a/src/core/PatternStore.cpp +++ b/src/core/PatternStore.cpp @@ -50,13 +50,6 @@ PatternStore::PatternStore() : -PatternStore::~PatternStore() -{ -} - - - - bool PatternStore::play(TimePos start, fpp_t frames, f_cnt_t offset, int clipNum) { bool notePlayed = false; diff --git a/src/core/Plugin.cpp b/src/core/Plugin.cpp index e71df15b8..edc183c23 100644 --- a/src/core/Plugin.cpp +++ b/src/core/Plugin.cpp @@ -74,13 +74,6 @@ Plugin::Plugin(const Descriptor * descriptor, Model * parent, const -Plugin::~Plugin() -{ -} - - - - template T use_this_or(T this_param, T or_param) { diff --git a/src/core/PluginFactory.cpp b/src/core/PluginFactory.cpp index 184dc0b94..81a6122d1 100644 --- a/src/core/PluginFactory.cpp +++ b/src/core/PluginFactory.cpp @@ -58,10 +58,6 @@ PluginFactory::PluginFactory() discoverPlugins(); } -PluginFactory::~PluginFactory() -{ -} - void PluginFactory::setupSearchPaths() { // Adds a search path relative to the main executable if the path exists. diff --git a/src/core/PresetPreviewPlayHandle.cpp b/src/core/PresetPreviewPlayHandle.cpp index 1734ef497..6a5b86424 100644 --- a/src/core/PresetPreviewPlayHandle.cpp +++ b/src/core/PresetPreviewPlayHandle.cpp @@ -53,9 +53,7 @@ public: m_previewInstrumentTrack->setPreviewMode( true ); } - ~PreviewTrackContainer() override - { - } + ~PreviewTrackContainer() override = default; QString nodeName() const override { diff --git a/src/core/ProjectJournal.cpp b/src/core/ProjectJournal.cpp index 2a59a2724..bc1fee5c0 100644 --- a/src/core/ProjectJournal.cpp +++ b/src/core/ProjectJournal.cpp @@ -49,13 +49,6 @@ ProjectJournal::ProjectJournal() : -ProjectJournal::~ProjectJournal() -{ -} - - - - void ProjectJournal::undo() { while( !m_undoCheckPoints.isEmpty() ) diff --git a/src/core/ProjectRenderer.cpp b/src/core/ProjectRenderer.cpp index bb5020c9b..5af4e428b 100644 --- a/src/core/ProjectRenderer.cpp +++ b/src/core/ProjectRenderer.cpp @@ -108,13 +108,6 @@ ProjectRenderer::ProjectRenderer( const AudioEngine::qualitySettings & qualitySe -ProjectRenderer::~ProjectRenderer() -{ -} - - - - // Little help function for getting file format from a file extension // (only for registered file-encoders). ProjectRenderer::ExportFileFormats ProjectRenderer::getFileFormatFromExtension( diff --git a/src/core/TempoSyncKnobModel.cpp b/src/core/TempoSyncKnobModel.cpp index 58437db24..6fb457f2c 100644 --- a/src/core/TempoSyncKnobModel.cpp +++ b/src/core/TempoSyncKnobModel.cpp @@ -53,13 +53,6 @@ TempoSyncKnobModel::TempoSyncKnobModel( const float _val, const float _min, -TempoSyncKnobModel::~TempoSyncKnobModel() -{ -} - - - - void TempoSyncKnobModel::setTempoSync( QAction * _item ) { setTempoSync( _item->data().toInt() ); diff --git a/src/core/ToolPlugin.cpp b/src/core/ToolPlugin.cpp index 99c3e5bec..137029137 100644 --- a/src/core/ToolPlugin.cpp +++ b/src/core/ToolPlugin.cpp @@ -38,13 +38,6 @@ ToolPlugin::ToolPlugin( const Descriptor * _descriptor, Model * _parent ) : -ToolPlugin::~ToolPlugin() -{ -} - - - - ToolPlugin * ToolPlugin::instantiate( const QString & _plugin_name, Model * _parent ) { Plugin * p = Plugin::instantiate( _plugin_name, _parent, nullptr ); diff --git a/src/core/ValueBuffer.cpp b/src/core/ValueBuffer.cpp index 09aee65bd..01003dc3b 100644 --- a/src/core/ValueBuffer.cpp +++ b/src/core/ValueBuffer.cpp @@ -6,9 +6,6 @@ namespace lmms { -ValueBuffer::ValueBuffer() -{} - ValueBuffer::ValueBuffer(int length) : std::vector(length) {} diff --git a/src/core/audio/AudioSdl.cpp b/src/core/audio/AudioSdl.cpp index cb622a941..d321e8566 100644 --- a/src/core/audio/AudioSdl.cpp +++ b/src/core/audio/AudioSdl.cpp @@ -340,13 +340,6 @@ AudioSdl::setupWidget::setupWidget( QWidget * _parent ) : -AudioSdl::setupWidget::~setupWidget() -{ -} - - - - void AudioSdl::setupWidget::saveSettings() { ConfigManager::inst()->setValue( "audiosdl", "device", diff --git a/src/core/audio/AudioSndio.cpp b/src/core/audio/AudioSndio.cpp index f6c94f32a..0ba801585 100644 --- a/src/core/audio/AudioSndio.cpp +++ b/src/core/audio/AudioSndio.cpp @@ -204,12 +204,6 @@ AudioSndio::setupWidget::setupWidget( QWidget * _parent ) : } -AudioSndio::setupWidget::~setupWidget() -{ - -} - - void AudioSndio::setupWidget::saveSettings() { ConfigManager::inst()->setValue( "audiosndio", "device", diff --git a/src/core/audio/AudioSoundIo.cpp b/src/core/audio/AudioSoundIo.cpp index 165e38cde..4d8c48708 100644 --- a/src/core/audio/AudioSoundIo.cpp +++ b/src/core/audio/AudioSoundIo.cpp @@ -345,10 +345,6 @@ void AudioSoundIo::writeCallback(int frameCountMin, int frameCountMax) } } -AudioSoundIoSetupUtil::~AudioSoundIoSetupUtil() -{ -} - void AudioSoundIoSetupUtil::reconnectSoundIo() { ((AudioSoundIo::setupWidget *)m_setupWidget)->reconnectSoundIo(); diff --git a/src/core/lv2/Lv2ControlBase.cpp b/src/core/lv2/Lv2ControlBase.cpp index 6fb5900ea..c1679aaef 100644 --- a/src/core/lv2/Lv2ControlBase.cpp +++ b/src/core/lv2/Lv2ControlBase.cpp @@ -89,7 +89,7 @@ Lv2ControlBase::Lv2ControlBase(Model* that, const QString &uri) : -Lv2ControlBase::~Lv2ControlBase() {} +Lv2ControlBase::~Lv2ControlBase() = default; diff --git a/src/core/lv2/Lv2Ports.cpp b/src/core/lv2/Lv2Ports.cpp index 9e7a9e80c..1ce1d6956 100644 --- a/src/core/lv2/Lv2Ports.cpp +++ b/src/core/lv2/Lv2Ports.cpp @@ -352,15 +352,6 @@ void AtomSeq::Lv2EvbufDeleter::operator()(LV2_Evbuf *n) { lv2_evbuf_free(n); } -// make the compiler happy, give each class with virtuals -// a function (the destructor here) which is in a cpp file -PortBase::~PortBase() {} -ConstVisitor::~ConstVisitor() {} -Visitor::~Visitor() {} - - - - } // namespace lmms::Lv2Ports #endif // LMMS_HAVE_LV2 diff --git a/src/core/lv2/Lv2Proc.cpp b/src/core/lv2/Lv2Proc.cpp index 20987b32f..1276a13b8 100644 --- a/src/core/lv2/Lv2Proc.cpp +++ b/src/core/lv2/Lv2Proc.cpp @@ -756,11 +756,9 @@ struct ConnectPortVisitor : public Lv2Ports::Visitor connectPort((audio.mustBeUsed()) ? audio.m_buffer.data() : nullptr); } void visit(Lv2Ports::Unknown&) override { connectPort(nullptr); } - ~ConnectPortVisitor() override; + ~ConnectPortVisitor() override = default; }; -ConnectPortVisitor::~ConnectPortVisitor() {} - // !This function must be realtime safe! // use createPort to create any port before connecting void Lv2Proc::connectPort(std::size_t num) diff --git a/src/core/midi/MidiClient.cpp b/src/core/midi/MidiClient.cpp index def556170..af7cfee0a 100644 --- a/src/core/midi/MidiClient.cpp +++ b/src/core/midi/MidiClient.cpp @@ -30,13 +30,6 @@ namespace lmms { -MidiClient::MidiClient() -{ -} - - - - MidiClient::~MidiClient() { //TODO: noteOffAll(); / clear all ports @@ -106,20 +99,6 @@ void MidiClient::subscribeWritablePort( MidiPort* , const QString& , bool ) -MidiClientRaw::MidiClientRaw() -{ -} - - - - -MidiClientRaw::~MidiClientRaw() -{ -} - - - - void MidiClientRaw::parseData( const unsigned char c ) { /*********************************************************************/ diff --git a/src/core/midi/MidiController.cpp b/src/core/midi/MidiController.cpp index 75f548a37..fbd48e945 100644 --- a/src/core/midi/MidiController.cpp +++ b/src/core/midi/MidiController.cpp @@ -47,13 +47,6 @@ MidiController::MidiController( Model * _parent ) : -MidiController::~MidiController() -{ -} - - - - void MidiController::updateValueBuffer() { if( m_previousValue != m_lastValue ) diff --git a/src/gui/AudioDeviceSetupWidget.cpp b/src/gui/AudioDeviceSetupWidget.cpp index ae559404c..b78800cec 100644 --- a/src/gui/AudioDeviceSetupWidget.cpp +++ b/src/gui/AudioDeviceSetupWidget.cpp @@ -32,10 +32,6 @@ AudioDeviceSetupWidget::AudioDeviceSetupWidget(const QString & caption, QWidget { } -AudioDeviceSetupWidget::~AudioDeviceSetupWidget() -{ -} - void AudioDeviceSetupWidget::show() { parentWidget()->show(); diff --git a/src/gui/ControllerDialog.cpp b/src/gui/ControllerDialog.cpp index be7d5dbef..344898808 100644 --- a/src/gui/ControllerDialog.cpp +++ b/src/gui/ControllerDialog.cpp @@ -41,12 +41,6 @@ ControllerDialog::ControllerDialog( Controller * _controller, -ControllerDialog::~ControllerDialog() -{ -} - - - void ControllerDialog::closeEvent( QCloseEvent * _ce ) { _ce->ignore(); diff --git a/src/gui/ControllerRackView.cpp b/src/gui/ControllerRackView.cpp index e9f23c767..e110067d6 100644 --- a/src/gui/ControllerRackView.cpp +++ b/src/gui/ControllerRackView.cpp @@ -93,13 +93,6 @@ ControllerRackView::ControllerRackView() : -ControllerRackView::~ControllerRackView() -{ -} - - - - void ControllerRackView::saveSettings( QDomDocument & _doc, QDomElement & _this ) { diff --git a/src/gui/Controls.cpp b/src/gui/Controls.cpp index fa28c695f..088d54657 100644 --- a/src/gui/Controls.cpp +++ b/src/gui/Controls.cpp @@ -38,11 +38,6 @@ namespace lmms::gui { -Control::~Control() {} - - - - void KnobControl::setText(const QString &text) { m_knob->setLabel(text); } QWidget *KnobControl::topWidget() { return m_knob; } @@ -59,10 +54,6 @@ AutomatableModelView* KnobControl::modelView() { return m_knob; } KnobControl::KnobControl(QWidget *parent) : m_knob(new Knob(parent)) {} -KnobControl::~KnobControl() {} - - - void ComboControl::setText(const QString &text) { m_label->setText(text); } @@ -87,9 +78,6 @@ ComboControl::ComboControl(QWidget *parent) : m_combo->repaint(); } -ComboControl::~ComboControl() {} - - void CheckControl::setText(const QString &text) { m_label->setText(text); } @@ -115,8 +103,6 @@ CheckControl::CheckControl(QWidget *parent) : vbox->addWidget(m_label); } -CheckControl::~CheckControl() {} - @@ -138,7 +124,5 @@ LcdControl::LcdControl(int numDigits, QWidget *parent) : { } -LcdControl::~LcdControl() {} - } // namespace lmms::gui diff --git a/src/gui/EffectControlDialog.cpp b/src/gui/EffectControlDialog.cpp index a134435fa..1e0fbb802 100644 --- a/src/gui/EffectControlDialog.cpp +++ b/src/gui/EffectControlDialog.cpp @@ -44,13 +44,6 @@ EffectControlDialog::EffectControlDialog( EffectControls * _controls ) : -EffectControlDialog::~EffectControlDialog() -{ -} - - - - void EffectControlDialog::closeEvent( QCloseEvent * _ce ) { _ce->ignore(); diff --git a/src/gui/LadspaControlView.cpp b/src/gui/LadspaControlView.cpp index a82f2e33e..d8c167a1c 100644 --- a/src/gui/LadspaControlView.cpp +++ b/src/gui/LadspaControlView.cpp @@ -121,10 +121,4 @@ LadspaControlView::LadspaControlView( QWidget * _parent, -LadspaControlView::~LadspaControlView() -{ -} - - - } // namespace lmms::gui diff --git a/src/gui/LinkedModelGroupViews.cpp b/src/gui/LinkedModelGroupViews.cpp index 80b08f384..a16c930d5 100644 --- a/src/gui/LinkedModelGroupViews.cpp +++ b/src/gui/LinkedModelGroupViews.cpp @@ -55,11 +55,6 @@ LinkedModelGroupView::LinkedModelGroupView(QWidget* parent, -LinkedModelGroupView::~LinkedModelGroupView() {} - - - - void LinkedModelGroupView::modelChanged(LinkedModelGroup *group) { // reconnect models diff --git a/src/gui/LmmsPalette.cpp b/src/gui/LmmsPalette.cpp index 769405d3e..48d6de0df 100644 --- a/src/gui/LmmsPalette.cpp +++ b/src/gui/LmmsPalette.cpp @@ -52,10 +52,6 @@ LmmsPalette::LmmsPalette( QWidget * parent, QStyle * stylearg ) : ensurePolished(); } -LmmsPalette::~LmmsPalette() -{ -} - #define ACCESSMET( read, write ) \ QColor LmmsPalette:: read () const \ { return m_##read ; } \ diff --git a/src/gui/Lv2ViewBase.cpp b/src/gui/Lv2ViewBase.cpp index 7f7a06959..9e95fca2e 100644 --- a/src/gui/Lv2ViewBase.cpp +++ b/src/gui/Lv2ViewBase.cpp @@ -126,11 +126,6 @@ Lv2ViewProc::Lv2ViewProc(QWidget* parent, Lv2Proc* ctrlBase, int colNum) : -Lv2ViewProc::~Lv2ViewProc() {} - - - - AutoLilvNode Lv2ViewProc::uri(const char *uriStr) { return Engine::getLv2Manager()->uri(uriStr); diff --git a/src/gui/MixerView.cpp b/src/gui/MixerView.cpp index 6e3d9f95a..32355edd6 100644 --- a/src/gui/MixerView.cpp +++ b/src/gui/MixerView.cpp @@ -113,7 +113,7 @@ MixerView::MixerView() : public: ChannelArea( QWidget * parent, MixerView * mv ) : QScrollArea( parent ), m_mv( mv ) {} - ~ChannelArea() override {} + ~ChannelArea() override = default; void keyPressEvent( QKeyEvent * e ) override { m_mv->keyPressEvent( e ); diff --git a/src/gui/PeakControllerDialog.cpp b/src/gui/PeakControllerDialog.cpp index 62307fc7d..760c42591 100644 --- a/src/gui/PeakControllerDialog.cpp +++ b/src/gui/PeakControllerDialog.cpp @@ -55,12 +55,6 @@ PeakControllerDialog::PeakControllerDialog( Controller * _model, QWidget * _pare -PeakControllerDialog::~PeakControllerDialog() -{ -} - - - /* void effectView::closeEffects() { diff --git a/src/gui/ProjectNotes.cpp b/src/gui/ProjectNotes.cpp index 22e806cdb..15e507889 100644 --- a/src/gui/ProjectNotes.cpp +++ b/src/gui/ProjectNotes.cpp @@ -84,13 +84,6 @@ ProjectNotes::ProjectNotes() : -ProjectNotes::~ProjectNotes() -{ -} - - - - void ProjectNotes::clear() { m_edit->setHtml( tr( "Enter project notes here" ) ); diff --git a/src/gui/SampleTrackWindow.cpp b/src/gui/SampleTrackWindow.cpp index c8901dda2..c12ab1b1a 100644 --- a/src/gui/SampleTrackWindow.cpp +++ b/src/gui/SampleTrackWindow.cpp @@ -163,11 +163,6 @@ SampleTrackWindow::SampleTrackWindow(SampleTrackView * tv) : subWin->hide(); } -SampleTrackWindow::~SampleTrackWindow() -{ -} - - void SampleTrackWindow::setSampleTrackView(SampleTrackView* tv) { diff --git a/src/gui/SideBar.cpp b/src/gui/SideBar.cpp index e16367a7b..d3935024d 100644 --- a/src/gui/SideBar.cpp +++ b/src/gui/SideBar.cpp @@ -101,13 +101,6 @@ SideBar::SideBar( Qt::Orientation _orientation, QWidget * _parent ) : -SideBar::~SideBar() -{ -} - - - - void SideBar::appendTab( SideBarWidget *widget ) { SideBarButton *button = new SideBarButton( orientation(), this ); diff --git a/src/gui/SideBarWidget.cpp b/src/gui/SideBarWidget.cpp index 600ed245c..cf0233af1 100644 --- a/src/gui/SideBarWidget.cpp +++ b/src/gui/SideBarWidget.cpp @@ -55,13 +55,6 @@ SideBarWidget::SideBarWidget( const QString & _title, const QPixmap & _icon, -SideBarWidget::~SideBarWidget() -{ -} - - - - void SideBarWidget::paintEvent( QPaintEvent * ) { QPainter p( this ); diff --git a/src/gui/clips/AutomationClipView.cpp b/src/gui/clips/AutomationClipView.cpp index 2bc29184c..1ecf78155 100644 --- a/src/gui/clips/AutomationClipView.cpp +++ b/src/gui/clips/AutomationClipView.cpp @@ -71,13 +71,6 @@ AutomationClipView::AutomationClipView( AutomationClip * _clip, -AutomationClipView::~AutomationClipView() -{ -} - - - - void AutomationClipView::openInAutomationEditor() { if(getGUI() != nullptr) diff --git a/src/gui/editors/AutomationEditor.cpp b/src/gui/editors/AutomationEditor.cpp index fba88643e..2cc9a6faf 100644 --- a/src/gui/editors/AutomationEditor.cpp +++ b/src/gui/editors/AutomationEditor.cpp @@ -1967,11 +1967,6 @@ AutomationEditorWindow::AutomationEditorWindow() : } -AutomationEditorWindow::~AutomationEditorWindow() -{ -} - - void AutomationEditorWindow::setCurrentClip(AutomationClip* clip) { // Disconnect our old clip diff --git a/src/gui/editors/Editor.cpp b/src/gui/editors/Editor.cpp index 19f64a65c..cd2a23f66 100644 --- a/src/gui/editors/Editor.cpp +++ b/src/gui/editors/Editor.cpp @@ -133,11 +133,6 @@ Editor::Editor(bool record, bool stepRecord) : addButton(m_stopAction, "stopButton"); } -Editor::~Editor() -{ - -} - QAction *Editor::playAction() const { return m_playAction; diff --git a/src/gui/editors/PatternEditor.cpp b/src/gui/editors/PatternEditor.cpp index 86a116dd2..4c00942db 100644 --- a/src/gui/editors/PatternEditor.cpp +++ b/src/gui/editors/PatternEditor.cpp @@ -301,11 +301,6 @@ PatternEditorWindow::PatternEditorWindow(PatternStore* ps) : } -PatternEditorWindow::~PatternEditorWindow() -{ -} - - QSize PatternEditorWindow::sizeHint() const { return {minimumWidth() + 10, 300}; diff --git a/src/gui/editors/PianoRoll.cpp b/src/gui/editors/PianoRoll.cpp index b9f0e1397..0a10fa354 100644 --- a/src/gui/editors/PianoRoll.cpp +++ b/src/gui/editors/PianoRoll.cpp @@ -625,11 +625,6 @@ void PianoRoll::markSemiTone(int i, bool fromMenu) } -PianoRoll::~PianoRoll() -{ -} - - void PianoRoll::setGhostMidiClip( MidiClip* newMidiClip ) { // Expects a pointer to a MIDI clip or nullptr. diff --git a/src/gui/editors/Rubberband.cpp b/src/gui/editors/Rubberband.cpp index c1ef329f0..cfff787e0 100644 --- a/src/gui/editors/Rubberband.cpp +++ b/src/gui/editors/Rubberband.cpp @@ -38,13 +38,6 @@ RubberBand::RubberBand( QWidget * _parent ) : -RubberBand::~RubberBand() -{ -} - - - - QVector RubberBand::selectedObjects() const { QVector so = selectableObjects(); diff --git a/src/gui/editors/SongEditor.cpp b/src/gui/editors/SongEditor.cpp index eaabf52ea..bd1269b2a 100644 --- a/src/gui/editors/SongEditor.cpp +++ b/src/gui/editors/SongEditor.cpp @@ -277,10 +277,6 @@ SongEditor::SongEditor( Song * song ) : -SongEditor::~SongEditor() -{ -} - void SongEditor::saveSettings( QDomDocument& doc, QDomElement& element ) { MainWindow::saveWidgetState( parentWidget(), element ); diff --git a/src/gui/editors/TrackContainerView.cpp b/src/gui/editors/TrackContainerView.cpp index 43309d96b..e7db85e43 100644 --- a/src/gui/editors/TrackContainerView.cpp +++ b/src/gui/editors/TrackContainerView.cpp @@ -487,13 +487,6 @@ TrackContainerView::scrollArea::scrollArea( TrackContainerView * _parent ) : -TrackContainerView::scrollArea::~scrollArea() -{ -} - - - - void TrackContainerView::scrollArea::wheelEvent( QWheelEvent * _we ) { // always pass wheel-event to parent-widget (song-editor diff --git a/src/gui/instrument/InstrumentMidiIOView.cpp b/src/gui/instrument/InstrumentMidiIOView.cpp index 68491d6e6..31eebca20 100644 --- a/src/gui/instrument/InstrumentMidiIOView.cpp +++ b/src/gui/instrument/InstrumentMidiIOView.cpp @@ -171,12 +171,6 @@ InstrumentMidiIOView::InstrumentMidiIOView( QWidget* parent ) : -InstrumentMidiIOView::~InstrumentMidiIOView() -{ -} - - - void InstrumentMidiIOView::modelChanged() { diff --git a/src/gui/instrument/InstrumentView.cpp b/src/gui/instrument/InstrumentView.cpp index 23e758cf2..fe2c04cfb 100644 --- a/src/gui/instrument/InstrumentView.cpp +++ b/src/gui/instrument/InstrumentView.cpp @@ -75,9 +75,5 @@ InstrumentTrackWindow * InstrumentView::instrumentTrackWindow() -InstrumentViewFixedSize::~InstrumentViewFixedSize() -{ -} - } // namespace lmms::gui \ No newline at end of file diff --git a/src/gui/menus/MidiPortMenu.cpp b/src/gui/menus/MidiPortMenu.cpp index 88e6a4f30..a7c61fb0c 100644 --- a/src/gui/menus/MidiPortMenu.cpp +++ b/src/gui/menus/MidiPortMenu.cpp @@ -42,12 +42,6 @@ MidiPortMenu::MidiPortMenu( MidiPort::Modes _mode ) : -MidiPortMenu::~MidiPortMenu() -{ -} - - - void MidiPortMenu::modelChanged() { diff --git a/src/gui/modals/ControllerConnectionDialog.cpp b/src/gui/modals/ControllerConnectionDialog.cpp index fb86328a1..12dd7c6ef 100644 --- a/src/gui/modals/ControllerConnectionDialog.cpp +++ b/src/gui/modals/ControllerConnectionDialog.cpp @@ -60,9 +60,7 @@ public: } - ~AutoDetectMidiController() override - { - } + ~AutoDetectMidiController() override = default; void processInEvent( const MidiEvent& event, const TimePos& time, f_cnt_t offset = 0 ) override diff --git a/src/gui/modals/RenameDialog.cpp b/src/gui/modals/RenameDialog.cpp index 0028cd1a0..381064f39 100644 --- a/src/gui/modals/RenameDialog.cpp +++ b/src/gui/modals/RenameDialog.cpp @@ -52,12 +52,6 @@ RenameDialog::RenameDialog( QString & _string ) : -RenameDialog::~RenameDialog() -{ -} - - - void RenameDialog::resizeEvent (QResizeEvent * event) { m_stringLE->setGeometry ( 10, 5, width() - 20, 20 ); diff --git a/src/gui/tracks/FadeButton.cpp b/src/gui/tracks/FadeButton.cpp index d4b75cbf1..2f4727e5e 100644 --- a/src/gui/tracks/FadeButton.cpp +++ b/src/gui/tracks/FadeButton.cpp @@ -55,11 +55,6 @@ FadeButton::FadeButton(const QColor & _normal_color, - -FadeButton::~FadeButton() -{ -} - void FadeButton::setActiveColor(const QColor & activated_color) { m_activatedColor = activated_color; diff --git a/src/gui/tracks/TrackContentWidget.cpp b/src/gui/tracks/TrackContentWidget.cpp index 5e6344ec4..e22750ce3 100644 --- a/src/gui/tracks/TrackContentWidget.cpp +++ b/src/gui/tracks/TrackContentWidget.cpp @@ -82,14 +82,6 @@ TrackContentWidget::TrackContentWidget( TrackView * parent ) : -/*! \brief Destroy this trackContentWidget - * - * Destroys the trackContentWidget. - */ -TrackContentWidget::~TrackContentWidget() -{ -} - diff --git a/src/gui/tracks/TrackLabelButton.cpp b/src/gui/tracks/TrackLabelButton.cpp index 77e678617..4e0b2be35 100644 --- a/src/gui/tracks/TrackLabelButton.cpp +++ b/src/gui/tracks/TrackLabelButton.cpp @@ -73,11 +73,6 @@ TrackLabelButton::TrackLabelButton( TrackView * _tv, QWidget * _parent ) : -TrackLabelButton::~TrackLabelButton() -{ -} - - void TrackLabelButton::rename() diff --git a/src/gui/tracks/TrackOperationsWidget.cpp b/src/gui/tracks/TrackOperationsWidget.cpp index bef6ddcbf..b3c8ac379 100644 --- a/src/gui/tracks/TrackOperationsWidget.cpp +++ b/src/gui/tracks/TrackOperationsWidget.cpp @@ -120,13 +120,6 @@ TrackOperationsWidget::TrackOperationsWidget( TrackView * parent ) : -/*! \brief Destroy an existing trackOperationsWidget - * - */ -TrackOperationsWidget::~TrackOperationsWidget() -{ -} - diff --git a/src/gui/tracks/TrackView.cpp b/src/gui/tracks/TrackView.cpp index 2065b0b53..4eece14d4 100644 --- a/src/gui/tracks/TrackView.cpp +++ b/src/gui/tracks/TrackView.cpp @@ -115,12 +115,6 @@ TrackView::TrackView( Track * track, TrackContainerView * tcv ) : -/*! \brief Destroy this track View. - * - */ -TrackView::~TrackView() -{ -} diff --git a/src/gui/widgets/AutomatableSlider.cpp b/src/gui/widgets/AutomatableSlider.cpp index 13cd9771f..7e1be0e06 100644 --- a/src/gui/widgets/AutomatableSlider.cpp +++ b/src/gui/widgets/AutomatableSlider.cpp @@ -51,10 +51,6 @@ AutomatableSlider::AutomatableSlider( QWidget * _parent, -AutomatableSlider::~AutomatableSlider() -{ -} - diff --git a/src/gui/widgets/CPULoadWidget.cpp b/src/gui/widgets/CPULoadWidget.cpp index 3f465d347..799e037ef 100644 --- a/src/gui/widgets/CPULoadWidget.cpp +++ b/src/gui/widgets/CPULoadWidget.cpp @@ -59,10 +59,6 @@ CPULoadWidget::CPULoadWidget( QWidget * _parent ) : -CPULoadWidget::~CPULoadWidget() -{ -} - diff --git a/src/gui/widgets/CaptionMenu.cpp b/src/gui/widgets/CaptionMenu.cpp index 032ee10b9..bfcd3003e 100644 --- a/src/gui/widgets/CaptionMenu.cpp +++ b/src/gui/widgets/CaptionMenu.cpp @@ -40,9 +40,5 @@ CaptionMenu::CaptionMenu( const QString & _title, QWidget * _parent ) : -CaptionMenu::~CaptionMenu() -{ -} - } // namespace lmms::gui diff --git a/src/gui/widgets/ComboBox.cpp b/src/gui/widgets/ComboBox.cpp index 7b6121b23..bdf78ccce 100644 --- a/src/gui/widgets/ComboBox.cpp +++ b/src/gui/widgets/ComboBox.cpp @@ -82,10 +82,6 @@ ComboBox::ComboBox( QWidget * _parent, const QString & _name ) : -ComboBox::~ComboBox() -{ -} - void ComboBox::selectNext() diff --git a/src/gui/widgets/MeterDialog.cpp b/src/gui/widgets/MeterDialog.cpp index f60f6bd06..c13fe3802 100644 --- a/src/gui/widgets/MeterDialog.cpp +++ b/src/gui/widgets/MeterDialog.cpp @@ -103,10 +103,6 @@ MeterDialog::MeterDialog( QWidget * _parent, bool _simple ) : -MeterDialog::~MeterDialog() -{ -} - diff --git a/src/gui/widgets/PixmapButton.cpp b/src/gui/widgets/PixmapButton.cpp index 938322b51..13c09c52e 100644 --- a/src/gui/widgets/PixmapButton.cpp +++ b/src/gui/widgets/PixmapButton.cpp @@ -47,10 +47,6 @@ PixmapButton::PixmapButton( QWidget * _parent, const QString & _name ) : -PixmapButton::~PixmapButton() -{ -} -