mirror/lmms
1
0
Fork 0
mirror of https://github.com/LMMS/lmms.git synced 2026-05-17 11:18:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

Code review changes (#6548)

Browse Source 
Add a space after some while loops. Fix a typo in a comment.
This commit is contained in:
Michael Gregorius
2023-08-11 17:55:26 +02:00
parent 4f01094d98
commit dac1f77347
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/core/DataFile.cpp
View File

@@ -1699,7 +1699,7 @@ static PatternAnalysisResult analyzeAutomationPattern(QDomElement const & automa
// Iterate the objects. These contain the ids of the automated objects.
QDomElement object = automationPattern.firstChildElement("object");
while(!object.isNull())
while (!object.isNull())
{
unsigned int const id = object.attribute("id").toUInt();
@@ -1788,7 +1788,7 @@ static void fixInstrumentBaseNoteAndCollectIds(QDomElement & instrument, std::se
static void fixAutomationPattern(QDomElement & automationPattern)
{
QDomElement time = automationPattern.firstChildElement("time");
while(!time.isNull())
while (!time.isNull())
{
// Automation patterns can automate base notes as floats
// so we read and correct them as floats here.
@@ -1823,7 +1823,7 @@ static void fixTrack(QDomElement & track, std::set<unsigned int> & automatedBase
Track::TrackTypes const trackType = static_cast<Track::TrackTypes>(track.attribute("type").toInt());
// BB tracks need special handling because they container a track container of their own
// BB tracks need special handling because they contain a track container of their own
if (trackType == Track::PatternTrack)
{
// Assuming that a BB track cannot contain another BB track here...
@@ -1948,7 +1948,7 @@ static void fixAutomationTracks(QDomElement & song, std::set<unsigned int> const
{
// The pattern itself is mixed. Remove the base note objects.
QDomElement object = automationPattern.firstChildElement("object");
while(!object.isNull())
while (!object.isNull())
{
unsigned int const id = object.attribute("id").toUInt();
@@ -1978,7 +1978,7 @@ static void fixAutomationTracks(QDomElement & song, std::set<unsigned int> const
{
// This pattern has base note automations. Remove all other ones and fix the pattern.
QDomElement object = automationPattern.firstChildElement("object");
while(!object.isNull())
while (!object.isNull())
{
unsigned int const id = object.attribute("id").toUInt();