From e1cdfd1d478e6137b4c0799704026ae1cc3d9dc7 Mon Sep 17 00:00:00 2001 From: Lukas W Date: Sun, 24 Jun 2018 18:40:13 +0200 Subject: [PATCH] RemotePlugin: Revert unnecessary invalidate() changes Reverts some changes made in 9db8cbfb31f9b6d3e754887a6280770e3d3e2bcd. The consequences of this changes are unsure, so reverting them for now. Since a VST plugin's architecture is now detected before trying to load it, this fix is not needed any more for 64&32-bit VSTs to work, as the idVstBadDllFormat-message-mechanism was removed. It should be noted however that the bug still exists, probably rendering 4fd8ecd7e4084aedbd39900ffe5cfd107ceba1a0 ineffective. --- src/core/RemotePlugin.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/core/RemotePlugin.cpp b/src/core/RemotePlugin.cpp index c00d26be9..d68f6aa65 100644 --- a/src/core/RemotePlugin.cpp +++ b/src/core/RemotePlugin.cpp @@ -64,9 +64,7 @@ void ProcessWatcher::run() fprintf( stderr, "remote plugin died! invalidating now.\n" ); -#ifndef SYNC_WITH_SHM_FIFO m_plugin->invalidate(); -#endif } } @@ -467,6 +465,9 @@ void RemotePlugin::processFinished( int exitCode, { qCritical() << "Remote plugin exit code: " << exitCode; } +#ifndef SYNC_WITH_SHM_FIFO + invalidate(); +#endif } void RemotePlugin::processErrored( QProcess::ProcessError err )