mirror of
https://github.com/LMMS/lmms.git
synced 2026-01-15 18:08:07 -05:00
71ce49d7ba
Follow-Up of 7db3fa94a1 .
This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):
```
include-what-you-use;
-Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
-Xiwyu;--keep=*/xmmintrin.h;
-Xiwyu;--keep=*/lmmsconfig.h;
-Xiwyu;--keep=*/weak_libjack.h;
-Xiwyu;--keep=*/sys/*;
-Xiwyu;--keep=*/debug.h;
-Xiwyu;--keep=*/SDL/*;
-Xiwyu;--keep=*/alsa/*;
-Xiwyu;--keep=*/FL/x.h;
-Xiwyu;--keep=*/MidiApple.h;
-Xiwyu;--keep=*/MidiWinMM.h;
-Xiwyu;--keep=*/AudioSoundIo.h;
-Xiwyu;--keep=*/OpulenZ/adplug/*;
-Xiwyu;--keep=QPainterPath;
-Xiwyu;--keep=QtTest
```
FAQ:
* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.
* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
that your compiler needs to recompile, or your IDE has to re-scan.
* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
reduce output for those who want to use IWYU for new PRs.
Background:
This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.
However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
95 lines
3.2 KiB
C++
95 lines
3.2 KiB
C++
/*
|
|
* flangercontrolsdialog.cpp - defination of FlangerControlsDialog class.
|
|
*
|
|
* Copyright (c) 2014 David French <dave/dot/french3/at/googlemail/dot/com>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#include "FlangerControlsDialog.h"
|
|
|
|
#include <QVBoxLayout>
|
|
|
|
#include "embed.h"
|
|
#include "FlangerControls.h"
|
|
#include "LedCheckBox.h"
|
|
#include "TempoSyncKnob.h"
|
|
|
|
namespace lmms::gui
|
|
{
|
|
|
|
|
|
FlangerControlsDialog::FlangerControlsDialog( FlangerControls *controls ) :
|
|
EffectControlDialog( controls )
|
|
{
|
|
setAutoFillBackground( true );
|
|
QPalette pal;
|
|
pal.setBrush( backgroundRole(), PLUGIN_NAME::getIconPixmap( "artwork" ) );
|
|
setPalette( pal );
|
|
|
|
auto mainLayout = new QVBoxLayout(this);
|
|
auto knobLayout = new QHBoxLayout();
|
|
mainLayout->addLayout(knobLayout);
|
|
|
|
auto delayKnob = new Knob(KnobType::Bright26, tr("DELAY"), this);
|
|
delayKnob->setVolumeKnob( false );
|
|
delayKnob->setModel( &controls->m_delayTimeModel );
|
|
delayKnob->setHintText( tr( "Delay time:" ) + " ", "s" );
|
|
|
|
auto lfoFreqKnob = new TempoSyncKnob(KnobType::Bright26, tr("RATE"), this);
|
|
lfoFreqKnob->setVolumeKnob( false );
|
|
lfoFreqKnob->setModel( &controls->m_lfoFrequencyModel );
|
|
lfoFreqKnob->setHintText( tr( "Period:" ) , " Sec" );
|
|
|
|
auto lfoAmtKnob = new Knob(KnobType::Bright26, tr("AMNT"), this);
|
|
lfoAmtKnob->setVolumeKnob( false );
|
|
lfoAmtKnob->setModel( &controls->m_lfoAmountModel );
|
|
lfoAmtKnob->setHintText( tr( "Amount:" ) , "" );
|
|
|
|
auto lfoPhaseKnob = new Knob(KnobType::Bright26, tr("PHASE"), this);
|
|
lfoPhaseKnob->setVolumeKnob( false );
|
|
lfoPhaseKnob->setModel( &controls->m_lfoPhaseModel );
|
|
lfoPhaseKnob->setHintText( tr( "Phase:" ) , " degrees" );
|
|
|
|
auto feedbackKnob = new Knob(KnobType::Bright26, tr("FDBK"), this);
|
|
feedbackKnob->setVolumeKnob( true) ;
|
|
feedbackKnob->setModel( &controls->m_feedbackModel );
|
|
feedbackKnob->setHintText( tr( "Feedback amount:" ) , "" );
|
|
|
|
auto whiteNoiseKnob = new Knob(KnobType::Bright26, tr("NOISE"), this);
|
|
whiteNoiseKnob->setVolumeKnob( true) ;
|
|
whiteNoiseKnob->setModel( &controls->m_whiteNoiseAmountModel );
|
|
whiteNoiseKnob->setHintText( tr( "White noise amount:" ) , "" );
|
|
|
|
knobLayout->addWidget(delayKnob);
|
|
knobLayout->addWidget(lfoFreqKnob);
|
|
knobLayout->addWidget(lfoAmtKnob);
|
|
knobLayout->addWidget(lfoPhaseKnob);
|
|
knobLayout->addWidget(feedbackKnob);
|
|
knobLayout->addWidget(whiteNoiseKnob);
|
|
|
|
auto invertCb = new LedCheckBox(tr("Invert"), this);
|
|
invertCb->setModel(&controls->m_invertFeedbackModel);
|
|
|
|
mainLayout->addWidget(invertCb, 0, Qt::AlignLeft);
|
|
}
|
|
|
|
|
|
} // namespace lmms::gui
|