mirror of
https://github.com/LMMS/lmms.git
synced 2026-01-22 21:38:12 -05:00
71ce49d7ba
Follow-Up of 7db3fa94a1 .
This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):
```
include-what-you-use;
-Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
-Xiwyu;--keep=*/xmmintrin.h;
-Xiwyu;--keep=*/lmmsconfig.h;
-Xiwyu;--keep=*/weak_libjack.h;
-Xiwyu;--keep=*/sys/*;
-Xiwyu;--keep=*/debug.h;
-Xiwyu;--keep=*/SDL/*;
-Xiwyu;--keep=*/alsa/*;
-Xiwyu;--keep=*/FL/x.h;
-Xiwyu;--keep=*/MidiApple.h;
-Xiwyu;--keep=*/MidiWinMM.h;
-Xiwyu;--keep=*/AudioSoundIo.h;
-Xiwyu;--keep=*/OpulenZ/adplug/*;
-Xiwyu;--keep=QPainterPath;
-Xiwyu;--keep=QtTest
```
FAQ:
* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.
* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
that your compiler needs to recompile, or your IDE has to re-scan.
* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
reduce output for those who want to use IWYU for new PRs.
Background:
This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.
However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
103 lines
2.7 KiB
C++
103 lines
2.7 KiB
C++
/* SaWaterfallView.h - declaration of SaWaterfallView class.
|
|
*
|
|
* Copyright (c) 2019 Martin Pavelek <he29/dot/HS/at/gmail/dot/com>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
#ifndef SAWATERFALLVIEW_H
|
|
#define SAWATERFALLVIEW_H
|
|
|
|
#include <string>
|
|
#include <utility>
|
|
#include <vector>
|
|
#include <QWidget>
|
|
|
|
|
|
|
|
namespace lmms
|
|
{
|
|
class SaControls;
|
|
class SaProcessor;
|
|
}
|
|
|
|
namespace lmms::gui
|
|
{
|
|
|
|
class EffectControlDialog;
|
|
|
|
|
|
// Widget that displays a spectrum waterfall (spectrogram) and time labels.
|
|
class SaWaterfallView : public QWidget
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
explicit SaWaterfallView(SaControls *controls, SaProcessor *processor, QWidget *_parent = 0);
|
|
~SaWaterfallView() override = default;
|
|
|
|
QSize sizeHint() const override {return QSize(400, 350);}
|
|
|
|
// Check if waterfall should be displayed and adjust window size if needed.
|
|
void updateVisibility();
|
|
|
|
protected:
|
|
void paintEvent(QPaintEvent *event) override;
|
|
void mouseMoveEvent(QMouseEvent *event) override;
|
|
void mousePressEvent(QMouseEvent *event) override;
|
|
void resizeEvent(QResizeEvent *event) override;
|
|
|
|
private slots:
|
|
void periodicUpdate();
|
|
|
|
private:
|
|
const SaControls *m_controls;
|
|
SaProcessor *m_processor;
|
|
const EffectControlDialog *m_controlDialog;
|
|
|
|
// Methods and data used to make time labels
|
|
float m_oldSecondsPerLine;
|
|
float m_oldHeight;
|
|
float samplesPerLine();
|
|
float secondsPerLine();
|
|
float timeToYPixel(float time, int height);
|
|
float yPixelToTime(float position, int height);
|
|
std::vector<std::pair<float, std::string>> makeTimeTics();
|
|
std::vector<std::pair<float, std::string>> m_timeTics; // 0..n (s)
|
|
|
|
// current cursor location and a method to draw it
|
|
QPointF m_cursor;
|
|
void drawCursor(QPainter &painter);
|
|
|
|
// current boundaries for drawing
|
|
unsigned int m_displayTop;
|
|
unsigned int m_displayBottom;
|
|
unsigned int m_displayLeft;
|
|
unsigned int m_displayRight;
|
|
unsigned int m_displayWidth;
|
|
unsigned int m_displayHeight;
|
|
|
|
#ifdef SA_DEBUG
|
|
float m_execution_avg;
|
|
#endif
|
|
};
|
|
|
|
|
|
} // namespace lmms::gui
|
|
|
|
#endif // SAWATERFALLVIEW_H
|