mirror of
https://github.com/LMMS/lmms.git
synced 2025-12-30 01:58:01 -05:00
63d03fa3a7
Introduced in #5970 , `CPULoadWidget::m_stepSize` is uninitialized, leading to valgrind warnings: ``` ==9429== Conditional jump or move depends on uninitialised value(s) ==9429== at 0x3715A9: int const& std::max<int>(int const&, int const&) (stl_algobase.h:262) ==9429== by 0x59E3BB: lmms::gui::CPULoadWidget::stepSize() const (CPULoadWidget.h:59) ==9429== by 0x59DA2E: lmms::gui::CPULoadWidget::paintEvent(QPaintEvent*) (CPULoadWidget.cpp:78) ``` Even though `grep` shows: ``` data/themes/classic/style.css: qproperty-stepSize: 4; data/themes/default/style.css: qproperty-stepSize: 1; ``` It seems like the issue is caused by paint events occurring even before the style sheet has been applied. In order to fix this, and to be future proof with style sheets which do not set it, we initialize `CPULoadWidget::m_stepSize` to `1`.
79 lines
1.7 KiB
C++
79 lines
1.7 KiB
C++
/*
|
|
* CPULoadWidget.h - widget for displaying CPU-load (partly based on
|
|
* Hydrogen's CPU-load-widget)
|
|
*
|
|
* Copyright (c) 2005-2014 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_GUI_CPU_LOAD_WIDGET_H
|
|
#define LMMS_GUI_CPU_LOAD_WIDGET_H
|
|
|
|
#include <algorithm>
|
|
#include <QTimer>
|
|
#include <QPixmap>
|
|
#include <QWidget>
|
|
|
|
#include "lmms_basics.h"
|
|
|
|
|
|
namespace lmms::gui
|
|
{
|
|
|
|
|
|
class CPULoadWidget : public QWidget
|
|
{
|
|
Q_OBJECT
|
|
Q_PROPERTY(int stepSize MEMBER m_stepSize)
|
|
public:
|
|
CPULoadWidget( QWidget * _parent );
|
|
~CPULoadWidget() override = default;
|
|
|
|
|
|
protected:
|
|
void paintEvent( QPaintEvent * _ev ) override;
|
|
|
|
|
|
protected slots:
|
|
void updateCpuLoad();
|
|
|
|
|
|
private:
|
|
int stepSize() const { return std::max(1, m_stepSize); }
|
|
|
|
int m_currentLoad;
|
|
|
|
QPixmap m_temp;
|
|
QPixmap m_background;
|
|
QPixmap m_leds;
|
|
|
|
bool m_changed;
|
|
|
|
QTimer m_updateTimer;
|
|
|
|
int m_stepSize = 1;
|
|
|
|
} ;
|
|
|
|
|
|
} // namespace lmms::gui
|
|
|
|
#endif // LMMS_GUI_CPU_LOAD_WIDGET_H
|