mirror of
https://github.com/LMMS/lmms.git
synced 2025-12-30 10:08:00 -05:00
815f88dd09
## Scalable LFO graph Make the rendering of the LFO graph scalable. Change the fixed size to a minimum size. Adjust the rendering code such that it uses the width and height of the widget instead of the background pixmap. Only draw only poly line once instead of many line segments. Collect the points in the for-loop to be able to do so. This makes the code a bit more understandable because we now compute exacly one point per iteration in the for-loop. Use the same interpolation for the line color like in the envelope graph. Rename some variables to make them consistent with the other code. Remove the member `m_params` which is not used anyway. This also allows for the removal of the overridden `modelChanged` method. ## Use "Hz" instead of "ms/LFO" Use the more common unit "Hz" to display the frequency of the LFO instead of "ms/LFO". The frequency is always displayed with three digits after the decimal separator to prevent "jumps". ## Take "Freq * 100" into account This commit fixes a bug where the "Freq * 100" option was not taken into account when computing and displaying the frequency of the LFO. ## Keep info text legible Draw a slightly transparent black rectangle underneath the text to keep it legible, e.g. for high frequencies with an LFO amount of 1 which results in a very bright and dense graph. ## Extract drawing of info text into method Extract the drawing of the info text into its own private method `drawInfoText`.
66 lines
1.6 KiB
C++
66 lines
1.6 KiB
C++
/*
|
|
* LfoGraph.h - Displays LFO graphs
|
|
*
|
|
* Copyright (c) 2004-2009 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
* Copyright (c) 2024- Michael Gregorius
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_GUI_LFO_GRAPH_H
|
|
#define LMMS_GUI_LFO_GRAPH_H
|
|
|
|
#include <QWidget>
|
|
|
|
#include "ModelView.h"
|
|
#include "embed.h"
|
|
|
|
namespace lmms
|
|
{
|
|
|
|
class EnvelopeAndLfoParameters;
|
|
|
|
namespace gui
|
|
{
|
|
|
|
class LfoGraph : public QWidget, public ModelView
|
|
{
|
|
public:
|
|
LfoGraph(QWidget* parent);
|
|
|
|
protected:
|
|
void mousePressEvent(QMouseEvent* me) override;
|
|
void paintEvent(QPaintEvent* pe) override;
|
|
|
|
private:
|
|
void drawInfoText(const EnvelopeAndLfoParameters&);
|
|
void toggleAmountModel();
|
|
|
|
private:
|
|
QPixmap m_lfoGraph = embed::getIconPixmap("lfo_graph");
|
|
|
|
float m_randomGraph {0.};
|
|
};
|
|
|
|
} // namespace gui
|
|
|
|
} // namespace lmms
|
|
|
|
#endif // LMMS_GUI_LFO_GRAPH_H
|