mirror of
https://github.com/LMMS/lmms.git
synced 2026-03-28 02:43:11 -04:00
71ce49d7ba
Follow-Up of 7db3fa94a1 .
This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):
```
include-what-you-use;
-Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
-Xiwyu;--keep=*/xmmintrin.h;
-Xiwyu;--keep=*/lmmsconfig.h;
-Xiwyu;--keep=*/weak_libjack.h;
-Xiwyu;--keep=*/sys/*;
-Xiwyu;--keep=*/debug.h;
-Xiwyu;--keep=*/SDL/*;
-Xiwyu;--keep=*/alsa/*;
-Xiwyu;--keep=*/FL/x.h;
-Xiwyu;--keep=*/MidiApple.h;
-Xiwyu;--keep=*/MidiWinMM.h;
-Xiwyu;--keep=*/AudioSoundIo.h;
-Xiwyu;--keep=*/OpulenZ/adplug/*;
-Xiwyu;--keep=QPainterPath;
-Xiwyu;--keep=QtTest
```
FAQ:
* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.
* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
that your compiler needs to recompile, or your IDE has to re-scan.
* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
reduce output for those who want to use IWYU for new PRs.
Background:
This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.
However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
119 lines
3.3 KiB
C++
119 lines
3.3 KiB
C++
/*
|
|
* EffectSelectDialog.h - dialog to choose effect plugin
|
|
*
|
|
* Copyright (c) 2006-2009 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
* Copyright (c) 2023 Lost Robot <r94231/at/gmail.com>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_GUI_EFFECT_SELECT_DIALOG_H
|
|
#define LMMS_GUI_EFFECT_SELECT_DIALOG_H
|
|
|
|
#include "Effect.h"
|
|
|
|
#include <QDialog>
|
|
#include <QRegularExpression>
|
|
#include <QSortFilterProxyModel>
|
|
#include <QStandardItemModel>
|
|
|
|
class QScrollArea;
|
|
class QTableView;
|
|
class QLineEdit;
|
|
|
|
namespace lmms::gui
|
|
{
|
|
|
|
class DualColumnFilterProxyModel : public QSortFilterProxyModel
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
DualColumnFilterProxyModel(QObject* parent = nullptr) : QSortFilterProxyModel(parent)
|
|
{
|
|
}
|
|
|
|
void setEffectTypeFilter(const QString& filter)
|
|
{
|
|
m_effectTypeFilter = filter;
|
|
invalidateFilter();
|
|
}
|
|
|
|
protected:
|
|
bool filterAcceptsRow(int source_row, const QModelIndex& source_parent) const override
|
|
{
|
|
QModelIndex nameIndex = sourceModel()->index(source_row, 0, source_parent);
|
|
QModelIndex typeIndex = sourceModel()->index(source_row, 1, source_parent);
|
|
|
|
QString name = sourceModel()->data(nameIndex, Qt::DisplayRole).toString();
|
|
QString type = sourceModel()->data(typeIndex, Qt::DisplayRole).toString();
|
|
|
|
// TODO: cleanup once we drop Qt5 support
|
|
#if (QT_VERSION >= QT_VERSION_CHECK(5,12,0))
|
|
QRegularExpression nameRegularExpression(filterRegularExpression());
|
|
nameRegularExpression.setPatternOptions(QRegularExpression::CaseInsensitiveOption);
|
|
|
|
bool nameFilterPassed = nameRegularExpression.match(name).capturedStart() != -1;
|
|
#else
|
|
QRegExp nameRegularExpression(filterRegExp());
|
|
nameRegularExpression.setCaseSensitivity(Qt::CaseInsensitive);
|
|
|
|
bool nameFilterPassed = nameRegularExpression.indexIn(name) != -1;
|
|
#endif
|
|
|
|
bool typeFilterPassed = type.contains(m_effectTypeFilter, Qt::CaseInsensitive);
|
|
|
|
return nameFilterPassed && typeFilterPassed;
|
|
}
|
|
|
|
private:
|
|
QString m_effectTypeFilter;
|
|
};
|
|
|
|
|
|
class EffectSelectDialog : public QDialog
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
EffectSelectDialog(QWidget* parent);
|
|
|
|
Effect* instantiateSelectedPlugin(EffectChain* parent);
|
|
|
|
protected slots:
|
|
void acceptSelection();
|
|
void rowChanged(const QModelIndex&, const QModelIndex&);
|
|
void updateSelection();
|
|
|
|
bool eventFilter(QObject* obj, QEvent* event) override;
|
|
|
|
private:
|
|
EffectKeyList m_effectKeys;
|
|
EffectKey m_currentSelection;
|
|
|
|
QStandardItemModel m_sourceModel;
|
|
DualColumnFilterProxyModel m_model;
|
|
QWidget* m_descriptionWidget;
|
|
QTableView* m_pluginList;
|
|
QScrollArea* m_scrollArea;
|
|
QLineEdit* m_filterEdit;
|
|
};
|
|
|
|
} // namespace lmms::gui
|
|
|
|
#endif
|